Dean Herbert
c5fb4d0f5c
Mark flaky test temporarily
2023-12-21 01:52:40 +09:00
rushiiMachine
ebbc8333e8
Prevent ExportReplay being spammed on fail by being held down
...
This was already handled in ReplayDownloadButton (98efff0bd6/osu.Game/Screens/Ranking/ReplayDownloadButton.cs (L114-L115)
2023-12-20 08:41:16 -08:00
Dean Herbert
eb8fb8092d
Attempt to standardise miss handling logic
2023-12-21 00:59:35 +09:00
Dean Herbert
fcf47267fd
Revert change to OsuHitWindows and move logic local to pooling initialisation
2023-12-21 00:48:46 +09:00
Bartłomiej Dach
9515f7dbfa
Bump score version in order to recompute legacy scores
2023-12-20 16:01:59 +01:00
Bartłomiej Dach
8c06d3873d
Merge branch 'master' into mania-scorev2-values
2023-12-20 15:54:31 +01:00
Bartłomiej Dach
b0da24176e
Remove outdated inline comments
2023-12-20 15:44:02 +01:00
Dean Herbert
a8c9db2115
Merge pull request #25958 from smoogipoo/remove-mania-rate-multipliers
...
Remove mania mod multiplier for DT/NC
2023-12-20 23:31:44 +09:00
Bartłomiej Dach
77d8bbf152
Merge pull request #25949 from peppy/fix-song-select-extra-selections
...
Fix beatmap updates causing one extra carousel selection
2023-12-20 15:30:38 +01:00
Dan Balasescu
bff08d124b
Remove mania mod multiplier for DT/NC
2023-12-20 22:28:50 +09:00
Bartłomiej Dach
83e885192b
Merge pull request #25931 from peppy/fix-thread-safety
...
Fix thread safety of `OnlineMetadataClient.UserStates`
2023-12-20 12:55:31 +01:00
Dean Herbert
d1ba2a4a64
Use orange for non-combo-breaking miss
2023-12-20 20:45:27 +09:00
Dean Herbert
d2716d8557
Improve animation for legacy skins
2023-12-20 20:34:05 +09:00
Bartłomiej Dach
6bddc56851
Merge branch 'master' into fix-song-select-extra-selections
2023-12-20 12:23:55 +01:00
Dean Herbert
9b383e3276
Add support for showing tick misses
2023-12-20 20:23:19 +09:00
Bartłomiej Dach
22513e0070
Merge pull request #25943 from peppy/fix-song-select-sound-at-gameplay
...
Fix song select running updates when screen is not active
2023-12-20 12:20:06 +01:00
Dan Balasescu
38d6b7f45b
Update total score conversion
2023-12-20 20:03:13 +09:00
Dean Herbert
d417b156b2
Update test expectations
2023-12-20 19:57:42 +09:00
Dean Herbert
e0c27510f2
Remove remaining usage of NotePerfectBonus
2023-12-20 19:47:36 +09:00
Dean Herbert
5284b95bb8
Schedule even more
2023-12-20 19:42:05 +09:00
Dean Herbert
7fa4dcf0fb
Fix selection retention logic copy paste failure
2023-12-20 19:27:57 +09:00
Dean Herbert
e003462f7d
Fix beatmap updates causing one extra carousel selection
2023-12-20 19:15:02 +09:00
Dan Balasescu
72274041eb
Merge pull request #25876 from bdach/fix-standardised-score-conversion
...
Fix osu! standardised score conversion sometimes exceeding bounds
2023-12-20 18:54:33 +09:00
Dan Balasescu
023bbda7db
Change mania to 85% acc / 15% combo
2023-12-20 18:43:06 +09:00
Dan Balasescu
104fbbde94
Change mania scoring to match ScoreV2
2023-12-20 18:35:45 +09:00
Dean Herbert
64f62e7d90
Fix song select running updates when screen is not active
...
Who would have guessed that `Schedule` calls were there for a reason!
I've tidied things up. Most of the changes I've made here are not
required – the schedule is the main thing here. The reason the sound was
playing is because one-too-many schedules was removed causing beatmap
updates to update carousel specifics while still at the player loader
screen.
Note that the selection sound still plays on returning to song select,
but this is not a regression. I'm looking at fixing this in a separate
PR because I'm in a good place as far as understanding the logic right
now and it would be a waste to leave it broken.
Closes https://github.com/ppy/osu/issues/25875 .
2023-12-20 17:31:09 +09:00
Dean Herbert
831c273b45
Merge pull request #25887 from smoogipoo/restore-taiko-accuracy
...
Restore taiko accuracy to ScoreV2 values
2023-12-20 17:29:40 +09:00
Dan Balasescu
188c463c9c
Merge pull request #25934 from peppy/adjust-classic-mod-multiplier
...
Adjust "classic" mod multiplier to 0.96x
2023-12-20 17:11:09 +09:00
Bartłomiej Dach
9a5027e556
Merge pull request #25900 from peppy/editor-from-any-carousel
...
Allow choosing "Edit" from any beatmap carousel item
2023-12-20 08:35:42 +01:00
Dean Herbert
98efff0bd6
Merge pull request #25917 from rushiiMachine/remove-relax-mod-exclusions
...
Allow failing with "relax" and "autopilot" mods
2023-12-20 15:48:21 +09:00
Dean Herbert
b6f0c98a09
Also apply to autopilot
2023-12-20 14:56:52 +09:00
Dean Herbert
14d2d0d215
Remove ModBlockFail
...
Was only being used by `NoFail` now.
2023-12-20 14:50:45 +09:00
Dan Balasescu
3818977a36
Merge pull request #25898 from peppy/song-select-stats
...
Update song select to always show difficulty stats
2023-12-20 14:39:35 +09:00
Dean Herbert
d7603e8021
Adjust "classic" mod multiplier to 0.96x
...
Following discussions on discord, this seems like the most agreed upon
value. Increasing this is important so that imported legacy scores don't
lose too much value.
2023-12-20 14:33:14 +09:00
Dean Herbert
856c59f7f7
Fix thread safety of OnlineMetadataClient.UserStates
...
Closes https://github.com/ppy/osu-framework/issues/6081 .
2023-12-20 14:15:00 +09:00
Dean Herbert
85e5d74a16
Apply proposed changes
2023-12-20 12:42:06 +09:00
Dan Balasescu
ff6a02be82
Merge pull request #25916 from OliBomby/fix-zero-length
...
Fix near zero-length sliders being placeable and crashing the game
2023-12-20 12:38:45 +09:00
rushiiMachine
1b004dbebc
Allow Relax to fail and remove failable mod exclusions
...
Allows the Relax mod to fail, and remove NF/PF/SD mod exclusion
ref: https://github.com/ppy/osu/discussions/13229
2023-12-19 12:33:00 -08:00
OliBomby
c167f10ad5
fix crash from dragging near zero-length repeating object in timeline
2023-12-19 21:20:45 +01:00
OliBomby
ec578e1d9f
fix near-zero length sliders n stuff being placeable
2023-12-19 21:20:21 +01:00
Bartłomiej Dach
1ebb6262fd
Merge pull request #25895 from peppy/fix-beatmap-statsitics-reprocessing
...
Fix some beatmaps being reprocessed each startup
2023-12-19 18:05:40 +01:00
Bartłomiej Dach
322cfaae1d
Merge branch 'master' into fix-standardised-score-conversion
2023-12-19 17:41:38 +01:00
Bartłomiej Dach
3f41c20ac6
Use safer fix for now
2023-12-19 17:25:15 +01:00
Bartłomiej Dach
64b0534fb8
Merge pull request #25857 from peppy/fix-mod-settings-keyboard-adjust
...
Fix mod search textbox having focus while settings are visible
2023-12-19 15:44:17 +01:00
Bartłomiej Dach
b86997318b
Merge pull request #25838 from peppy/fix-song-select-realm-refresh-performance
...
Fix song select realm refresh performance
2023-12-19 15:04:20 +01:00
Bartłomiej Dach
d793d1cea1
Add test coverage of desired input handling behaviour
2023-12-19 14:52:16 +01:00
Bartłomiej Dach
e306cc35ba
Merge branch 'master' into fix-song-select-realm-refresh-performance
2023-12-19 14:14:46 +01:00
Dean Herbert
bbfdd6892d
Allow choosing "Edit" from any beatmap carousel item
2023-12-19 19:58:49 +09:00
Dean Herbert
c556475c2c
Revert to using a more manual approach to holding focus
2023-12-19 19:46:30 +09:00
Dean Herbert
502e3edac3
Add missing invalidation call
2023-12-19 19:39:48 +09:00
