1776 Commits

• Merge pull request #33530 from JackArmstrong22/fix-negative-zero-audio-offset

  Fix beatmap offset control potentially reporting negative zero

  Dean Herbert · 2025-07-23 16:54:33 +09:00
  9f6b156d0c
• Add test coverage of incorrect formatting output

  Fix a cosmetic UI issue where -0.0 is displayed when clicking the Calibrate using last play button.
  
  Removed changes to AudioOffsetAdjustControl and added check to ToStandardFormattedString for if floatValue is 0

  Dean Herbert · 2025-07-23 14:47:38 +09:00
  44531794a1
• Fix tests
  Bartłomiej Dach · 2025-07-22 10:11:16 +02:00
  b9bda61e27
• Store pause timestamps (rounded to ms) instead of general count
  Bartłomiej Dach · 2025-07-22 09:26:12 +02:00
  d8900defd3
• Track count of times gameplay was paused on ScoreInfo
  Bartłomiej Dach · 2025-07-07 11:00:30 +02:00
  f082b60c9b
• Fix player settings no longer collapsing correctly

  Regressed with https://github.com/ppy/osu/pull/33621 for obvious
  reasons. Tachyon doing its job, caught this before hitting a proper
  release.

  Dean Herbert · 2025-06-30 16:57:51 +09:00
  d1c0d58f2e
• Merge pull request #33670 from bdach/ensure-replays-are-played-to-end

  Ensure partial failed replays are played to their end

  Dean Herbert · 2025-06-30 15:56:13 +09:00
  768d44596a
• Fix flaky TestSceneGameplaySamplePlayback test

  See: https://github.com/ppy/osu/actions/runs/15924307907/job/44920278903
  
  Similar null-checks within `Update()` are present in the
  `PlayerTestScene` superclass.

  Dan Balasescu · 2025-06-29 00:24:12 +09:00
  5c89644d58
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Add failing test scene
  Bartłomiej Dach · 2025-06-12 14:03:52 +02:00
  e59f9b1aa7
• Merge pull request #33630 from peppy/leaderboard-always-expand-setting

  Add a skin-level setting to leaderboard to allow disabling automatic collapsing

  Bartłomiej Dach · 2025-06-12 11:16:17 +02:00
  d13676fcc6
• Combine two similar flags into one
  Dean Herbert · 2025-06-12 17:27:23 +09:00
  ebfc3c9ccf
• Adjust tests based on changed behaviour

  Calibration no longer goes away on missing / invalid scores.

  Dean Herbert · 2025-06-11 22:47:47 +09:00
  90877a079c
• Adjust commentary to not suck

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-06-11 15:55:08 +09:00
  38ad48bb35
• Allow using previous valid score for offset calibration when subsequent retries are too short

  As proposed in https://github.com/ppy/osu/discussions/33572.
  
  Note that this won't work if you leave to song select. We could make
  that work but it would require further global faffing and I don't think
  it's worth the effort.

  Dean Herbert · 2025-06-11 15:26:02 +09:00
  cdb2f216f2
• Disallow placing gameplay leaderboard in skins outside player

  Closes https://github.com/ppy/osu/issues/33542.
  
  For a diff this simple this took much more hemming and hawing because
  things are a bit annoying here from a few angles:
  
  - The only way that is considered idiomatic right now for a skin
    component to not be applicable to a screen is to require a dependency
    from DI that is only provided by applicable screens.
    `DrawableGameplayLeaderboard` has a few of those dependencies, but the
    scope of all the usages makes it so that the only really viable one to
    use here is `IGameplayLeaderboardProvider` itself (see: visual tests,
    and also the usage of multiplayer spectator, where the leaderboard is
    *not* under a player instance).
  
  - The smelly part of this is that the `Player` inheritance hierarchy
    must ensure that *every* non-abstract class has an
    `IGameplayLeaderboardProvider` cached. It is not trivial - if not
    straight up impossible - to force this via some `Player` level
    abstract method, because such a method would need to somehow
    accommodate all possible leaderboard providers. That however also
    means that every possible future `Player` implementor *must inherently
    know* to also cache a leaderboard provider lest it die at runtime. I
    don't love that, but I also don't see better alternatives.
  
  - Speaking of which, I also noticed that solo spectator and playlists
    don't have gameplay leaderboards. At all. Which I don't believe to be
    something that I broke with the leaderboard work - I'm pretty sure
    that was the pre-existing state - however I don't see any reason why
    they *couldn't* receive gameplay leaderboards. I'm not doing that
    here, though, just leaving TODOs for later.

  Bartłomiej Dach · 2025-06-09 13:11:29 +02:00
  6416f59c7b
• Fix general confusion in which combo should be read on which gameplay leaderboard

  Closes https://github.com/ppy/osu/issues/33455.
  
  The fundamental misunderstanding and source of confusion in
  https://github.com/ppy/osu/pull/33062 is that solo wants to show
  *maximum combo*, and multiplayer wants to show *current combo*, for
  their own, valid reasons. Which is spelled out explicitly in this
  change.

  Bartłomiej Dach · 2025-06-06 10:08:01 +02:00
  a92a659662
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Mark some more recent flaky tests
  Dean Herbert · 2025-06-03 16:23:31 +09:00
  ef29eda3e0
• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Expose total scores count from backend
  Salman Alshamrani · 2025-05-22 00:57:49 +03:00
  6bc407310e
• Merge pull request #32972 from bdach/multiplayer-position-indicator

  Add non-skinnable position indicator to multiplayer player

  Dean Herbert · 2025-05-13 20:53:15 +09:00
  3ce5389558
• Fix test not showing immediately useful state

  Also standardises the testing leaderboard provider component for
  (immediate) future use.

  Dean Herbert · 2025-05-13 15:53:47 +09:00
  1d7f922068
• Merge pull request #33075 from bdach/do-not-allow-reading-garbage-from-hitwindows

  Fix `HitWindows.WindowFor()` returning values for invalid results

  Dean Herbert · 2025-05-09 22:24:26 +09:00
  afe8ab842d
• Fix HitWindows.WindowFor() returning values for invalid results

  This fell out of my work on hit window-related replay issues. In my WIP
  branch (that is probably going to get PR'd as draft soon) I refactored
  `HitWindows` and found a few straggling test failures due to some places
  reading hit windows for results that were not actually supported by the
  underlying `HitWindows` implementations, leading to returning garbage
  (mostly zeroes).
  
  Importantly, there is one actual usage in game code with impact here -
  `TaikoModSingleTap` was attempting to read the hit window for MEH, when
  MEH was never actually a valid hit result in taiko (OK is). This was a
  result of a copy-paste oversight from osu!, specifically from
  
  	https://github.com/ppy/osu/blob/51cf835fb6300aca53b5b98143d606f64d7a4d49/osu.Game.Rulesets.Osu/Mods/InputBlockingMod.cs#L58

  Bartłomiej Dach · 2025-05-09 09:40:20 +02:00
  ceb58a1141
• Fix gameplay leaderboard not always being expanded in gameplay leaderboard

  I'd have preferred a `get; init;` property but tests were also attached
  at the hip to the public bindable. Without some extra composition this
  is the best that I can do.

  Bartłomiej Dach · 2025-05-07 12:09:26 +02:00
  8cc2af4060
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-05-07 10:45:51 +02:00
  5b61761bbd
• Merge pull request #32947 from bdach/use-actual-score-positions-in-gameplay-leaderboard

  Use actual score positions in gameplay leaderboard

  Dean Herbert · 2025-04-30 17:20:12 +09:00
  1b5553a2d8
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-04-28 13:11:22 +02:00
  4ad86685e0
• Remove failing test

  The sorting logic is now exercised in
  `TestSceneSoloGameplayLeaderboardProvider`. Trying to work around
  it with local test classes would mean that the test would be covering
  test code, i.e. complete nonsense and having a green test for the sake
  of having a green test.

  Bartłomiej Dach · 2025-04-28 12:32:41 +02:00
  c1fbf50622
• Adjust variables for legibility

  I found the previous way things were written a bit awkward. Easier to
  just enforce non-null here.

  Dean Herbert · 2025-04-26 05:18:24 +09:00
  0301463810
• Fix filename not matching test scene
  Dean Herbert · 2025-04-26 04:51:03 +09:00
  0287ca285c
• Add test coverage of new behaviour of solo gameplay leaderboard
  Bartłomiej Dach · 2025-04-25 12:45:28 +02:00
  7822412c42
• Use actual score positions in gameplay leaderboard

  Intends to close https://github.com/ppy/osu/issues/32859.
  
  The difference between this and https://github.com/ppy/osu/pull/32942 is
  that this PR takes the approach of completely moving the score sorting
  behaviour to `IGameplayLeaderboardProvider` implementations.
  
  This is going to be helpful for further work - to be precise, I am
  looking to add a leaderboard position indicator in the bottom right of
  multiplayer player to match stable, and having the position in the
  provider will make the implementation of that *much* easier.

  Bartłomiej Dach · 2025-04-25 12:40:55 +02:00
  06dc4235f0
• Delete no-longer-relevant test
  Bartłomiej Dach · 2025-04-24 14:50:09 +02:00
  242f1bf68f
• Remove (currently) unused resolved dependency
  Bartłomiej Dach · 2025-04-24 13:23:00 +02:00
  9818f859cb
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Add test scene coverage of HUD layouts on various ruleset/skin combinations

  As time goes on, default skin layouts are getting more and more
  complicated because of per-ruleset overrides. This was already sort of
  apparent in https://github.com/ppy/osu/pull/31527, and I'm about to make
  it worse, so before I do, this is a test scene that is supposed to make
  it easier to check all possible combinations at a glance.

  Bartłomiej Dach · 2025-04-24 12:50:34 +02:00
  33f45b0a6d
• Merge branch 'master' into leaderboards/gameplay-provider
  Bartłomiej Dach · 2025-04-21 09:03:24 +02:00
  6b0567e882
• Add failing test coverage
  Bartłomiej Dach · 2025-04-18 14:21:50 +02:00
  20b2cc8251
• Remove unnecessary interface
  Bartłomiej Dach · 2025-04-18 12:12:21 +02:00
  6d258d4ed5
• Add failing test for incorrect score position treatment
  Bartłomiej Dach · 2025-04-18 12:01:04 +02:00
  39f9eabf40
• Fix code quality
  Bartłomiej Dach · 2025-04-18 09:09:57 +02:00
  2c690ae94c
• Separate gameplay leaderboard data management from display

  This is a prerequisite for supporting skinning of leaderboards.
  
  - New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
    interfaces are introduced. They are strictly concerned with supplying
    leaderboard data.
  
  - Logic of managing display, which was previously jammed into the
    inheritance hierarchy of `GameplayLeaderboard`, is now moved into
    `IGameplayLeaderboardProvider` implementations. Solo play,
    multiplayer, and multiplayer spectator get their own implementation of
    the interface.
  
  - The inheritance hierarchy of `GameplayLeaderboard` and per-player
    overriding of the implementation of the gameplay leaderboard is gone.
    Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
    allowed to display the leaderboards, across all modes of play.

  Bartłomiej Dach · 2025-04-16 14:46:55 +02:00
  c231571f06
• Merge pull request #32601 from sineplusx/median-offset

  Use median instead of mean for average hit error calculations

  Dean Herbert · 2025-04-03 18:56:04 +09:00
  db0811bad9
• Add failing test case

  Co-authored-by: Rodrigo Correia <rodrigo.figueiredo.correia@tecnico.ulisboa.pt>

  Bartłomiej Dach · 2025-03-31 14:25:35 +02:00
  79375eccb7
• Adapt TestNotEnoughTimedHitEvents with new minimum hit amount
  sineplusx · 2025-03-29 20:43:59 +01:00
  403b24ef9b
• Fix LetterboxOverlay not handling its own visibility
  Dean Herbert · 2025-03-12 17:46:18 +09:00
  77aac2922f
• Fix storyboard letterbox hiding HUD elements

  Addresses https://github.com/ppy/osu/discussions/29788.

  Dean Herbert · 2025-03-12 14:20:16 +09:00
  72854d0ae6
• Disable user customisation of spectator list font / colour

  It's all a bit weird so let's just disable it for now. For instance,
  this is exposed as "text" font / colour but only affects the header.
  Also, no other headers are cusotmisable in similar components.

  Dean Herbert · 2025-03-10 15:19:34 +09:00
  3cb32c38ad