61792 Commits

This Branch

This Branch

All Branches

• Remove unnecessary text comparison
  Joseph Madamba · 2023-07-29 11:02:04 -07:00
  6ebfafa9c3
• Remove unnecessary prefix parameter
  Joseph Madamba · 2023-07-29 10:40:18 -07:00
  740898dffb
• Apply NRT to BreakInfoLine
  Joseph Madamba · 2023-07-29 10:39:50 -07:00
  9d928c0225
• Fix accuracy break info decimal separator being incorrect in certain languages
  Joseph Madamba · 2023-07-28 23:26:07 -07:00
  a3301dc7ff
• Merge pull request #24405 from bdach/spinner-input-test
  Dean Herbert · 2023-07-29 11:34:45 +09:00
  a7ff084be2
• Add test scene for checking spinner judgements
  Bartłomiej Dach · 2023-07-29 00:49:21 +02:00
  cd416e09f9
• Merge pull request #24360 from peppy/spinner-faster-rotation

  Change spinner rotation animation to match input 1:1

  Bartłomiej Dach · 2023-07-29 00:48:56 +02:00
  c21167e2ab
• Merge pull request #24389 from peppy/ladder-grid-expand

  Allow ladder editor grid to scale with content

  Bartłomiej Dach · 2023-07-28 23:40:40 +02:00
  35defd97e1
• Use better safety in rectangular grid

  - Checking `DrawSize != Vector2.Zero` is too specific. It could also
    crash on zero-height-but-non-zero-width, or
    zero-width-but-non-zero-height.
  
  - Take the `gridCache.Validate()` call out of the zero checks, because
    even if the width or height are zero, not generating anything is valid
    and there is no reason to validate every frame until `gridCache` gets
    invalidated again.

  Bartłomiej Dach · 2023-07-28 22:57:02 +02:00
  c6f0cf50ca
• Merge branch 'master' into ladder-grid-expand
  Bartłomiej Dach · 2023-07-28 22:51:33 +02:00
  0c10d875ce
• Merge pull request #24390 from peppy/tournament-client-fix-startup-crash

  Fix potential startup crash due to early application of animations

  Bartłomiej Dach · 2023-07-28 22:47:07 +02:00
  998395c7a7
• Merge pull request #24374 from peppy/fix-taiko-alignment

  Fix osu!taiko editor playfield missing a piece

  Bartłomiej Dach · 2023-07-28 22:46:01 +02:00
  318aa4627b
• Move comment to more fitting place
  Bartłomiej Dach · 2023-07-28 22:10:10 +02:00
  caad931a16
• Rename Apply{Vertical -> Horizontal}Centering to match common understanding
  Bartłomiej Dach · 2023-07-28 22:09:28 +02:00
  6d018c08af
• Fix potential startup crash due to early application of animations

  This was always haphazard code, but by luck it never triggered before
  drawable load until now. With the recently nullability changes, this
  would be triggered when `flash` is not yet constructed.
  
  Switching to `AddOnce` seems safer to avoid multiple applications,
  regardless.

  Dean Herbert · 2023-07-28 17:17:15 +09:00
  f58c69e639
• Fix playfield not taking up full width correclty when not vertically centered
  Dean Herbert · 2023-07-28 16:40:14 +09:00
  c9155f85ab
• Merge branch 'master' into fix-taiko-alignment
  Dean Herbert · 2023-07-28 16:32:37 +09:00
  d26164e9fe
• Always place first match at (0,0)
  Dean Herbert · 2023-07-28 16:29:55 +09:00
  aa91000505
• Fix placing new match via right click not using original click position
  Dean Herbert · 2023-07-28 16:29:39 +09:00
  b5c3e2a648
• Allow ladder editor grid to scale with content

  Closes https://github.com/ppy/osu/issues/24378.

  Dean Herbert · 2023-07-28 16:26:03 +09:00
  b5f0d739e6
• Add safety in RectangularPositionSnapGrid that size is greater than zero

  Would crash otherwise

  Dean Herbert · 2023-07-28 16:25:40 +09:00
  0e4db9b439
• Merge pull request #24357 from peppy/tournament-fix-null-population

  Fix startup tournament population not recovering from null beatmaps

  Dean Herbert · 2023-07-28 14:31:48 +09:00
  57e51f4d5b
• Merge pull request #24377 from ILW8/fix-tournament-switcher-height

  Allow scrolling in tournament setup screen to avoid information ending up off-screen

  Dean Herbert · 2023-07-28 14:27:55 +09:00
  c824b2dedf
• make SetupScreen scrollable
  Dao Heng Liu · 2023-07-28 14:18:48 +09:00
  c7717da232
• Merge branch 'master' into tournament-fix-null-population
  Bartłomiej Dach · 2023-07-27 22:36:11 +02:00
  780b8f0ec8
• Remove fallbacks to empty APIBeatmap on population failure

  Was causing there to be two kinds of missing `TournamentBeatmap`s: one
  with missing `Beatmap == null`, and one with `Beatmap == new
  APIBeatmap()`. In particular, they would appear differently in UI
  (either as "unknown - unknown", or the intensely enigmatic " - ").

  Bartłomiej Dach · 2023-07-27 22:33:00 +02:00
  b7ddb5c946
• Fix even more missed nullability-related inspections
  Bartłomiej Dach · 2023-07-27 22:10:41 +02:00
  3c923b9e81
• Merge pull request #24367 from peppy/fix-replay-export-from-results

  Fix attempting to export replay from results screen after play not working

  Bartłomiej Dach · 2023-07-27 20:47:07 +02:00
  22163020c3
• Avoid intercepting temporary files in new test
  Dean Herbert · 2023-07-27 17:44:36 +09:00
  e702e0a23e
• Fix some missed null checks
  Dean Herbert · 2023-07-27 17:41:27 +09:00
  1e9b927b50
• Merge pull request #24375 from peppy/add-back-mode-select-enter-close

  Add back the ability to close mod select using enter key

  Bartłomiej Dach · 2023-07-26 22:43:38 +02:00
  057bac39dd
• Update wrong comment, too
  Bartłomiej Dach · 2023-07-26 21:56:04 +02:00
  973e6ded2a
• Use more consistent way of closing overlay
  Bartłomiej Dach · 2023-07-26 21:54:35 +02:00
  992f78b158
• Revert failing test to prior assertions too
  Bartłomiej Dach · 2023-07-26 21:51:32 +02:00
  f66093d3cf
• Fix code quality inspection
  Bartłomiej Dach · 2023-07-26 20:52:03 +02:00
  7bc3edb05a
• Add back the ability to close mod select using enter key

  I've seen this brought up a few times (with people thinking
  the fact it's not working is a bug) so we'll need to keep this
  behaviour for now.

  Dean Herbert · 2023-07-27 02:36:25 +09:00
  8d5efc9612
• Fix osu!taiko editor playfield missing a piece

  Regressed with recent centering changes in https://github.com/ppy/osu/pull/24220

  Dean Herbert · 2023-07-27 02:24:10 +09:00
  deba6e2508
• Apply NRT and avoid throws from null RoundBeatmap.Beatmaps
  Dean Herbert · 2023-07-26 17:49:07 +09:00
  fa4992f05a
• Fix files references not correctly being copied after replay import in Player
  Dean Herbert · 2023-07-26 15:22:00 +09:00
  4889864478
• Fix ReplayDownloadButton handling key repeat
  Dean Herbert · 2023-07-26 15:21:43 +09:00
  e26afc2b89
• Add test coverage of score arriving on disk when exporting from results screen after play
  Dean Herbert · 2023-07-26 15:21:43 +09:00
  2dace742a3
• Merge pull request #24358 from peppy/song-select-drain-length

  Show break time in tooltip at song select

  Bartłomiej Dach · 2023-07-25 23:22:18 +02:00
  0b5be51ee0
• Merge branch 'master' into song-select-drain-length
  Bartłomiej Dach · 2023-07-25 22:40:45 +02:00
  57ccf82f34
• Merge pull request #24359 from peppy/fix-unknown-mod-test-failure

  Fix `TestSceneUnknownMod` failing due to null reference

  Bartłomiej Dach · 2023-07-25 22:40:03 +02:00
  653f01f4ce
• Merge pull request #24208 from peppy/menu-star-fountains

  Add kiai fountains to main menu

  Bartłomiej Dach · 2023-07-25 22:39:07 +02:00
  5214efca5a
• Rename test to match class
  Bartłomiej Dach · 2023-07-25 22:18:31 +02:00
  c6099edb88
• Revert "Show only the break length instead of total minute breaks"

  This reverts commit 9edaa6909e.

  Bartłomiej Dach · 2023-07-25 22:17:55 +02:00
  3b11559fd0
• Merge branch 'master' into menu-star-fountains
  Bartłomiej Dach · 2023-07-25 21:58:13 +02:00
  3b9f250c1b
• Merge pull request #24305 from chayleaf/fix-taiko-hd-hit-overlap

  Fix alive hitobjects blocking hits in taiko with HD

  Bartłomiej Dach · 2023-07-25 21:20:29 +02:00
  7c78fcd6f5
• Merge branch 'master' into fix-taiko-hd-hit-overlap
  Bartłomiej Dach · 2023-07-25 20:11:43 +02:00
  0b7b70fd9c