1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 10:12:54 +08:00
Commit Graph

57563 Commits

Author SHA1 Message Date
Joseph Madamba
6e62033bc4 Fix some comment actions not being lowercased 2022-12-18 20:20:15 -08:00
Dean Herbert
e2d68f6ea9
Merge pull request #21686 from bdach/spectator-end-playing-on-completion
Call spectator `EndPlaying()` immediately after score submission
2022-12-18 13:26:47 +09:00
Bartłomiej Dach
fea0895f16
Call spectator EndPlaying() immediately after score submission
As it turns out, in current `master`, if a gameplay session ends
normally (i.e. by the player completing the beatmap in full), then
the spectator server `EndPlaying()` method will not be called until
`SubmittingPlayer.OnExiting()`, which in practice turns out to be
the moment where the user exits from the post-gameplay results screen
back to song select.

There is seemingly no reasonable cause for not calling this earlier. In
fact the solo spectator flow looks more broken without this call than
with, because without it the spectator view just hangs until the
spectated player exits gameplay, and *only then* shows results, rather
than do it upon normal gameplay completion.
2022-12-17 21:35:43 +01:00
Salman Ahmed
64e0e6f096
Merge pull request #21667 from bdach/fix-wrong-macos-logs-path
Fix wrong paths to macOS log folder in docs
2022-12-16 19:20:51 +03:00
Salman Ahmed
00bae8fab9 Fix slight mistake in path 2022-12-16 18:44:23 +03:00
Bartłomiej Dach
190e7acd39
Fix wrong paths to macOS log folder in docs
Wrong since 2eb1c60d6e72d8b2c478cf4376470ca614ef3f88.
2022-12-16 16:37:38 +01:00
Dean Herbert
965be5123d
Merge pull request #21661 from nekodex/clamp-sfx-panning
Limit SFX panning on results screen
2022-12-16 18:05:40 +09:00
Jamie Taylor
d5b2c7dfe9
Clamp SFX panning on results screen 2022-12-16 17:19:07 +09:00
Dan Balasescu
cbee72897a
Merge pull request #21654 from Susko3/use-localisable-strings-for-dates-and-times
Use `LocalisableString`s for date and time formats
2022-12-16 16:17:14 +09:00
Dean Herbert
232f590ba3
Merge pull request #21628 from peppy/go-hard-file-writes
Use hard links on windows when importing beatmaps from a legacy osu! install
2022-12-16 14:52:57 +09:00
Dean Herbert
6b85a123a4
Merge pull request #21646 from peppy/featured-artist-default
Turn on featured artist filter by default and add disclaimer when toggling for the first time
2022-12-16 13:09:03 +09:00
Susko3
0f34d908c7 Use LocalisableStrings for date and time formats 2022-12-16 00:05:47 +01:00
Dean Herbert
9813bc9544 Reword disclaimer and fix translation keys 2022-12-15 22:46:31 +09:00
Dean Herbert
91adf2e80f
Apply the wala-hyphen
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2022-12-15 22:44:47 +09:00
Dean Herbert
57048f0eba Add test coverage of featured artist filter confirmation process 2022-12-15 18:42:58 +09:00
Dean Herbert
d2b98b803d Turn on featured artist filter by default and add disclaimer when toggling for the first time 2022-12-15 18:42:47 +09:00
Dean Herbert
0763b86236 Add more padding around text in dialog popups 2022-12-15 17:32:27 +09:00
Dean Herbert
78bc94d3cb Set featured artists filter to enabled by default 2022-12-15 16:57:39 +09:00
Dean Herbert
a7f3e13946 Fix MultipleSelectionFilter not correctly handling initial selection 2022-12-15 16:56:09 +09:00
Dean Herbert
6bf1477939
Fix some hard links not being created due to missing directory structure
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-15 14:17:28 +09:00
Dean Herbert
60c8ef3fe5
Merge pull request #21637 from smoogipoo/score-encoder-doc
Add description for lazer score version 30000001
2022-12-14 18:49:41 +09:00
Dan Balasescu
fb85eaee95 Add description for lazer score version 30000001 2022-12-14 18:30:33 +09:00
Dean Herbert
50dc76d579
Merge pull request #21618 from smoogipoo/multi-spec-only-local-results
Only show local results in multi-spectator results screen
2022-12-14 14:00:02 +09:00
Dean Herbert
a3c3112f89
Add SetLastError hint to CreateHardLink pinvoke method
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-14 11:34:06 +09:00
Dean Herbert
f4316a9827
Fix incorrect grammar in hard link explanation text
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-14 11:30:01 +09:00
Bartłomiej Dach
9d14292320
Merge pull request #21588 from smoogipoo/beginplaying-score-token
Add score token to `BeginPlaySession()`
2022-12-13 18:19:07 +01:00
Bartłomiej Dach
849245b90c
Merge branch 'master' into beginplaying-score-token 2022-12-13 17:15:24 +01:00
Bartłomiej Dach
9d549c3059
Merge pull request #21619 from EVAST9919/buttons-fix
Fix buttons receiving input outside the content
2022-12-13 17:15:00 +01:00
Bartłomiej Dach
dfb8f4fdd9
Merge branch 'master' into buttons-fix 2022-12-13 16:35:03 +01:00
Dean Herbert
efe057176e Make OsuButton abstract 2022-12-13 22:13:48 +09:00
Dean Herbert
edc78205d5 Add comments about why both positional input checks are required in OsuClickableContainer 2022-12-13 22:12:52 +09:00
Dean Herbert
b8904fe747 Move ImportParameters to better home 2022-12-13 21:41:26 +09:00
Dean Herbert
cb16d62700 Hook up ImportParameter flow with IModelImporter caller methods 2022-12-13 21:29:32 +09:00
Dean Herbert
6bb612ce69 Move hard link availability check to helper class 2022-12-13 20:20:42 +09:00
Dean Herbert
cbd7cae70a
Merge pull request #21625 from Mogiiii/catch-disable-cursor
Always hide cursor in osu!catch gameplay
2022-12-13 20:14:04 +09:00
Dean Herbert
bbf931c746 Move hard link helper functions to their own class 2022-12-13 19:55:18 +09:00
Dean Herbert
1d4230993d Hook up parameter with RealmFileStore to complete the chain 2022-12-13 19:55:18 +09:00
Dean Herbert
cf2719d4c0 Convert batchImport parameter to parameters class to allow further import configuration 2022-12-13 19:55:18 +09:00
Salman Ahmed
898d88bf8a
Merge branch 'master' into catch-disable-cursor 2022-12-13 13:23:43 +03:00
Dean Herbert
775952380f Remove unused using statements 2022-12-13 18:57:17 +09:00
Dean Herbert
fd1f144f47
Merge pull request #21627 from smoogipoo/score-encoder-leaveopen
Allow keeping stream open after encoding scores
2022-12-13 16:32:27 +09:00
Dan Balasescu
ad7554cc7d Allow keeping stream open after encoding scores 2022-12-13 16:15:14 +09:00
Dylan Nantz
0dd4e0cf94 hide cursor in catch 2022-12-12 21:18:01 -05:00
Andrei Zavatski
15bd82add8 Fix DrawableUsername being affected 2022-12-12 18:24:49 +03:00
Andrei Zavatski
890dd9cd06 Fix input doesn't take original drawable modifications into account 2022-12-12 15:10:03 +03:00
Andrei Zavatski
b0d475cd8b CI fix 2022-12-12 14:57:07 +03:00
Andrei Zavatski
d2b3533356 Fix OsuClickableContainer input receiving 2022-12-12 14:42:54 +03:00
Andrei Zavatski
7e39f171fb Fix OsuButton input receiving 2022-12-12 14:42:54 +03:00
Andrei Zavatski
37a0756321 Add tests 2022-12-12 14:38:24 +03:00
Dean Herbert
5800734589
Merge pull request #21587 from smoogipoo/spectatorstate-maximum-statistics
Store maximum statistics to spectator state
2022-12-12 20:00:52 +09:00