Jamie Taylor
6dc13ef396
Use default hover sample instead of song-ping (they're the same sample anyway)
2021-11-10 17:14:20 +09:00
Dan Balasescu
9404eac227
Merge pull request #15552 from Naxesss/dispose-background-after-check
...
Use disposal in `CheckBackgroundQuality`
2021-11-10 15:05:46 +09:00
Dean Herbert
328c72c358
Fix TeamDisplay
not showing after changing to team versus
2021-11-10 13:44:31 +09:00
Dean Herbert
52c740b377
Add failing test showing team display display failure
2021-11-10 13:44:31 +09:00
Naxesss
b888185799
Properly dispose of Stream
in bg quality check
2021-11-10 05:06:11 +01:00
Dan Balasescu
baa5285b59
Merge pull request #15535 from peppy/remove-bass-track-ctor-usage
...
Rewrite `PreviewTrackManager` to avoid constructing `TrackBass` locally
2021-11-09 21:36:49 +09:00
Bartłomiej Dach
31b0acde85
Merge branch 'master' into fix-realm-migration-crash
2021-11-09 10:54:17 +01:00
Dean Herbert
dfbc1f3394
Fix "conflicting" variable name
2021-11-09 17:42:03 +09:00
Dean Herbert
3b485b5f37
Rewrite PreviewTrackManager
to avoid constructing TrackBass
locally
...
This paves the way for the framework code quality change
(https://github.com/ppy/osu-framework/pull/4873 ) which stops exposing
the constructor.
Most of the restructuring here is required to give `PreviewTrackManager`
an adjustable target to apply the global mute.
2021-11-09 17:38:12 +09:00
Bartłomiej Dach
74c37e248d
Merge branch 'master' into master
2021-11-09 08:40:52 +01:00
Dean Herbert
999d625e76
Fix realm migration potentially failing for users that haven't run osu! in a long time
...
As reported at https://github.com/ppy/osu/discussions/15530 .
2021-11-09 14:51:10 +09:00
Chinmay Patil
1b11a034a7
Reverted Default Skin Changes
2021-11-08 07:25:02 -07:00
Dean Herbert
423b1397fc
Merge pull request #15526 from Susko3/move-HoverClickSounds
...
Move `HoverClickSounds` to cover only the clickable button in `KeyBindingRow`
2021-11-08 23:01:05 +09:00
Dean Herbert
2b518035da
Merge pull request #15522 from bdach/taiko-slider-multiplier-saving
...
Fix taiko beatmap scroll speed increasing after every save in editor
2021-11-08 22:51:43 +09:00
Susko3
8a23b648fe
Move HoverClickSounds
to the clickable button
2021-11-08 14:32:00 +01:00
Chinmay Patil
d5ad776c33
Remove decimal part of UR Counter and rename methods
2021-11-08 06:27:25 -07:00
Bartłomiej Dach
74603253d2
Store full model rather than online ID only
2021-11-08 13:42:56 +01:00
Dean Herbert
72489b32f9
Move toggle code into own method for readability
2021-11-08 21:39:16 +09:00
Dean Herbert
9a2425f316
Remove unused field for now to appease inspectcode
2021-11-08 21:36:28 +09:00
Bartłomiej Dach
540b7e1b38
Fix taiko editor not unapplying slider multiplier changes on save
2021-11-08 13:28:42 +01:00
Bartłomiej Dach
f4b8dee2d0
Update favourite statistic value on favourite button clicks
2021-11-08 11:53:54 +01:00
Bartłomiej Dach
b5cbdcf981
Implement basic behaviour of favourite button
2021-11-08 11:53:54 +01:00
Bartłomiej Dach
5cb533004d
Add test coverage for favourite button
2021-11-08 11:53:53 +01:00
Bartłomiej Dach
0faa26fc13
Add basic structure for buttons
2021-11-08 11:53:53 +01:00
Dean Herbert
49c26a465c
Debounce and schedule updates to key combinations
2021-11-08 18:29:11 +09:00
Dean Herbert
b4225804ed
Add missing null check
2021-11-08 18:26:12 +09:00
Dean Herbert
f5842e7587
Shorten variable names
2021-11-08 18:24:37 +09:00
Dean Herbert
82f24b0502
Revert "Change font to default"
...
This reverts commit cc286f165d
.
2021-11-08 18:16:06 +09:00
Dean Herbert
c1e7fcd2d7
Update framework
2021-11-08 18:15:51 +09:00
Dean Herbert
3183b20e2f
Merge branch 'master' into use-ReadableKeyCombinationProvider
2021-11-08 18:15:49 +09:00
Dean Herbert
ea0715cce4
Add missing dispose call
2021-11-08 16:35:05 +09:00
Dean Herbert
dbdae4b033
Merge branch 'master' into realm-ruleset-store-thread-correctness
2021-11-08 15:21:30 +09:00
Dean Herbert
8b85c2c8de
Merge pull request #15491 from peppy/remove-stupid-weak-reference-bindable-events
...
Revert weird event flow in model manager/importers
2021-11-08 15:19:58 +09:00
Dean Herbert
413f98999a
Start initialising RealmRulesetStore
on startup
2021-11-08 15:10:19 +09:00
Dan Balasescu
b5a6fd3f00
Merge pull request #15517 from peppy/fix-beatmap-wedge-user-display
...
Fix `LinkFlowContainer` not creating user links supporting full `IUser` specification
2021-11-08 15:06:28 +09:00
Dean Herbert
72b4afdea6
Move RealmRulesetStore
initial work off incorrect thread
2021-11-08 15:05:43 +09:00
Susko3
cc286f165d
Change font to default
...
Non-english letters look tiny with size 10
and don't fit into the look.
2021-11-08 06:56:57 +01:00
Susko3
c3069ad002
Change to use ReadableKeyCombinationProvider
...
Changes all usages of `KeyCombination.ReadableString()` to
`ReadableKeyCombinationProvider.GetReadableString()`.
Subscribing to `KeymapChanged` is only required in `KeyButton`.
All other places query `GetReadableString()` every time.
2021-11-08 06:55:26 +01:00
Dean Herbert
a2dfb5fd8c
Merge pull request #15513 from bdach/beatmap-card/statistics
...
Add statistics display to beatmap card
2021-11-08 14:45:56 +09:00
Dan Balasescu
1c40d5bc08
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-08 14:41:32 +09:00
Dean Herbert
6b6dd93e9e
Fix LinkFlowContainer
not creating user links supporting full IUser
specification
2021-11-08 14:17:47 +09:00
Dean Herbert
dede0e56ce
Merge branch 'master' into user-lookup-by-username-cleanup
2021-11-08 13:38:26 +09:00
Dean Herbert
78aef9ce86
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-08 13:35:49 +09:00
Dean Herbert
1589b50d6e
Merge branch 'master' into beatmap-card/statistics
2021-11-08 13:28:31 +09:00
Dan Balasescu
da0d9726f5
Merge pull request #15466 from peppy/user-class-cleanup
...
Clean up `User` class
2021-11-08 13:27:26 +09:00
Dean Herbert
fb495d77ce
Implement TooltipText
directly
2021-11-08 13:22:57 +09:00
Dean Herbert
8dbe69dec5
Merge pull request #15515 from Joehuu/fix-statistics-loading-spinner
...
Fix loading spinner potentially showing on statistics unavailable message
2021-11-08 13:02:39 +09:00
Dean Herbert
62600b47b1
Merge branch 'master' into user-class-cleanup
2021-11-08 12:51:12 +09:00
Joseph Madamba
9e13c20bd4
Move spinner hiding before newScore null check
2021-11-07 19:35:30 -08:00
Joseph Madamba
ac5d9853d3
Fix loading spinner potentially showing on statistics unavailable message
2021-11-07 17:25:33 -08:00