77 Commits

Author	SHA1	Message	Date
Dan Balasescu	bf5640049a	Fix banana showers causing fails when hp is at 0	2024-03-20 17:31:33 +09:00
Bartłomiej Dach	2c0a5b7ef5	Fix missing tiny droplet not triggering fail with perfect on ... Stable does this: 46cd3a10af/osu!/GameplayElements/HitObjectManagerFruits.cs#L98-L102 I'd rather not say what I think about it doing that, since it's likely to be unpublishable, but to approximate that, just make it so that only the "default fail condition" is beholden to the weird ebbs and flows of what the ruleset wants. This appears to fix the problem case and I'm hoping it doesn't break something else but I'm like 50/50 on it happening anyway at this point. Just gotta add tests add nauseam.	2024-02-14 14:21:48 +01:00
Bartłomiej Dach	f53bce8ff7	Fix catch health processor allowing fail on tiny droplet ... Closes https://github.com/ppy/osu/issues/27159. In today's episode of "just stable things"...	2024-02-14 09:02:33 +01:00
Bartłomiej Dach	cb8ec48717	Make RankFromScore()'s dictionary param readonly ... Just to make sure nobody tries any "funny" business.	2024-01-22 19:56:30 +01:00
Dean Herbert	c8521b49cd	Change S rank to require no miss	2024-01-22 21:43:32 +09:00
Bartłomiej Dach	8295ad1feb	Change catch scoring to match score V2	2024-01-05 20:46:11 +01:00
Dan Balasescu	6b4b2a57fc	Expose only as one method	2023-12-21 14:58:23 +09:00
Dan Balasescu	4e3b994142	Relocate HitResult numeric score to ScoreProcessor	2023-12-21 14:52:31 +09:00
Dan Balasescu	c1b55c7fac	Add ScoreProcessor methods to override numeric result	2023-12-19 13:50:31 +09:00
Dan Balasescu	295a1b01d6	Adjust catch score grade cutoffs	2023-11-29 19:05:31 +09:00
Dan Balasescu	8314f656a3	Encapsulate common HP logic from osu and catch HP calculations	2023-11-24 18:32:06 +09:00
Dan Balasescu	c126c46e2d	Remove legacy implementations (moved to osu-tools)	2023-11-24 15:43:57 +09:00
Dan Balasescu	4ba6450c77	Use better break calculation	2023-11-24 13:49:28 +09:00
Dan Balasescu	acf3de5e25	Add CatchHealthProcessor, following legacy calculations	2023-11-24 13:49:28 +09:00
Dan Balasescu	62a04a93c8	Implement legacy catch health processor	2023-11-24 13:49:28 +09:00
Dan Balasescu	c291d6fc82	Remove catch tiny droplet portion	2023-05-23 15:36:34 +09:00
Dan Balasescu	30a296bd09	Rename parameters	2023-05-19 17:27:02 +09:00
Dan Balasescu	6c6f8621c1	Add score processor statistics to replay header	2023-05-19 16:29:24 +09:00
Dan Balasescu	d74bf2a096	Refactor for safety	2023-05-19 14:37:26 +09:00
Dan Balasescu	2ae34530f7	Avoid NaN values during ApplyBeatmap processing()	2023-05-19 14:14:34 +09:00
Dan Balasescu	7cbf48ffcf	Fix TestSceneScoring and incorrect combo calculations	2023-05-19 14:09:19 +09:00
Dan Balasescu	8b56a3f87d	Remove ClassicScoreMultiplier and DefaultScoreProcessor	2023-05-19 12:24:52 +09:00
Dan Balasescu	a7b623f52a	Reimplement classic scoring mode	2023-05-09 20:21:38 +09:00
Dan Balasescu	3c3c812ed6	Initial implementation of ScoreV2	2023-05-09 19:33:33 +09:00
ekrctb	b08a1e3a0b	Remove #nullable disable from misc Catch files	2023-01-15 17:29:35 +09:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Dan Balasescu	daac933498	Remove unnecessary ctor arguments	2022-03-15 12:34:58 +09:00
Dan Balasescu	59d57a44d4	Prevent incorrect usages by hard-typing ctor type	2022-03-15 09:11:59 +09:00
Dan Balasescu	3fff7f4b7e	Require ScoreProcessor to receive ruleset	2022-03-14 15:51:10 +09:00
Dan Balasescu	c36badab4b	Add per-ruleset score multipliers for classic scoring	2022-03-10 10:26:09 +09:00
Bartłomiej Dach	122a624b7f	Remove bogus CatchHitWindows ... `CatchHitWindows` were a vestige from the past, and were not actually used anywhere except for the hit error meter test, giving off an appearance that the hit error meter was working properly. `CatchHitObject` actually specifies empty hit windows.	2021-06-07 13:16:07 +02:00
smoogipoo	f439c1afbc	Make osu/taiko/catch use Ok+Great	2020-09-29 17:16:55 +09:00
smoogipoo	31fae045fa	Update judgement processors with new hit results	2020-09-29 16:33:38 +09:00
smoogipoo	522847987b	Implement break/gameplay start times	2019-12-26 15:00:58 +09:00
smoogipoo	90cb9d9162	Simplify scoreprocesor/healthprocessor implementations	2019-12-26 14:59:49 +09:00
smoogipoo	76f2fb378f	Separate score and health parts of ScoreProcessor	2019-12-19 20:03:14 +09:00
smoogipoo	48f1dad4aa	Remove abstract ScoreProcessor class	2019-12-11 17:25:06 +09:00
Dean Herbert	f925e781a9	Refactor HitWindows for legibility	2019-09-06 15:24:14 +09:00
smoogipoo	13b9b04bb8	Apply more cases/fix some existing ones	2019-05-07 13:23:09 +09:00
smoogipoo	aeae759fcd	Rename method + add xmldoc	2019-04-22 18:08:15 +09:00
smoogipoo	4edb17a88a	Make hp work + cleanup	2019-04-22 18:02:49 +09:00
smoogipoo	78c844e259	Make catch provide some HP at DrainRate=10	2019-04-22 17:24:22 +09:00
smoogipoo	d7919544fe	Implement approximate hp increase for catch	2019-04-22 16:59:14 +09:00
Dean Herbert	3b7a76aa4e	Fix typo	2019-03-20 11:22:34 +09:00
Dean Herbert	baea7230bc	Rename RulesetContainer to DrawableRuleset	2019-03-19 23:47:31 +09:00
Dean Herbert	2d7c23dd9f	Merge remote-tracking branch 'upstream/master' into fix-replay-import-statistics	2019-02-04 12:15:53 +09:00
Dean Herbert	8617aaa2a7	Update licence header (and remove year)	2019-01-24 17:43:03 +09:00
Dean Herbert	aec3753863	Fix imported replays having excess statistics	2019-01-03 14:01:20 +09:00
smoogipoo	b64932f6db	Implement hit windows	2018-12-27 22:39:15 +09:00