Bartłomiej Dach
8ac0a759f0
Set combo immediately rather than via repeat steps
...
Doesn't help anyone to be waiting literal minutes for combo to hit 50 or
150 in a test scene supposed to quickly visually demonstrate a
component. Doesn't help for CI runtime, either.
2022-11-22 20:30:27 +01:00
Bartłomiej Dach
5a5b0ed4ef
Restructure tests not to call each other
...
Bit weird to have tests call other tests. Private helper methods is
better, if unavoidable.
2022-11-22 20:28:41 +01:00
Bartłomiej Dach
8dbc38e17a
Remove unused setter
2022-11-22 20:14:22 +01:00
Bartłomiej Dach
39934bccd6
Add back removed test coverage
2022-11-22 19:47:41 +01:00
Bartłomiej Dach
0d2d77f276
Merge pull request #21377 from peppy/song-select-alt-scroll-only
...
Change song select to only allow volume adjusting if alt is held while scrolling
2022-11-22 19:00:04 +01:00
Bartłomiej Dach
012e69fe4f
Merge branch 'master' into song-select-alt-scroll-only
2022-11-22 17:29:58 +01:00
Bartłomiej Dach
54c2becda7
Merge pull request #21372 from peppy/mania-hold-note-end-nearby-tests
...
Add test coverage of input near end of hold note with nearby subsequent note
2022-11-22 17:29:44 +01:00
Joppe27
db34fa99b1
Add tests and clean up inefficient code
2022-11-22 17:22:34 +01:00
Joppe27
5343f6922c
Add legacy circle piece animations based on combo
2022-11-22 17:22:00 +01:00
Bartłomiej Dach
76bb529cfa
Add test for local echo adding day separator
2022-11-22 16:46:21 +01:00
Bartłomiej Dach
eb311f3fe5
Merge branch 'master' into mania-hold-note-end-nearby-tests
2022-11-22 16:41:25 +01:00
Dean Herbert
de163b2bb5
Change song select to only allow volume adjusting if alt is held while scrolling
2022-11-22 19:48:55 +09:00
Dan Balasescu
2e4dc7c467
Merge pull request #21371 from peppy/fix-mania-hold-note-stuck
...
Fix osu!mania hold notes occasionally getting in a visually incorrect hit state
2022-11-22 17:14:39 +09:00
Dean Herbert
c1b193149c
Add test coverage of input near end of hold note with nearby subsequent note
...
Covers the scenarios mentioned in #21371 .
Turns out this seems mostly okay already, so there are no fixes applied here.
2022-11-22 17:09:14 +09:00
Dean Herbert
57723107dd
Fix osu!mania hold notes occasionally getting in a visually incorrect hit state
...
To correctly end a mania hold note, `endHold()` needs to be called. This
was not happening in a very specific scenario:
- The hold note's head is not hit
- The user pressed the column's key within the hold note's tail's window,
but does so to hit the next object (a note in proximity to the hold note's tail).
- The hit policy forces a miss on the hold note, but `endHold()` is not called
- `CheckForResult` is not called after this point due to `Judged` being `true`.
Closes #21311 .
2022-11-22 16:15:34 +09:00
Dean Herbert
1632df1f4d
Update DifficultyBindable to match new bindable spec
2022-11-22 14:51:19 +09:00
Dan Balasescu
6b75f529c7
Merge pull request #21366 from bdach/broken-rank-graph-test
...
Fix broken rank graph test
2022-11-22 14:35:14 +09:00
Dan Balasescu
985781bc3b
Merge pull request #21356 from peppy/standardise-broken-storyboard-paths
...
Add support for storyboards with incorrect path specifications (`\\` instead of `\`)
2022-11-22 14:33:51 +09:00
Bartłomiej Dach
cd43e83494
Merge pull request #21344 from peppy/tablet-settings-test-scene
...
Fix `TestSceneTabletSettings` falling off the bottom of the screen
2022-11-21 21:46:15 +01:00
Bartłomiej Dach
41039340cf
Fix rank graphs not showing in test due to unset IsRanked
2022-11-21 21:00:06 +01:00
Bartłomiej Dach
1777a60136
Add failing assertions
2022-11-21 20:58:52 +01:00
Bartłomiej Dach
735cac3104
Rewrite rank graph test to use more modern style
2022-11-21 20:56:38 +01:00
Bartłomiej Dach
f36ccab84e
Merge branch 'master' into tablet-settings-test-scene
2022-11-21 20:42:04 +01:00
Bartłomiej Dach
4490504104
Merge pull request #21346 from peppy/higher-aspect-ratio-max
...
Increase maximum aspect ratio for tablet settings to 23:9 / 2.55
2022-11-21 20:41:47 +01:00
Bartłomiej Dach
8dbe31a172
Merge branch 'master' into higher-aspect-ratio-max
2022-11-21 19:51:39 +01:00
Bartłomiej Dach
f75353d8f4
Merge pull request #21350 from peppy/hide-no-spin-bonus
...
Hide spinner ticks / bonus from results screen when not applicable to score
2022-11-21 19:50:56 +01:00
Bartłomiej Dach
ff5cb116f0
Fix weird scroll container sizing
2022-11-21 19:27:06 +01:00
Bartłomiej Dach
c0f65d83b3
Merge branch 'master' into hide-no-spin-bonus
2022-11-21 19:14:54 +01:00
Bartłomiej Dach
c79841dad2
Merge pull request #21360 from peppy/mania-argon-hold-better
...
Realign white line on argon hold note ends to match hit target
2022-11-21 18:53:05 +01:00
Bartłomiej Dach
c805eb330a
Merge branch 'master' into mania-argon-hold-better
2022-11-21 18:17:35 +01:00
Bartłomiej Dach
d5e9cb2477
Merge pull request #21352 from peppy/avoid-null-audio-device-name-crahs
...
Avoid crashing when a system audio device provides a `null` name
2022-11-21 17:16:30 +01:00
Bartłomiej Dach
206aece77b
Merge branch 'master' into avoid-null-audio-device-name-crahs
2022-11-21 16:37:13 +01:00
Bartłomiej Dach
7944d9cefa
Merge pull request #21304 from EVAST9919/beatmap-bar
...
Rework BarGraph to use Quads
2022-11-21 16:24:18 +01:00
Dean Herbert
b404b87f68
Realign white line on argon hold note ends to match hit target
2022-11-21 18:26:53 +09:00
Terochi
d81ef541bc
Variant 5: cannot change history, edit resets index
2022-11-21 10:17:28 +01:00
Terochi
7dc7729ac2
Variant 4: cannot change history, empty text/everything selected resets index (current with bug fix)
2022-11-21 10:11:26 +01:00
C0D3 M4513R
93ab1c9432
Merge branch 'master' into beatmap-info
2022-11-21 09:01:24 +00:00
Terochi
58288275a6
Variant 3: cannot change history, cannot reset index (the "default")
2022-11-21 09:43:36 +01:00
Terochi
672e1cd45b
Variant 2: edit changes history, cannot reset index (similar to stable)
2022-11-21 09:41:29 +01:00
Terochi
8f942f130b
Variant 1: edit changes history, empty text resets index
2022-11-21 09:36:31 +01:00
Andrei Zavatski
ec8532951c
Make Thickness property auto
2022-11-21 10:32:19 +03:00
Dean Herbert
2774c1ea49
Merge pull request #21215 from jai-x/triangles-bundled-beatmap
...
Add winner of Triangles mapping competition as a bundled beatmap
2022-11-21 16:22:23 +09:00
Andrei Zavatski
14a4de36f4
Expose thickness property
2022-11-21 10:20:35 +03:00
Dean Herbert
3da21e596a
Add support for storyboards with incorrect path specifications (\\ instead of \)
...
Closes https://github.com/ppy/osu/issues/21204 .
2022-11-21 16:12:01 +09:00
Dean Herbert
9a330c3cdb
Apply nullability and clean up conditionals
2022-11-21 15:02:45 +09:00
Dean Herbert
a07b033d22
Merge branch 'master' into triangles-v2
2022-11-21 14:55:01 +09:00
Dean Herbert
981264b011
Avoid crashing when a system audio device provides a null name
2022-11-21 14:51:41 +09:00
Dean Herbert
40f2da364c
Limit how far before the first hitobject that barlines can be generated
2022-11-21 14:40:25 +09:00
Dean Herbert
93a189603a
Hide spinner ticks / bonus from results screen when not applicable to score
2022-11-21 14:20:36 +09:00
Dean Herbert
4a79141824
Merge pull request #21338 from RATCM/fix-leaderboard-filter
...
Match leaderboard filter behaviour to web
2022-11-21 14:01:55 +09:00
