62623 Commits

This Branch

This Branch

All Branches

• Fix broken automatic beatmap download setting migration
  Bartłomiej Dach · 2023-09-19 21:38:07 +02:00
  333b839e0d
• Fix DrawableStoryboardVideo attempting to unmap path once too much

  The `StoryboardResourceLookupStore` cached at storyboard level is
  supposed to already be handling that; no need for local logic anymore.

  Bartłomiej Dach · 2023-09-19 20:18:33 +02:00
  641e651bf2
• Fix StoryboardResourceLookupStore dying on failure to unmap path

  Before the introduction of `StoryboardResourceLookupStore`, missing
  files would softly fail by use of null fallbacks. After the
  aforementioned class was added, however, the fallbacks would not work
  anymore if for whatever reason `GetStoragePathFromStoryboardPath()`
  failed to unmap the storyboard asset name to a storage path.

  Bartłomiej Dach · 2023-09-19 20:11:16 +02:00
  ba518e1da8
• Merge pull request #24800 from sw1tchbl4d3r/invalid_bank

  Default to normal bank if invalid sample bank is specified

  Dean Herbert · 2023-09-19 22:28:34 +09:00
  aea7f81f1c
• Replace sample bank fix with more correct fix

  stable does not treat unknown enum members as `None` / `Auto`, it treats
  them as `Normal`:
  
      switch (sampleSet)
      {
          case SampleSet.Normal:
          default:
              sample = 0;
              break;
          case SampleSet.None:
          case SampleSet.Soft:
              sample = 1;
              break;
          case SampleSet.Drum:
              sample = 2;
              break;
      }
  
      (from https://github.com/peppy/osu-stable-reference/blob/1531237b63392e82c003c712faa028406073aa8f/osu!/Audio/AudioEngine.cs#L1158-L1171).

  Bartłomiej Dach · 2023-09-19 13:53:49 +02:00
  c4a0ca326e
• Replace test with better test
  Bartłomiej Dach · 2023-09-19 13:47:46 +02:00
  320a9fc171
• Merge pull request #24612 from peppy/add-app-category

  Add application category type to enable game mode on new macOS versions

  Dean Herbert · 2023-09-19 20:21:53 +09:00
  ca659c8eda
• Merge pull request #24809 from peppy/storyboard-resource-lookup-refactor

  Refactor storyboard resource lookup to be more streamlined

  Bartłomiej Dach · 2023-09-19 12:52:02 +02:00
  43ae26b8ef
• Merge pull request #24810 from peppy/remove-slider-head-movement-allowance

  Remove slider head circle movement (and remove setting from "classic" mod)

  Bartłomiej Dach · 2023-09-19 12:25:33 +02:00
  92cafe23fe
• Merge pull request #24450 from cdwcgt/missing-beatmap

  Fetch missing beatmap when importing replay

  Dean Herbert · 2023-09-19 18:40:02 +09:00
  067c487b21
• Fix notification text sets overwriting each other
  Bartłomiej Dach · 2023-09-19 11:12:58 +02:00
  ed9039f60f
• Merge pull request #24860 from bdach/beatmap-card-thumbnail-match-better

  Adjust beatmap card thumbnail dim state to match web better

  Dean Herbert · 2023-09-19 18:02:35 +09:00
  fd28c0de79
• Increase transition speed slightly
  Dean Herbert · 2023-09-19 18:02:08 +09:00
  05e05f8160
• Remove unused translations
  Dean Herbert · 2023-09-19 17:53:00 +09:00
  cdb5fea513
• Pass ArchiveReader instead of Stream to simplify resolution code
  Dean Herbert · 2023-09-19 17:49:15 +09:00
  f726c38215
• Fix log output using incorrect name
  Dean Herbert · 2023-09-19 17:34:24 +09:00
  0593c76c57
• Adjust beatmap card thumbnail dim state to match web better
  Bartłomiej Dach · 2023-09-19 10:28:08 +02:00
  62f97a8d83
• Adjust sizing slightly to remove need for CollapsibleButtonContainerSlim
  Dean Herbert · 2023-09-19 17:20:58 +09:00
  7f30354e61
• Add comment mentioning why hover is disabled on the notification type
  Dean Herbert · 2023-09-19 16:35:22 +09:00
  0555d22eb8
• Tweak nano beatmap card UX further to meet expectations
  Bartłomiej Dach · 2023-09-19 08:36:32 +02:00
  8e199de78a
• Check if path lists are empty
  Magnus-Cosmos · 2023-09-19 02:28:28 -04:00
  73db68a49a
• Fix typo in comment
  Dean Herbert · 2023-09-19 15:27:56 +09:00
  c0f603eb0e
• Apply NRT to slider snaking tests
  Dean Herbert · 2023-09-19 14:51:03 +09:00
  046e96afcd
• Merge pull request #24831 from peppy/update-deps

  Update all dependencies (except for Moq)

  Bartłomiej Dach · 2023-09-19 07:50:27 +02:00
  0ffb906741
• Update tests in line with new slider snaking behaviour
  Dean Herbert · 2023-09-19 14:42:07 +09:00
  4504c9fc43
• Avoid fast fade out if slider head was not hit
  Dean Herbert · 2023-09-19 14:38:53 +09:00
  0360646e9b
• Fix slider path calculations for edge cases
  Magnus-Cosmos · 2023-09-19 01:31:26 -04:00
  a9b45c6fdc
• Merge pull request #24824 from bdach/scoring-test-scene-mania

  Add scoring test scene for mania

  Dean Herbert · 2023-09-19 14:05:15 +09:00
  144847779d
• Merge branch 'master' into scoring-test-scene-mania
  Dean Herbert · 2023-09-19 14:01:07 +09:00
  84d63f1445
• Merge pull request #24823 from bdach/scoring-test-scene-catch

  Add scoring test scene for catch

  Dean Herbert · 2023-09-19 13:59:11 +09:00
  aba98f2985
• Merge pull request #24854 from frenzibyte/fix-player-test-scene-crash

  Fix crash when loading player instance without exiting previous instance

  Dean Herbert · 2023-09-19 13:47:21 +09:00
  33582b7273
• Fix crash when loading player instance without exiting previous instance
  Salman Ahmed · 2023-09-19 05:09:01 +03:00
  8e992de763
• Merge branch 'master' into missing-beatmap
  Dean Herbert · 2023-09-19 04:01:56 +09:00
  72457147a7
• Add test for slider path edge case
  Magnus-Cosmos · 2023-09-18 12:02:20 -04:00
  bd7dab1d86
• Fix extension check using control points instead of path points
  Magnus-Cosmos · 2023-09-18 11:40:00 -04:00
  83584519e6
• Merge branch 'master' into scoring-test-scene-catch
  Bartłomiej Dach · 2023-09-18 15:15:03 +02:00
  8b5a851f31
• Merge pull request #24846 from bdach/get-reader-regression

  Fix `MemoryStreamArchiveReader.GetStream()` failing in some cases

  Dean Herbert · 2023-09-18 22:06:33 +09:00
  163b6df357
• Auto-close notification after successful download
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  25e43bd7d7
• Use different copy when auto-downloading
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  4cdd19bb5a
• Rename spectator-specific settings to more generic (with backwards migration)
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  3bddf4bf9a
• Make missing beatmap notification simple

  Progress didn't work for several reasons:
  
  - It was spinning when nothing was actually happening yet
    (especially egregious with autodownload off)
  
  - It was blocking exits (as all progress notifications do)
  
  - When actually going to download, two progress notifications would
    pertain to one thing
  
  - It wasn't helping much with the actual implementation of score
    re-import, cancelling the progress notification would result in
    similarly jank UX of beatmap importing but not the score.

  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  27471ad170
• Reword and localise copy
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  b2c98da330
• Integrate nano beatmap card into the notification
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  2709c6cd67
• Add very basic visual tests for missing beatmap notification

  The full-stack test using the whole 9 `OsuGameTest` yards is unusable
  for rapid development. I don't really get how you could ever design
  anything using it without tossing your computer out the window.

  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  775f96f061
• Fix OsuTestScene.CreateAPIBeatmapSet() not backlinking set beatmaps to the set
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  47764b3012
• Redo nano beatmap card design to fit needs better

  Wanting to use this inside notification, it turns out that the original
  design did not work very well at such narrow widths, and additionally
  the typical button setup borrowed from elsewhere resulted in teeny tiny
  action buttons.
  
  To that end, slim down the design (get rid of thumbnail, audio preview,
  make expandable right side slimmer), as well as change the entire panel
  so that it has only one action associated with it at all times, and
  clicking the panel in any place triggers that action.

  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  5fcd736332
• Merge branch 'get-reader-regression' into missing-beatmap
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  67b5dfb9cf
• Merge branch 'beatmap-card-nano' into missing-beatmap
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  06d1a2a316
• Merge pull request #24822 from bdach/scoring-test-scene-taiko

  Add scoring test scene for taiko

  Dean Herbert · 2023-09-18 21:04:40 +09:00
  18c18fef22
• Merge branch 'master' into scoring-test-scene-taiko
  Dean Herbert · 2023-09-18 19:55:05 +09:00
  41f2644713