Dean Herbert
653480b2f8
Add regression test
2020-03-29 23:29:46 +09:00
Dean Herbert
e9dc545429
Merge branch 'master' into fix-no-break-info
2020-03-28 12:39:37 +09:00
Dean Herbert
a317ef65b8
Remove default for argument
2020-03-28 12:18:28 +09:00
Bartłomiej Dach
15fb1a099e
Modify assert to avoid false failures
...
In headless tests it was possible for TestInstantLoad() to erroneously
fail. There were two scenarios in which LoadingSpinner could be null:
1. If the test runner was quick enough, the assert could end up running
even before Loader.OnEntering() had even had a chance to, meaning
that the spinner was never even actually assigned to or instantiated
at that point in time.
2. Even if Loader.OnEntering() had managed to run, there was also
a possibility that the spinner itself wasn't loaded at the point
of checking the assertion. As the spinner is accessed through
ChildrenOfType(), which only checks InternalChildren and ignores
all currently-loading drawables, it would therefore return null.
As null != 0, both of these cases would actually fail the test (this is
best seen running headless, preferably with a [Repeat] attribute
attached).
To resolve, allow the spinner to be null at the point of asserting and
duplicate the assertion step at the end. This weakens the test, as case
(1) should probably be waited for and case (2) could be solved with
exposition as protected in the base, but when attempting to wait for
the loader itself to be loaded there were also cases where the
appropriate until step would take so much time that the spinner would
actually become visible in line with the delayed display logic, so this
is a best-effort attempt to address both points without radical
changes.
2020-03-28 00:43:57 +01:00
Bartłomiej Dach
46af4bce32
Cover regression in autoplay test
2020-03-27 19:42:45 +01:00
Dean Herbert
6ecfeb8cc3
Merge pull request #8455 from Game4all/handle-novideo-beatmaps
...
Fix NullReferenceException when starting the no-video version of a beatmap with video
2020-03-27 21:12:40 +09:00
Lucas A
6788b7f9cd
Add test for loading storyboards with missing video file.
2020-03-27 12:07:47 +01:00
Dean Herbert
07462120e4
Split break tracking into its own component
2020-03-26 15:30:23 +09:00
Andrei Zavatski
1e025b7c31
Add tests to cover the issue
2020-03-25 20:58:51 +03:00
Dean Herbert
880d138a47
Fix intro tests not asserting pass or working at all
2020-03-25 15:12:19 +09:00
Dean Herbert
98e6896e93
Rename test class
2020-03-23 15:37:34 +09:00
Dean Herbert
680d058f3f
Merge branch 'master' into friends-layout-split
2020-03-23 15:36:04 +09:00
Dan Balasescu
d0c7b49376
Merge branch 'master' into fix-carousel-root-selects-from-nothing
2020-03-23 11:34:04 +09:00
smoogipoo
448e5c0deb
Merge branch 'master' into fix-carousel-root-selects-from-nothing
2020-03-23 11:15:22 +09:00
smoogipoo
bf70276496
Fix test re-using the same beatmap sets
2020-03-23 11:12:36 +09:00
Dan Balasescu
fb21c7d82d
Merge branch 'master' into fix-carousel-restore-previous-selection
2020-03-23 11:01:18 +09:00
Dean Herbert
bfd643dd16
Rename classes
2020-03-23 10:47:27 +09:00
Dean Herbert
0b728f483f
Rename base test class to help avoid incorrect reference
2020-03-23 10:01:33 +09:00
Andrei Zavatski
2b0c267cb9
Expose Fetch method
2020-03-21 20:37:21 +03:00
Andrei Zavatski
f8169e9712
Merge remote-tracking branch 'refs/remotes/ppy/master' into friends-layout-split
2020-03-21 20:31:38 +03:00
Dean Herbert
febf9adabd
Merge pull request #8329 from Fuewburvpoa/MyBranch
...
Fix beat divisor control selecting invalid divisors on drag end
2020-03-22 02:21:13 +09:00
Dean Herbert
8136ea561e
Fix a couple of broken tests
2020-03-20 15:02:13 +09:00
Dean Herbert
9b60b535e5
Fix selection not occurring when switching from empty ruleset on first load
2020-03-20 15:01:26 +09:00
Dean Herbert
3a50c4bb51
Update tests
2020-03-19 18:58:22 +09:00
Dean Herbert
c50784da93
Show 'D' rank badge on accuracy circle
2020-03-19 11:58:52 +09:00
Bartłomiej Dach
23338a6c82
Adjust test implementation
...
* Use slider bar and slider marker coordinates in manual tests instead
of hard-coded offsets.
* Reword test steps slightly for greater clarity.
2020-03-18 22:23:06 +01:00
Bartłomiej Dach
1d3cac4cdc
Eliminate osuTK.Input namespace qualifications
2020-03-18 21:55:35 +01:00
Bartłomiej Dach
4bda520695
Use [SetUp] instead of reset method
2020-03-18 21:54:17 +01:00
Fuewburvpoa
648e9fa21f
Merge branch 'master' into MyBranch
2020-03-18 21:18:17 +02:00
Fuewburvpoa
d5541dfc65
Codefactor fix
2020-03-18 21:06:14 +02:00
Fuewburvpoa
463dde1fc4
Tests for BeatDivisorControl
2020-03-18 21:04:38 +02:00
Dan Balasescu
9b029fa9e0
Merge pull request #8212 from peppy/update-loader-animation
...
Update loader animation
2020-03-18 12:07:50 +09:00
Dan Balasescu
514e72bffb
Merge branch 'master' into update-loader-animation
2020-03-18 11:36:29 +09:00
Dan Balasescu
04991315f9
Merge branch 'master' into improve-chat-test
2020-03-18 11:30:48 +09:00
Bartłomiej Dach
944f0b0285
Rewrite tests
...
* Use [Cached] injection instead of modifying beatmaps read from store.
* Add assertion steps verifying the presence of mapper name (or lack
thereof).
2020-03-17 20:45:48 +01:00
Andrei Zavatski
e951979a12
Remove assert from online test
2020-03-17 22:34:46 +03:00
Andrei Zavatski
4d376636c3
Merge remote-tracking branch 'refs/remotes/ppy/master' into friends-layout-split
2020-03-17 22:12:48 +03:00
recapitalverb
7186e3466b
Fix formatting issues
2020-03-18 01:39:19 +07:00
recapitalverb
dc73105a10
Add tests for beatmaps with(out) null mappers
2020-03-18 01:33:01 +07:00
Dean Herbert
2d6dcb3ba9
Merge branch 'master' into results-screen
2020-03-17 22:03:36 +09:00
Dean Herbert
b27bb4aeae
Merge branch 'master' into results-middle-content
2020-03-17 21:37:23 +09:00
Dean Herbert
75695938e2
Merge branch 'master' into results-top-content
2020-03-17 20:42:02 +09:00
Dean Herbert
3b9c64b76f
Merge branch 'master' into results-scorepanel
2020-03-17 20:06:11 +09:00
smoogipoo
6f569d1485
Fix colour conflicts for expert-plus
2020-03-17 18:01:46 +09:00
smoogipoo
1c4296f5e7
Implement the new results screen
2020-03-17 17:43:16 +09:00
smoogipoo
afed01d781
Merge branch 'results-middle-content' into results-screen
2020-03-17 17:35:40 +09:00
smoogipoo
1521f25c96
Implement middle panel contents
2020-03-17 17:25:24 +09:00
smoogipoo
19106daf8b
Merge branch 'results-circle' into results-middle-content
2020-03-17 17:09:15 +09:00
smoogipoo
7cc1a6040f
Implement top panel contents
2020-03-17 17:01:38 +09:00
smoogipoo
05789e6fe4
Implement the score panel
2020-03-17 16:59:34 +09:00
