Dean Herbert
189c680555
Add basic xmldoc on interface type
2024-02-27 20:46:25 +08:00
Bartłomiej Dach
bbdd85020c
Fix slider tails sometimes not dimming correctly
...
Originally noticed during review of another change:
https://github.com/ppy/osu/pull/27369#issuecomment-1966140198 .
`DrawableOsuHitObject` tries to solve the initial dimming of objects
by applying transform to a list of dimmable parts. For plain drawables
this is safe, but if one of the parts is a DHO, it is not safe,
because drawable transforms can be cleared at will.
In particular, on first use of a drawable slider,
`UpdateInitialTransforms()` would fire via `LoadComplete()` on the
`DrawableSlider`, but *then*, also via `LoadComplete()`,
the `DrawableSliderTail` would update its own state and by doing so
inadvertently clear the dim transform just added by the slider.
To fix, ensure dim transforms are applied to DHOs
via `ApplyCustomUpdateState`.
2024-02-27 11:45:03 +01:00
Dan Balasescu
069b400dd0
Move manager to desktop game
2024-02-27 19:36:03 +09:00
Bartłomiej Dach
087a2a741a
Merge pull request #27369 from Detze/incorrect-slider-head-dim
...
Fix slider head being incorrectly dimmed twice
2024-02-27 11:17:34 +01:00
Dan Balasescu
dc3b41865c
Add logging
2024-02-27 19:17:34 +09:00
Dan Balasescu
f2d52fbaa2
Make class not overrideable
2024-02-27 17:33:24 +09:00
Dean Herbert
7f0a552b86
Merge pull request #27366 from EVAST9919/mod-overlay-performnce
...
Reduce allocations when `ModSelectOverlay` is visible
2024-02-27 08:54:18 +08:00
Salman Ahmed
83af9dfb39
Fix aa_width being incorrect
2024-02-27 02:43:02 +03:00
Salman Ahmed
18e26e39fe
Remove SliderBorderSize for simplicity
2024-02-27 02:20:34 +03:00
Salman Ahmed
2f54775182
Add stable code references
2024-02-27 02:17:02 +03:00
Salman Ahmed
81e6a6d96a
Rewrite LegacySliderBody rendering to perfectly match stable
2024-02-27 02:11:32 +03:00
Salman Ahmed
e01722a266
Revert "Match stable's slider border thickness more closely"
...
This reverts commit 3502ec456d
2024-02-27 01:30:20 +03:00
Salman Ahmed
8363c39da8
Revert "Match stable's slider border thickness perfectly"
...
This reverts commit 8032ce9225
2024-02-27 01:30:20 +03:00
Salman Ahmed
2151e0a294
Improve test coverage
2024-02-26 22:30:09 +03:00
Salman Ahmed
3f9fbb9318
Introduce the concept of ActiveMods in mod select overlay and rewrite once more
2024-02-26 22:25:06 +03:00
Salman Ahmed
2b73d816a7
Bring back mod setting tracker in BeatmapAttributesDisplay
2024-02-26 22:24:45 +03:00
Detze
8032ce9225
Match stable's slider border thickness perfectly
2024-02-26 18:37:27 +01:00
Bartłomiej Dach
3833f2cfa7
Merge pull request #27393 from peppy/main-menu-key-delay
...
Fix main menu eating keys if user presses too fast
2024-02-26 16:22:27 +01:00
Bartłomiej Dach
ab90b756e7
Merge pull request #27390 from peppy/cutoff-fix
...
Fix low pass filter getting stuck in multiple locations
2024-02-26 16:19:16 +01:00
Dean Herbert
fe59a3b9be
Merge branch 'master' into medals
2024-02-26 22:49:55 +08:00
Dean Herbert
4c6e8a606f
Fix main menu eating keys if user presses too fast
2024-02-26 22:24:39 +08:00
Dean Herbert
d6622c1756
Add test coverage of fast menu keypresses failing to register
2024-02-26 22:24:39 +08:00
Dan Balasescu
bfb5098238
Use high performance session during gameplay
2024-02-26 22:32:48 +09:00
Dean Herbert
c686dfd361
Apply safeties for AudioFilter usage around drawables which go non-present
2024-02-26 21:22:25 +08:00
Dean Herbert
7a96cf1289
Expose AudioFilter.IsAttached publicly
2024-02-26 21:15:44 +08:00
Dan Balasescu
3e9425fdf2
Adjust API of HighPerformanceSession + rename
2024-02-26 22:12:46 +09:00
Bartłomiej Dach
09b420a083
Merge pull request #27234 from brandondong/delete_none_message
...
Add feedback to delete button even when no-op
2024-02-26 13:13:53 +01:00
Susko3
9b3ec64f41
Inline HKCU\Software\Classes usage
2024-02-26 13:10:37 +01:00
Susko3
f2807470ef
Inline EXE_PATH usage
2024-02-26 13:03:23 +01:00
Bartłomiej Dach
119a373285
Merge pull request #27389 from peppy/menu-hotkeys
...
Allow better menu navigation using same hotkey to progress to destination
2024-02-26 12:31:22 +01:00
Bartłomiej Dach
46ec477191
Merge pull request #27386 from peppy/fix-use-current-distance-snap
...
Fix "Use current" snap not working
2024-02-26 12:30:35 +01:00
Susko3
6dbba705b3
Refine uninstall logic to account for legacy windows features
2024-02-26 12:27:02 +01:00
Dean Herbert
588e510363
Merge pull request #26181 from rushiiMachine/flashlight-playfield-based-size-
...
Make flashlight scale with playfield
2024-02-26 19:18:40 +08:00
Bartłomiej Dach
8966ea2fa3
Add test coverage
2024-02-26 11:59:57 +01:00
Dean Herbert
8e336610d0
Add xmldoc explaining Ruleset bindable's usage
2024-02-26 18:31:40 +08:00
Bartłomiej Dach
353485a707
Merge branch 'master' into flashlight-playfield-based-size-
2024-02-26 10:55:06 +01:00
Bartłomiej Dach
115d82664b
Assert proportional scaling rather than assume average
...
Because if scaling is ever actually non-proportional then this should be
somewhat loud.
Also use the absolute value to prevent funny things happening if/when
someone does negative scale.
2024-02-26 10:53:04 +01:00
Dean Herbert
8962be2ed5
Allow better menu navigation using same hotkey to progress to destination
...
As touched on in https://github.com/ppy/osu/discussions/27102 .
You can now use:
- `L L L` to get to playlists
- `M M M` to get to multiplayer
- `S` to get to settings
2024-02-26 17:24:04 +08:00
Dean Herbert
9a46e738bd
Fix inspections
2024-02-26 15:45:29 +08:00
Dean Herbert
4c744ccb69
Fix "Use current" snap not working
...
Regressed with https://github.com/ppy/osu/pull/27249 .
I was suspicious of this specific operation at the time but didn't test properly.
2024-02-26 14:11:54 +08:00
Detze
3502ec456d
Match stable's slider border thickness more closely
2024-02-26 04:36:09 +01:00
Dean Herbert
b0c45c87c6
Merge pull request #27379 from EVAST9919/gameplay-alloc
...
Further reduce allocations during gameplay
2024-02-26 09:55:28 +08:00
Dean Herbert
4421ff975b
Add local function to perform iteration to better explain the "why"
2024-02-26 09:04:39 +08:00
Salman Ahmed
b30a6d5224
Adjust existing test coverage
2024-02-25 21:23:14 +03:00
Salman Ahmed
5c049feca1
Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps
2024-02-25 21:18:15 +03:00
Andrei Zavatski
9e3defebda
Remove unused using
2024-02-25 19:05:40 +03:00
Andrei Zavatski
c3fa97d062
Reduce allocations in HitObjectLifetimeEntry
2024-02-25 18:02:42 +03:00
Andrei Zavatski
f948f8ee5c
Fix HUDOverlay allocations
2024-02-25 17:59:20 +03:00
Andrei Zavatski
081aa84718
Simplify last footer button selection
2024-02-25 10:36:15 +03:00
Dean Herbert
e8d2abc4f7
Merge pull request #27364 from EVAST9919/spinner-alloc
...
Reduce osu spinner allocations
2024-02-25 09:36:02 +08:00
