Dean Herbert
61a8873266
Ensure GameplayClockContainer's FramedClock is always non-null
2022-08-15 20:22:36 +09:00
Dean Herbert
1696a905ba
Reduce exposed properties in GameplayClockContainer
2022-08-15 20:22:36 +09:00
Dean Herbert
704568ae3b
Remove remaining usage of GameplayClock
2022-08-15 20:22:36 +09:00
Dean Herbert
43442dbf65
Merge branch 'even-less-gameplay-clock' into even-nicer-frame-stability-clock
2022-08-15 20:22:30 +09:00
Dean Herbert
87760bbc06
Fix IsCatchingUp not being in correct state
2022-08-15 20:17:48 +09:00
Dean Herbert
1fc3d005c0
Seal FrameStabilityContainer
...
No one should ever derive from this class. It is already too complex.
2022-08-15 19:31:02 +09:00
Dean Herbert
fff2b57905
Tidy up and document FrameStabilityContainer
2022-08-15 19:28:12 +09:00
Dean Herbert
9bc2e91de0
Fix incorrect handling of reference clocks when no parent IGameplayClock is available
2022-08-15 19:19:19 +09:00
Dean Herbert
04d88b8216
Use constraint based assertions in TestSceneFrameStabilityContainer
2022-08-15 19:19:19 +09:00
Dean Herbert
828b6f2c30
Remove unnecessary setClock shenanigans
2022-08-15 19:19:19 +09:00
Dean Herbert
27569e2ed5
Remove FrameStableClock (and redirect usages to FrameStabilityContainer)
2022-08-15 19:19:19 +09:00
Bartłomiej Dach
71961b244e
Merge branch 'master' into less-gameplay-clock
2022-08-15 11:58:30 +02:00
Bartłomiej Dach
11854158a8
Merge pull request #19773 from peppy/constraint-asserts-in-tests
...
Update some clock tests to use constraint-based assertions
2022-08-15 11:57:43 +02:00
Dean Herbert
cc982d374c
Cache self rather than GameplayClock
2022-08-15 18:30:53 +09:00
Dean Herbert
c5f8529d20
Mark unused methods as NotImplemented for safety
2022-08-15 18:30:53 +09:00
Dean Herbert
f81c7644b4
Make GameplayClockContainer also an IGameplayClock and expose to remaining tests
2022-08-15 18:30:53 +09:00
Dean Herbert
c8764cb333
Move all usage of GameplayClock to IGameplayClock
2022-08-15 18:30:53 +09:00
Dean Herbert
6d78218142
Update usages of GameplayClockContainer.GameplayClock to access properties directly
2022-08-15 18:08:49 +09:00
Dean Herbert
224f3eaa84
Make GameplayClockContainer non-abstract and use in MultiSpectatorPlayer
2022-08-15 18:08:49 +09:00
Dean Herbert
95c1b488a7
Add non-null assertion to FrameStabilityContainer
2022-08-15 18:08:49 +09:00
Dean Herbert
58146598c8
Update TestSceneEditorClock to use constraint-based assertions
2022-08-15 18:08:05 +09:00
Dean Herbert
0087935708
Update TestSceneSpinnerRotation to use constraint-based assertions
2022-08-15 18:05:39 +09:00
Dan Balasescu
4b5439f434
Merge pull request #19768 from peppy/fix-song-progress-div-by-zero
...
Fix div-by-zero in `SongProgress` when no object duration could be calculated
2022-08-15 16:44:28 +09:00
Dean Herbert
623e90a7b2
Fix div-by-zero in SongProgress when no object duration could be calculated
2022-08-15 15:05:35 +09:00
Dean Herbert
0d3cda3329
Merge pull request #19746 from bastianpedersen/beatmap-comments-image-not-visible
...
Make `CommentMarkdownTextFlowContainer` render images
2022-08-15 00:02:03 +09:00
basseX
383afe04f3
Remove not needed override
2022-08-14 15:15:36 +02:00
basseX
932becc4b2
Remove CommentMarkdownTextFlowContainer and rather use base-class OsuMarkdownTextFlowContainer
2022-08-14 10:11:49 +02:00
basseX
b05acb0073
Make CommentMarkdownTextFlowContainer render images
2022-08-13 21:32:24 +02:00
Dan Balasescu
c02990ad67
Merge pull request #19718 from peppy/fix-playlist-imported-items
...
Fix playlist overlay showing new imports when they don't match collection filter
2022-08-12 23:27:26 +09:00
Dan Balasescu
e6ecdf7457
Merge pull request #19715 from peppy/relax-mod-multiplier
...
Adjust various mod multipliers to avoid competition with normal scores
2022-08-12 23:12:57 +09:00
Dan Balasescu
9d1b0b5836
Revert sealing
2022-08-12 22:32:27 +09:00
Dean Herbert
e5e9841652
Apply multiple other mod debuffs as decided in pull request discussion
2022-08-12 18:58:09 +09:00
Dean Herbert
b76e5757e1
Fix InSelectedCollection not being applied to newly imported beatmaps
2022-08-12 15:06:34 +09:00
Dean Herbert
a90967715c
Add test coverage of new imports not correctly being filtered by collection filter
2022-08-12 15:06:34 +09:00
Dean Herbert
5111bad86c
Refactor TestScenePlaylistOverlay to use realm for testing
...
Removes the dual-purpose flow which existed only for testing.
2022-08-12 15:06:34 +09:00
Dan Balasescu
9dcf45079c
Merge pull request #19717 from peppy/visual-tests-development-directory
...
Update interactive visual test runs to use development directory
2022-08-12 15:00:39 +09:00
Dean Herbert
38afc53bad
Update interactive visual test runs to use development directory
2022-08-12 13:40:29 +09:00
Dean Herbert
ac4213ecee
Adjust relax mod multiplayer to 0.5x
...
Has previously been discussed internally. Probably good to get this out
before the next full reprocess of scores server-side.
The multiplier here was @smoogipoo's suggested value. I'd be willing to
go lower if this is seen at too high, but it should be a round number to
make it easy for users to understand the max score available to them.
2022-08-12 12:30:13 +09:00
Dean Herbert
9148305fd8
Merge pull request #19657 from novialriptide/open-profile-hotkey
...
Add keybind for showing profile
2022-08-12 02:47:13 +09:00
Andrew Hong
667b700a28
Merge branch 'master' into open-profile-hotkey
2022-08-11 13:04:19 -04:00
Dean Herbert
b4af32efb7
Merge pull request #19708 from smoogipoo/fix-inspection
...
Fix possible null reference inspection
2022-08-11 21:52:09 +09:00
Dan Balasescu
d88f247594
Fix possible null reference inspection
2022-08-11 20:38:08 +09:00
Dan Balasescu
f29d1b2ded
Merge pull request #19001 from stanriders/pp-balancing
...
osu! performance points balancing pass
2022-08-11 20:31:33 +09:00
Dan Balasescu
9f28c4c033
Adjust test values
2022-08-11 19:47:32 +09:00
Dan Balasescu
61a3758cd9
Merge branch 'master' into pp-balancing
2022-08-11 19:46:16 +09:00
Dan Balasescu
9839d9933d
Merge pull request #19707 from peppy/api-run-loop-refactor
...
Refactor `APIAccess` main loop to read better
2022-08-11 19:44:01 +09:00
Dan Balasescu
d6c64af5e3
Merge branch 'master' into api-run-loop-refactor
2022-08-11 19:09:32 +09:00
Dan Balasescu
77cd279a76
Merge pull request #19706 from peppy/api-connected-state-refactor
...
Fix avatar potentially not loading in `LoginOverlay` due to misordered events
2022-08-11 19:08:25 +09:00
Dean Herbert
865d63f768
Refactor APIAccess main loop to read better
2022-08-11 15:43:39 +09:00
Dean Herbert
47196b19a5
Stop setting Online state in handleRequest
...
This is already handled amicably by the `Failing` -> `Connecting` flow.
Having this set in `handleRequest` throws things off, potentially
leading to the `Online` state change before the user has been populated.
2022-08-11 14:36:30 +09:00
