1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 19:55:37 +08:00
Commit Graph

40558 Commits

Author SHA1 Message Date
Joseph Madamba
3da2cdfd05 Fix nullref in test 2021-05-19 14:06:21 -07:00
Salman Ahmed
3d99b89633 Add back actually needed change
*no comment*
2021-05-20 00:03:11 +03:00
Joseph Madamba
85a3027f1b Add failing test 2021-05-19 13:58:41 -07:00
Salman Ahmed
d8efcc0793 Remove drive-by change 2021-05-19 23:44:53 +03:00
Bartłomiej Dach
b8c1ffdef3
Merge pull request #12872 from peppy/disable-skin-editor-border 2021-05-19 22:42:38 +02:00
Salman Ahmed
a4d52a7f52 Use switch—case instead 2021-05-19 23:37:22 +03:00
Salman Ahmed
e20c25b0d9 Fix miswritten test assertion 2021-05-19 23:32:16 +03:00
Salman Ahmed
a730349629 Remove the ignore attribute once again 2021-05-19 23:18:54 +03:00
Salman Ahmed
43094425e2 Merge branch 'legacy-beatmap-skin-hud-fallback' into catch-hide-combo-workaround 2021-05-19 23:18:27 +03:00
Salman Ahmed
97c8499884 Add test coverage 2021-05-19 23:01:41 +03:00
Salman Ahmed
9f3ea150f5 Fix legacy beatmap skins not falling back properly on HUD components 2021-05-19 23:01:29 +03:00
Salman Ahmed
71da960000 Extract assert step addition out of assertion method 2021-05-19 22:53:22 +03:00
Bartłomiej Dach
788f1fcf48
Merge branch 'master' into disable-skin-editor-border 2021-05-19 21:52:29 +02:00
Bartłomiej Dach
d8a2b85acb
Merge pull request #12863 from peppy/fix-editor-blueprint-wrong-beatmap 2021-05-19 21:52:00 +02:00
Salman Ahmed
21ca9c8431 Merge branch 'master' into beatmap-skin 2021-05-19 22:39:32 +03:00
Salman Ahmed
6fc06a10a1 Add extensible test scene for beatmap skins fallback instead 2021-05-19 21:52:29 +03:00
Bartłomiej Dach
5df7d3bfd0 Merge branch 'master' into fix-editor-blueprint-wrong-beatmap 2021-05-19 20:48:10 +02:00
Bartłomiej Dach
e9cab29134 Cache editor beatmap in placement blueprint test scene 2021-05-19 20:48:06 +02:00
Salman Ahmed
434377aa52 Revert "Add failing test case"
This reverts commit ec89a149dd.
2021-05-19 21:35:06 +03:00
Bartłomiej Dach
73234b8b27
Merge pull request #12845 from peppy/hit-error-skinnable 2021-05-19 19:55:27 +02:00
Bartłomiej Dach
1d9a4b7bba
Merge branch 'master' into fix-editor-blueprint-wrong-beatmap 2021-05-19 19:30:11 +02:00
Gagah Pangeran Rosfatiputra
bc1cad0963
change header breadcrumb when page change 2021-05-20 00:28:26 +07:00
Dean Herbert
eb5db8ff03 Disable border display on skin editor to avoid crashes
This wasn't being displayed correctly anyway, so rather than fixing
let's just remove it for now.

Closes #12868.
2021-05-20 02:01:46 +09:00
Dean Herbert
22337e0fc7 Add comment explaining why origin is flipped 2021-05-20 01:59:30 +09:00
Dean Herbert
00ed699340 Fix origin specifications using incorrect flags 2021-05-20 01:53:24 +09:00
Dean Herbert
363aec8179 Merge branch 'master' into hit-error-skinnable 2021-05-20 01:51:45 +09:00
Dean Herbert
a55879e511 Fix oversights in scale algorithm 2021-05-20 01:47:31 +09:00
Dean Herbert
14af86d6c5 Use the same code path for all scaling 2021-05-19 21:46:41 +09:00
Andrei Zavatski
d60478851f Add proper action to YearButton 2021-05-19 15:38:53 +03:00
Andrei Zavatski
e3ed9b8135 Implement sidebar metadata handling in NewsOverlay 2021-05-19 15:36:05 +03:00
Andrei Zavatski
6cc4ffadab Implement sticky container for sidebar in NewsOverlay 2021-05-19 15:28:12 +03:00
Andrei Zavatski
150ed01c62 Make NewsSidebar scrollable 2021-05-19 15:22:55 +03:00
Andrei Zavatski
16ffedde8a Add year parameter to GetNewsRequest 2021-05-19 15:17:57 +03:00
Dean Herbert
6a3c58b9ad Implement proper scaling algorithms 2021-05-19 19:58:55 +09:00
Salman Ahmed
ec89a149dd Add failing test case 2021-05-19 13:37:55 +03:00
Dean Herbert
db6d980623
Merge pull request #12784 from smoogipoo/mania-pooling
Implement pooling for osu!mania
2021-05-19 18:36:03 +09:00
Dean Herbert
6c4709e7b4 Fix PlacementBlueprint using the wrong beatmap when applying defaults
Closes #12855.
2021-05-19 18:34:07 +09:00
Dean Herbert
b2c736b42a Combine and move const closer to usage 2021-05-19 18:09:46 +09:00
Salman Ahmed
825d61e22c Separate default beatmap skins from DefaultSkin 2021-05-19 12:06:10 +03:00
Dean Herbert
a639132825 Avoid doing any re-fetch on beatmap from test scenes 2021-05-19 17:58:28 +09:00
Salman Ahmed
9806d94b74 Move beatmap skin info creation to static method at IBeatmapSkin 2021-05-19 11:58:00 +03:00
Dean Herbert
a0f67ef3bc Move scaling logic out of OsuSelectionHandler for reuse 2021-05-19 17:37:28 +09:00
Dean Herbert
cc5c702a92 Apply all properties after cast (looks cleaner) 2021-05-19 17:31:47 +09:00
Dean Herbert
bddc3121dc Merge branch 'master' into mania-pooling 2021-05-19 17:23:45 +09:00
Dean Herbert
b33d5e7a7a Add new test and assertions to existing DialogOverlay test 2021-05-19 17:04:45 +09:00
Dean Herbert
fc5987bf69 Refactor DialogOverlay logic to avoid dismissal potentially being unhandled 2021-05-19 16:52:34 +09:00
Vinicius Barbosa
4f397ae7f5
Merge branch 'master' into applause-stops-on-score-switch 2021-05-19 09:52:31 +02:00
Dean Herbert
44e22b31a9 Refactor editor exit sequence to avoid any scenario where a dialog could go stray 2021-05-19 16:51:54 +09:00
Dean Herbert
b83322281e Consume updated logic at MainMenu 2021-05-19 16:51:54 +09:00
Dean Herbert
124ac689b8 Add method to PopupDialog to press the first OK button 2021-05-19 16:51:54 +09:00