1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-14 10:57:30 +08:00
Commit Graph

23 Commits

Author SHA1 Message Date
Dean Herbert
54982dcdd7 Refactor LoadingLayer to avoid applying effects to external drawables
In theory this seemed like a good idea (and an optimisation in some
cases, due to lower fill rate), but in practice this leads to weird edge
cases.

This aims to do away with the operations on external drawables by
applying a dim to the area behind the `LoadingLayer` when required.
I went over each usage and ensured they look as good or better than
previously.

The specific bad usage here was the restoration of the colour on dispose
(if the `LoadingLayer` was disposed in a still-visible state).

I'm aware that the `BeatmapListingOverlay` will now dim completely during
load. I think this is fine for the time being.
2021-01-05 17:31:45 +09:00
Dean Herbert
7bcbac6f45 Move header setting to FullscreenOverlay 2020-09-03 16:34:58 +09:00
Dean Herbert
dceae21bbf Centralise fetching of overlay component titles and textures 2020-09-03 16:34:58 +09:00
Dean Herbert
3916d98e52 Add comment for clarity 2020-08-05 18:50:37 +09:00
Andrei Zavatski
af320e4a61 Fix NewsOverlay running request on startup 2020-08-03 10:03:42 +03:00
Andrei Zavatski
598e48678e Refactor NewsHeader 2020-07-12 15:45:48 +03:00
Andrei Zavatski
3ba8ec0fd7 Don't set null value to show front page 2020-07-09 03:40:14 +03:00
Andrei Zavatski
900f2d309b Classes naming adjustments 2020-07-09 01:26:56 +03:00
Andrei Zavatski
0b4213f330 Implement FrontPageDisplay 2020-07-08 20:07:29 +03:00
Andrei Zavatski
49d998c8db Refactor NewsOverlay to use displays logic 2020-07-08 18:24:13 +03:00
Andrei Zavatski
4c5d01a611 Remove unused usings 2020-04-13 12:34:51 +03:00
Andrei Zavatski
b741e359cd Use OverlayScrollContainer for overlays 2020-04-13 12:23:28 +03:00
Andrei Zavatski
fe078c244d Expose TabControlOverlayHeader.Current value 2020-02-04 00:43:04 +03:00
Andrei Zavatski
db4cd51d02 Implement OverlayColourProvider 2020-01-24 12:24:35 +03:00
Lucas A
0a278ef943 Apply review suggestions 2019-12-17 19:23:30 +01:00
Lucas A
88ec0c1486 Add missing async content loading logic to NewsOverlay 2019-12-08 18:49:58 +01:00
Lucas A
4d1b1a4022 Fix CI inspections 2019-08-14 21:52:36 +02:00
Lucas A
840d4741da Add NewsContent class and fix broken reference. 2019-08-14 21:19:59 +02:00
Lucas A
87811afade Add missing licence headers to added files. 2019-08-12 20:16:41 +02:00
Lucas A
b92e331730 Add tabcontrol logic to news overlay 2019-08-10 17:06:52 +02:00
Lucas A
b19c378fc8 Add NewsHeader class 2019-08-10 15:39:13 +02:00
Lucas A
4b0ac381b7 Add visual tests. 2019-08-10 15:39:13 +02:00
Lucas A
e3d52d8d71 Add NewsOverlay class 2019-08-10 15:39:13 +02:00