1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-25 03:22:57 +08:00
Commit Graph

45989 Commits

Author SHA1 Message Date
Dean Herbert
fc59e20c14
Merge pull request #15478 from bdach/fix-labelled-drawable-descriptions 2021-11-05 10:13:11 +09:00
Salman Ahmed
36d99a2e34 Move action to private named method to avoid null inspection 2021-11-05 03:51:08 +03:00
Salman Ahmed
6197ef426d Disable another "code heurstically unreachable" with comment 2021-11-05 03:50:17 +03:00
Salman Ahmed
af6ae1cce5 Remove hacky code with explicit pragma disable 2021-11-05 03:49:35 +03:00
Jason Won
9e7d559f55 fix aspect locked scaling of skin components 2021-11-04 17:10:41 -04:00
Bartłomiej Dach
4c8d6a77be
Fix labelled drawable descriptions not showing 2021-11-04 21:44:08 +01:00
Bartłomiej Dach
9246adc349
Add failing test coverage for labelled drawable description visible 2021-11-04 21:43:20 +01:00
Dean Herbert
e5d229f005 Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2 2021-11-05 01:16:43 +09:00
Dean Herbert
630d63101d Merge branch 'master' into beatmap-refactor/to-model-removal-2 2021-11-05 01:16:42 +09:00
Dean Herbert
7049d0de66 Merge branch 'master' into beatmap-refactor/remove-online-info 2021-11-05 01:16:11 +09:00
Salman Ahmed
78ed77805f
Merge pull request #15468 from smoogipoo/upgrade-nvika
Use official nvika package again
2021-11-04 15:16:03 +03:00
Salman Ahmed
9846596c02
Merge branch 'master' into upgrade-nvika 2021-11-04 14:48:42 +03:00
Dan Balasescu
66509264ff
Merge pull request #15467 from peppy/update-framework
Update framework
2021-11-04 20:19:56 +09:00
Salman Ahmed
4b46833ee9
Merge branch 'master' into upgrade-nvika 2021-11-04 13:53:30 +03:00
Salman Ahmed
aa2711e6ec
Merge branch 'master' into update-framework 2021-11-04 13:51:57 +03:00
Dan Balasescu
f12a2c7767
Merge pull request #15458 from peppy/beatmap-refactor/playlist-use-api-beatmap-extended
Refactor `PlaylistItem` to allow `Beatmap` to be an interfaced type
2021-11-04 19:23:33 +09:00
smoogipoo
30635fb476 Use official nvika package again 2021-11-04 19:19:00 +09:00
Dean Herbert
28e9b9a25f Update framework 2021-11-04 19:01:39 +09:00
Dan Balasescu
45dcf187b9
Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended 2021-11-04 18:59:04 +09:00
Dean Herbert
df3c3a32ce Fix unintentionally broken background update logic 2021-11-04 18:07:39 +09:00
Dan Balasescu
388c074c15
Merge pull request #15464 from peppy/fix-crash-on-gameplay
Fix crash on gameplay startup if beatmap has no background
2021-11-04 18:07:10 +09:00
Dean Herbert
b80c02b757 Fix crash on gameplay startup if beatmap has no background 2021-11-04 17:24:40 +09:00
Dean Herbert
eb17d897a3 Finally, remove the To* methods as they have no usages 2021-11-04 17:09:53 +09:00
Dean Herbert
08d94f864f Update ScoresContainer to not use ToBeatmapInfo 2021-11-04 17:09:53 +09:00
Dean Herbert
7bab487621 Remove usage of ToBeatmapInfo in APIScoreInfo.CreateScoreInfo 2021-11-04 17:09:53 +09:00
Dean Herbert
8a873bd6b1 Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/to-model-removal-2 2021-11-04 17:09:51 +09:00
Dean Herbert
d2831b1152 Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2 2021-11-04 17:09:50 +09:00
Dean Herbert
77be610b26 Revert "Clean up DirectDownloadButton test scene"
This reverts commit baabe99f78.
2021-11-04 17:09:20 +09:00
Dean Herbert
5a078da4d9 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:50:14 +09:00
Dean Herbert
c820d445ad
Merge pull request #15461 from peppy/fix-more-computationally-expensive
Fix a few more "maybe null" inspections
2021-11-04 16:49:38 +09:00
Dean Herbert
e50c961185
Merge pull request #15312 from jaswon/editor-context-menu-on-select
Fix editor context menu requiring two right-clicks to display
2021-11-04 16:49:19 +09:00
Dean Herbert
a9eef4199a
Merge pull request #15460 from smoogipoo/upgrade-nvika
Upgrade to nvika 1.0.4
2021-11-04 16:47:23 +09:00
Dean Herbert
8f459e6ce8 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:44:17 +09:00
Dean Herbert
baabe99f78 Clean up DirectDownloadButton test scene 2021-11-04 16:28:29 +09:00
Dean Herbert
317506d4d7 Fix a few more "maybe null" inspections 2021-11-04 16:11:23 +09:00
Dan Balasescu
63cfa69bd1
Merge branch 'master' into upgrade-nvika 2021-11-04 16:10:23 +09:00
smoogipoo
0c14d8af23 Upgrade to nvika 1.0.4 2021-11-04 16:03:59 +09:00
Dean Herbert
09701d0af1 Use explicit primitive type specification 2021-11-04 16:02:37 +09:00
Dean Herbert
0f4f1349db Merge branch 'master' into editor-context-menu-on-select 2021-11-04 15:59:06 +09:00
Dan Balasescu
222c3e552b
Merge pull request #15456 from peppy/beatmap-refactor/beatmap-metadata-nullable-enable
Enable nullable support on `BeatmapMetadata`
2021-11-04 15:47:18 +09:00
Dean Herbert
a5a7181915 Fix unintentionally broken background update logic 2021-11-04 15:35:32 +09:00
Dean Herbert
4b1b92cde6 Stop BeatmapInfo from implementing IBeatmapOnlineInfo and remove all usages 2021-11-04 15:23:04 +09:00
Dean Herbert
9c926e5514 Remove BeatmapSetInfo.OnlineInfo and all usages 2021-11-04 15:23:04 +09:00
Dean Herbert
66f4516eee Allow creating sample API models without specifying a ruleset 2021-11-04 15:23:04 +09:00
Dean Herbert
e3a9fbecfe Add method to create sample APIBeatmap (with BeatmapSet populated) 2021-11-04 15:23:04 +09:00
Dean Herbert
0d0eab90bc Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/remove-online-info 2021-11-04 15:23:02 +09:00
Dean Herbert
8733767416 Merge branch 'beatmap-refactor/beatmap-metadata-nullable-enable' into beatmap-refactor/remove-online-info 2021-11-04 15:23:02 +09:00
Dean Herbert
84d36cbae7 Add fallback for cases where BeatmapSet may be null
Seems to only happen in tests, but better safe than sorry.
2021-11-04 15:22:33 +09:00
Dean Herbert
e43d91ad5d Fix another case of incorrect null checking in editor verification processing 2021-11-04 15:18:10 +09:00
Dean Herbert
09f9731d74 Add temporary disable of failing r# inspection 2021-11-04 15:09:04 +09:00