75943 Commits

This Branch

This Branch

All Branches

• Merge pull request #35923 from smoogipoo/qp-abandoned-at

  Consider abandon time for user placements

  Dean Herbert · 2025-12-08 19:27:56 +09:00
  2025.1208.0 59a27dad3d
• Consider abandon time for user placements
  Dan Balasescu · 2025-12-07 23:26:40 +09:00
  d6cd748d2a
• Merge pull request #35913 from smoogipoo/qp-chat-hold-focus

  Make quick play chat retain focus after posting

  Dean Herbert · 2025-12-06 20:20:42 +09:00
  582ff999aa
• Make quick play chat retain focus after posting
  Dan Balasescu · 2025-12-06 17:50:58 +09:00
  a96b024ac5
• Update framework
  Dean Herbert · 2025-12-05 22:28:55 +09:00
  2025.1205.0-lazer fbac5db964
• Merge pull request #35875 from bdach/always-bind-virtual-modifier

  Do not distinguish between left/right modifiers when assigning new key combinations

  Dean Herbert · 2025-12-05 22:02:50 +09:00
  5a920d15c1
• Merge pull request #35878 from frenzibyte/vote-to-skip-design-2

  Update multiplayer vote-to-skip button design

  Dean Herbert · 2025-12-05 21:40:16 +09:00
  324d088d46
• Update tests to match new behaviour
  Dean Herbert · 2025-12-05 21:27:11 +09:00
  1db4b897eb
• Add xmldoc to confusing field

  I don't have any better ideas at this time.

  Bartłomiej Dach · 2025-12-05 13:05:51 +01:00
  8e2230d149
• Update framework
  Dean Herbert · 2025-12-05 20:50:07 +09:00
  8d33c35646
• Merge pull request #35890 from bdach/disallow-placing-objects-before-first-timing-point

  Disallow placing objects before first timing point

  Dean Herbert · 2025-12-05 20:49:44 +09:00
  c359898a75
• Privatise setter
  Bartłomiej Dach · 2025-12-05 12:35:26 +01:00
  6343bf7d29
• Ensure skip counter doesn't overflow the button
  Bartłomiej Dach · 2025-12-05 12:34:18 +01:00
  b1e27d842b
• Merge pull request #35889 from smoogipoo/fix-quick-play-kick-message

  Fix "kicked" users not being marked as quit

  Bartłomiej Dach · 2025-12-05 10:24:30 +01:00
  28eeb7f743
• Merge pull request #35888 from smoogipoo/fix-quick-play-crash

  Fix quick play crash when presenting random selection

  Bartłomiej Dach · 2025-12-05 09:54:20 +01:00
  38c3167a9d
• Fix failing tests after disallowing object placements before first timing point
  Bartłomiej Dach · 2025-12-05 09:52:32 +01:00
  66ebce8c12
• Fix "kicked" users not being marked as quit
  Dan Balasescu · 2025-12-05 17:26:55 +09:00
  fed9564b40
• Fix quick play crash when presenting random selection
  Dan Balasescu · 2025-12-05 16:59:23 +09:00
  f595a47059
• Add failing test
  Dan Balasescu · 2025-12-05 16:59:23 +09:00
  8a9f60df68
• Make button brighter on hover
  Salman Alshamrani · 2025-12-04 14:00:39 -05:00
  2d8b1e7152
• Add test coverage for players leaving during intro
  Salman Alshamrani · 2025-12-04 13:38:30 -05:00
  fef8117b5c
• Implement redesigned multiplayer vote-to-skip button
  Salman Alshamrani · 2025-12-04 13:38:30 -05:00
  99da986e02
• Adjust skip button colour and add triangles
  Salman Alshamrani · 2025-12-04 13:38:30 -05:00
  1c33291b3f
• Add basic colour indication as to when placements are valid

  Unsure about this one, but I find the preceding commit to be very
  lacking in explaining to the user why the editor don't work. Shining
  some things red may help aid understanding.

  Bartłomiej Dach · 2025-12-04 14:37:56 +01:00
  c6cc92315c
• Disallow placing hit objects before first timing point

  Because they can break stable. See
  https://github.com/ppy/osu/issues/31591#issuecomment-3575270120 for
  detailed rationale.

  Bartłomiej Dach · 2025-12-04 14:15:52 +01:00
  12170df80a
• Do not distinguish between left/right modifiers when assigning new key combinations

  Addresses https://github.com/ppy/osu/discussions/35851.
  
  And no I'm not making it "you have to press both modifiers for it to
  become any of the two" because that's ultra weird.

  Bartłomiej Dach · 2025-12-04 12:09:27 +01:00
  3e4c038a37
• Merge pull request #35874 from bdach/fix-skinnable-welcome

  Fix welcome intro text not being looked up from user skin for supporters

  Dean Herbert · 2025-12-04 19:36:11 +09:00
  5d76353ae4
• Fix changing beatmap during hold-to-reveal-background delay turning off blur (#35867)

  Closes https://github.com/ppy/osu/issues/35864.

  Bartłomiej Dach · 2025-12-04 19:23:32 +09:00
  0b3ec3f1e1
• Disable quick retry binding in solo spectator (#35873)

  Closes https://github.com/ppy/osu/issues/35870? For some definition of
  "closes", I guess?
  
  Why would you ever do this, unless on purpose just to break stuff? Don't
  answer that.
  
  A side effect of setting this flag is that the hold-to-exit menu button
  that's there on devices that support touch will slightly change
  behaviour to the behaviour multiplayer play has:
  
  	https://github.com/ppy/osu/blob/e3ea38a366601df01f045f4f111765c34d041145/osu.Game/Screens/Play/HUD/HoldForMenuButton.cs#L67
  	https://github.com/ppy/osu/blob/8d9245c1d4f72db4307da7492d65bd09fc48bc02/osu.Game/Graphics/Containers/HoldToConfirmContainer.cs#L79-L82
  
  but upon thinking about it for three minutes I decided I don't care and
  it's probably fine because all of this was already racking up to fifteen
  minutes that I shouldn't have had to spend on any of this.
  
  Notably this shouldn't affect the actual spectated user retrying,
  because all of that is handled elsewhere via
  
  	https://github.com/ppy/osu/blob/2f90bb4d6793475835d1d51bef92b2c40f69112c/osu.Game/Screens/Spectate/SpectatorScreen.cs#L138-L154

  Bartłomiej Dach · 2025-12-04 19:17:44 +09:00
  043a1c2793
• Fix welcome intro skin not being looked up from user skin for supporters

  Closes https://github.com/ppy/osu/issues/35833.

  Bartłomiej Dach · 2025-12-04 10:43:18 +01:00
  ca8247c667
• Merge pull request #35872 from peppy/locus-winners-part-2

  Add remaining two locus winners as bundled beatmaps

  Bartłomiej Dach · 2025-12-04 09:40:37 +01:00
  a5ae542502
• Add remaining two locus winners as bundled beatmaps
  Dean Herbert · 2025-12-04 14:20:04 +09:00
  fe5cbc4932
• Merge pull request #35835 from Hiviexd/trim-timestamp-when-pasting

  Trim editor timestamp when pasting into `TimeInfoContainer`

  Bartłomiej Dach · 2025-12-03 14:56:52 +01:00
  2025.1203.0-tachyon 0a378e5efd
• Merge pull request #35852 from frenzibyte/support-ipad-resizing

  Allow window resizing on iPadOS

  Dean Herbert · 2025-12-03 13:11:19 +09:00
  1d221c1a7a
• Allow resizing osu! on iPadOS
  Salman Alshamrani · 2025-11-30 05:14:02 -05:00
  82f4406c79
• Force exit to menu on quick play disonnection (#35793)
  Vanni · 2025-11-28 11:25:43 +09:00
  92e9a36744
• trim timestamp when pasting into TimeInfoContainer
  Hivie · 2025-11-28 01:40:07 +01:00
  c6eba26a67
• Fix Beatmap.GetMostCommonBeatLength() potentially returning a beat length smaller or larger than the actual limits (#35827)

  Closes https://github.com/ppy/osu/issues/35807.
  
  The reason this closes the aforementioned issue is as follows:
  
  Taking https://osu.ppy.sh/beatmapsets/1236180#osu/4650477 as the
  example, we have:
  
  ```
  minBeatLength = 342.857142857143
  maxBeatLength = 419.58041958042003
  mostCommonBeatLength = 342.85700000000003
  ```
  
  Note that `mostCommonBeatLength < minBeatLength` here.
  
  Taking the inverse of that to compute BPM, we get
  
  ```
  minBpm = 174.99999999999991
  maxBpm = 142.99999999999986
  mostCommonBpm = 175.00007291669704
  ```
  
  which without DT present doesn't do anything bad, but when DT is
  engaged (and thus BPM is multiplied by 1.5), midpoint rounding causes
  the min BPM to become 262, and the most common BPM to become 263.

  Bartłomiej Dach · 2025-11-28 08:25:47 +09:00
  8f927ea7b5
• Fix several issues with editor timestamps for objects with fractional start times in osu!mania (#35829)

  * Fix mania editor timestamp generation being culture-dependent
  
  Mostly closes https://github.com/ppy/osu/issues/35809.
  
  * Add failing test for notes with fractions
  
  * Round note time when copying out timestamp & apply half-millisecond tolerance when parsing
  
  Closes the rest of https://github.com/ppy/osu/issues/35809.
  
  One issue here was that while the timestamp generation would allow
  fractional object timestamps to be output, the parsing (via
  `selection_regex`) would *reject* fractional timestamps, therefore
  making lazer incompatible even with itself.
  
  The other is that rounding is probably fine to do anyway for
  interoperability with stable. I'd hope nobody actually *needs*
  sub-millisecond precision but I'm ready to be proven wrong by some
  aspire jokester.
  
  * Specify invariant culture when writing out combo indices to editor timestamp in other rulesets
  
  Pretty sure this is just a much-of-muchness because it's integers but
  might as well if I'm spending time here already.

  Bartłomiej Dach · 2025-11-28 08:21:13 +09:00
  a8f058141b
• Fix gameplay leaderboard tracked player not using team colour (#35826)

  * Demonstrate colour problem in test
  
  * Fix gameplay leaderboard tracked player not using team colour
  
  Closes https://github.com/ppy/osu/issues/35806.

  Bartłomiej Dach · 2025-11-27 21:22:06 +09:00
  6bb25b2abe
• Add context menu shortcut to watch local replays from song select (#35823)

  Addresses https://github.com/ppy/osu/discussions/35811 I guess.
  
  Will only work for local leaderboards for now but maybe good enough for
  what is essentially a 5 minute job?
  
  Can be made to work with online leaderboards too I guess if need be.

  Bartłomiej Dach · 2025-11-27 21:10:46 +09:00
  037743e002
• Attempt to prevent main menu osu! logo being triggered by media keys (#35825)

  Maybe addresses https://github.com/ppy/osu/discussions/35813. I can't
  reproduce on macOS, may be a $USER_OS idiosyncrasy.

  Bartłomiej Dach · 2025-11-27 20:58:47 +09:00
  6244617e5e
• Merge pull request #35821 from smoogipoo/qp-adjust-pool-selector

  Display quick play pool name as sub-heading in selector

  Bartłomiej Dach · 2025-11-27 12:16:02 +01:00
  ddfcb4d6da
• Merge pull request #35822 from smoogipoo/remove-unnecessary-code

  Remove now-unnecessary timestamp updates

  Bartłomiej Dach · 2025-11-27 12:15:38 +01:00
  2660f4dcb0
• Remove now-unnecessary timestamp updates

  Since #35820, this is now handled when messages are added and removed.

  Dan Balasescu · 2025-11-27 18:42:48 +09:00
  5a865476ce
• Merge pull request #35820 from smoogipoo/fix-chat-background-alt-2

  Fix chat lines flipping colours at maximum history

  Bartłomiej Dach · 2025-11-27 10:37:52 +01:00
  2472c91924
• Display quick play pool name as sub-heading
  Dan Balasescu · 2025-11-27 18:25:32 +09:00
  db50019f31
• Fix formatting
  Bartłomiej Dach · 2025-11-27 09:37:40 +01:00
  1e43509e4a
• Fix chat lines flipping colours at maximum history
  Dan Balasescu · 2025-11-27 15:42:47 +09:00
  ded8aaecfd
• Add failing tests
  Dan Balasescu · 2025-11-27 15:42:40 +09:00
  75df8e3639