1098 Commits

• Apply minor performance rules
  Huo Yaoyuan · 2024-11-28 20:41:44 +08:00
  f5a7716509
• Merge pull request #30812 from smoogipoo/playlist-populate-on-enter

  Fix joining playlists room sometimes not selecting the first item

  Dean Herbert · 2024-11-22 23:57:45 +09:00
  ce41c000a1
• Merge branch 'master' into multiplayer-nrt
  Bartłomiej Dach · 2024-11-22 08:09:42 +01:00
  512d2c6e3b
• Rename variable to imply it is now a function
  Dean Herbert · 2024-11-22 13:11:32 +09:00
  41addaae9a
• Recreate beatmap every test run in ModTestScene
  Salman Alshamrani · 2024-11-21 17:48:33 -05:00
  5dffc322af
• Fix tests
  Dan Balasescu · 2024-11-22 01:26:35 +09:00
  2a7266cb23
• Enable NRT in TestMultiplayerRoomManager
  Dan Balasescu · 2024-11-21 21:03:12 +09:00
  209380cbac
• Enable NRT for multiplayer and playlists
  Dan Balasescu · 2024-11-21 20:32:09 +09:00
  6870c99eb2
• Add failing test
  Dan Balasescu · 2024-11-21 18:09:39 +09:00
  fe8e9d455a
• Merge branch 'master' into multiplayer-remove-cmc-and-composite
  Dean Herbert · 2024-11-20 17:24:55 +09:00
  6fba6de4dc
• Remove CachedModelDependencyContainer usages from online play
  Dan Balasescu · 2024-11-15 15:59:28 +09:00
  1a656d0ec3
• Make Room.Playlist non-bindable
  Dan Balasescu · 2024-11-15 15:51:01 +09:00
  34c0f72dd6
• Make Room.RecentParticipants non-bindable
  Dan Balasescu · 2024-11-15 15:25:43 +09:00
  b16edbbf52
• Make Room.PlaylistItemStats non-bindable
  Dan Balasescu · 2024-11-15 14:42:46 +09:00
  487a010b12
• Make Room.Duration & Room.StartDate & Room.EndDate non-bindable
  Dan Balasescu · 2024-11-15 14:42:45 +09:00
  0ceaafe731
• Make Room.AutoStartDuration non-bindable
  Dan Balasescu · 2024-11-15 14:42:45 +09:00
  89de4f0f87
• Make Room.Password & Room.HasPassword non-bindable
  Dan Balasescu · 2024-11-15 14:42:18 +09:00
  ec5be6dbc3
• Make Room.QueueMode non-bindable
  Dan Balasescu · 2024-11-15 14:42:18 +09:00
  198681e644
• Make Room.Type non-bindable
  Dan Balasescu · 2024-11-15 14:42:18 +09:00
  81e4cb348f
• Make Room.Category non-bindable
  Dan Balasescu · 2024-11-15 14:42:18 +09:00
  bde7b8e610
• Make Room.Host non-bindable
  Dan Balasescu · 2024-11-15 14:42:17 +09:00
  8694f7e1cc
• Make Room.Name non-bindable
  Dan Balasescu · 2024-11-15 14:29:15 +09:00
  6160df1586
• Make RoomID non-bindable

  Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.

  Dan Balasescu · 2024-11-13 16:28:54 +09:00
  99762da7b8
• Merge pull request #30411 from frenzibyte/editor-slider-touch-support-2

  Fix placing objects via touch in editor not working sometimes

  Dean Herbert · 2024-11-13 15:09:57 +09:00
  78084e33af
• Make CurrentPlaylistItem not a bindable
  Dan Balasescu · 2024-11-12 18:17:24 +09:00
  72564b5c98
• Only use MD5 when performing metadata lookups

  Both online and offline using the cache.
  
  The rationale behind this change is that in the current state of
  affairs, `TestPartiallyMaliciousSet()` fails in a way that cannot be
  reconciled without this sort of change.
  
  The test exercises a scenario where the beatmap being imported has an
  online ID in the `.osu` file, but its hash does not match the online
  hash of the beatmap. This turns out to be a more frequent scenario than
  envisioned because of users doing stupid things with manual file editing
  rather than reporting issues properly.
  
  The scenario is realistic only because the behaviour of the endpoint
  responsible for looking up beatmaps is such that if multiple parameters
  are given (e.g. all three of beatmap MD5, online ID, and filename), it
  will try the three in succession:
  
  	https://github.com/ppy/osu-web/blob/f6b341813be270de59ec8f9698428aa6422bc8ae/app/Http/Controllers/BeatmapsController.php#L260-L266
  
  and the local metadata cache implementation reflected this
  implementation.
  
  Because online ID and filename are inherently unreliable in this
  scenario due to being directly manipulable by clueless or malicious
  users, neither should not be used as a fallback.

  Bartłomiej Dach · 2024-10-30 08:12:30 +01:00
  776fabd77c
• Merge branch 'master' into editor-slider-touch-support-2
  Salman Alshamrani · 2024-10-23 17:02:38 -04:00
  6e9ff49e59
• Fix placement blueprints sometimes not behaving correctly with touch input

  More specifically, this fixes placement blueprints not beginning placement when using touch input while the cursor was previously outside compose area, due to the placement blueprint not existing (removed from the scene by `ComposeBlueprintContainer`).

  Salman Alshamrani · 2024-10-23 16:51:21 -04:00
  3a4d5af83e
• Merge branch 'master' into lookup-users-endpoint
  Dean Herbert · 2024-10-22 18:48:00 +09:00
  6ea1623889
• Fix placement blueprints not receiving latest mouse position with touch input
  Salman Alshamrani · 2024-10-13 11:01:18 -04:00
  f8c8184c5c
• Add failing test
  Bartłomiej Dach · 2024-10-11 14:16:24 +02:00
  9d1eb842a7
• Switch multiplayer away from using UserLookupCache

  After switching `UserLookupCache` to `GET /users/lookup` from `GET
  /users`, multiplayer sort of breaks, since the former endpoint does not
  return `ruleset_statistics`, which are used in multiplayer to show
  users' ranks. Therefore, switch multiplayer to use the appropriate
  request type directly.

  Bartłomiej Dach · 2024-10-08 14:46:50 +02:00
  5104f3e7ac
• Merge pull request #29914 from peppy/fix-judgement-counter-sync

  Fix judgement counter not showing correct counts when spectating user mid-play

  Bartłomiej Dach · 2024-09-27 10:57:26 +02:00
  a00ed8dd77
• Refactor PlacementBlueprint to not be hitobject specific
  OliBomby · 2024-09-24 20:31:00 +02:00
  e3b4483872
• Add test coverage of judgements not being synced when resuming a replay
  Dean Herbert · 2024-09-18 15:28:10 +09:00
  2d993645af
• Merge pull request #29542 from frenzibyte/show-daily-challenge-intro-once-per-session

  Show daily challenge intro screen once per session

  Dean Herbert · 2024-09-01 21:27:16 +09:00
  e79604cc13
• Add DailyChallengeButton for intro played flag reset logic
  Salman Ahmed · 2024-08-24 22:19:17 +09:00
  b54487031a
• Rename SkinComponentsContainer to SkinnableContainer
  Dean Herbert · 2024-08-22 17:42:50 +09:00
  41756520b1
• Merge branch 'master' into master
  Bartłomiej Dach · 2024-08-19 14:30:20 +02:00
  7693d4c039
• More hardening of TestMultiplayerClient to attempt to fix test failures
  Dean Herbert · 2024-08-19 04:04:24 +09:00
  e75ae4a37b
• update var names and test logic
  Layendan · 2024-08-01 02:52:41 -07:00
  19a4cef113
• Fix tests
  Layendan · 2024-07-30 17:08:56 -07:00
  8eeb5ae06b
• Fix test failure due to TestMetadataClient providing null statistics array
  Dean Herbert · 2024-07-31 02:53:10 +09:00
  5ebb5ad670
• Add notification on daily challenge conclusion & start of new one

  Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
  on #general.
  
  The notifications are constrained to the daily challenge screen only to
  not spam users who may not care.

  Bartłomiej Dach · 2024-07-29 14:30:10 +02:00
  b46f3c97da
• Add vague test coverage
  Bartłomiej Dach · 2024-07-29 10:58:05 +02:00
  861b546562
• Add screen footer to ScreenTestScene
  Salman Ahmed · 2024-07-11 15:30:07 +03:00
  7a5624fd0e
• Merge branch 'master' into footer-v2-integration
  Dean Herbert · 2024-07-10 15:33:05 +09:00
  9a88281ab0
• Replace old bad daily challenge leaderboard with new implementation

  - Actually shows scores rather than playlist aggregates (which are
    useful... in playlists, where there is more than one item)
  - Actually allows scores to be shown by clicking on them
  - Doesn't completely break down visually on smaller window sizes
  
  The general appearance is not as polished as the old one in details but
  I wanted something quick that we can get out by next weekend.
  
  Also includes the naive method of refetching scores once a new top 50
  score is detected. I can add a stagger if required.

  Bartłomiej Dach · 2024-07-04 13:52:08 +02:00
  5fa586848d
• Migrate mod select overlay footer content
  Salman Ahmed · 2024-06-30 06:50:36 +03:00
  48bf3f1385
• Add client/server models for allowing clients to receive realtime playlist updates
  Bartłomiej Dach · 2024-06-27 11:32:18 +02:00
  d6e7781be1