49104 Commits

This Branch

This Branch

All Branches

• Also make APIUser opt-in and remove the remaining serialization exclusion rule
  Dean Herbert · 2022-02-23 17:12:38 +09:00
  53bbd00675
• Add note about why RoomID is nulled in DeepClone
  Dean Herbert · 2022-02-23 17:10:11 +09:00
  43c83d2de1
• Make Room opt-in rather than opt-out for json serialization
  Dean Herbert · 2022-02-23 17:10:10 +09:00
  f14a9af801
• Remove unnecessary ShouldSerialize rules in Room
  Dean Herbert · 2022-02-23 17:10:10 +09:00
  28c9c5ab6a
• Don't update count twice immediately

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2022-02-23 13:42:47 +09:00
  71a012bea6
• Fix currently playing text not showing in lounge
  Dan Balasescu · 2022-02-23 13:37:47 +09:00
  2bea485af8
• Add missing property copies in Room.CopyFrom implementation
  Dean Herbert · 2022-02-22 15:47:00 +09:00
  61b3280de1
• Merge branch 'master' into rooms-request-faster
  Dean Herbert · 2022-02-22 15:45:05 +09:00
  71ae425fb2
• Add mention of StarRatingRangeDisplay fallback scenario being wrong for multiplayer
  Dean Herbert · 2022-02-22 15:37:42 +09:00
  057fd6c352
• Add mention of PlaylistItem.Beatmap being a placeholder in many cases
  Dean Herbert · 2022-02-22 15:31:08 +09:00
  f12044b03e
• Change precedence order to favour playlist as a source for beatmap count
  Dean Herbert · 2022-02-22 15:15:57 +09:00
  cde3d9c08b
• Merge pull request #16945 from peppy/three-column-playlist

  Update playlist room display to a three column layout

  Dan Balasescu · 2022-02-22 12:21:56 +09:00
  a676acd80d
• Merge pull request #16943 from peppy/spotlights-on-top
  Dean Herbert · 2022-02-22 10:08:59 +09:00
  c2af1526aa
• Merge branch 'master' into spotlights-on-top
  Bartłomiej Dach · 2022-02-21 23:42:02 +01:00
  d71e511413
• Merge branch 'master' into three-column-playlist
  Bartłomiej Dach · 2022-02-21 23:40:21 +01:00
  959f0330e0
• Merge pull request #16894 from dekrain/leaderboard-score-timeref

  Add text displaying recent score time on the leaderboard

  Bartłomiej Dach · 2022-02-21 21:16:31 +01:00
  a5af89d143
• Merge branch 'master' into leaderboard-score-timeref
  Bartłomiej Dach · 2022-02-21 20:50:00 +01:00
  e3ae52360e
• Merge pull request #16938 from smoogipoo/classic-score-hitobject-factor

  Scale classic score by hitobject count instead of max combo

  Dean Herbert · 2022-02-22 00:40:56 +09:00
  897f0ecd5f
• Fix remaining filter tests
  Dean Herbert · 2022-02-22 00:25:00 +09:00
  113153e6a3
• Fix null reference in tests during attempted ruleset filtering
  Dean Herbert · 2022-02-22 00:14:33 +09:00
  2aa0364092
• Fix test failures due to order change
  Dean Herbert · 2022-02-21 19:48:39 +09:00
  98c008b95f
• Update playlist room display to a three column layout

  Similar to the changes made to multiplayer.

  Dean Herbert · 2022-02-21 19:46:33 +09:00
  655b23f408
• Fix incorrect null check on now-bindable DifficultyRange
  Dean Herbert · 2022-02-21 19:38:26 +09:00
  c7e9cf904b
• Add fallback handling for item count to support different request types
  Dean Herbert · 2022-02-21 19:37:36 +09:00
  ffa5291b74
• Update ruleset filtering to use newly provided array return
  Dean Herbert · 2022-02-21 19:05:32 +09:00
  b5348e0407
• Add cover and count handling from newer response version
  Dean Herbert · 2022-02-21 19:05:22 +09:00
  b43008b9f6
• Handle API returned difficulty range for rooms
  Dean Herbert · 2022-02-21 19:05:19 +09:00
  39d64e779c
• Add API versioning
  Dean Herbert · 2022-02-21 19:02:03 +09:00
  7f4cc221d2
• Merge pull request #16939 from peppy/fix-intro-import-failure-ruleset-test-projects

  Add safeties to skip attempted import of the intro beatmap when osu! ruleset not present

  Dan Balasescu · 2022-02-21 18:24:56 +09:00
  0cfb85f3bb
• Merge pull request #16942 from peppy/copy-spotlight-category

  Allow room category to be copied even if `Spotlight`

  Dan Balasescu · 2022-02-21 18:21:21 +09:00
  33592b3e9e
• Update tests to match new behaviour
  Dan Balasescu · 2022-02-21 18:19:55 +09:00
  46b408be75
• Ensure spotlights always show at the top of the lounge listing

  As proposed at https://github.com/ppy/osu/discussions/16936. Spotlights
  are intended to have focus, so let's make sure they are the first thing
  the user sees for the time being.

  Dean Herbert · 2022-02-21 18:01:46 +09:00
  02a8500500
• Add test coverage of spotlights being at the top of the listing
  Dean Herbert · 2022-02-21 18:01:46 +09:00
  ab8b502709
• Allow room category to be copied even if Spotlight

  I remember that this conditional copy was added to support making copies
  of spotlight rooms without carrying across the `Spotlight` type, but in
  testing this is already handled web side to the point that it's not
  required.
  
  The rationale for allowing the copy is that this method is used for
  tests, where it was not being copied correctly from the input as
  expected (used at
  https://github.com/ppy/osu/blob/bdc3b76df0b58406796e2b08db13be7f2140fa7e/osu.Game/Tests/Visual/OnlinePlay/TestRoomManager.cs#L38).

  Dean Herbert · 2022-02-21 17:47:56 +09:00
  1737128334
• Ensure to not multiply by 0
  Dan Balasescu · 2022-02-21 17:19:35 +09:00
  c466d6df94
• Gracefully handle undefined DateTimeOffset values

  Only seems to happen in tests, but best to safeguard against this
  regardless.

  Dean Herbert · 2022-02-21 16:35:40 +09:00
  2f6e65a9a2
• Add safeties to skip attempted import of the intro beatmap when osu! ruleset not present

  In general running this import will not cause any critical failures, but
  the import itself *will* fail – and more loudly with the upcoming
  changes to `RulesetStore` (https://github.com/ppy/osu/pull/16890). Due
  to it being a loud failure, it will cause the notification overlay to
  display a parsing error, which can interrupt the flow of some tests.
  
  See test failure at
  https://github.com/ppy/osu/runs/5268848949?check_suite_focus=true as an
  example (video coverage at
  https://github.com/ppy/osu/pull/16890#issuecomment-1046542243).

  Dean Herbert · 2022-02-21 16:21:38 +09:00
  656c58567d
• Remove unused utils class
  Dean Herbert · 2022-02-21 13:43:30 +09:00
  3d0caa44c8
• Move to extension method and revert logic to match previous implementation
  Dean Herbert · 2022-02-21 13:42:26 +09:00
  fc1877b6fa
• Scale classic score by hitobject count
  Dan Balasescu · 2022-02-21 13:31:03 +09:00
  c3b365cf6b
• Add xmldoc and clean up ScoreboardTimeUtils extension methods a touch
  Dean Herbert · 2022-02-21 13:30:58 +09:00
  79408f6afc
• Remove unused using statement
  Dean Herbert · 2022-02-21 13:17:19 +09:00
  2ded7d281b
• Merge branch 'master' into leaderboard-score-timeref
  Dean Herbert · 2022-02-21 12:11:10 +09:00
  abe1a3990a
• Merge pull request #16933 from bdach/mod-overlay/basic-colour-theme

  Add all colour constants for "basic" colour theme to `OsuColour`

  Dean Herbert · 2022-02-21 11:12:34 +09:00
  85e2f68a64
• Remove static OverlayColourProviders
  Bartłomiej Dach · 2022-02-20 21:09:08 +01:00
  36a00c1ee2
• Remove all references to static OverlayColourProviders
  Bartłomiej Dach · 2022-02-20 21:09:08 +01:00
  ce0db9d4db
• Add Colour0 to OverlayColourProvider
  Bartłomiej Dach · 2022-02-20 21:09:08 +01:00
  79ba37bbab
• Add comments about OverlayColourProvider vs OsuColour distinction
  Bartłomiej Dach · 2022-02-20 21:08:58 +01:00
  2592f0900d
• Add all colour constants for "basic" colour theme to OsuColour
  Bartłomiej Dach · 2022-02-20 21:00:49 +01:00
  e20ae5b871
• Revert highlighting recent scores
  dekrain · 2022-02-19 21:23:35 +01:00
  262751a98a