Dean Herbert
1bbbe80420
Fix missing instances of HealthProcessor caching
2021-05-10 12:22:24 +09:00
Dean Herbert
132bb7832d
Fix some regressions when updating test scenes
2021-05-10 12:06:33 +09:00
Dean Herbert
b274fdf20d
Merge branch 'master' into skin-components-bind-outwards-health
2021-05-10 11:13:44 +09:00
Dan Balasescu
002622a92c
Merge pull request #12732 from Joehuu/ss-sort-by-source
...
Add ability to sort by source in song select
2021-05-10 10:10:56 +09:00
Dan Balasescu
0ff0353e13
Merge pull request #12734 from Susko3/make-max-volume-feel-better
...
Make adjusting volume to max feel better
2021-05-10 09:35:20 +09:00
Susko3
ab6239fd5f
change math for displaying volume "MAX"
2021-05-10 00:51:58 +02:00
Joseph Madamba
a71e52da4c
Fix enum ordering after adding source
2021-05-09 15:39:59 -07:00
Joseph Madamba
a21718f1cd
Move source case to a better spot
2021-05-09 14:26:45 -07:00
Joseph Madamba
8964d51de9
Add ability to sort by source in song select
2021-05-09 14:10:38 -07:00
Dean Herbert
2bcf1ed306
Merge pull request #12715 from Cublibre/fix-early-exit-crash
...
Fix InvalidOperationException when exiting a map at the end
2021-05-09 23:21:19 +09:00
Dean Herbert
a480e530fb
Merge pull request #12706 from peppy/skin-components-bind-outwards-accuracy
...
Update `AccuracyCounter` components to use DI to attach data source
2021-05-09 20:10:23 +09:00
Bartłomiej Dach
eb716455b7
Merge branch 'master' into skin-components-bind-outwards-accuracy
2021-05-09 12:13:18 +02:00
Dean Herbert
a669f90ae7
Merge pull request #12727 from EVAST9919/news-fix
...
Hide "Show More" button in news overlay if returned cursor is null
2021-05-09 18:50:35 +09:00
Andrei Zavatski
879c08e666
Use UntilStep instead of Assert to check button visibility
2021-05-09 10:06:36 +03:00
Andrei Zavatski
f0c1784d05
Use FirstOrDefault instead of First
2021-05-09 09:12:37 +03:00
Andrei Zavatski
8868439ce4
Another approach to fix test scene failure
2021-05-09 06:49:12 +03:00
Andrei Zavatski
0818deac17
Fix potential test scene failure due to showMoreButton not being loaded in time
2021-05-09 06:06:34 +03:00
Christine Chen
ae2b5a0806
Actually test that player was exited
2021-05-08 22:42:14 -04:00
Andrei Zavatski
dde9fd28e6
Hide ShowMore button if there's nothing to load
2021-05-09 04:57:24 +03:00
Andrei Zavatski
342c5a5938
Add tests to indicate the issue
2021-05-09 04:49:40 +03:00
Dean Herbert
0e91e6a155
Merge pull request #12724 from bdach/remove-current-from-legacyscorecounter
...
Remove vestigial `Current` reimplementation from `LegacyScoreCounter`
2021-05-09 05:01:53 +09:00
Dean Herbert
ea066cddc9
Merge pull request #12722 from bdach/fix-beatmap-listing-temporary-files
...
Fix temporary files from beatmap downloads not being cleaned up
2021-05-09 04:51:48 +09:00
Bartłomiej Dach
67cea6e762
Remove explicit binding to accuracy counter from overlay
2021-05-08 21:38:06 +02:00
Bartłomiej Dach
efb9164658
Restore previous test scene logic
2021-05-08 21:35:12 +02:00
Bartłomiej Dach
0bc6a026eb
Merge branch 'master' into skin-components-bind-outwards-accuracy
2021-05-08 21:08:53 +02:00
Bartłomiej Dach
c3bf6a0287
Remove weird vestigial Current reimplementation
...
Has no functional purpose anymore since the changes in the HUD element
data binding flow.
2021-05-08 21:01:37 +02:00
Bartłomiej Dach
b4a9c7095f
Merge pull request #12705 from peppy/skin-components-bind-outwards-score-display
2021-05-08 21:00:29 +02:00
Bartłomiej Dach
dec5400c0a
Merge branch 'master' into skin-components-bind-outwards-score-display
2021-05-08 19:58:19 +02:00
Bartłomiej Dach
d5efab0648
Merge pull request #12670 from peppy/skin-components-bind-outwards
2021-05-08 19:57:51 +02:00
Bartłomiej Dach
9e0ea494fd
Merge branch 'master' into skin-components-bind-outwards
2021-05-08 19:04:56 +02:00
Christine Chen
25312b3e88
Don't restart completion delegate on exit, revert exit behavior to lazer
2021-05-08 11:47:44 -04:00
Bartłomiej Dach
fe86ee629e
Fix temp files from beatmap listing imports not being cleaned up
...
As reported in #12718 , it turns out that temporary files from beatmap
set downloads performed via the beatmap listing overlay could remain in
the user's filesystem even after the download has concluded.
The reason for the issue is a failure in component integration.
In the case of online downloads, files are first downloaded to a
temporary directory (`C:/Temp` or `/tmp`), with a randomly generated
filename, which ends in an extension of `.tmp`.
On the other side, `ArchiveModelManager`s have a `ShouldDeleteArchive()`
method, which determines whether a file should be deleted after
importing. At the time of writing, in the case of beatmap imports the
file is only automatically cleaned up if the extension of the file is
equal to `.osz`, which was not the case for temporary files.
As it turns out, `APIDownloadRequest` has a facility for adjusting the
file's extension, via the protected `FileExtension` property. Therefore,
use it in the case of `DownloadBeatmapSetRequest` to specify `.osz`,
which then will make sure that the `ShouldDeleteArchive()` check in
`BeatmapManager` picks it up for clean-up.
2021-05-08 17:09:14 +02:00
Bartłomiej Dach
13bd3e95a9
Merge pull request #12698 from peppy/fix-editor-slider-input-handling
2021-05-08 17:08:48 +02:00
Dean Herbert
01d732bb65
Revert "Refactor SliderSelectionBlueprint to not reference blueprint pieces for input handling"
...
This reverts commit 54fe10c82a
2021-05-08 23:33:03 +09:00
Dean Herbert
63e267a3be
Revert "Trim redundant this qualifier"
...
This reverts commit df630d9428
2021-05-08 23:32:52 +09:00
Bartłomiej Dach
942281d6b0
Merge branch 'master' into fix-editor-slider-input-handling
2021-05-08 14:56:18 +02:00
Bartłomiej Dach
df630d9428
Trim redundant this qualifier
2021-05-08 14:53:19 +02:00
Christine Chen
8c564a69ed
Fix InvalidOperationException when exiting a map at the end
2021-05-07 21:11:03 -04:00
Dean Herbert
495eb04e2f
Merge pull request #12488 from Denrage/add-missing-author-links
...
Add missing author links in Beatmap Details
2021-05-08 05:41:40 +09:00
Dan Balasescu
b475c1a364
Merge pull request #12709 from peppy/update-framework
...
Update framework
2021-05-07 20:44:59 +09:00
Dean Herbert
5b2f786f97
Update framework
2021-05-07 19:16:00 +09:00
Dean Herbert
a1aeac5677
Remove remaining cruft from SkinnableAccuracyCounter
2021-05-07 18:12:18 +09:00
Dean Herbert
68de870986
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-07 18:11:14 +09:00
Dean Herbert
9fe6e1096a
Remove cruft from SkinnableHealthDisplay
2021-05-07 18:11:08 +09:00
ekrctb
111b501ced
Revert accidental removal of UTF-8 BOM
2021-05-07 18:04:38 +09:00
Dean Herbert
1cb10c2a22
Remove unnecessary binding logic from HUDOverlay
2021-05-07 17:51:46 +09:00
Dean Herbert
a7acecc52b
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-07 17:51:41 +09:00
Dean Herbert
3044b1c432
Add missing cache rules
2021-05-07 17:50:44 +09:00
Dean Herbert
6c255a0572
Fix drain start time being weirdly incorrect
2021-05-07 17:47:33 +09:00
Dean Herbert
8e78cac058
Fix HealthProcessor cached as derived type in test
2021-05-07 17:31:29 +09:00
