75563 Commits

This Branch

This Branch

All Branches

• Slightly delay retrieval of working beatmaps in song select panels

  Beatmap panels can be visible for very brief instants.
  `PanelSetBackground` has a backstop to prevent expensive background
  loads which is based on the position of the panel relative to centre of
  screen.
  
  However, retrieving the working beatmap that *precedes* any of that
  expensive background load logic, is *also* expensive, and *always* runs
  even if a panel is visible on screen for only a brief second. Therefore,
  by moving some of that background load delay towards delaying retrieving
  the working beatmap, we can save on doing even more work, which has
  beneficial implications for performance.

  Bartłomiej Dach · 2025-10-22 11:00:20 +02:00
  4ebd97b804
• Add pool names to quick play pool selector (#35394)
  Dean Herbert · 2025-10-22 17:54:49 +09:00
  dcb30ed5b3
• Fix intermittent footer test failures

  See:
  https://github.com/ppy/osu/pull/35367/checks?check_run_id=53269836615
  
  Can be reproed via a `Thread.Sleep(1000)` in a `TestScreenOne` BDL load.
  Code here is similar to `OsuGameTestScene.PushAndConfirm()`.

  Dan Balasescu · 2025-10-22 16:40:20 +09:00
  62599de649
• Merge pull request #35365 from bdach/bump-diffcalc-versions

  Bump difficulty calculator versions

  Dean Herbert · 2025-10-22 15:12:56 +09:00
  47b95de06d
• Merge pull request #35388 from Hoopsier/master

  Accuracy to pause

  Dean Herbert · 2025-10-22 14:31:23 +09:00
  2025.1022.0-tachyon 4e4eba2070
• Allow localisation of accuracy display on pause screen
  Dean Herbert · 2025-10-22 13:56:38 +09:00
  2ec0cbe5db
• Accuracy to pause and fail
  Hoopsy · 2025-10-22 00:29:55 +03:00
  0644543e28
• Merge pull request #35377 from peppy/update-framework

  Update framework

  Dean Herbert · 2025-10-21 18:58:42 +09:00
  61547d6b38
• Update framework
  Dean Herbert · 2025-10-21 17:24:33 +09:00
  0b84916c3e
• Merge pull request #35366 from bdach/carousel-collapsing-broke

  Fix beatmap set not expanding post-filter if grouping was turned off after manually collapsing active group

  Dean Herbert · 2025-10-20 20:22:56 +09:00
  3120871298
• Merge pull request #35313 from smoogipoo/subscreen-footer

  Make `ScreenFooter` support subscreens

  Bartłomiej Dach · 2025-10-20 10:00:36 +02:00
  0af3f15c7c
• Fix beatmap set not expanding post-filter if grouping was turned off after manually collapsing active group

  Closes https://github.com/ppy/osu/issues/35339.

  Bartłomiej Dach · 2025-10-20 09:30:02 +02:00
  594b8c1a60
• Add failing test
  Bartłomiej Dach · 2025-10-20 09:23:06 +02:00
  0269257287
• Bump difficulty calculator versions

  To trigger client-side recalculations of star ratings.
  
  Should have been done in https://github.com/ppy/osu/pull/35029.
  
  Probably closes https://github.com/ppy/osu/issues/35357.

  Bartłomiej Dach · 2025-10-20 08:46:30 +02:00
  03a5aedf99
• Merge pull request #35342 from peppy/revert-framework

  Revert framework bump to fix crashes for some users

  Dean Herbert · 2025-10-19 00:39:43 +09:00
  2025.1019.0-tachyon fbaf27e3db
• Merge pull request #35335 from peppy/fix-quick-play-user-panels

  Fix quick play player panels being hard to see against bright user backgrounds

  Dean Herbert · 2025-10-19 00:39:37 +09:00
  45eb34ecde
• Revert framework bump to fix crashes for some users
  Dean Herbert · 2025-10-18 23:53:45 +09:00
  10beab6ad3
• Fix quick play player panels being hard to see against bright user backgrounds
  Dean Herbert · 2025-10-18 23:18:57 +09:00
  70188d4fab
• Update framework
  Dean Herbert · 2025-10-18 19:08:07 +09:00
  1ce846294b
• Use new implementation in ScreenTestScene
  Dan Balasescu · 2025-10-17 19:01:28 +09:00
  4be29425a0
• Isolate footer behaviour to ScreenStackFooter, support subscreens
  Dan Balasescu · 2025-10-17 19:01:28 +09:00
  db3cc583e6
• Merge pull request #35316 from kennyaja/round_control_points

  Round slider control points to integer positions (instead of truncating them)

  Bartłomiej Dach · 2025-10-17 11:46:52 +02:00
  fec7ef7624
• Update relevant test with new expectations
  Bartłomiej Dach · 2025-10-17 08:58:09 +02:00
  6e378ad5af
• Use MathF instead of casting
  Bartłomiej Dach · 2025-10-17 08:44:58 +02:00
  8f8f605748
• Fix code quality
  Bartłomiej Dach · 2025-10-17 08:44:30 +02:00
  5f9ade6610
• Merge pull request #35317 from peppy/locus-bundle

  Add locus 2025 winners to bundled download beatmaps list

  Bartłomiej Dach · 2025-10-16 20:16:40 +02:00
  2025.1017.0-tachyon 1a569e9e2a
• Add locus 2025 winners to bundled download beatmaps list
  Dean Herbert · 2025-10-17 02:03:52 +09:00
  98762ce09e
• SSV2 : Replace "Mark as Played" with "Remove from Played" if map is already played (#35287)

  * SSV2 : Replace Mark as Played with Remove from Played if already played
  
  * Remove checks of BeatmapInfo.LastPlayed for DateTimeOffset.MinValue
  
  * Make FooterButtonOptions use a RealmLive<BeatmapInfo> and act on review comments
  
  * FIXUP: Detach BeatmapInfo before passing it to FooterButtonOptions.Popover
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Alban Cabannes-Michel · 2025-10-16 14:59:16 +02:00
  8f6f859c15
• Also round slider control points to integer positions if it has less than 2 segments
  kennyaja · 2025-10-16 19:25:43 +07:00
  cf1834b080
• Fix Hold Off mod changing scroll speed in rare scenarios (#35265)

  Reported (in a rather confusing manner) in
  https://discord.com/channels/188630481301012481/1097318920991559880/1426084740783538268.
  
  The relevant bit here is the following logic:
  
  	https://github.com/ppy/osu/blob/32c60bfb36ae428e6fe56b077d9397c6bc57dd30/osu.Game/Rulesets/UI/Scrolling/DrawableScrollingRuleset.cs#L111-L118
  
  which mania enables.

  Bartłomiej Dach · 2025-10-16 21:09:52 +09:00
  a2bae15db1
• Merge pull request #35312 from smoogipoo/fix-mp-exit

  Fix screen event misusages in multplayer/matchmaking

  Dean Herbert · 2025-10-16 18:19:01 +09:00
  159349a64b
• Add footer tests involving subscreens
  Dan Balasescu · 2025-10-16 17:38:51 +09:00
  81a529200d
• Refactor resuming / exiting events
  Dan Balasescu · 2025-10-16 17:05:52 +09:00
  6fa4a7152f
• Fix missing entering / suspending events
  Dan Balasescu · 2025-10-16 17:05:52 +09:00
  508c37c27b
• Fix matchmaking calling OnExiting() twice

  Once prior to the confirmation dialog being displayed, then a second
  time after the exit is confirmed.

  Dan Balasescu · 2025-10-16 17:05:46 +09:00
  95f86a5c0e
• Fix multiplayer calling OnExiting() twice

  Once via explicit call to `OnExiting()`, and the second time via
  `.Exit()`.

  Dan Balasescu · 2025-10-16 17:02:20 +09:00
  cd62f66d79
• Round instead of truncating slider control points to integer positions
  kennyaja · 2025-10-16 14:44:44 +07:00
  3fbe777f33
• Merge pull request #35236 from tadatomix/song-select/coloured-group-ranked-status

  Colour Ranked Status panel to the related status

  Dean Herbert · 2025-10-15 16:56:45 +09:00
  b8ceb91a78
• Merge pull request #35300 from bdach/show-leaderboard-in-solo-spectator

  Show leaderboard in solo spectator

  Dean Herbert · 2025-10-14 22:55:55 +09:00
  9f61284371
• Merge pull request #35263 from bdach/user-tag-not-equals-filter

  Fix not-equals user, artist, and title tag filters not working

  Dean Herbert · 2025-10-14 22:29:09 +09:00
  3f18a1312e
• Merge pull request #34845 from diquoks/localisation/binding-settings

  Localise "back" button in `BindingSettings`

  Bartłomiej Dach · 2025-10-14 13:00:26 +02:00
  17758d5934
• Merge pull request #35273 from diquoks/localisation/play

  Localise `Break` & `PlayerSettings` on `Play` screen

  Bartłomiej Dach · 2025-10-14 12:57:45 +02:00
  eaebe99a5c
• Show leaderboard in solo spectator

  Closes https://github.com/ppy/osu/issues/35293.
  
  The removed comment here says that "there's no guarantee" that
  `LeaderboardManager` has the correct scores:
  
  	https://github.com/ppy/osu/blob/a060ddb5439412e8b503800f4e6e8d80df40cacf/osu.Game/Screens/Play/SpectatorPlayer.cs#L22-L25
  
  but at least now, that's not correct because this is ensured via
  
  	https://github.com/ppy/osu/blob/a060ddb5439412e8b503800f4e6e8d80df40cacf/osu.Game/Screens/Play/PlayerLoader.cs#L280-L286
  
  through which the solo spectator player is pushed:
  
  	https://github.com/ppy/osu/blob/a060ddb5439412e8b503800f4e6e8d80df40cacf/osu.Game/Screens/Play/SoloSpectatorScreen.cs#L239
  
  The empty leaderboard provider is still valid however in the case of
  multiplayer spectator, because there we don't really ever want to be
  showing any leaderboards on the individual player instances.

  Bartłomiej Dach · 2025-10-14 11:50:55 +02:00
  1edbb1d586
• Merge pull request #35262 from bdach/song-select-move-realm-fetches-off-thread

  Move realm refetches of beatmap in song select wedges off of update thread

  Dean Herbert · 2025-10-13 22:57:54 +09:00
  a060ddb543
• Improve design of quick play endgame results (#35267)
  Dean Herbert · 2025-10-13 22:07:21 +09:00
  f488974d39
• Fix artist/title keyword filters not working properly with not-equals operator

  Closes https://github.com/ppy/osu/issues/35264.

  Bartłomiej Dach · 2025-10-13 11:39:59 +02:00
  8e01fb70c3
• Fix exclusion filters filtering out empty strings
  Bartłomiej Dach · 2025-10-13 11:39:38 +02:00
  a3f635588c
• Add failing test coverage for artist text filters also not working correct
  Bartłomiej Dach · 2025-10-13 11:22:29 +02:00
  f8d3285ab4
• Fix code quality
  Bartłomiej Dach · 2025-10-13 10:19:19 +02:00
  a73c325235
• Attempt to ensure RealmAccess waits for the async read before disposing itself
  Bartłomiej Dach · 2025-10-13 09:27:21 +02:00
  97739c39e7