Salman Alshamrani
40b95901e3
Fix more cases of settings with no defined precision values
2024-11-20 12:11:38 -05:00
Salman Alshamrani
1ef02fec06
Fix "positional hitsounds level" setting not specifying a precision constraint
2024-11-20 12:08:57 -05:00
Bartłomiej Dach
273095fd82
Merge pull request #30757 from peppy/fix-scroll-absolute-pos
...
Fix right click scroll at song select not quite matching scrollbar position
2024-11-19 10:40:00 +01:00
Dean Herbert
a529cef28b
Merge pull request #30743 from peppy/collection-scroll-etc
...
Further UX improvements to collection management
2024-11-19 00:32:16 +09:00
Dean Herbert
a2af4cbb50
Fix right click scroll at song select not quite matching scrollbar position
...
Closes https://github.com/ppy/osu/issues/30744 .
2024-11-18 23:54:56 +09:00
Bartłomiej Dach
22b082d968
Fix not being able to scroll to new collection text box when list overflows
2024-11-18 15:28:30 +01:00
Bartłomiej Dach
259e9ecf65
Deactivate new combo toggle on deselecting objects
...
Closes https://github.com/ppy/osu/issues/30713 .
Was a point of discussion doing review:
https://github.com/ppy/osu/pull/30214#discussion_r1798833139
Given it got pointed out immediately for something so minor, I'm
inclined to believe it's a rather undesirable change.
2024-11-18 15:13:32 +01:00
Dean Herbert
5ce1f7679b
Add search bar to collection management dialog
2024-11-18 16:32:56 +09:00
Dean Herbert
a570863854
Scroll to new collection in list when adding a new collection
2024-11-18 16:32:56 +09:00
Dean Herbert
e5778eb1fc
Add scrollbar to manage collections dialog
2024-11-18 16:32:56 +09:00
Dan Balasescu
5276f77ebd
Merge pull request #30684 from Joehuu/source-filter
...
Add missing source query filter in song select
2024-11-18 16:06:26 +09:00
Joseph Madamba
ad9acc5a0f
Add hotkey hints to skin editor menus
2024-11-15 23:03:40 -08:00
Joseph Madamba
706f5b3e55
Add missing clone keybinding to skin editor
2024-11-15 23:03:40 -08:00
Joseph Madamba
465cc716d3
Add missing source query filter in song select
2024-11-15 22:53:23 -08:00
Dean Herbert
0a1f589c80
Fix black layer not fading fast enough when exiting quickly from quick restart
2024-11-16 11:52:02 +09:00
Dean Herbert
a5fab23e44
Update framework
2024-11-16 11:49:19 +09:00
Bartłomiej Dach
21d407680b
Merge pull request #30623 from peppy/fix-flash-transition-player
...
Fix occasional flash when quick exiting / retrying from player
2024-11-15 08:42:43 +01:00
Dan Balasescu
58aba5439a
Merge pull request #30622 from bdach/not-enough-timed-events
...
Do not show timing distribution graph in offset control if there's not enough timed hits
2024-11-15 11:59:20 +09:00
Dean Herbert
1a31e56d4a
Fix double restart call still existing
2024-11-14 23:59:55 +09:00
Bartłomiej Dach
b94d3d7a64
Merge pull request #30607 from OliBomby/legacy-export-offset
...
Fix timing point truncation causing missnaps on compatibility-exported lazer beatmaps
2024-11-14 15:49:05 +01:00
Bartłomiej Dach
15a474dead
Merge pull request #30613 from shinmorisawa/1hour-song-multi
...
Fix difficulty icon tooltip not displaying duration above 1 hour correctly
2024-11-14 15:43:48 +01:00
Bartłomiej Dach
5d3f55fe4d
Fill out xmldoc
2024-11-14 15:05:46 +01:00
Dean Herbert
d1b5d31ea6
Add explicit parameter in
2024-11-14 22:23:42 +09:00
Dean Herbert
3262b6d989
Refactor to avoid dual-boolean mess
2024-11-14 22:10:45 +09:00
Dean Herbert
afeb138ea0
Fix occasional flash when quick exiting / retrying from player
...
The gist of the issue is that `fadeOut` was being called *twice* in the
quick exit/retry scenarios, causing weirdness with transforms.
I've restructured things to ensure it's only called once.
2024-11-14 21:54:34 +09:00
Bartłomiej Dach
7ee9802923
Merge pull request #30616 from peppy/collection-management-revamp
...
Fix collection management dialog refreshing full display when any change occurs
2024-11-14 13:21:09 +01:00
Bartłomiej Dach
bd1d3cad49
Do not show timing distribution graph in offset control if there's not enough timed hits
...
Intended to address concerns raised in
https://github.com/ppy/osu/pull/30620#issuecomment-2475744164 .
2024-11-14 13:17:03 +01:00
Bartłomiej Dach
d08c8ae482
Merge pull request #30620 from peppy/fix-offset-adjust-crash
...
Fix crash when resetting offset after a play with no hit events
2024-11-14 12:43:47 +01:00
Bartłomiej Dach
1355fa636d
Merge pull request #30603 from peppy/quick-restart-faster-better
...
Make quick restart even faster
2024-11-14 12:30:13 +01:00
Bartłomiej Dach
f9489690cb
Fix code inspection
2024-11-14 11:58:57 +01:00
Dean Herbert
36d48a01c8
Add missing expire call
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-11-14 19:33:34 +09:00
Dean Herbert
9849a88eef
Adjust transition further to avoid brief "jumpscare" display of metadata
2024-11-14 18:28:27 +09:00
Bartłomiej Dach
88aea70429
Do not permit new combo toggle to remain in indeterminate state on deselect
2024-11-14 10:07:09 +01:00
Bartłomiej Dach
1b279e45cc
Merge branch 'master' into feat/optimize-polygon-tool
2024-11-14 09:54:04 +01:00
Dean Herbert
23167b0221
Merge pull request #30618 from Natelytle/ltca-broke-pp
...
Fix NaN PP counter values while SR is 0
2024-11-14 17:42:05 +09:00
Shin Morisawa
7dff243e6a
use .ToFormattedDuration
2024-11-14 16:59:03 +09:00
Dean Herbert
4957a517aa
Update framework
2024-11-14 16:38:26 +09:00
Shin Morisawa
64e7e44f28
fix issue
2024-11-14 16:33:52 +09:00
Shin Morisawa
53fcb494ff
Merge branch 'ppy:master' into 1hour-song-multi
2024-11-14 16:32:24 +09:00
Bartłomiej Dach
02e4907fb6
Merge pull request #29896 from OliBomby/hs-toggle2
...
Collapse sample point indicators into dots if they cannot be displayed in full
2024-11-14 08:28:11 +01:00
Dean Herbert
7f8eebc510
Merge pull request #30578 from smoogipoo/beatmap-legacy-object-type
...
Simplify convertible hitobject parsing and add `IHasLegacyHitObjectType`
2024-11-14 16:16:44 +09:00
Dean Herbert
88d220f4c5
Fix crash when resetting offset after a play with no hit events
...
Closes https://github.com/ppy/osu/issues/30573 .
2024-11-14 16:03:15 +09:00
Nathen
d0e793a3b3
More correct but not too important
2024-11-14 01:50:05 -05:00
Nathen
2ea2e5f1db
Be doubly careful
2024-11-14 01:47:24 -05:00
Nathen
ce818f59e7
Fix NaN PP values when SR is 0
2024-11-14 01:42:07 -05:00
Dean Herbert
fea6a54432
Fix more tests reading in wrong order
2024-11-14 14:46:58 +09:00
Dean Herbert
17b1888c59
Avoid using newTexst as it doesn't work well with tests
2024-11-14 14:39:05 +09:00
Dean Herbert
ebe9a9f083
Avoid writing changes to realm when collection name wasn't actually changed
2024-11-14 14:39:05 +09:00
Dean Herbert
695f156f5f
Change collection management dialog to handle changes more correctly
2024-11-14 14:39:05 +09:00
Dean Herbert
d37c1bb6d0
Remove redundant null initialisation and apply nullability
2024-11-14 13:37:58 +09:00
