75015 Commits

This Branch

This Branch

All Branches

• Merge pull request #34808 from peppy/fix-difficulty-churn

  Fix beatmap carousel triggering full filters more often than it needs to

  Bartłomiej Dach · 2025-08-28 14:26:25 +02:00
  3eaa5314ac
• Ensure filtering also runs after local gameplay LastPlayed changes
  Dean Herbert · 2025-08-28 19:10:20 +09:00
  7e109add96
• Merge pull request #34740 from bdach/maximised-player-audio

  Always use audio from maximised player if there is one in multiplayer spectator

  Dean Herbert · 2025-08-28 18:27:56 +09:00
  f953d58922
• Merge pull request #34818 from smoogipoo/completion-handler-override

  Preserve pre-post notification completion target

  Dean Herbert · 2025-08-28 14:10:59 +09:00
  0b40f1d0db
• Preserve pre-post notification completion target
  Dan Balasescu · 2025-08-28 13:07:05 +09:00
  e831d1b6fa
• Merge branch 'master' into fix-difficulty-churn
  Dean Herbert · 2025-08-28 02:38:10 +09:00
  ed15e1fb88
• Merge pull request #34812 from bdach/failed-at-judgement

  Fix `HealthProcessor` potentially incorrectly reverting failed state

  Dean Herbert · 2025-08-28 02:37:44 +09:00
  33b99a51b1
• Fix hidden beatmap state not being reflected immediately
  Dean Herbert · 2025-08-28 02:33:18 +09:00
  8a6c857719
• Merge pull request #34809 from peppy/fix-star-rating-weird-mod-double-handling

  Fix beatmap panels locally handling mod and ruleset changes unnecessarily

  Dean Herbert · 2025-08-28 01:27:31 +09:00
  5abd93eda7
• Apply in more places
  Dean Herbert · 2025-08-27 19:59:44 +09:00
  f9c1b24df4
• Fix HealthProcessor potentially incorrectly reverting failed state

  This stems from me looking into `TestSceneFailAnimation` failures
  (https://github.com/ppy/osu/runs/48663953318). As it turns out, I should
  not have been mad by CI, and rather should have been mad at myself for
  failing to read.
  
  `FailedAtJudgement` in fact does not mean "this judgement, and only this
  judgement, triggered failure". If any further judgements occur
  post-fail, they will also have `FailedAtJudgement` set to true. It is
  essentially a *dump* of the state of `HealthProcessor.Failed` prior to
  applying the judgement.
  
  	https://github.com/ppy/osu/blob/ec21685c2531af3b243f7f0833ffbb340bf3c044/osu.Game/Rulesets/Scoring/HealthProcessor.cs#L49-L57
  
  Because of this, reverting several judgements which occur post-fail
  could lead to failed state reverting earlier than intended, and thus
  potentially trigger a second fail, thus tripping the `Player` assertion.

  Bartłomiej Dach · 2025-08-27 12:27:11 +02:00
  197c318180
• Fix beatmap panels locally handling mod changes unnecessarily

  The `BeatmapDifficultyCache` handles mod changes, so handling locally is
  unnecessary. By handling locally, it creates a visual issue when
  adjusting mods often. Test using Ctrl +/- at song select and observing
  that without this change, the star rating will flicker back to the
  default due to the local re-fetch.

  Dean Herbert · 2025-08-27 18:31:50 +09:00
  fda40d7fd5
• Fix beatmap carousel re-filtering when it doesn't need to

  Local rules ensure we only handle callbacks when we need to.

  Dean Herbert · 2025-08-27 18:21:19 +09:00
  be6fb9aa77
• Avoid triggering changes when add operations are empty

  Only seems to happen in tests. I think.

  Dean Herbert · 2025-08-27 18:13:13 +09:00
  0e57ee9ba6
• Add test coverage ensuring filtering does not occur on unnecessary updates
  Dean Herbert · 2025-08-27 18:13:12 +09:00
  043235fed2
• Merge pull request #34803 from peppy/update-framework-please-no-clock-breakage

  Update framework

  Dean Herbert · 2025-08-27 13:23:09 +09:00
  2025.827.0-tachyon ec21685c25
• Update framework
  Dean Herbert · 2025-08-26 21:43:09 +09:00
  244bad07c7
• Merge pull request #34802 from bdach/hack-around-carousel-panel-refresh

  Work around excessive refreshes of carousel beatmap set panel backgrounds

  Dean Herbert · 2025-08-26 21:13:28 +09:00
  2bea59e65f
• Work around excessive refreshes of carousel beatmap set panel backgrounds

  Closes https://github.com/ppy/osu/issues/34511 I guess.

  Bartłomiej Dach · 2025-08-26 13:27:54 +02:00
  c0fd5637de
• Merge pull request #34801 from peppy/replay-player-null

  Fix crash on exiting `ReplayPlayer` is beatmap was not loaded successfully

  Bartłomiej Dach · 2025-08-26 12:11:27 +02:00
  5e7a99c97f
• Merge pull request #34800 from peppy/fix-daily-challenge-leaderboard-skip

  Fix daily challenge / playlist leaderboard sometimes showing incorrect default state

  Bartłomiej Dach · 2025-08-26 12:07:41 +02:00
  8f628d16ae
• Add test coverage and fix one more fail case
  Dean Herbert · 2025-08-26 18:41:14 +09:00
  2ccb65aa65
• Fix crash on exiting ReplayPlayer is beatmap was not loaded successfully

  Closes https://github.com/ppy/osu/issues/34763.

  Dean Herbert · 2025-08-26 18:31:42 +09:00
  4d851f2527
• Apply NRT to ReplayPlayer for good measure
  Dean Herbert · 2025-08-26 18:30:12 +09:00
  4bafbfb9e4
• Sort scores immediately for good measure
  Dean Herbert · 2025-08-26 17:51:14 +09:00
  3f179e3903
• Fix playlist leaderboard provider potentially inserting local user in wrong order

  Due to `Perform` being used from a BDL method in conjunction with
  `Success` (which is scheduled to the *update* thread), there was a
  chance that the order of execution would be not quite as intended.
  
  To rectify, let's not use `Success` and just continue with synchronous
  flow.

  Dean Herbert · 2025-08-26 17:51:02 +09:00
  196b28115e
• Merge pull request #34794 from bdach/fix-aim-meter

  Fix aim error meter applying incorrect scaling constant in normalised mode

  Dean Herbert · 2025-08-26 15:16:15 +09:00
  7660a9ba8e
• Fix aim error meter applying incorrect scaling constant in relative mode

  Closes https://github.com/ppy/osu/issues/34769
  
  Visible (and easiest to check) in test scene.

  Bartłomiej Dach · 2025-08-25 14:20:05 +02:00
  e908b80359
• Fix copy-paste fail in log message
  Bartłomiej Dach · 2025-08-25 13:43:03 +02:00
  a2bf8e3988
• Merge pull request #34761 from frenzibyte/fix-flashlight

  Fix flashlight not always matching gameplay scaling

  Bartłomiej Dach · 2025-08-25 12:03:58 +02:00
  6e8246b539
• Fix xmldoc error and reword
  Salman Alshamrani · 2025-08-24 18:55:45 +03:00
  3cca458c21
• Fix flashlight not handling internal playfield sizing changes

  Note that this does not handle sizing/scaling changes applied directly
  to `Playfield`, but it handles any changes within the layers inside
  `PlayfieldAdjustmentContainer`.

  Salman Alshamrani · 2025-08-24 17:51:05 +03:00
  bc59270f3e
• Merge pull request #34766 from bdach/remove-double-lookup

  Pull up online beatmap set lookup to song select level to avoid two components doing the same fetch independently

  Dean Herbert · 2025-08-23 20:50:17 +09:00
  16343fd7d6
• Merge pull request #34757 from bdach/new-mod-icons

  Update mod icons

  Dean Herbert · 2025-08-23 19:55:10 +09:00
  acafc06bcc
• Remove no longer valid test
  Salman Alshamrani · 2025-08-23 09:28:14 +03:00
  c0c3690908
• Fix song select favourite button potentially showing stale data from (un)favourite request callback
  Bartłomiej Dach · 2025-08-22 14:25:25 +02:00
  5292d4a04e
• Pull up online beatmap set lookup to song select level to avoid two components doing the same fetch independently
  Bartłomiej Dach · 2025-08-22 14:25:21 +02:00
  d3ae20dd88
• Merge pull request #34723 from bdach/status-updates-are-great-arent-they

  Refresh realm before performing song select refetches following an online metadata lookup

  Dean Herbert · 2025-08-22 20:25:36 +09:00
  2025.822.0-tachyon c852e5854c
• No longer download iOS simulator

  https://github.com/actions/runner-images/issues/12862#issuecomment-3209787203

  Dan Balasescu · 2025-08-22 13:29:46 +09:00
  0756c45d70
• Add visual test setup for taiko flashlight
  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  73624e4e25
• Fix taiko flashlight applying aspect ratio twice
  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  f374af7ce7
• Adjust default flashlight size on osu! & osu!catch

  Because the flashlight is made to be scaled by playfield, there are
  constant scale factors applied somewhere in the
  `PlayfieldAdjustmentContainer` which needs to be reflected in the
  flashlight size to keep the size the same.
  
  The factor is specifically 1.6x, computed in {Osu,Catch}PlayfieldAdjustmentContainer.ScalingContainer`.
  
  More generally, I've deduced these factors by logging the difference
  between the `flashlightSize` before and after b78abe2f.

  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  7530ad1a7b
• Fix flashlight not correctly scaled to match playfield
  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  a049f5065d
• Update resources
  Bartłomiej Dach · 2025-08-21 14:44:43 +02:00
  4627c8a859
• Merge pull request #34759 from bdach/BACKGROUND-STUCK-PLEASE-I-BEG-YOU

  Fix song select background being stuck in revealed state

  Dean Herbert · 2025-08-21 21:01:59 +09:00
  30f7da8f71
• Merge pull request #34752 from bdach/avoid-endless-futile-backpopulation

  Fix submission & rank date backpopulation failing every launch for some users

  Dean Herbert · 2025-08-21 20:37:03 +09:00
  4b8ff481fd
• Fix song select background being stuck in revealed state

  Closes https://github.com/ppy/osu/issues/34731.
  
  The failure scenario here is as follows:
  
  - User holds down left mouse button for >200ms to reveal the background.
  - User presses down another mouse button and releases it in <200ms.
  - User releases left mouse button. Song select does not return.
  
  The timing here is key because what is happening here is that the second
  mouse button press is overwriting the `revealingBackground` scheduled
  delegate. Releasing that same mouse button within 200ms leads to that
  scheduled delegate being cancelled and cleared, and thus the release of
  left mouse wrongly decides there is nothing left to do.
  
  One thing I'm not entirely sure about is the release behaviour even with
  this change; as things stand, the first release of any mouse button will
  bring song select back, even if it was not the button that was initially
  held down to reveal the background. That's probably easily fixed if
  deemed required, but I'm most interested in fixing the bad breakage.

  Bartłomiej Dach · 2025-08-21 11:31:37 +02:00
  a7f1795f98
• Adjust icon sizings in mod display to match new assets
  Bartłomiej Dach · 2025-08-21 09:00:48 +02:00
  c053cfbf9b
• Add test steps to mod icon test scene for exercising all rulesets
  Bartłomiej Dach · 2025-08-21 09:00:46 +02:00
  e47a60f303
• Add and use new mod icon assets
  Bartłomiej Dach · 2025-08-21 09:00:44 +02:00
  92016a7d9b