933 Commits

• Fix incorrect parsing of BSpline curve types
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  3d094f84ad
• Adjust casing of curve type menu items

  The "Perfect curve" one in particular... fixes test failures, as some
  tests were relying on this particular casing. But the new version feels
  more correct anyway, so it's whatever.

  Bartłomiej Dach · 2023-11-20 15:42:55 +09:00
  8e39dbbff1
• Fix incorrect legacy conversion when B-splines are used
  Bartłomiej Dach · 2023-11-20 15:08:58 +09:00
  6d7d826b8b
• Use static BEZIER instead of allocating new every time
  Bartłomiej Dach · 2023-11-20 13:35:07 +09:00
  80a3225bb2
• Remove pattern matching syntax usage in switch

  Also throw on unknown types.

  Bartłomiej Dach · 2023-11-20 13:34:01 +09:00
  487326a4c7
• Decrease redundancy of equality implementations
  Bartłomiej Dach · 2023-11-20 12:28:20 +09:00
  7820c8ce4d
• Change switchexpr to standard switch statement
  Bartłomiej Dach · 2023-11-20 12:26:45 +09:00
  25c1a90047
• Move static instances / construction methods closer together
  Bartłomiej Dach · 2023-11-20 12:26:43 +09:00
  577cb9994c
• Fix control point hover text and context menu
  cs · 2023-11-15 07:45:09 +01:00
  520642975b
• Fix code style/quality issues
  cs · 2023-11-13 08:25:27 +01:00
  fa976a5aa0
• CI Fixup
  cs · 2023-11-11 15:02:06 +01:00
  54b8244a18
• Add free-hand drawing of sliders to the editor
  cs · 2023-11-11 13:33:25 +01:00
  3f85aa79c5
• Generalize Bezier curves to BSplines of Nth degree
  Thomas Müller-Höhne · 2023-11-11 13:32:53 +01:00
  926636cc03
• Merge pull request #25185 from bdach/minimum-sample-volume
  Dean Herbert · 2023-10-24 22:04:43 +09:00
  34505b3933
• Enforce minimum gameplay sample volume of 5%
  Bartłomiej Dach · 2023-10-20 15:50:13 +02:00
  b321d556b6
• Fix fudge not being applied
  Dean Herbert · 2023-10-20 20:18:14 +09:00
  906b700aca
• Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch

  As discussed, it isn't used in stable like this. Was a mistake.

  Dean Herbert · 2023-10-20 18:57:14 +09:00
  3fb74cb5f9
• Merge branch 'master' into legacy-tick-test-coverage
  Dan Balasescu · 2023-10-18 15:21:31 +09:00
  939b55020c
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2
• Move validation to DHO.ApplyResult()
  Dan Balasescu · 2023-10-10 21:42:37 +09:00
  a1a46e58fc
• Add better commenting around legacy last tick edge case
  Dean Herbert · 2023-10-04 13:45:26 +09:00
  cfb18e18c0
• Document remaining pieces of LastTick and add back legacy prefix for generation flow
  Dean Herbert · 2023-09-29 16:58:17 +09:00
  62bcb62842
• Move LegacyLastTickOffset specification to generation code and stop passing everywhere
  Dean Herbert · 2023-09-29 14:32:29 +09:00
  81485c548c
• Merge branch 'master' into fix-slider-length
  Bartłomiej Dach · 2023-09-20 11:10:01 +02:00
  28da5baea4
• Merge pull request #24800 from sw1tchbl4d3r/invalid_bank

  Default to normal bank if invalid sample bank is specified

  Dean Herbert · 2023-09-19 22:28:34 +09:00
  aea7f81f1c
• Replace sample bank fix with more correct fix

  stable does not treat unknown enum members as `None` / `Auto`, it treats
  them as `Normal`:
  
      switch (sampleSet)
      {
          case SampleSet.Normal:
          default:
              sample = 0;
              break;
          case SampleSet.None:
          case SampleSet.Soft:
              sample = 1;
              break;
          case SampleSet.Drum:
              sample = 2;
              break;
      }
  
      (from https://github.com/peppy/osu-stable-reference/blob/1531237b63392e82c003c712faa028406073aa8f/osu!/Audio/AudioEngine.cs#L1158-L1171).

  Bartłomiej Dach · 2023-09-19 13:53:49 +02:00
  c4a0ca326e
• Check if path lists are empty
  Magnus-Cosmos · 2023-09-19 02:28:28 -04:00
  73db68a49a
• Fix slider path calculations for edge cases
  Magnus-Cosmos · 2023-09-19 01:31:26 -04:00
  a9b45c6fdc
• Fix extension check using control points instead of path points
  Magnus-Cosmos · 2023-09-18 11:40:00 -04:00
  83584519e6
• Make not extension method
  Dean Herbert · 2023-09-15 18:13:04 +09:00
  56cc2b62f0
• Move to extension method and throw on non-legacy ruleset
  Dean Herbert · 2023-09-15 17:38:34 +09:00
  0031da76ff
• Default to none bank if invalid samplebank is specified
  sw1tchbl4d3 · 2023-09-13 12:44:00 +02:00
  5b2af7f264
• Make rounding error even less precise

  Basically matching the old code more closely to avoid too much precision
  from doing math in a slightly different way.

  Dean Herbert · 2023-09-12 18:41:09 +09:00
  4ecc4632aa
• Remove all usage of LegacyDifficultyControlPoint
  Dean Herbert · 2023-09-07 17:41:57 +09:00
  b34a36f6ce
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28
• Merge branch 'master' into judge-fix
  Bartłomiej Dach · 2023-08-22 09:44:58 +02:00
  8cd9f0822a
• Reword comment to be better
  Bartłomiej Dach · 2023-08-22 09:37:54 +02:00
  5be5335784
• Update inline comments
  OliBomby · 2023-08-21 13:09:31 +02:00
  e283aa2843
• Merge branch 'master' into fix-slider-reversing
  Bartłomiej Dach · 2023-08-21 09:29:46 +02:00
  1d657a8844
• Reformat xmldoc
  Bartłomiej Dach · 2023-08-21 08:29:51 +02:00
  dd1ac461db
• expand xmldoc
  OliBomby · 2023-08-19 19:39:29 +02:00
  56b1062c2f
• Add braces for clarification

  I like no-braces for single-line ifs as much as anyone, but with inline
  comments involved it gets rather dicey.

  Bartłomiej Dach · 2023-08-19 14:34:20 +02:00
  0a55830c16
• Update Reverse() based on the changes in #24581
  Pasi4K5 · 2023-08-19 02:40:18 +02:00
  44a85139e4
• Merge remote-tracking branch 'OliBomby/fix-segment-ends' into fix-slider-reversing
  Pasi4K5 · 2023-08-19 02:38:34 +02:00
  47d787b359
• Revert changes in SliderPath
  Pasi4K5 · 2023-08-19 00:16:05 +02:00
  0e691d5935
• fix GetSegmentEnds
  OliBomby · 2023-08-18 12:20:40 +02:00
  ff07fbae15
• Fix segmentEnds being calculated incorrectly
  Pasi4K5 · 2023-08-18 04:34:10 +02:00
  3481c41a22
• Fix possible IndexOutOfRangeException
  Pasi4K5 · 2023-08-16 01:19:41 +02:00
  58bffa13cd
• Replace .Distinct() with truncateEndingDuplicates()
  Pasi4K5 · 2023-08-16 01:14:25 +02:00
  e7e0c49f42
• Improve code readability and add assertion to test scene
  Pasi4K5 · 2023-08-15 23:27:12 +02:00
  6346872c39