39810 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	3bddf4bf9a	Rename spectator-specific settings to more generic (with backwards migration)	2023-09-18 14:56:06 +02:00
Bartłomiej Dach	27471ad170	Make missing beatmap notification simple ... Progress didn't work for several reasons: - It was spinning when nothing was actually happening yet (especially egregious with autodownload off) - It was blocking exits (as all progress notifications do) - When actually going to download, two progress notifications would pertain to one thing - It wasn't helping much with the actual implementation of score re-import, cancelling the progress notification would result in similarly jank UX of beatmap importing but not the score.	2023-09-18 14:56:06 +02:00
Bartłomiej Dach	b2c98da330	Reword and localise copy	2023-09-18 14:56:06 +02:00
Bartłomiej Dach	2709c6cd67	Integrate nano beatmap card into the notification	2023-09-18 14:56:06 +02:00
Bartłomiej Dach	47764b3012	Fix OsuTestScene.CreateAPIBeatmapSet() not backlinking set beatmaps to the set	2023-09-18 14:56:06 +02:00
Bartłomiej Dach	5fcd736332	Redo nano beatmap card design to fit needs better ... Wanting to use this inside notification, it turns out that the original design did not work very well at such narrow widths, and additionally the typical button setup borrowed from elsewhere resulted in teeny tiny action buttons. To that end, slim down the design (get rid of thumbnail, audio preview, make expandable right side slimmer), as well as change the entire panel so that it has only one action associated with it at all times, and clicking the panel in any place triggers that action.	2023-09-18 14:56:06 +02:00
Bartłomiej Dach	67b5dfb9cf	Merge branch 'get-reader-regression' into missing-beatmap	2023-09-18 14:56:06 +02:00
Bartłomiej Dach	06d1a2a316	Merge branch 'beatmap-card-nano' into missing-beatmap	2023-09-18 14:56:06 +02:00
Dean Herbert	f3b6aa5435	Merge pull request #24821 from bdach/scoring-test-scene-osu ... Refactor scoring test scene for ruleset extensibility (and move existing instance to osu! ruleset project)	2023-09-18 19:54:14 +09:00
Bartłomiej Dach	e57d7d1205	Fix MemoryStreamArchiveReader.GetStream() failing in some cases ... `MemoryStreamArchiveReader` introduced in 0657b55196 would previously use `MemoryStream.GetBuffer()` to retrieve the underlying byte buffer with stream data. However, this is not generally the method you would want, for two reasons: 1. It can fail if the stream wasn't created in the way that supports it. 2. As per https://learn.microsoft.com/en-us/dotnet/api/system.io.memorystream.getbuffer?view=net-7.0#system-io-memorystream-getbuffer, it will return the _raw_ contents of the buffer, including potentially unused bytes. To fix, use `MemoryStream.ToArray()` instead, which avoids both pitfalls. Notably, `ToArray()` always returns the full contents of the buffer, regardless of `Position`, as documented in: https://learn.microsoft.com/en-us/dotnet/api/system.io.memorystream.toarray?view=net-7.0#system-io-memorystream-toarray	2023-09-18 11:50:36 +02:00
Bartłomiej Dach	5c2413c06b	Implement nano beatmap card	2023-09-18 11:30:14 +02:00
Bartłomiej Dach	59b9a636d3	Fix grammar in comment	2023-09-18 10:46:14 +02:00
Bartłomiej Dach	3709861132	Merge pull request #24814 from LukynkaCZE/parse-only-supported-char-uris ... Parse only supported schemes as URIs	2023-09-18 10:20:09 +02:00
Bartłomiej Dach	d3cc6dbaa0	Fix link protocol allowlist allowing too much	2023-09-18 09:20:24 +02:00
Joseph Madamba	c2685da94c	Fix dummy beatmap showing AR 5 on song select	2023-09-15 20:26:17 -07:00
Bartłomiej Dach	ebdc501e5b	Add example scenarios and configurable score multiplier	2023-09-15 12:58:29 +02:00
Bartłomiej Dach	0c22ff2a80	Refactor further to allow extensibility to other rulesets	2023-09-15 12:58:29 +02:00
Bartłomiej Dach	45751dd1f2	Minimum viable changes for ruleset-specific scoring test scenes	2023-09-15 12:58:29 +02:00
Bartłomiej Dach	a6fab28461	Merge branch 'master' into no-legacy-difficulty-control-point	2023-09-15 11:14:28 +02:00
Dean Herbert	56cc2b62f0	Make not extension method	2023-09-15 18:13:04 +09:00
Dean Herbert	0031da76ff	Move to extension method and throw on non-legacy ruleset	2023-09-15 17:38:34 +09:00
Bartłomiej Dach	9b391cd661	Merge branch 'master' into import-task-improve	2023-09-14 19:37:01 +02:00
Bartłomiej Dach	c8b18acd4d	Bring back disposal of stream after copy-out to MemoryStream ... Was there in previous code and got removed in the refactor. I'd rather have it than not.	2023-09-14 19:36:35 +02:00
Lukynka CZE	9b8fdcbcdc	somehow accidentally removed backslashes	2023-09-14 17:55:53 +02:00
Lukynka CZE	66751ef5bb	add regex	2023-09-14 17:46:29 +02:00
Bartłomiej Dach	6aff1d4063	Merge branch 'master' into mod-select-difficulty-multiplier-animation	2023-09-14 16:23:30 +02:00
Dean Herbert	57f32b177d	Fix incorrect handling of non-MemoryStream pathway	2023-09-14 22:19:18 +09:00
Bartłomiej Dach	94cdcfd7ce	Move collapsed bindable back to BeatmapAttributesDisplay for now ... Better to have it only in one place that needs it, rather than have it not work as expected when someone inherits `ModFooterInformationDisplay`.	2023-09-14 14:56:58 +02:00
Bartłomiej Dach	44461b4eff	Merge branch 'master' into mod-select-diff-multiplier-visual-matching	2023-09-14 12:12:23 +02:00
Bartłomiej Dach	3f7b8dbe58	Merge branch 'master' into move-mod-select-diff-multiplier	2023-09-14 11:26:22 +02:00
Bartłomiej Dach	25dbd0a1d3	Rename variable to reflect new "beatmap attributes display" naming	2023-09-14 11:24:53 +02:00
Bartłomiej Dach	2d3be819d0	Merge pull request #24796 from peppy/collapse-preset-column ... Collapse mod presets column slightly when not in use	2023-09-14 11:07:36 +02:00
Bartłomiej Dach	18672e178f	Merge pull request #24795 from peppy/fix-mod-rate-adjust-tooltip-x ... Fix rate adjust mods not showing "x" prefix on customisation slider's tooltip	2023-09-14 10:18:32 +02:00
Bartłomiej Dach	68323671ec	Update framework and resources	2023-09-14 08:24:18 +02:00
Dean Herbert	7bf0a22112	Improve flash effect	2023-09-14 13:57:56 +09:00
Dean Herbert	364094fcf2	Inline all archive reader pathing	2023-09-14 13:38:23 +09:00
Dean Herbert	541cd972e1	Rename ArchiveReader implementations to read better	2023-09-14 13:36:07 +09:00
Dean Herbert	0657b55196	Avoid MemoryStream.ToArray overhead in LegacyByteArrayReader	2023-09-14 13:33:25 +09:00
Dean Herbert	b5902a8736	Avoid MemoryStream overhead for incoming non-MemoryStream in ImportTask	2023-09-14 13:29:29 +09:00
Dan Balasescu	753c1c877c	Revert masking SSBO changes	2023-09-13 23:10:13 +09:00
Dean Herbert	32946413de	Change display text from "difficulty" to "score" multiplier	2023-09-13 20:01:19 +09:00
Dean Herbert	3e1388c73f	Add vertical animation when difficulty multiplier is changed	2023-09-13 19:57:48 +09:00
Dean Herbert	824a3e4adc	Update DifficultyMultiplierDisplay to use new shared design	2023-09-13 19:56:31 +09:00
Dean Herbert	46d5aa59bf	Split base design out of BeatmapAttributesDisplay	2023-09-13 19:33:30 +09:00
Dean Herbert	9a7d1ed98b	Tidy up DifficultyMultiplierDisplay	2023-09-13 18:55:17 +09:00
Dean Herbert	35840bf671	Combine ModCounterDisplay and DifficultyMultiplierDisplay into one class	2023-09-13 18:51:56 +09:00
Dean Herbert	491d94c5ac	Use local shear definition	2023-09-13 18:51:50 +09:00
Dean Herbert	41b0619533	Fix shear being included on wrong side of ModCounterDisplay	2023-09-13 18:19:42 +09:00
Dean Herbert	923c2a16ed	Fix weird centering of multiplier "x"	2023-09-13 18:11:16 +09:00
Dean Herbert	21252c1c23	Fix animations	2023-09-13 18:06:50 +09:00