38668 Commits

This Branch

This Branch

All Branches

• Merge pull request #11561 from Mysfit/fix-storyboard-samples

  Fix storyboard samples continuing to play when the beatmap is paused or intro is skipped

  Dean Herbert · 2021-02-01 17:48:08 +09:00
  328bd191d4
• Rename class to better match purpose
  Dean Herbert · 2021-02-01 17:32:54 +09:00
  1d8de2f718
• Add signalr messagepack key attribute
  Dean Herbert · 2021-02-01 17:27:14 +09:00
  fabb0eeb29
• Merge branch 'master' into multiplayer-beatmap-tracker
  Dean Herbert · 2021-02-01 17:24:24 +09:00
  c73a05d0b5
• Apply documentation changes

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Ahmed · 2021-02-01 11:02:08 +03:00
  49e62c3a4b
• Add more comprehensive commenting and simplify base call logic

  We can call the base method regardless for better safety. Worst case
  it's just going to run `Stop()` twice anyway.

  Dean Herbert · 2021-02-01 16:43:54 +09:00
  05982f42ab
• Merge pull request #11636 from bdach/fix-time-ramp-calculation

  Fix incorrect speed change calculation in time ramp mods

  Dean Herbert · 2021-02-01 16:32:44 +09:00
  25614c7923
• Merge pull request #11626 from peppy/fix-spinner-spm-negative

  Ensure spinners only handle input during their hittable time

  Dean Herbert · 2021-02-01 16:27:22 +09:00
  0dd1208579
• Once again disallow DT/etc as allowable mods
  smoogipoo · 2021-02-01 15:07:56 +09:00
  0909c73ead
• Fix allowed mods being copied into required mods
  smoogipoo · 2021-02-01 15:07:43 +09:00
  b43e529964
• Move common song select implementation for online play
  smoogipoo · 2021-02-01 14:57:39 +09:00
  426569c2a9
• Update mods when resuming room subscreen
  smoogipoo · 2021-02-01 13:58:44 +09:00
  b846146f16
• Add initial UI for selecting extra mods
  smoogipoo · 2021-02-01 13:40:59 +09:00
  4ae10b1e1c
• Disallow selecting DT/HT/WU/WD as allowable freemods
  smoogipoo · 2021-02-01 13:35:48 +09:00
  e02e3cf19a
• Allow unstacking mods
  smoogipoo · 2021-02-01 13:24:56 +09:00
  797a810287
• Move ModSelectOverlay.IsValidMod to a property
  smoogipoo · 2021-02-01 12:18:11 +09:00
  230b347c1e
• Improve robustness of chat auto-scrolling logic

  Fix auto-scrolling state changing by old messages removal logic

  Salman Ahmed · 2021-01-31 23:45:49 +03:00
  e806e5bcd1
• Add failing test case
  Salman Ahmed · 2021-01-31 23:44:51 +03:00
  39d46d21e6
• Handle no-duration single-object edge case
  Bartłomiej Dach · 2021-01-31 21:09:41 +01:00
  a0de1cbfd0
• Fix speed change calculation in time ramp mods
  Bartłomiej Dach · 2021-01-31 20:34:56 +01:00
  547b3d8bed
• Add failing test cases
  Bartłomiej Dach · 2021-01-31 20:34:22 +01:00
  81b052b866
• Merge pull request #11635 from bdach/storyboard-loop-type-decoding

  Fix invalid numeric values for storyboard animation type parsing incorrectly

  Dean Herbert · 2021-02-01 00:50:22 +09:00
  adc57dd94b
• Coerce undefined animation loop types to Forever
  Bartłomiej Dach · 2021-01-31 15:43:58 +01:00
  b9a49d5589
• Add failing test case
  Bartłomiej Dach · 2021-01-31 15:43:58 +01:00
  d7e5a21213
• Don't part room if join task was cancelled
  Bartłomiej Dach · 2021-01-30 23:39:01 +01:00
  90ba8ae234
• Move lease check inside schedule

  Theoretically safer due to avoiding a potential data race (change in
  `leasedInProgress` between the time of the check and start of schedule
  execution).

  Bartłomiej Dach · 2021-01-30 21:03:09 +01:00
  5f320cd426
• Return tracker lease via UnbindAll()

  Improves reliability by being fail-safe in case of multiple returns,
  which can happen if the operation tracker is part of a screen being
  exited (as is the case with its current primary usage in multiplayer).

  Bartłomiej Dach · 2021-01-30 21:00:13 +01:00
  96f56d1c94
• Add failing test case
  Bartłomiej Dach · 2021-01-30 20:55:56 +01:00
  0aaa62efc2
• Set canceled result in scheduleAsync

  Was holding up the task completion source, and in consequence,
  potentially the entire task chain.

  Bartłomiej Dach · 2021-01-30 16:13:50 +01:00
  c3ba92f057
• Merge branch 'master' into fix-leave-room-race-2
  Bartłomiej Dach · 2021-01-30 13:41:04 +01:00
  9ab1ad25eb
• Merge pull request #11500 from peppy/fix-skin-dropdown-update-crash
  Bartłomiej Dach · 2021-01-30 13:34:00 +01:00
  fec3bd898e
• Merge branch 'master' into fix-skin-dropdown-update-crash
  Bartłomiej Dach · 2021-01-30 13:01:52 +01:00
  6a1387191a
• Reset SPM counter state on DHO application
  Bartłomiej Dach · 2021-01-29 20:32:45 +01:00
  ae08ef2543
• Merge pull request #11625 from peppy/fix-beatmap-cache-lookup-null-failure

  Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present

  Bartłomiej Dach · 2021-01-29 18:58:00 +01:00
  44e88f09e5
• Don't directly update HandleUserInput (as it is used by mods)
  Dean Herbert · 2021-01-30 02:35:11 +09:00
  d521bfc251
• Fix unused using
  Dean Herbert · 2021-01-29 20:22:25 +09:00
  5a306dfc2b
• Ensure spinners only handle input during their hittable time

  While this was already being enforced inside of `CheckForResult`, the
  internal tracking values of rotation were still being incremented as
  long as the `DrawableSpinner` was present. This resulted in incorrect
  SPM values being displayed if a user was to start spinning before the
  object's `StartTime`.
  
  Kind of annoying to write a test for (there's no setup for spinners yet)
  but am willing to do so if that is deemed necessary.
  
  Closes https://github.com/ppy/osu/issues/11600.

  Dean Herbert · 2021-01-29 19:55:55 +09:00
  f25809d35f
• Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present

  It turns out the SQLite API isn't smart enough to handle nullables
  directly, so we need to help it out a bit.
  
  Stops the following from being thrown:
  
  ```
  System.InvalidOperationException: Value must be set.
     at Microsoft.Data.Sqlite.SqliteParameter.Bind(sqlite3_stmt stmt) = 3
  at
     at Microsoft.Data.Sqlite.SqliteParameterCollection.Bind(sqlite3_stmt
  stmt) = 3 at
     at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader(CommandBehavior
  behavior)
     at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader()
     at
  osu.Game.Beatmaps.BeatmapManager.BeatmapOnlineLookupQueue.checkLocalCache(BeatmapSetInfo
  set, BeatmapInfo beatmap) in
  /Users/dean/Projects/osu/osu.Game/Beatmaps/BeatmapManager_BeatmapOnlineLookupQueue.cs:line
  166 = 166
  ```

  Dean Herbert · 2021-01-29 19:53:57 +09:00
  16f3d1815f
• Merge pull request #11622 from peppy/remove-unobserved-exception-handling

  Remove all usage of CatchUnobservedExceptions

  Dan Balasescu · 2021-01-29 19:31:07 +09:00
  cd8ef5373d
• Merge pull request #11623 from Firmatorenio/apply-sv-to-taiko-diffadjust

  Add scroll speed adjustment to taiko's DifficultyAdjust mod

  Dean Herbert · 2021-01-29 19:25:17 +09:00
  d52376cc17
• Ensure the item is present before trying to select it
  Dean Herbert · 2021-01-29 19:17:12 +09:00
  18e6afbec0
• Merge branch 'master' into fix-skin-dropdown-update-crash
  Dean Herbert · 2021-01-29 19:16:20 +09:00
  1ce383fc20
• Pass allowed mods and consume on server callback
  smoogipoo · 2021-01-29 18:21:22 +09:00
  ab9a3e6dd0
• rename SliderVelocity to ScrollSpeed
  Firmatorenio · 2021-01-29 15:04:55 +06:00
  37ef5c7072
• Remove all usage of CatchUnobservedExceptions

  This should no longer be required with the recent framework side change
  that stops a game from crashing on unobserved exceptions
  (https://github.com/ppy/osu-framework/pull/4171).

  Dean Herbert · 2021-01-29 16:32:29 +09:00
  a61444690e
• Revert test changes to test original class/scope

  Importantly, this removes the call to CatchUnobservedExceptions(), which was
  outright incorrect (awaiting on the wrong task as a result) in the
  original test code.

  Dean Herbert · 2021-01-29 16:20:26 +09:00
  c3aec3bfe4
• Update TaskChain to use ContinueWithSequential internally

  It turns out we may still want to use TaskChain for its locking
  behaviour, so I've made it internally use the refactored version I
  implemented, while keeping the general structure.

  Dean Herbert · 2021-01-29 16:19:46 +09:00
  1ec305e10d
• add SV multiplier adjustment to TaikoModDifficultyAdjust
  Firmatorenio · 2021-01-29 11:48:51 +06:00
  449f883be1
• Merge pull request #11618 from vltspr/catch-auto-fix

  Fix Catch autoplay rewinding on instantaneous hits

  Dan Balasescu · 2021-01-29 12:17:46 +09:00
  4c4770bf4b
• Formatting
  Corentin PALLARD · 2021-01-29 03:03:23 +01:00
  d168de0ae3