38668 Commits

This Branch

This Branch

All Branches

• Implement dynamic previous hitobject retention for Skill class

  There is no reason we should be limiting skills to knowing only the previous 2 objects. This originally existed as an angle implementation detail of the original pp+ codebase which made its way here, but didn't get used in the same way.

  Samuel Cattini-Schultz · 2021-04-03 20:28:51 +11:00
  fe66b84bed
• Merge pull request #12254 from smoogipoo/spectator-refactor

  Move frame-handling spectator logic into abstract base class

  Dean Herbert · 2021-04-03 17:23:33 +09:00
  eb1e850f99
• Merge pull request #12271 from hbnrmx/filechooser-preselect-folder

  Open editor file selector in the directory of the previous selection

  Dean Herbert · 2021-04-03 14:31:19 +09:00
  dc3163ccf2
• Merge pull request #12276 from PercyDan54/beatmap-info-unicode

  Make beatmap listing use unicode title & artist name

  Dean Herbert · 2021-04-03 14:30:27 +09:00
  f0e656fb12
• Merge pull request #12275 from peppy/update-framework

  Update framework

  Dean Herbert · 2021-04-03 13:57:21 +09:00
  e94d9febb7
• Fix formatting
  PercyDan54 · 2021-04-03 12:45:42 +08:00
  dde255980b
• Make beatmap title use unicode
  PercyDan54 · 2021-04-03 12:43:17 +08:00
  bd7da9eb39
• Update framework
  Dean Herbert · 2021-04-03 13:01:08 +09:00
  0dce4b8894
• Merge branch 'master' into spectator-refactor
  Dean Herbert · 2021-04-03 12:55:11 +09:00
  67f0c0ceb9
• reopen FileSelector in the directory of the previous selection
  hbnrmx · 2021-04-02 18:01:26 +02:00
  824fb9f398
• move fallback text to PlaceholderText
  hbnrmx · 2021-04-02 17:57:21 +02:00
  438f3e6349
• Fix code style
  PercyDan54 · 2021-04-02 21:15:28 +08:00
  a5a19319cc
• Merge pull request #11849 from Syriiin/diffcalc/fix/clockrate-adjusted-decay

  Fix clockrate adjusted difficulty calculations bug in strain decay

  Dan Balasescu · 2021-04-02 21:41:58 +09:00
  0c35128ead
• Schedule spectator callbacks
  smoogipoo · 2021-04-02 21:27:20 +09:00
  cd53074941
• Use OnlineViewContainer
  PercyDan54 · 2021-04-02 20:14:31 +08:00
  1ff77754fd
• Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay
  Dan Balasescu · 2021-04-02 20:58:29 +09:00
  345779b19a
• Add comment explaining use of lock
  smoogipoo · 2021-04-02 20:31:34 +09:00
  d2950105fb
• Merge pull request #12265 from amberkowalski/classic-slidertail

  Add classic mod setting to always play slider tail samples

  Dan Balasescu · 2021-04-02 19:45:21 +09:00
  dac8e5fdf4
• Merge pull request #12259 from frenzibyte/fix-ruleset-file-loading

  Guard against same ruleset file with filenames of loaded assembly location instead

  Dan Balasescu · 2021-04-02 19:21:33 +09:00
  143b8c422c
• Reword xmldoc slightly
  smoogipoo · 2021-04-02 18:00:28 +09:00
  9c3d15171c
• Switch AlwaysPlaySample to SamplePlaysOnlyOnHit in DrawableSliderTail for conformity
  Amber · 2021-04-02 03:56:23 -05:00
  5ac36a2462
• Make "AlwaysPlayTailSample" a mod setting rather than a hardcoded constant.
  Amber · 2021-04-02 03:10:28 -05:00
  48e9985782
• Rename event parameter for clarity
  Dean Herbert · 2021-04-02 16:56:47 +09:00
  45d16fb916
• Force hit sample to play when Classic mod is enabled
  Amber · 2021-04-02 02:54:35 -05:00
  5063cd957f
• Merge pull request #12262 from smoogipoo/add-score-export

  Add dropdown option to export score

  Dean Herbert · 2021-04-02 15:28:53 +09:00
  c564f6b8ec
• Fix exported replay filenames not having full metadata
  Dean Herbert · 2021-04-02 14:10:25 +09:00
  6d4d574a65
• Add dropdown option to export score
  smoogipoo · 2021-04-02 13:20:15 +09:00
  e1aa927827
• Remove unused using directive
  Salman Ahmed · 2021-04-02 02:45:26 +03:00
  5b1dc7d2b4
• Guard against same ruleset file with loaded assembly filenames instead
  Salman Ahmed · 2021-04-02 02:12:25 +03:00
  fcd56dba44
• Merge pull request #12255 from ppy/dependabot/nuget/Microsoft.NET.Test.Sdk-16.9.4

  Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4

  Dean Herbert · 2021-04-02 04:11:14 +09:00
  133c529b2d
• Add margin to large segment test

  Test ran fine on my end, but apparently not on the CI. This should make results a bit more consistent, hopefully.

  Naxess · 2021-04-01 20:34:04 +02:00
  8621a6b4fe
• Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4

  Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.9.1 to 16.9.4.
  - [Release notes](https://github.com/microsoft/vstest/releases)
  - [Commits](https://github.com/microsoft/vstest/compare/v16.9.1...v16.9.4)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2021-04-01 17:16:02 +00:00
  6a286c5e21
• Remove unused blueprint variable
  Naxess · 2021-04-01 18:06:12 +02:00
  b8479a979f
• Merge branch 'master' into circular-arc-freeze
  Naxess · 2021-04-01 17:09:45 +02:00
  7e47922fb7
• Fix tests
  smoogipoo · 2021-04-01 23:48:26 +09:00
  c3c7c18549
• Make SoloSpectator use the new SpectatorScreen class
  smoogipoo · 2021-04-01 22:10:17 +09:00
  9bc2a486e0
• Rename Spectator -> SoloSpectator
  smoogipoo · 2021-04-01 22:08:52 +09:00
  9e95441aa6
• Add abstract spectator screen class
  smoogipoo · 2021-04-01 22:02:32 +09:00
  af478fb2eb
• Fix broken test case

  Seems this technically works, but only because of the edge case of being entirely linear, which the framework catches.
  
  This fixes that.

  Naxess · 2021-03-31 20:48:17 +02:00
  25afae5671
• Undo public -> internal for PathControlPoint.Changed

  No longer used.

  Naxess · 2021-03-31 20:32:49 +02:00
  7b684339ed
• Check current point instead of start point

  Since each control point will call this when the path updates, the previous would correct the start segment 3 times instead of just once.
  
  This fixes that.

  Naxess · 2021-03-31 20:25:46 +02:00
  5022a78e80
• Move updatePathTypes to PathControlPointPiece

  Here we produce a local bound copy of the path version, and bind it to update the path type.
  
  This way, if the path version updates (i.e. any control point changes type or position), we check that all control points have a well-defined path.
  
  Additionally, if the control point piece is disposed of, the GB should also swoop up the subscription because of the local bound copy.

  Naxess · 2021-03-31 20:09:56 +02:00
  75b8f2535f
• Update/remove determinant tests

  We now only change the path type based on the bounding box.
  
  If the control points are too linear, the framework now handles the fallback to Bezier.

  Naxess · 2021-03-31 20:08:39 +02:00
  1718084dbc
• Merge pull request #12220 from peppy/editor-fix-speed-multiplier-precision

  Fix legacy control point precision having an adverse effect on the editor

  Dan Balasescu · 2021-03-31 18:00:11 +09:00
  f6f1ef6986
• Merge branch 'master' into editor-fix-speed-multiplier-precision
  Dan Balasescu · 2021-03-31 17:17:25 +09:00
  f8c1dfe57f
• Merge pull request #12238 from peppy/fix-mass-drag-drop-imports

  Group large drag drop imports into a single operation

  Dan Balasescu · 2021-03-31 16:15:26 +09:00
  ef1f133fb1
• Merge pull request #12235 from smoogipoo/fix-never-ending-mania

  Fix mania beatmaps sometimes never ending

  Dean Herbert · 2021-03-31 15:48:05 +09:00
  f46fae9ec6
• Merge pull request #12237 from peppy/fix-retry-count

  Fix retry count not updating correctly

  Dean Herbert · 2021-03-31 14:59:12 +09:00
  ffc28256d0
• Group large drag drop imports into a single operation
  Dean Herbert · 2021-03-31 14:57:28 +09:00
  30cae46cbd
• Fix wrong counting and add test
  Dean Herbert · 2021-03-31 14:09:39 +09:00
  0c53b4eb93