2642 Commits

• Schedule control point switch for settings modifications to apply first
  Salman Ahmed · 2024-01-17 08:15:01 +03:00
  46429c5074
• Fix crash when dragging rotation control in editor with both mouse buttons

  Closes https://github.com/ppy/osu/issues/26325.

  Dean Herbert · 2024-01-03 13:34:50 +09:00
  bdfaa4b583
• change floor to round
  iminlikewithyou · 2023-12-30 23:59:47 -06:00
  5ae5d7f92d
• Use alternative workaround
  Bartłomiej Dach · 2023-12-29 11:07:45 +01:00
  99cddb6317
• Fix crash after changing audio track in editor

  Closes https://github.com/ppy/osu/issues/26213.
  
  Reproduction scenario: switch audio track in editor after timeline
  loads.
  
  Happens because `beatmap.Value.Track.Length` is 0 immediately after a
  track switch, until BASS computes the actual track length on the audio
  thread.
  
  Yes this is a hack. No I have no better immediate ideas how to address
  this otherwise.

  Bartłomiej Dach · 2023-12-29 10:37:36 +01:00
  cd1f6b46c4
• Remove remaining hexacons usages
  Bartłomiej Dach · 2023-12-27 17:42:18 +01:00
  53766285ce
• Use new icons in editor

  Some that exist on figma are purposefully not used due to an editorial
  request from @peppy.

  Bartłomiej Dach · 2023-12-27 17:42:18 +01:00
  288ac930e4
• Add test coverage and refactor to better handle equality edge case
  Dean Herbert · 2023-12-26 21:21:08 +09:00
  03e2463b06
• Fix selection not being retained in control point list when undoing / redoing
  Dean Herbert · 2023-12-26 21:04:42 +09:00
  1f2f749db6
• Fix editor's control point list refreshing multiple times for a single change
  Dean Herbert · 2023-12-26 21:04:42 +09:00
  f2c0e7cf2e
• Add visual offset to better align editor waveforms with expectations
  Dean Herbert · 2023-12-26 17:44:49 +09:00
  f9e47242db
• fix crash from dragging near zero-length repeating object in timeline
  OliBomby · 2023-12-19 21:20:45 +01:00
  c167f10ad5
• Apply Bindable.Parse refactorings
  Dean Herbert · 2023-12-13 14:07:38 +09:00
  0be6743e87
• Change default slider velocity to 1.4

  This is the default in osu!stable and plays better than 1.0.

  Dean Herbert · 2023-12-06 13:38:46 +09:00
  0af16732b8
• Changed file chooser in resource selection to show file name when file is selected
  Guido · 2023-12-04 22:51:56 +01:00
  8756dd25c6
• Replace all hexacon lookups with strongly typed properties
  Dean Herbert · 2023-11-24 13:17:39 +09:00
  340227a06d
• Merge pull request #25520 from peppy/context-menu-spacers

  Allow context menus to have visible spacers

  Dean Herbert · 2023-11-21 16:56:36 +09:00
  21bf288277
• Merge pull request #25371 from RatinFX/open-editor-timestamp

  Implement opening editor timestamp links

  Bartłomiej Dach · 2023-11-21 15:48:36 +09:00
  d83b2e24e7
• Use SimpleErrorNotification for error display
  Dean Herbert · 2023-11-21 15:10:41 +09:00
  7c5345bf7e
• Adjust localisablel strings and keys
  Dean Herbert · 2023-11-21 15:08:15 +09:00
  917a68eac3
• Allow context menus to have visible spacers
  Dean Herbert · 2023-11-21 14:24:10 +09:00
  405ab499e9
• Rename and document SelectFromTimestamp
  Bartłomiej Dach · 2023-11-20 21:57:14 +09:00
  b6215b2809
• Rectify selection keep-alive logic
  Bartłomiej Dach · 2023-11-20 21:57:14 +09:00
  234ef6f923
• Remove unnecessary guard

  Setting a bindable's value to something if that value is already there
  is a no-op (doesn't trigger bindings / callbacks).

  Bartłomiej Dach · 2023-11-20 21:57:14 +09:00
  246aacb216
• Simplify parsing code

  Less methods, less smeared around logic, saner data types.

  Bartłomiej Dach · 2023-11-20 21:57:12 +09:00
  0e0ab66148
• Refactor HitObject selection in Composer
  ratinfx · 2023-11-11 14:02:42 +01:00
  4e1e19728c
• Rename diagonal scale variable and update xmldoc
  Dean Herbert · 2023-11-10 17:55:02 +09:00
  35e11c7c63
• Change selection handling to adjust Size instead of Scale for edge nodes
  Dean Herbert · 2023-11-10 14:22:28 +09:00
  ec3b6e47fb
• Forgot a clock.Stop call
  ratinfx · 2023-11-07 12:23:22 +01:00
  544d5d1d86
• Renamed CollectionChanged event handler
  ratinfx · 2023-11-07 11:11:32 +01:00
  bdbeb2bce4
• HitObject Selection logic and separation for gamemodes

  + moved time_regex into EditorTimestampParser

  ratinfx · 2023-11-07 01:36:58 +01:00
  aa87e0a44d
• Renamed method and made private
  ratinfx · 2023-11-07 01:02:45 +01:00
  44f127c8a8
• Renamed method and moved Notifications inside
  ratinfx · 2023-11-07 00:56:24 +01:00
  0834b79cc7
• Display "required save" popup when creating another difficulty on a new beatmap
  Salman Ahmed · 2023-11-06 21:54:40 +03:00
  b2749943e2
• Automatically refresh the verify screen's issue list on re-entering it

  Addresses https://github.com/ppy/osu/discussions/25365.

  Dean Herbert · 2023-11-06 19:34:36 +09:00
  51c891e2e4
• Ensure every SelectedItem is alive and has Blueprint
  ratinfx · 2023-11-05 18:26:51 +01:00
  277cf7dc12
• Moved error checks into Editor

  - Invoke Action on error to Notify user
  - added some comments

  ratinfx · 2023-11-04 21:17:58 +01:00
  7492d953ae
• Renamed Editor method
  ratinfx · 2023-11-04 03:30:38 +01:00
  60f62faec3
• Added OpenEditorTimestamp base implementation
  ratinfx · 2023-11-04 02:01:18 +01:00
  43ab7f4942
• Merge pull request #25316 from peppy/metronome-always-play-tick

  Decouple metronome tick playback from pendulum movement

  Bartłomiej Dach · 2023-10-31 09:37:29 +01:00
  850866e7f4
• Update autoselect implementation to work correctly with framework changes
  Bartłomiej Dach · 2023-10-31 08:38:22 +01:00
  144006fbe8
• Merge branch 'master' into beat-divisor-select-text-on-click
  Bartłomiej Dach · 2023-10-31 08:36:53 +01:00
  8a68333425
• Decouple metronome tick playback from pendulum movement

  Not super happy about doing this, but it seems like it's in the best
  interest of editor usability.

  Dean Herbert · 2023-10-31 15:33:46 +09:00
  64efc3d251
• Merge pull request #25307 from bdach/slider-velocity-undo

  Fix slider velocity changes not being undone correctly

  Dean Herbert · 2023-10-31 01:44:18 +09:00
  f706fd2fca
• Privatise setters
  Bartłomiej Dach · 2023-10-30 12:42:34 +01:00
  cea24298cb
• Fix slider velocity changes not being undone correctly

  Closes https://github.com/ppy/osu/issues/25239.
  
  `LegacyEditorBeatmapPatcher.processHitObjectLocalData()` was already
  supposed to be handling changes to hitobjects that will show up neither
  when comparing the hitobjects themselves or the timing point with
  "legacy" info stripped - so, in other words, changes to slider velocity
  and samples.
  
  However, a change to slider velocity requires default application to
  take effect, so just resetting the value would visually fix the timeline
  marker but not change the actual object. Calling
  `EditorBeatmap.Update()` fixes this by way of triggering default
  re-application.
  
  This could probably be smarter (by only invoking the update when
  strictly necessary, etc.) - but I'm not sure it's worth the hassle. This
  is intended to be a quick fix, rather than a complete solution - the
  complete solution would indeed likely entail a wholesale restructuring
  of the editor's change handling.

  Bartłomiej Dach · 2023-10-30 10:59:02 +01:00
  de89b7e53c
• Fix failing tests
  Dean Herbert · 2023-10-30 18:06:11 +09:00
  63e6eaf538
• Fix right clicks on timeline objects potentially getting eaten by playfield area

  `SelectionHandler` is receiving input from anywhere out of necessity:
  
  https://github.com/ppy/osu/blob/19f892687a0607afbe4e0d010366dc2a66236073/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs#L119-L125
  
  Also important is that `BlueprintContainer` will selectively not block
  right clicks to make sure they fall through to the
  `ContextMenuContainer`:
  
  https://github.com/ppy/osu/blob/19f892687a0607afbe4e0d010366dc2a66236073/osu.Game/Screens/Edit/Compose/Components/BlueprintContainer.cs#L122-L126
  
  But because the whole editor is sharing a `ContextMenuContainer` and
  it's at a higher level than both components, we observe here the
  playfield's `SelectionHandler` intercepting the right click before it
  can reach the `ContextMenuContainer`.
  
  The fix here is similar to what we're already doing in
  `TimelineBlueprintContaienr`.

  Dean Herbert · 2023-10-30 18:06:11 +09:00
  57d88a0ac4
• Fix editor not prompting before saving beatmap for export
  Dean Herbert · 2023-10-25 14:39:46 +09:00
  6934e045df
• Disallow setting sample volume lower than 5% in editor
  Bartłomiej Dach · 2023-10-20 15:50:21 +02:00
  12282fff5c