1
0
mirror of https://github.com/ppy/osu.git synced 2025-02-21 13:42:55 +08:00
Commit Graph

71717 Commits

Author SHA1 Message Date
Dean Herbert
37db539226
Merge pull request #31805 from bdach/bss/the-actual-submission
Add initial beatmap submission support
2025-02-13 17:32:09 +09:00
Bartłomiej Dach
9adf80bbfd
Merge pull request #31868 from smoogipoo/fix-intermittent-test
Attempt to fix intermittent collections test
2025-02-13 08:53:03 +01:00
Bartłomiej Dach
de9362dae5
Merge branch 'master' into bss/the-actual-submission 2025-02-13 08:45:23 +01:00
Dan Balasescu
c13bc8beca
Merge pull request #31864 from peppy/fix-follow-circle-rewind-display
Fix weird follow circle display when rewinding through sliders in editor
2025-02-13 15:04:18 +09:00
Dean Herbert
ecc12abe02
Merge pull request #31850 from smoogipoo/freestyle-mods
Allow user mods in multiplayer freestyle
2025-02-13 02:25:37 +09:00
Dan Balasescu
7d6701f8e9
Attempt to fix intermittent collections test 2025-02-13 01:23:40 +09:00
Dean Herbert
550d21df42
Fix failing tests due to text change 2025-02-13 00:21:08 +09:00
Dean Herbert
7490bca17f
Merge pull request #31746 from mcendu/taiko-legacy-spinner
Add legacy taiko swell (spinner)
2025-02-12 23:06:17 +09:00
Bartłomiej Dach
ee6dcbd808
Fix android build again
Another month, another freak android build failure.

From what I can tell, this time the build is broken because the second-
-to-last workaround applied to fix it, namely explicitly specifying
the version of workloads to install, stopped working, presumably because
github pushed a new .NET SDK version to runners, and microsoft didn't
actually put up a set of workload packages whose version matches the
.NET SDK version 1:1.

Thankfully, the fix to the *last* android build breakage (which caused
the workload installation to completely and irrecoverably fail), appears
to be rolling out this week, and *also* fix that same second-last issue,
so both workarounds of specifying the workload version and pinning the
image to `windows-2019` appear to no longer be required.

Note that the newest image version, 20250209.1.0, is still not fully
rolled out yet, thus rather than just fix all builds, this will fix like
20% of builds until the newest image is fully rolled out. But I guess
a 20% passing build is better than a 0% passing build, in a sense...?
2025-02-12 14:18:03 +01:00
Bartłomiej Dach
d87a775e71
Fix clear sample potentially playing multiple times simultaneously 2025-02-12 13:25:46 +01:00
Bartłomiej Dach
e385848edc
Add missing animation of warning sprite 2025-02-12 13:25:46 +01:00
Bartłomiej Dach
0ac08158e3
Fix transforms from swell progress being cleared on completion by not using transforms 2025-02-12 13:25:42 +01:00
Bartłomiej Dach
96db6964df
Adjust things further 2025-02-12 13:20:04 +01:00
Dean Herbert
c049ae6937
Update height specification for playlist screen too 2025-02-12 18:45:00 +09:00
Dean Herbert
bc94ffe21e
Merge branch 'master' into freestyle-mods 2025-02-12 18:32:01 +09:00
Dean Herbert
218151bb3c
Flash footer freemod/freestyle buttons when active 2025-02-12 18:30:34 +09:00
Dean Herbert
9c3e9e7c55
Change free mods button to show "all" when freestyle is enabled 2025-02-12 18:27:10 +09:00
Dean Herbert
9aef95c381
Adjust some paddings and text
Mostly trying to give more space to the queue as we add more vertical
elements to the middle area of multiplayer / playerlists. This whole UI
will likely change – this is just a stop-gap fix.
2025-02-12 17:43:49 +09:00
Dean Herbert
b92e9f515b
Fix layout of user setting areas when aspect ratio is vertically tall 2025-02-12 17:31:55 +09:00
Dean Herbert
84b5ea3dbf
Fix weird follow circle display when rewinding through sliders in editor
Closes https://github.com/ppy/osu/issues/31812.
2025-02-12 16:33:23 +09:00
Dean Herbert
f97708e6b3
Avoid binding directly to DHO's bindable 2025-02-12 16:28:14 +09:00
Dean Herbert
ffd8bd7bf4
Rename ParentObject to DrawableObject
It's not a parent. The follow circle is directly part of the slider
itself.
2025-02-12 16:14:12 +09:00
Dan Balasescu
0612c0af9d
Merge pull request #31861 from minetoblend/chore/globalaction-enum-comment
Add comment warning about enum entry order in `GlobalAction`
2025-02-12 10:52:08 +09:00
Marvin Schürz
a8f07ae7b1 Add comment warning about enum entry order in GlobalAction 2025-02-11 18:04:23 +01:00
Bartłomiej Dach
46e8187d48
Merge pull request #22932 from peppy/collection-counts
Show count of beatmaps in collections in manage dialog
2025-02-11 15:43:22 +01:00
Bartłomiej Dach
231988bc9d
Adjust things to be closer to stable (but not close enough yet) 2025-02-11 15:29:53 +01:00
Dean Herbert
1203c85d30
Merge pull request #31682 from frenzibyte/mania-fix-judgements-on-scroll-up
Fix osu!mania judgement position not shifted on flipped scroll direction
2025-02-11 22:13:09 +09:00
Bartłomiej Dach
be035538c2
Fix remaining hit counter scaling in the incorrect direction 2025-02-11 14:01:32 +01:00
Dan Balasescu
693ef8f538
Merge pull request #31846 from bdach/fix-missing-rank-on-results
Fix score position not being displayed in solo results screen
2025-02-11 21:55:35 +09:00
Dean Herbert
b9c4e23595
Fix potential bad realm access to collection name 2025-02-11 20:05:48 +09:00
Bartłomiej Dach
58d040112b
Merge pull request #31854 from peppy/editor-test-button-scale-disable
Disable scale animation when holding editor "test" button
2025-02-11 09:58:07 +01:00
Bartłomiej Dach
d8b3c28c2e
Use more neutral terminology to avoid contentious 'beatmap' term 2025-02-11 09:17:11 +01:00
Dean Herbert
b9ed217308
Add basic brighten animation instead 2025-02-11 17:13:34 +09:00
Bartłomiej Dach
884fa20b28
Remove completely unnecessary subscriptions per collection 2025-02-11 09:13:08 +01:00
Dean Herbert
1fa8d53232
Disable scale animation when holding editor "test" button 2025-02-11 17:11:20 +09:00
Dean Herbert
9bb108311f
Merge pull request #31848 from bdach/open-beatmap-in-browser-from-editor
Add menu items to open beatmap info & discussion pages in browser from editor
2025-02-11 16:55:02 +09:00
Bartłomiej Dach
18965fe0a2
Merge branch 'master' into collection-counts 2025-02-11 08:54:24 +01:00
Bartłomiej Dach
7db0a6f817
Update xmldoc 2025-02-11 16:14:47 +09:00
Bartłomiej Dach
daf0130b23
Reword copy to be less verbose 2025-02-11 08:06:12 +01:00
Dan Balasescu
e51c09ec3d
Fix inspection
Interestingly, this is not a compiler error nor does R# warn about it.
No problem, because this is just restoring the original code anyway.
2025-02-11 14:23:51 +09:00
Dan Balasescu
748c2eb390
Refactor RoomSubScreen update 2025-02-11 12:43:54 +09:00
Dan Balasescu
78e5e0eddd
Refactor with a bit more null safety
In particular I don't like the non-null assert around
`GetCurrentItem()`, because there's no reason why it _couldn't_ be
`null`.
Consider, for example, if these panels are used in matchmaking where
there are no items initially present in the playlist.

The ruleset nullability part is debatable, but I've chosen to restore
the original code here.
2025-02-11 12:20:09 +09:00
Dean Herbert
8dc616738c
Merge pull request #31844 from bdach/fix-mp-players-appearing-as-spectators
Fix spectator list showing other users in multiplayer room even if they're not spectating
2025-02-10 21:49:06 +09:00
Dean Herbert
310700b4e7
Space out comment 2025-02-10 21:48:27 +09:00
Bartłomiej Dach
38e2f793ca
Add menu items to open beatmap info & discussion pages in browser from editor 2025-02-10 12:47:38 +01:00
Dean Herbert
6ff1a13b67
Merge pull request #31845 from frenzibyte/ios-threading-woes
Fix incorrect thread access in recent iOS orientation changes
2025-02-10 20:45:19 +09:00
Bartłomiej Dach
288851c606
Fix score position not being displayed in solo results screen
Closes https://github.com/ppy/osu/issues/31842.

To be honest, I recall this working too, but I don't recall when it
might have broken, nor do I want to go look for the point of breakage
because it might be borderline impossible to find it now. So I'm just
fixing as if it was just a straight omission.

Opting for a client-side fix because server-side inclusion of the score
position for an entire leaderboard has been previously rejected as too
expensive:

	https://github.com/ppy/osu-web/pull/11354#discussion_r1689217450
2025-02-10 12:17:52 +01:00
Salman Alshamrani
4b8890ef0c Fix incorrect thread access in recent iOS orientation changes 2025-02-10 05:55:21 -05:00
Bartłomiej Dach
ad642b8425
Fix spectator list showing other users in multiplayer room even if they're not spectating 2025-02-10 11:17:17 +01:00
Bartłomiej Dach
3ba56e009e
Privatise a few members 2025-02-10 10:41:10 +01:00