68286 Commits

This Branch

This Branch

All Branches

• Update collection state when users add/remove from collection
  Layendan · 2024-07-30 15:22:41 -07:00
  36bd83bb80
• Remove unnecessary depth and padding set
  Joseph Madamba · 2024-07-27 19:13:11 -07:00
  bc25e5d706
• Merge remote-tracking branch 'upstream/master' into pr/28991
  Joseph Madamba · 2024-07-27 19:09:02 -07:00
  850bcaef7a
• Remove direct margin set in popover that was causing positioning offset
  Joseph Madamba · 2024-07-27 19:02:57 -07:00
  334f5fda2d
• Remove unnecessary ReceivePositionalInputAt

  Results is not even using the new footer.

  Joseph Madamba · 2024-07-27 19:02:43 -07:00
  04b15d0d38
• Use same size button for everything
  Joseph Madamba · 2024-07-27 18:43:54 -07:00
  b4ca07300a
• Move some properties/bindables around
  Joseph Madamba · 2024-07-27 18:42:49 -07:00
  b5ff2dab43
• Inherit GrayButton instead

  Also fixes hover highlight.

  Joseph Madamba · 2024-07-27 18:42:49 -07:00
  aed2b3c7c6
• Merge pull request #29097 from bdach/dont-exit-to-menu-when-presenting-score-in-online

  Don't force exit to main menu when presenting scores from within online screens

  Dean Herbert · 2024-07-27 02:46:58 +09:00
  2024.727.0 565107205c
• Merge pull request #29115 from peppy/fix-download-tooltip-text

  Fix "Beatmap not downloaded" tooltip hint not showing in online play

  Dean Herbert · 2024-07-27 02:46:22 +09:00
  f2a38056b1
• Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge
  Dean Herbert · 2024-07-27 02:06:56 +09:00
  9323f89357
• Merge pull request #29112 from peppy/adjust-event-feed

  Adjust weight and text in event feed output

  Bartłomiej Dach · 2024-07-26 17:01:13 +02:00
  834ad3524a
• Reduce number spacing a bit more
  Dean Herbert · 2024-07-26 23:21:44 +09:00
  0421e1e9d0
• Adjust weight and text in event feed output

  Just some minor adjustments.

  Dean Herbert · 2024-07-26 23:20:32 +09:00
  96049807c4
• Merge pull request #29108 from bdach/daily-challenge/better-breakdown

  Improve score breakdown on daily challenge

  Dean Herbert · 2024-07-26 23:12:04 +09:00
  4fa6a19409
• Merge pull request #29101 from bdach/daily-challenge/fix-preview-track

  Fix preview tracks not stopping playback when suspending/exiting daily challenge screen

  Dean Herbert · 2024-07-26 21:52:26 +09:00
  47eca0eb37
• Merge pull request #29104 from bdach/daily-challenge/fix-no-audio-adjustments

  Fix daily challenge screen not applying track adjustments from mods

  Dean Herbert · 2024-07-26 21:51:58 +09:00
  6f7d05d5a0
• Fix code quality
  Bartłomiej Dach · 2024-07-26 14:45:39 +02:00
  0996f9b0b5
• Merge pull request #29099 from bdach/daily-challenge/totals-display

  Implement component for displaying running totals in daily challenge

  Dean Herbert · 2024-07-26 21:44:58 +09:00
  2024.726.1 1607075e0c
• Adjust easings and reduce character spacing slightly
  Dean Herbert · 2024-07-26 21:43:23 +09:00
  a870722ea6
• Highlight where local user's best is on the breakdown
  Bartłomiej Dach · 2024-07-26 14:32:01 +02:00
  fc0ade2c61
• Add tooltip with counts to daily challenge score breakdown chart
  Bartłomiej Dach · 2024-07-26 13:47:41 +02:00
  2caaebb670
• Rename new property to match true usage (per item)

  Also document a bit more.

  Dean Herbert · 2024-07-26 20:45:13 +09:00
  19affa7062
• Hook up score totals display to daily challenge screen
  Bartłomiej Dach · 2024-07-26 12:34:23 +02:00
  2e37f3b5de
• Add required pieces to MultiplayerPlaylistItemStats for total score tracking
  Dean Herbert · 2024-07-26 19:04:04 +09:00
  1ad0b31217
• Fix daily challenge screen not applying track adjustments from mods

  Closes https://github.com/ppy/osu/issues/29093.

  Bartłomiej Dach · 2024-07-26 11:50:43 +02:00
  1abcf16231
• Merge pull request #29100 from cbrwn/daily-mods-stats

  Fix statistics wedge not showing correct values in daily challenge

  Bartłomiej Dach · 2024-07-26 11:43:19 +02:00
  2b083bff29
• Fix preview tracks not stopping playback when suspending/exiting daily challenge screen

  Closes https://github.com/ppy/osu/issues/29083.

  Bartłomiej Dach · 2024-07-26 10:53:12 +02:00
  f9cfc7d96c
• Bind the mod select overlay's Beatmap to OsuScreen.Beatmap in constructor

  Suggested by @bdach!

  Cameron Brown · 2024-07-26 18:29:50 +10:00
  17f00ec0a6
• Update the beatmap of Daily Challenge's mods overlay when beatmap is set - #29094
  Cameron Brown · 2024-07-26 18:10:11 +10:00
  a8851950bc
• Implement component for displaying running totals in daily challenge

  Total pass count and cumulative total score, to be more precise.

  Bartłomiej Dach · 2024-07-26 09:51:39 +02:00
  174dc91f4b
• Merge pull request #29055 from peppy/event-feed-improvements

  Improve daily challenge event feed

  Bartłomiej Dach · 2024-07-26 08:37:47 +02:00
  e489ae8f72
• Don't force exit to main menu when presenting scores from within online screens

  Struck me as weird when reviewing https://github.com/ppy/osu/pull/29057.
  Like sure, that PR adds the replay button, but it's a bit terrible that
  clicking the button quits the daily challenge screen and you're back at
  main menu when done watching...?
  
  Also extended to cover playlists and multiplayer, which have the same
  issue.

  Bartłomiej Dach · 2024-07-26 08:17:39 +02:00
  662e9eab8c
• Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button

  Fix daily challenge not showing a replay button in results screen

  Bartłomiej Dach · 2024-07-26 08:03:17 +02:00
  09a1fd2cd1
• Adjust alpha for rows for better visibility
  Bartłomiej Dach · 2024-07-26 07:44:02 +02:00
  c17cabd981
• Reset download state when score is changed
  Salman Ahmed · 2024-07-26 05:11:54 +03:00
  c558dfdf13
• Add test case against resetting score in download button
  Salman Ahmed · 2024-07-26 05:08:13 +03:00
  3e8917cadb
• Merge pull request #29068 from bdach/results-statistics-toggle-crash

  Fix crash when toggling extended statistics visibility during results load

  Dean Herbert · 2024-07-25 22:49:41 +09:00
  2024.726.0 c90e04092a
• Merge pull request #29067 from bdach/report-daily-challenge

  Fix not being able to send chat reports on daily challenge screen

  Dean Herbert · 2024-07-25 22:33:41 +09:00
  6cc3e8aab8
• Merge pull request #29070 from Cai1Hsu/cursor-trail-disconnect

  Fix cursor trail disconnect from cursor when settings or notification overlay is opened

  Dean Herbert · 2024-07-25 22:32:09 +09:00
  12f237abca
• Merge pull request #29071 from bdach/wow-this-is-really-missing-question-mark

  Fix several missing properties on `MultiplayerScore`

  Dean Herbert · 2024-07-25 21:26:40 +09:00
  75e9f97633
• Fix several missing properties on MultiplayerScore

  You wouldn't think this would be an actual thing that can happen to us,
  but it is. The most important one by far is `MaximumStatistics`; that
  is the root cause behind why stuff like spinner ticks or slider tails
  wasn't showing.
  
  On a better day we should probably do cleanup to unify these models
  better, but today is not that day.

  Bartłomiej Dach · 2024-07-25 13:15:45 +02:00
  3bb30d7ff9
• Fix cursor trail alignment issue with UI panels

  - Convert cursor trail coordinates to local space before storing.
  - Apply necessary transformations to align with other UI elements.
  - Ensure cursor trail remains connected during UI panel movements.

  Caiyi Shyu · 2024-07-25 18:23:01 +08:00
  e564b1dc9e
• Fix crash when toggling extended statistics visibility during results load

  Closes https://github.com/ppy/osu/issues/29066.
  
  Initially I fixed this at where the assert is right now:
  
  	https://github.com/ppy/osu/blob/9790c5a574b782c41c8c6da99ad8c42dfadc9de8/osu.Game/Screens/Ranking/ResultsScreen.cs#L333
  
  but because of the weird way that visible state management is done in
  this screen that made it possible for the extended statistics to be
  visible *behind* the score panels, without the score panels making way
  for it. So this is in a way safer, because it prevents the visibility
  state of the extended statistics from changing in the first place if
  there is no score selected (yet).
  
  This can be also seen in playlists, at least.

  Bartłomiej Dach · 2024-07-25 11:45:17 +02:00
  8dbd4d70ff
• Fix not being able to send chat reports on daily challenge screen

  Something something some people cannot be trusted with a textbox.

  Bartłomiej Dach · 2024-07-25 11:11:54 +02:00
  8d89557ab8
• Merge pull request #29058 from frenzibyte/daily-challenge-fix-score-selection

  Fix daily challenge abruptly discarding score selection when opening results screen

  Bartłomiej Dach · 2024-07-25 10:46:32 +02:00
  9790c5a574
• Fix target score selection abruptly discarded after opening results screen
  Salman Ahmed · 2024-07-25 09:01:43 +03:00
  9d5fbb8b4f
• Revert "Add failing test case"

  This reverts commit 0182f3d7c3.

  Salman Ahmed · 2024-07-25 08:51:48 +03:00
  e1ccf68801
• Merge pull request #28995 from bdach/swell-editor-test-play

  Fix swells not being correctly treated in editor gameplay test

  Dan Balasescu · 2024-07-25 14:39:49 +09:00
  542cb12059
• Fix too many event rows displaying after spending a long time in gameplay/results
  Dean Herbert · 2024-07-25 14:31:22 +09:00
  f1dda4ab1e