78 Commits

Author	SHA1	Message	Date
Salman Ahmed	4e186b0cf5	ContentVisible -> HiddenByRulesetImplementation	2021-05-31 09:24:26 +03:00
Salman Ahmed	60b781701f	Rewrite catch combo counter hide logic	2021-05-30 14:22:11 +03:00
Salman Ahmed	fb81e5133f	Merge branch 'master' into catch-hide-combo-workaround	2021-05-30 14:16:46 +03:00
Dean Herbert	50d71faf56	Restructure lookup code to avoid repeating the base call	2021-05-30 17:55:10 +09:00
Salman Ahmed	fbc316ea1d	Fix legacy skin transformers potentially ignoring source implementations	2021-05-29 21:23:22 +03:00
Salman Ahmed	a4d52a7f52	Use switch—case instead	2021-05-19 23:37:22 +03:00
Salman Ahmed	ff419af512	Hide the combo counter content rather than full death	2021-05-18 09:10:15 +03:00
Salman Ahmed	df248ea41b	Improve code readability	2021-05-17 11:41:53 +03:00
Salman Ahmed	102842bcf1	Expire legacy combo counters on catch ruleset	2021-05-15 16:55:15 +03:00
Dean Herbert	004798d61d	Update Legacy components to not require skin in ctor	2021-05-11 18:39:14 +09:00
Salman Ahmed	43c1e1d217	Update existing usages ... Resolve post-conflict issues	2021-03-13 06:09:07 +03:00
Joehu	9ef130cdcc	Fix codefactor style issues	2021-02-04 13:28:35 -08:00
ekrctb	df9de7a8dd	Remove null check that is not required anymore	2020-12-09 10:28:42 +09:00
ekrctb	a32dac00dd	Introduce IHasCatchObjectState implemented by DHO and CaughtObject	2020-12-08 21:29:26 +09:00
ekrctb	c301223d8c	Make object on the catcher plate separate CaughtObject class	2020-12-08 21:11:40 +09:00
ekrctb	4d5c242d35	Use virtual property instead of a field for optional pieces	2020-12-08 17:15:40 +09:00
ekrctb	603cecb2eb	Make CatchHitObjectPiece abstract class	2020-12-08 17:02:57 +09:00
ekrctb	17d48c82f6	Use switch statement instead of an array	2020-12-08 16:59:06 +09:00
ekrctb	4da6717d0e	Rename things in PulpFormation	2020-12-08 10:33:18 +09:00
ekrctb	3cbdaf5960	Make resolved properties protected	2020-12-08 10:30:23 +09:00
ekrctb	b2e5658d23	Merge branch 'master' into fruit-piece-in-place	2020-12-07 18:57:42 +09:00
ekrctb	7f1ad1040d	Don't inherit DrawableFruit from DrawableBanana ... - A banana cannot be hyper	2020-12-07 14:08:50 +09:00
ekrctb	c0f39514b9	Fix legacy droplet scale	2020-12-07 14:00:22 +09:00
ekrctb	d51d2c5331	Don't recreate pieces when catch DHO is reused	2020-12-07 12:59:03 +09:00
ekrctb	87189452d1	Refactor legacy skin piece to allow texture update	2020-12-07 12:57:24 +09:00
ekrctb	d18397acad	Adjust namespace	2020-12-07 12:35:24 +09:00
ekrctb	b4b9312e0f	Move piece files of Catch ruleset	2020-12-07 12:34:38 +09:00
ekrctb	4cd234ea05	Fix null reference of LegacyFruitPiece	2020-11-30 19:56:12 +09:00
ekrctb	323533d945	Add hiding Palpable HitObject property	2020-11-25 08:07:59 +09:00
ekrctb	ab7251d742	Move members to PalpableCatchHitObject	2020-11-24 19:57:37 +09:00
Dean Herbert	8a3bce3cc3	Fix osu!catch showing two combo counters for legacy skins	2020-10-16 18:20:17 +09:00
Dean Herbert	899bac6ca5	Rename catch combo counter for clarity	2020-10-14 19:16:34 +09:00
Dean Herbert	1b261f177f	Disable rewind handling	2020-09-22 13:17:53 +09:00
Dean Herbert	1c58f568d6	Simplify and reformat rewind/transform logic	2020-09-22 12:54:21 +09:00
Dean Herbert	ffd4874ac0	Remove unnecessary double suffixes	2020-09-22 12:37:18 +09:00
Dean Herbert	08d8975566	Remove DisplayInitialCombo method for simplicity	2020-09-22 12:35:18 +09:00
Dean Herbert	92cda6bccb	Adjust xmldoc slightly	2020-09-22 12:27:47 +09:00
Dean Herbert	a27a65bf03	Don't recreate explosion counter each increment	2020-09-22 12:25:40 +09:00
Dean Herbert	f629c33dc0	Make explosion additive to match stable	2020-09-22 12:14:31 +09:00
Salman Ahmed	bfe332909c	Remove "hide combo counter on break time" feature for being too complex ... The combo counter will be hidden at most one second after the break has started anyways, so why not just remove this feature if the way of implementing it is complicated to be merged within the legacy counter implementation.	2020-09-21 14:32:14 +03:00
Bartłomiej Dach	3db0e7cd75	Generalise LegacyRollingCounter	2020-09-12 22:40:32 +02:00
Salman Ahmed	99a68e880a	Merge remote-tracking branch 'upstream/master' into catch-combo-counter	2020-09-01 20:46:38 +03:00
Salman Ahmed	a0a4501008	Merge remote-tracking branch 'upstream/master' into catch-combo-counter	2020-09-01 20:17:25 +03:00
smoogipoo	ab8d9be095	Move out into a separate method	2020-08-25 15:16:41 +09:00
Salman Ahmed	0e9242ee9a	Move combo font retrieval inside the legacy component	2020-08-23 10:29:01 +03:00
Salman Ahmed	7ae45b29db	Finish internal counter transformation regardless of the combo	2020-08-22 12:20:50 +03:00
smoogipoo	eaba323353	Update catch with legacy colour setters	2020-08-22 00:17:35 +09:00
Salman Ahmed	af52b73b06	Fill out missing documentation	2020-08-19 08:39:40 +03:00
Salman Ahmed	885f8104f5	Always use public accessors even on legacy classes ... Because of https://github.com/ppy/osu-framework/issues/3727	2020-08-19 08:00:57 +03:00
Salman Ahmed	422100192c	Move HasFont to legacy skin extensions class instead	2020-08-19 07:58:23 +03:00