24822 Commits

This Branch

This Branch

All Branches

• Add filter parsing tests

  Introduce unit tests covering parsing for the originally introduced
  filtering features. The introduced improvements (lower and upper
  interval and decimal point support) also tested.

  Bartłomiej Dach · 2019-09-22 00:20:54 +02:00
  d11d932a87
• Take culture into account when parsing filters

  Culture was not taken into account when parsing filters, which meant
  that in cultures that use the comma (,) as a decimal delimiter, it would
  conflict with the comma used to delimit search criteria. To remove
  any ambiguity, introduce local helper functions that allow the decimal
  point to be utilised, using the invariant culture. This also matches
  stable behaviour.
  
  The decision to not reuse osu.Game.Beatmaps.Formats.Parsing was
  deliberate due to differing semantics (it's not really sane to throw
  exceptions on receiving user-facing input).

  Bartłomiej Dach · 2019-09-22 00:18:53 +02:00
  f5f5094611
• Split out lower and upper interval inclusivity

  A single IsInclusive field causes unexpected issues when trying to
  formulate a half-open interval query. Split out IsInclusive into two
  fields, Is{Lower,Upper}Inclusive and update usages accordingly.

  Bartłomiej Dach · 2019-09-22 00:18:28 +02:00
  dddd94684b
• Extract parsing filter queries to class

  For the sake of testability without having to spin up visual tests,
  extract methods related to parsing filter queries from FilterControl
  to a static FilterQueryParser class.

  Bartłomiej Dach · 2019-09-22 00:18:28 +02:00
  33c51d5178
• Remove pluralize and use title letter casing
  iiSaLMaN · 2019-09-21 21:00:24 +03:00
  9be8bdef52
• Move humanizing to the model name instead
  iiSaLMaN · 2019-09-21 20:04:12 +03:00
  6bb0f3eb41
• Fix scores importing with deleted beatmap sets (#6190)

  Fix scores importing with deleted beatmap sets

  Dean Herbert · 2019-09-22 01:15:22 +09:00
  db90d211cb
• Adjust test to assert that the import failed
  smoogipoo · 2019-09-22 00:59:40 +09:00
  08440ce5fd
• Fix deleting null beatmap set
  smoogipoo · 2019-09-22 00:59:01 +09:00
  24cc8ce0b7
• Bring up-to-date and use IApplicableFailOverride
  Dean Herbert · 2019-09-21 23:30:54 +09:00
  c99b48f934
• Merge branch 'master' into master
  Dean Herbert · 2019-09-21 22:45:05 +09:00
  4c4b71eeec
• Add support for "additions" in changelog (#6177)

  Add support for "additions" in changelog

  Dean Herbert · 2019-09-21 22:27:18 +09:00
  a76771e696
• Implement skin slider ball tinting (#6181)

  Implement skin slider ball tinting

  Dean Herbert · 2019-09-21 22:06:42 +09:00
  68252c2ce6
• Merge pull request #6178 from Game4all/fix-html-unescaping

  Fix escaped html strings not being unescaped in changelog entries.

  Dan Balasescu · 2019-09-21 13:11:27 +09:00
  35f0e07007
• Merge branch 'master' into fix-html-unescaping
  Dan Balasescu · 2019-09-21 12:59:57 +09:00
  73fe402756
• Reverse padding changes
  Andrei Zavatski · 2019-09-20 23:50:19 +03:00
  befdd140f4
• Merge remote-tracking branch 'refs/remotes/ppy/master' into changelog-improvements
  Andrei Zavatski · 2019-09-20 23:49:24 +03:00
  6ad26e61d1
• Use System mod type for NoMod
  Andrei Zavatski · 2019-09-20 23:47:21 +03:00
  e7118a9272
• Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector
  Andrei Zavatski · 2019-09-20 23:39:44 +03:00
  0d43f4e4f9
• Add visual test for HTML string unescaping.
  Lucas A · 2019-09-20 21:35:26 +02:00
  bbf3ac77f8
• Update framework (#6196)

  Update framework

  Dean Herbert · 2019-09-21 02:21:00 +09:00
  dced3c38b5
• Merge pull request #6194 from VPeruS/fix-typo

  Fix typo in CreateResourceStore method name

  Dean Herbert · 2019-09-21 02:16:33 +09:00
  b7c51d7b12
• Update framework
  Dean Herbert · 2019-09-21 02:08:19 +09:00
  92f9cf3e06
• Fixed typo

  Changed CreateReourceStore() to CreateResourceStore()

  Vperus · 2019-09-20 19:58:39 +03:00
  ac8fe6045f
• Merge pull request #6191 from VPeruS/remove-unused-const

  Remove unused CORNER_RADIUS

  Dan Balasescu · 2019-09-21 00:33:56 +09:00
  234c8e9067
• Remove unused CORNER_RADIUS
  Vperus · 2019-09-20 18:17:35 +03:00
  2d99d41a6d
• Pluralize instead of adding 's'
  iiSaLMaN · 2019-09-20 16:18:55 +03:00
  3be03a26c9
• Specify model name on import notification messages
  iiSaLMaN · 2019-09-20 15:46:43 +03:00
  8300e86f20
• Remove unnecessary fields
  iiSaLMaN · 2019-09-20 15:09:51 +03:00
  57310c86c7
• Remove "allow slider ball tinting" ruleset setting
  iiSaLMaN · 2019-09-20 15:08:00 +03:00
  093ed8421e
• Allow undeleting scores if their beatmap exists
  smoogipoo · 2019-09-20 19:55:59 +09:00
  c89c092b98
• Add test
  smoogipoo · 2019-09-20 19:53:03 +09:00
  ff2f3cde02
• Fix scores importing with deleted beatmap sets
  smoogipoo · 2019-09-20 19:39:21 +09:00
  dfc0928ebe
• Update LabelledTextBox to use LabelledComponent
  smoogipoo · 2019-09-20 18:50:50 +09:00
  2bbf4ca4b5
• Add xmldocs
  smoogipoo · 2019-09-20 18:39:04 +09:00
  523272edab
• Add a LabelledComponent base class
  smoogipoo · 2019-09-20 18:35:15 +09:00
  e0a97cfac5
• Merge pull request #6185 from peppy/checksum-before-skip-copy

  Checksum before skip copy

  Dan Balasescu · 2019-09-20 15:37:04 +09:00
  33e39795c3
• Merge branch 'master' into beatmap-parsing-fallback-v2
  Dean Herbert · 2019-09-20 15:28:08 +09:00
  a06cb54732
• Add test to cover corruption case
  Dean Herbert · 2019-09-20 15:05:48 +09:00
  f306fe27d8
• Force a checksum check before skipping FileStore copy op
  Dean Herbert · 2019-09-20 15:00:27 +09:00
  d0a4e1e3c2
• Merge pull request #6179 from revelsix/leaderboard-mod-filter

  Reduce ambiguity of leaderboard mod filter button

  Dean Herbert · 2019-09-20 12:31:36 +09:00
  c5474bc2ef
• Use logical-OR
  iiSaLMaN · 2019-09-20 00:25:16 +03:00
  1b45014ff6
• Implement tinting slider ball with combo colour
  iiSaLMaN · 2019-09-20 00:11:37 +03:00
  f6291170b1
• Add AllowSliderBallTint to skin configuration
  iiSaLMaN · 2019-09-20 00:10:55 +03:00
  8fcfd82316
• Add setting to always tint slider ball
  iiSaLMaN · 2019-09-20 00:10:28 +03:00
  033ed2e1f5
• Update BeatmapDetailAreaTabControl.cs
  Revel · 2019-09-19 15:47:32 -04:00
  f7f9c0f7e0
• Fix escaped html strings not being unescaped in changelog entries.
  Lucas A · 2019-09-19 20:08:14 +02:00
  5663e3e6b3
• Adjust icon padding
  Andrei Zavatski · 2019-09-19 20:53:06 +03:00
  daa64f1be7
• Merge pull request #6175 from peppy/confirm-via-key

  Always show exit confirmation when closing via alt-f4 or window control

  Dan Balasescu · 2019-09-20 02:47:09 +09:00
  c09f384a7e
• Implement ChangelogEntryType
  Andrei Zavatski · 2019-09-19 20:34:37 +03:00
  573da7b1e7