Bartłomiej Dach
181d2c672b
Fix outdated comment
2021-02-02 22:05:25 +01:00
Bartłomiej Dach
fe7f4f7222
Merge branch 'master' into playlists-item-visual-improvements
2021-02-02 21:26:16 +01:00
Salman Ahmed
62d0036c81
Fix using private constructor on MessagePack object
2021-02-02 17:45:11 +03:00
Salman Ahmed
50d57a3931
Move tracker loading into BDL
2021-02-02 17:22:48 +03:00
Dean Herbert
abb32d11b5
Merge pull request #11662 from smoogipoo/refactor-mod-sections
...
Refactor mod sections and make them overridable
2021-02-02 23:12:34 +09:00
Salman Ahmed
8e96ffd1e6
Fix "wait for import" until step potentially finishing early
...
If not obvious, the issue with previous code is that it was checking for `IsAvailableLocally`, while the import is happening on a different thread, so that method could return `true` before the importing has finished and `ItemUpdated` event is called.
2021-02-02 16:54:41 +03:00
smoogipoo
aeb3ed8bb3
Renamespace footer button
2021-02-02 21:46:22 +09:00
smoogipoo
6453367a9c
Merge branch 'freemod-select-overlay' into freemods
2021-02-02 21:43:35 +09:00
Dean Herbert
b76116d943
Merge branch 'master' into modselect-disable-stacking
2021-02-02 21:41:33 +09:00
smoogipoo
097ce37e96
Merge branch 'fix-mod-icon' into freemods
2021-02-02 21:37:24 +09:00
smoogipoo
921f008217
Fix ModIcon not updating background colour correctly
2021-02-02 21:35:08 +09:00
smoogipoo
6ff8e8dd37
Disable a few mods by default
2021-02-02 21:29:08 +09:00
smoogipoo
5a56e2ba4b
Fix sound duplication due to checkbox
2021-02-02 21:29:00 +09:00
smoogipoo
f25535548a
Fix buzzing on select all/deselect all
2021-02-02 21:20:16 +09:00
smoogipoo
643c0605d8
Implement the freemod selection overlay
2021-02-02 21:14:38 +09:00
smoogipoo
8b3a85daa7
Merge branch 'refactor-mod-sections' into freemod-select-overlay
2021-02-02 21:09:51 +09:00
smoogipoo
728f8599b2
Move incompatible mod deselection to SoloModOverlay
2021-02-02 21:06:32 +09:00
smoogipoo
e58ece9e10
Make ModSelectOverlay abstract
2021-02-02 21:06:04 +09:00
smoogipoo
50e92bd0ed
Fix selection not being preserved when IsValidMod changes
2021-02-02 20:50:54 +09:00
smoogipoo
10ceddf3ff
Make IsValidMod adjustable
2021-02-02 20:47:50 +09:00
Dean Herbert
2d7c3d95c0
Merge pull request #11642 from peppy/mod-consistency-function
...
Fix invalid mod combinations potentially being selectable at a game level
2021-02-02 20:46:05 +09:00
smoogipoo
75f81bfa06
Add back mod validation
2021-02-02 20:35:41 +09:00
smoogipoo
6d620264f4
Allow mod buttons to not be stacked
2021-02-02 20:27:41 +09:00
smoogipoo
3741f05ab3
Refactor mod sections and make them overridable
2021-02-02 20:11:40 +09:00
Dean Herbert
ac5662b1aa
Merge branch 'master' into mod-consistency-function
2021-02-02 20:01:42 +09:00
Dean Herbert
4ecbe058f7
Merge pull request #11640 from smoogipoo/add-mod-utils
...
Add ModUtils class for validating mod usages
2021-02-02 20:01:20 +09:00
smoogipoo
2dece12a7c
Disable/disallow freemods on incompatible/selected mods
2021-02-02 19:57:42 +09:00
Dean Herbert
8e70a50af0
Remove unused using statement
2021-02-02 19:22:13 +09:00
Dean Herbert
41593ff09e
Privatise protected property setters
2021-02-02 19:14:44 +09:00
smoogipoo
4fee762a4f
Merge branch 'add-mod-utils' into freemods
2021-02-02 19:02:45 +09:00
smoogipoo
a2e3b1c0e4
Move Mods reset code to OnlinePlaySongSelect
2021-02-02 19:02:39 +09:00
smoogipoo
180af3c7f8
Add codeanalysis attribute
2021-02-02 19:02:09 +09:00
smoogipoo
8cc4de2396
Merge branch 'add-mod-utils' into freemods
2021-02-02 18:53:21 +09:00
smoogipoo
0a9861d0ab
Use TestCaseSource and add multi-mod test
2021-02-02 18:51:13 +09:00
Dean Herbert
fc3adaf612
Show maximum attempt count in room display (when not unlimited)
2021-02-02 18:45:05 +09:00
Dean Herbert
9b209d67dc
Match size of participants text with host display
2021-02-02 18:45:05 +09:00
Dean Herbert
96d20bf607
Reduce height of ModeTypeInfo to match adjacent text sections
2021-02-02 18:45:05 +09:00
Dean Herbert
90acdd4361
Display the correct error message on score submission failure
...
The server will return a valid error message in most cases here. We may
eventually want to add some fallback message for cases an error may
occur that isn't of
[InvariantException](3169b33ccc/app/Exceptions/InvariantException.php (L9-L10)
2021-02-02 18:45:05 +09:00
Dean Herbert
6fdaf02518
Hook up room-level max attempts to UI
2021-02-02 18:45:05 +09:00
smoogipoo
052cf1abae
Reuse existing method
2021-02-02 18:42:02 +09:00
smoogipoo
5881b8be96
Merge branch 'add-mod-utils' into mod-consistency-function
2021-02-02 18:41:35 +09:00
Dean Herbert
c41c854ce3
Merge pull request #11637 from frenzibyte/improve-chat-autoscroll
...
Improve auto-scrolling logic for drawable channels
2021-02-02 18:40:25 +09:00
smoogipoo
12f52316cd
Prevent multiple enumeration
2021-02-02 18:37:11 +09:00
smoogipoo
9955e02898
Make more tests use the custom mod classes
...
For safety purposes... In implementing the previous tests, I found that
using mod.Object.GetType() can lead to bad assertions since the same
ModProxy class is used for all mocked classes.
2021-02-02 18:33:14 +09:00
smoogipoo
1df412a03c
Fix incorrect handling of multi-mod incompatibilities
2021-02-02 18:31:08 +09:00
smoogipoo
d0655c21c6
Simplify implementation of CheckCompatibleSet
2021-02-02 18:18:57 +09:00
smoogipoo
8232d9d2fe
Fix incorrect implementation
2021-02-02 18:01:38 +09:00
smoogipoo
7c29386717
Add failing tests
2021-02-02 18:01:33 +09:00
Dan Balasescu
45758a5f7f
Merge pull request #11657 from peppy/fix-playlist-lounge-test-scene
...
Fix PlaylistLoungeTestScene appearing very narrow
2021-02-02 17:33:14 +09:00
Dan Balasescu
627c55f748
Merge pull request #11658 from peppy/playlists-settings-taller-area
...
Make playlist settings area taller to better match screen aspect ratio
2021-02-02 17:32:47 +09:00
