58147 Commits

This Branch

This Branch

All Branches

• Add confirmation dialog when about to discard a playlist

  The confirmation will only show if items have been added to the
  playlist.
  
  Closes https://github.com/ppy/osu/issues/19444.

  Dean Herbert · 2022-07-29 17:11:37 +09:00
  9d457535c6
• Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering

  Move spectator begin/end playing to SubmittingPlayer

  Dean Herbert · 2022-07-29 16:09:50 +09:00
  eb92c35335
• Merge branch 'master' into bypass-local-metadata-cache
  Dean Herbert · 2022-07-29 16:05:54 +09:00
  cb52b696ed
• Use tuple to better explain new bool parameter
  Dean Herbert · 2022-07-29 16:05:41 +09:00
  2ff6ff06d3
• Ensure realm is in a good state before asserts in TestSceneFilterControl
  Dean Herbert · 2022-07-29 15:59:53 +09:00
  e07e761c10
• Merge pull request #19453 from smoogipoo/multiplayer-test-misordering

  Fix potential test failures due to Setup/SetUpSteps ordering

  Dean Herbert · 2022-07-29 15:59:51 +09:00
  be7a9e1487
• Fix potential test failures due to Setup/SetUpSteps ordering
  Dan Balasescu · 2022-07-29 15:27:39 +09:00
  aaa6f963bd
• Merge pull request #19451 from peppy/dont-wait-spectator-frames

  Revert blocking call when sending spectator frames

  Dan Balasescu · 2022-07-29 14:17:57 +09:00
  bc685918b6
• Revert blocking call when sending spectator frames

  There are a lot of these requests, and we don't really care about
  waiting on them to finish sending. This may have negatively affected
  send performance for users with very high latency.
  
  Reverts part of 0533249d11.
  
  Addresses concerns in https://github.com/ppy/osu/discussions/19429#discussioncomment-3276400.

  Dean Herbert · 2022-07-29 12:24:54 +09:00
  fd09155990
• Merge branch 'master' into kps
  Ryuki · 2022-07-28 18:38:09 +02:00
  2df24019fd
• Add some tests
  Ryuki · 2022-07-28 18:37:50 +02:00
  079150849a
• Add basic Queue based implementation of KPS
  Ryuki · 2022-07-28 18:37:12 +02:00
  b2e7da5aa0
• Merge pull request #19443 from smoogipoo/fix-intermittent-hud-tests

  Fix intermittent HUD tests

  Dean Herbert · 2022-07-28 23:20:46 +09:00
  45879f7836
• Merge pull request #19431 from peppy/collections-track-beatmap-updates

  Add collection transfer logic to beatmap import-as-update flow

  Dan Balasescu · 2022-07-28 22:52:54 +09:00
  0d6b45e515
• Remove unnecessary LoadTrack call
  Dean Herbert · 2022-07-28 22:19:46 +09:00
  e664690fe2
• Merge branch 'master' into pie-chart-progress
  Dean Herbert · 2022-07-28 22:19:27 +09:00
  3005ff1b9f
• Merge branch 'master' into collections-track-beatmap-updates
  Dan Balasescu · 2022-07-28 22:05:34 +09:00
  a59d7f6710
• Merge pull request #19441 from peppy/test-working-beatmap-unfuck

  Reduce calls to `LoadTrack` by implicitly running on test/dummy classes

  Dan Balasescu · 2022-07-28 22:05:25 +09:00
  aa03df905f
• Merge pull request #19430 from peppy/realm-collections

  Move beatmap collections to realm

  Dan Balasescu · 2022-07-28 22:05:10 +09:00
  5003eb5629
• Merge branch 'master' into realm-collections
  Dan Balasescu · 2022-07-28 21:00:08 +09:00
  11e0022fad
• Move spectator begin/end playing to SubmittingPlayer
  Dan Balasescu · 2022-07-28 20:44:04 +09:00
  ce694123eb
• Adjust metrics
  Dean Herbert · 2022-07-28 18:50:46 +09:00
  4b140e1f5a
• Apply nullability to DefaultSongProgress and clean up more stuff
  Dean Herbert · 2022-07-28 18:37:17 +09:00
  86c2b7e449
• Move initial show to base implementation and add transition for legacy version
  Dean Herbert · 2022-07-28 18:29:49 +09:00
  ea027eda46
• Remove pointless null check
  Dean Herbert · 2022-07-28 18:28:03 +09:00
  bfa026879c
• Fix DefaultSongProgress graph not resetting if time is in intro
  Dean Herbert · 2022-07-28 18:25:24 +09:00
  d5e5761892
• Tidy up various things everywhere
  Dean Herbert · 2022-07-28 18:25:14 +09:00
  7108553883
• Reduce calls to LoadTrack by implicitly running on test/dummy classes
  Dean Herbert · 2022-07-28 18:11:40 +09:00
  a21aee4e9c
• Fix intermittent HUD tests
  Dan Balasescu · 2022-07-28 17:58:07 +09:00
  1039338d80
• Remove incorrect TrackLoaded override from TestWorkingBeatmap
  Dean Herbert · 2022-07-28 17:49:17 +09:00
  628a30193f
• Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store

  Remove unused `RulesetStore` from `BeatmapManager` constructor

  Dan Balasescu · 2022-07-28 17:46:12 +09:00
  1da9830145
• Rename parameter to read better (and still use local cache if no online API is available)
  Dean Herbert · 2022-07-28 17:08:59 +09:00
  8cb4fb35e0
• Adjust comment
  Dan Balasescu · 2022-07-28 16:56:11 +09:00
  6d4023b933
• Merge pull request #19433 from peppy/beatmap-model-documentation

  Add more comprehensive xmldoc for beatmap model classes

  Dan Balasescu · 2022-07-28 16:40:29 +09:00
  ebe64422d6
• Fix assertion
  Dan Balasescu · 2022-07-28 16:34:31 +09:00
  cd01c5d3ac
• Add flow for bypassing local cache lookups when refreshing beatmap metadata
  Dean Herbert · 2022-07-28 16:33:51 +09:00
  c35da62224
• Move scheduler from OnlineLookupQueue to BeatmapUpdater
  Dean Herbert · 2022-07-28 16:32:22 +09:00
  17a3fd30fb
• apply code quality fixes
  Nitrous · 2022-07-28 15:30:45 +08:00
  0d36907cad
• set FirstHitTime and LastHitTime once
  Nitrous · 2022-07-28 15:25:12 +08:00
  bca3994d91
• Merge pull request #19432 from peppy/fix-update-test-failures

  Add realm refresh calls to fix intermittent test failures on new update tests

  Dan Balasescu · 2022-07-28 16:19:46 +09:00
  fe6b487d75
• simplify helper methods
  Nitrous · 2022-07-28 15:19:35 +08:00
  70ed347b06
• Remove unused RulesetStore from BeatmapManager constructor
  Dean Herbert · 2022-07-28 16:19:05 +09:00
  2b9d46d803
• apply suggestions

  - refactor `SongProgress`
  - make`UpdateProgress` more readable
  - enable NRT on new classes
  - refactor `TestSceneSongProgress` to use `GameplayClockContainer`

  Nitrous · 2022-07-28 15:15:41 +08:00
  db62d4be3a
• Link to correct model in xmldoc
  Dan Balasescu · 2022-07-28 16:02:19 +09:00
  c1aaf27c54
• Fix crash in DrawableRoomPlaylistItem context menu creation due to incorrect enumeration casting
  Dean Herbert · 2022-07-28 15:51:18 +09:00
  525e4a2019
• Fix managed object reused between test runs
  Dan Balasescu · 2022-07-28 15:45:33 +09:00
  6bf293e130
• Add more comprehensive xmldoc for beatmap model classes
  Dean Herbert · 2022-07-28 15:41:28 +09:00
  452d82f292
• Merge pull request #19419 from andy840119/remove-nullable-disable-in-the-mods-for-taiko-ruleset

  Remove nullable disable annotation in mods for taiko ruleset.

  Salman Ahmed · 2022-07-28 09:32:35 +03:00
  ce48984bda
• Update test to account for sort order
  Dean Herbert · 2022-07-28 15:20:25 +09:00
  8ac886a247
• Add realm Refresh calls to ensure tests are stable
  Dean Herbert · 2022-07-28 15:18:04 +09:00
  67c44552cb