58147 Commits

This Branch

This Branch

All Branches

• Reuse "select/deselect all" localisable string on column toggle
  Bartłomiej Dach · 2022-05-07 10:56:03 +02:00
  f761d4d4d4
• Add localisable string for difficulty multiplier display
  Bartłomiej Dach · 2022-05-07 10:48:15 +02:00
  fa0a256f48
• Merge branch 'master' into distance-snap-grid-current-tiume
  Salman Ahmed · 2022-05-07 11:47:38 +03:00
  db04bcf1ce
• Merge branch 'master' into mod-overlay/localisation-strings
  Salman Ahmed · 2022-05-07 11:33:18 +03:00
  e9b0ae6da5
• Merge pull request #18130 from bdach/mod-overlay/bulk-select-buttons

  Add back select/deselect all mods buttons to new mod select design

  Dean Herbert · 2022-05-07 17:32:10 +09:00
  2752bdf04f
• Update free mod select/deselect all test after back button addition
  Bartłomiej Dach · 2022-05-07 10:25:23 +02:00
  9d3e67b10d
• Add test coverage for mod select back button
  Bartłomiej Dach · 2022-05-07 10:23:49 +02:00
  1c029552d7
• Add back button to mod select overlays
  Bartłomiej Dach · 2022-05-07 10:17:32 +02:00
  271d64fd54
• Add basic localisation strings for new mod select
  Bartłomiej Dach · 2022-05-07 10:17:24 +02:00
  6ad990dfc3
• Dim other buttons if customisation panel is open
  Bartłomiej Dach · 2022-05-07 09:50:09 +02:00
  4ff96f82be
• Update mod columns even if they're not present/offscreen

  Important to make "select/deselect all" operations work on all columns
  simultaneously, even if they're offscreen. Unfortunately by the nature
  of how the existing selection animation works, it is hard-tied to the
  update loop, so we need to compensate.

  Bartłomiej Dach · 2022-05-07 09:50:09 +02:00
  18e4c3ed0f
• Only load panels asynchronously outside of BDL
  Bartłomiej Dach · 2022-05-07 09:50:09 +02:00
  9514a5cef7
• Remove schedule in panel load

  It was causing selection/deselection of all mods to work improperly if a
  select/deselect all operation was requested before the panel was
  scrolled into view.
  
  In general the schedule was an over-optimisation - the game-global set
  of available mods shouldn't be changing so often as to warrant such an
  aggressive debounce.

  Bartłomiej Dach · 2022-05-07 09:50:09 +02:00
  9f96dd47d1
• Add test coverage for selecting/deselecting all mods on free mod select
  Bartłomiej Dach · 2022-05-07 09:50:08 +02:00
  e1953c484c
• Add test coverage for deselecting all mods on user mod select
  Bartłomiej Dach · 2022-05-07 09:29:33 +02:00
  35c106efaa
• Add select/deselect all buttons to free mod select screen
  Bartłomiej Dach · 2022-05-07 09:29:33 +02:00
  852e4a9766
• Add some more padding between footer and column scroll
  Bartłomiej Dach · 2022-05-07 09:29:33 +02:00
  0b95594f60
• Move footer button padding to a higher level
  Bartłomiej Dach · 2022-05-07 09:29:32 +02:00
  0c6de331f3
• Merge branch 'master' into distance-snap-grid-current-tiume
  Bartłomiej Dach · 2022-05-07 08:49:30 +02:00
  202a603d72
• Merge pull request #18065 from huoyaoyuan/code-style

  Enforce code style analysis shipped with .NET SDK

  Dean Herbert · 2022-05-07 14:58:19 +09:00
  dd63657dfb
• Merge pull request #18126 from bdach/mod-overlay/fix-broken-mod-reference-logic

  Fix several issues with new mod select reference replacement logic

  Dean Herbert · 2022-05-07 14:36:05 +09:00
  2dd9899cd7
• Merge pull request #18125 from frenzibyte/fix-overlay-horizontal-offset-overlays

  Fix side overlay offset not affecting fullscreen overlays

  Dean Herbert · 2022-05-07 14:02:22 +09:00
  34237fd05e
• Use above-1 offset instead for more correct feeling parallax
  Dean Herbert · 2022-05-07 14:02:07 +09:00
  ce14fddcb2
• Fix time based distance grid alpha not correctly accounting for distance spacing multiplier
  Dean Herbert · 2022-05-07 13:37:36 +09:00
  71758390b5
• Code quality
  Jai Sharma · 2022-05-06 23:17:59 +01:00
  6fc808be22
• Update new chat overlay day separator colours and spacing

  Updates the `DaySeparator` component to have separately settable colours
  for the text and the lines.
  
  Updates existing overrides of the `DaySeparator` to use the new colour
  setter.
  
  Create new `ChatOverlayDrawableChannel` with adjusted spacing and new
  `DaySeparator` colours.

  Jai Sharma · 2022-05-06 23:06:18 +01:00
  9d62206176
• Fix sequence equality check not using reference comparison
  Bartłomiej Dach · 2022-05-06 21:47:04 +02:00
  8c73ed7207
• Do not modify selected mods through panel state change during external update
  Bartłomiej Dach · 2022-05-06 21:47:04 +02:00
  621f746789
• Simplify state management in ModColumn

  Bad sign when you can't follow your own code.
  
  All of the various state changing methods were flattened into one
  because it was too hard to follow what was calling what and why.

  Bartłomiej Dach · 2022-05-06 21:46:16 +02:00
  c199b8fcb6
• Add test coverage for lack of customisation on free mod select
  Bartłomiej Dach · 2022-05-06 21:35:22 +02:00
  380cd1e036
• Apply offset by a factor of 0.8x from screen offset
  Salman Ahmed · 2022-05-06 22:20:09 +03:00
  8080f784fd
• Fix side overlay offsetting not affecting fullscreen overlays
  Salman Ahmed · 2022-05-06 21:42:20 +03:00
  049fed42e2
• 🔧 Update Sentry DSN
  Hugo Denizart · 2022-05-06 19:52:25 +02:00
  cc251ed5c3
• Move inverting value to happen outside clamp

  Looks to have no effect, but makes sense to happen outside instead.

  Salman Ahmed · 2022-05-06 18:54:13 +03:00
  723fce8174
• Use GetEndTime() instead of StartTime

  Companion to
  https://github.com/ppy/osu/pull/18103/commits/246479bf34c725d886742017099f9d509e58b2f7

  Salman Ahmed · 2022-05-06 18:51:35 +03:00
  d78f1d158d
• Make nested class private
  Salman Ahmed · 2022-05-06 18:50:28 +03:00
  112496204d
• Merge pull request #18120 from peppy/fix-toolbox-expansion

  Fix user-contracted toolbox groups in editor incorrectly expanding on hover

  Salman Ahmed · 2022-05-06 18:44:09 +03:00
  404798395c
• Merge branch 'master' into distance-snap-grid-current-tiume
  Salman Ahmed · 2022-05-06 18:20:22 +03:00
  3077d398ef
• Merge branch 'master' into fix-toolbox-expansion
  Salman Ahmed · 2022-05-06 18:00:01 +03:00
  1409f8ca96
• Merge pull request #18122 from bdach/mod-overlay/leftover-mod-area-border

  Remove leftover border thickness spec in mod settings area

  Dean Herbert · 2022-05-06 23:58:35 +09:00
  bda57dd970
• Merge branch 'master' into fix-toolbox-expansion
  Salman Ahmed · 2022-05-06 17:54:14 +03:00
  f222affe88
• Merge pull request #18103 from peppy/distance-snapping-test

  Fix distance snapping grid providing incorrect time values for non-1.0x spacing

  Salman Ahmed · 2022-05-06 17:53:44 +03:00
  a7c7fc745b
• Merge branch 'master' into distance-snapping-test
  Salman Ahmed · 2022-05-06 17:29:27 +03:00
  144d33f0d2
• Merge pull request #18121 from peppy/editor-drag-box

  Fix editor drag box visuals

  Bartłomiej Dach · 2022-05-06 15:52:26 +02:00
  9961545147
• Remove leftover border thickness spec in mod settings area

  Was never supposed to be there, it was a vestige of a previous design
  iteration that went by unnoticed.

  Bartłomiej Dach · 2022-05-06 15:34:49 +02:00
  c533c93ffd
• Merge branch 'master' into editor-drag-box
  Bartłomiej Dach · 2022-05-06 15:22:39 +02:00
  56fa5c9db1
• Halve drag box padding

  Allows the drag box borders to collapse in on themselves to a single
  line if the drag selection has zero width or height.

  Bartłomiej Dach · 2022-05-06 15:21:35 +02:00
  29a3ab7e7a
• Reword test step
  Salman Ahmed · 2022-05-06 15:38:38 +03:00
  b119726b28
• Merge branch 'master' into fix-toolbox-expansion
  Bartłomiej Dach · 2022-05-06 13:47:36 +02:00
  e527574ede
• Update tests to reflect new expected behaviour
  Bartłomiej Dach · 2022-05-06 13:47:13 +02:00
  19297375e2