1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 15:07:44 +08:00
Commit Graph

742 Commits

Author SHA1 Message Date
Dan Balasescu
4c1a1b54be
Fix NVAPI startup exception on non-Windows platforms 2024-03-27 00:07:51 +09:00
Bartłomiej Dach
53c3aec3c3
Fix discord RPC errors in multiplayer
Reproduction steps:

1. Go to multiplayer
2. Create a room
3. Play a map to completion
4. Wait for "secrets cannot currently be sent with buttons" error
   messages

The fix is to clear the buttons since they're the less important ones.
2024-03-25 18:05:00 +01:00
Bartłomiej Dach
a398754a27
Merge all presence methods into one
I'm about to make them interdependent (and it's discord's fault),
so it doesn't really make sense to make them separate at this point
I don't think. And it felt weird anyway.
2024-03-25 18:00:42 +01:00
Bartłomiej Dach
e95f29cf4b
Rename updatePresence() => schedulePresenceUpdate()
The method doesn't actually update anything by itself, and I want to
free up the `updatePresence()` name for the actual update.
2024-03-25 17:57:13 +01:00
Bartłomiej Dach
3db88fbcea
Use less confusing message format when logging discord errors
The "code" is a number, so it looked weird when put in the middle
without any nearby punctuation. Example:

	An error occurred with Discord RPC Client: 5005 secrets cannot currently be sent with buttons
2024-03-25 17:54:20 +01:00
Salman Ahmed
5f86b5a2fa Use DI correctly 2024-03-20 07:36:15 +03:00
Salman Ahmed
b11ae1c571 Organise code, still hook up to RoomChanged to update room privacy mode, and use SkipIdenticalPresence + scheduling to avoid potential rate-limits 2024-03-20 07:28:01 +03:00
jvyden
1a08dbaa2b
Fix code style 2024-03-19 17:03:30 -04:00
jvyden
4305c3db5b
Show login overlay when joining room while not logged in 2024-03-19 16:15:22 -04:00
jvyden
c71daba4f6
Improve logging of RPC
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2024-03-19 16:05:13 -04:00
jvyden
0ecfa580d7
Move room code from activity code, prevent duplicate RPC updates 2024-03-19 16:03:37 -04:00
jvyden
808d6e0943
Prevent potential threading issues 2024-03-19 16:02:06 -04:00
jvyden
f851716a47
Merge branch 'master' into discord-rpc-invites 2024-03-19 15:29:52 -04:00
jvyden
e4e7dd14f3
Revert "Update presence on changes to multiplayer room"
This reverts commit 8b730acb08.
2024-03-11 18:16:13 -04:00
jvyden
5580ce31fa
Log Discord RPC updates 2024-03-11 18:15:18 -04:00
Salman Ahmed
8b730acb08 Update presence on changes to multiplayer room 2024-03-11 13:16:00 +03:00
Salman Ahmed
169e2e1b4e Change maximum room number to closest powers of two 2024-03-11 13:16:00 +03:00
Dean Herbert
226df7163e
Update client ID 2024-03-11 16:55:49 +08:00
Salman Ahmed
283de215d3 Adjust log message and comment 2024-03-11 01:17:17 +03:00
jvyden
98ca021e66
Catch and warn about osu!stable lobbies 2024-03-06 01:17:37 -05:00
Jayden
9871300317
Improve language of user-facing errors
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-03-05 18:22:39 -05:00
jvyden
b53777c2a4
Refactor room secret handling to use JSON
Also log room secrets for debugging purposes
2024-03-05 18:21:26 -05:00
Jayden
cceb616a18
Update failure messages
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2024-03-04 22:25:36 -05:00
Jayden
37e7a4dea7
Fix yapping
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2024-03-01 14:32:44 -05:00
Susko3
3df32638c2 Fix association descriptions never being written on update 2024-03-01 16:06:30 +01:00
jvyden
92235e7789
Make truncate and getBeatmapID static
Code quality was complaining about hidden variables so I opted for this solution.
2024-03-01 00:02:20 -05:00
jvyden
060e17e989
Support Discord game invites in multiplayer lobbies 2024-02-29 23:41:40 -05:00
Dean Herbert
91483bdc2f
Merge pull request #27001 from Susko3/windows-file-uri-association
Associate with files and URIs on windows
2024-03-01 11:26:44 +08:00
Dean Herbert
61cc5d6f29
Fix typos in xmldoc 2024-03-01 11:24:12 +08:00
Salman Ahmed
c69c881cd3 Combine conditionals and remove "InLobby" check 2024-02-28 07:58:02 +03:00
jvyden
e2a364332b
Merge branch 'master' into discord-dnd-fix 2024-02-27 16:23:56 -05:00
jvyden
e053c08f6b
Hide social interactions while in Do Not Disturb 2024-02-27 16:23:36 -05:00
Bartłomiej Dach
87509fbf6e
Privatise registry-related constants
Don't see any reason for them to be public.
2024-02-27 14:07:49 +01:00
Dan Balasescu
069b400dd0
Move manager to desktop game 2024-02-27 19:36:03 +09:00
Susko3
9b3ec64f41 Inline HKCU\Software\Classes usage 2024-02-26 13:10:37 +01:00
Susko3
f2807470ef Inline EXE_PATH usage 2024-02-26 13:03:23 +01:00
Susko3
6dbba705b3 Refine uninstall logic to account for legacy windows features 2024-02-26 12:27:02 +01:00
jvyden
8934cf33f0
Apply Discord RPC changes regardless of user's status 2024-02-23 22:29:09 -05:00
Joseph Madamba
27ce965dd2 Update unsupported windows startup blocker comment 2024-02-15 22:52:27 -08:00
Dean Herbert
e705190664
Update windows icon metrics to match previous icon 2024-02-15 23:23:49 +08:00
Susko3
6ded79cf07 Make NotifyShellUpdate() public to ease testing 2024-02-08 01:15:37 +01:00
Susko3
1dc54d6f25 Fix stable install path lookup
`osu` is the `osu://` protocol handler, which gets overriden by lazer.
Instead, use `osu!` which is the stable file handler.
2024-02-08 00:54:48 +01:00
Susko3
dfa0c51bc8 Copy icons to nuget and install package
Don't ask me why this uses the folder for .NET Framework 4.5
2024-02-08 00:23:46 +01:00
Susko3
7864810fc9 Merge branch 'master' into windows-file-uri-association 2024-02-07 23:10:13 +01:00
Susko3
8049270ad2 Remove unused param 2024-02-07 22:45:58 +01:00
Susko3
bf47221594 Make things testable via 'Run static method' in Rider 2024-02-07 22:42:42 +01:00
Susko3
139072fa81 Standardise using declaration 2024-02-07 22:29:20 +01:00
Susko3
3419b8ffa8 Standardise using declaration 2024-02-07 22:28:54 +01:00
Susko3
7f5dedc118 Refactor ProgID logic so it's more visible 2024-02-07 22:23:59 +01:00
Susko3
da8c4541db Use Logger.Error 2024-02-07 22:21:04 +01:00