52789 Commits

This Branch

This Branch

All Branches

• Adjust animations and tolerances to make things feel snappier
  Dean Herbert · 2022-06-25 19:50:10 +09:00
  2ecab454aa
• Adjust menu cursor rotation to follow mouse, rather than be fixated around original click location
  Dean Herbert · 2022-06-25 19:33:44 +09:00
  a039f9878a
• Merge pull request #18830 from peppy/c-sharp-10
  Dean Herbert · 2022-06-25 12:03:29 +09:00
  f15698d025
• Revert downgrades in code inspection settings
  Bartłomiej Dach · 2022-06-24 16:43:57 +02:00
  e0c2228b41
• Fix compile failures from framework breaking change
  Bartłomiej Dach · 2022-06-24 16:07:14 +02:00
  a83c45b50e
• Update framework again
  Bartłomiej Dach · 2022-06-24 16:01:52 +02:00
  df30bedab6
• Update framework
  Dean Herbert · 2022-06-24 21:28:30 +09:00
  14327943a2
• Update DotSettings to match framework (in most cases)
  Dean Herbert · 2022-06-24 21:28:24 +09:00
  81bfe14063
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Merge branch 'master' into c-sharp-10
  Dean Herbert · 2022-06-24 21:22:33 +09:00
  30eebf3511
• Merge pull request #18834 from bdach/ban-implicit-to-lower-upper

  Disallow usage of `string.To{Upper,Lower}()` without explicit culture

  Dean Herbert · 2022-06-24 20:39:58 +09:00
  2ca4184eda
• Merge pull request #18832 from peppy/bdc-remove-unused-path

  Remove unused bindable retrieval flow in `BeatmapDifficultyCache`

  Dan Balasescu · 2022-06-24 20:20:23 +09:00
  7eb49dac7a
• Merge pull request #18833 from peppy/beatmap-manager-misc

  Ensure `WorkingBeatmap` is always using a detached instance

  Bartłomiej Dach · 2022-06-24 13:06:09 +02:00
  a329b346a4
• Ensure WorkingBeatmap is always using a detached instance
  Dean Herbert · 2022-06-24 19:07:54 +09:00
  823b3c1c0f
• Rename incorrect parameter name in BeatmapManager.GetWorkingBeatmap
  Dean Herbert · 2022-06-24 19:07:54 +09:00
  2ae48d5a87
• Replace usages of string.To{Lower,Upper}()
  Bartłomiej Dach · 2022-06-24 11:57:45 +02:00
  26c5b59f6d
• Merge branch 'master' into bdc-remove-unused-path
  Dan Balasescu · 2022-06-24 17:55:56 +09:00
  e536256e3b
• Merge pull request #18819 from peppy/difficulty-icon-refactor-pass

  Refactor difficulty icons to not suck

  Dan Balasescu · 2022-06-24 17:50:50 +09:00
  c7e92f46f4
• Remove unused bindable retrieval flow
  Dean Herbert · 2022-06-24 17:09:56 +09:00
  c179127670
• Use AddOnce for update calls
  Dean Herbert · 2022-06-24 17:09:56 +09:00
  0755430006
• Fix dangerous File.Copy causing intermittent realm migration test failures

  Resolves an issue I've been able to locally reproduce on windows.
  Basically, the `File.Copy` would begin while realm was blocking. The
  "restore" operation is posted to the `SynchronizationContext` to run on
  next update call, but in the mean time the copy would begin, causing a
  conflict of interest.
  
  Very dangerous. Only really noticeable on windows.

  Dean Herbert · 2022-06-24 17:09:56 +09:00
  453b77e0dc
• Merge pull request #18831 from peppy/fix-failing-realm-migration-test

  Fix dangerous `File.Copy` causing intermittent realm migration test failures

  Dan Balasescu · 2022-06-24 17:05:22 +09:00
  6487cd674f
• Merge branch 'master' into difficulty-icon-refactor-pass
  Dean Herbert · 2022-06-24 16:34:35 +09:00
  8912f07745
• Fix dangerous File.Copy causing intermittent realm migration test failures

  Resolves an issue I've been able to locally reproduce on windows.
  Basically, the `File.Copy` would begin while realm was blocking. The
  "restore" operation is posted to the `SynchronizationContext` to run on
  next update call, but in the mean time the copy would begin, causing a
  conflict of interest.
  
  Very dangerous. Only really noticeable on windows.

  Dean Herbert · 2022-06-24 16:18:56 +09:00
  545c04aaf5
• Downgrade to v9 to support iOS toolchain
  Dean Herbert · 2022-06-24 14:58:22 +09:00
  224c23df77
• Remove unnecessary null casts
  Dean Herbert · 2022-06-24 14:50:11 +09:00
  f71f6302fd
• Update c# language version to 10
  Dean Herbert · 2022-06-24 14:48:32 +09:00
  f4173a3bff
• Nuke calculating everything

  The whole component is pointless so I'm just going to nuke for now I
  guess. Kind of makes the whole refactor effort pointless but oh well?
  
  To expand on this, the implementation was actually incorrect as pointed
  out at https://github.com/ppy/osu/pull/18819#pullrequestreview-1017886035.

  Dean Herbert · 2022-06-24 14:24:06 +09:00
  28837693e5
• Update retriever to be relatively sized
  Dean Herbert · 2022-06-24 14:06:31 +09:00
  12ea8369ee
• Use new property to specify no tooltip, rather than passing only ruleset
  Dean Herbert · 2022-06-24 14:06:18 +09:00
  d9c1a9d71f
• Remove unused parameters
  Dean Herbert · 2022-06-24 13:58:02 +09:00
  129c907092
• Merge pull request #18826 from frenzibyte/ignore-rule-typo
  Dean Herbert · 2022-06-24 11:03:45 +09:00
  2f86ad88ae
• Fix typo in auto-import ignore rule
  Salman Ahmed · 2022-06-24 04:58:27 +03:00
  eaae600a49
• Merge pull request #18818 from nekodex/rearrangeable-list-feedback

  Add audio feedback for rearranging list items

  Dean Herbert · 2022-06-23 23:30:55 +09:00
  730228ec2a
• Merge pull request #18820 from peppy/beatmap-difficulty-cache-cleanup

  Enable NRT and tidy up `BeatmapDifficultyCache`

  Dan Balasescu · 2022-06-23 23:23:17 +09:00
  55f1702448
• Don't play sample if there is no item being actively dragged
  Jamie Taylor · 2022-06-23 20:13:01 +09:00
  aaf619b35c
• Move collection change event binding to LoadComplete
  Jamie Taylor · 2022-06-23 20:04:54 +09:00
  9c46592e0e
• Move GetDifficultyRating helper method to StarDifficulty
  Dean Herbert · 2022-06-23 19:51:58 +09:00
  ef258122d2
• Enable NRT on BeatmapDiffiultyCache
  Dean Herbert · 2022-06-23 19:51:58 +09:00
  b068df2149
• Update resources
  Dean Herbert · 2022-06-23 19:51:44 +09:00
  32652ace75
• Tidy up all remaining usages
  Dean Herbert · 2022-06-23 19:27:35 +09:00
  01da6f20b3
• Split out simple DifficultyIcon with no calculation overhead and update usages
  Dean Herbert · 2022-06-23 19:27:35 +09:00
  7dec530ca5
• Remove unused ModeTypeInfo class
  Dean Herbert · 2022-06-23 19:27:35 +09:00
  4a2ca4394b
• Tidy up DifficultyIcon
  Dean Herbert · 2022-06-23 19:27:35 +09:00
  3a83e5684c
• Move DifficultyRetrieve to own class and split both pathways into separate constructors
  Dean Herbert · 2022-06-23 19:27:35 +09:00
  d6b073ebad
• Merge pull request #18817 from peppy/remove-room-null-check-more

  Remove remaining `Room != null` checks in `TestMultiplayerClient` where possible

  Dean Herbert · 2022-06-23 18:27:05 +09:00
  777ac98599
• Add audio feedback for rearranging list items
  Jamie Taylor · 2022-06-23 17:45:42 +09:00
  4a316fad2f
• Remove remaining Room!=null checks in TestMultiplayerClient where possible
  Dean Herbert · 2022-06-23 17:38:34 +09:00
  158f0a1f23
• Merge pull request #18816 from peppy/avoid-waiting-forever

  Ban usage of `ManualResetEventSlim.Wait()` without a timeout value

  Dan Balasescu · 2022-06-23 17:26:26 +09:00
  9ed37621a7
• Merge pull request #18815 from peppy/remove-room-null-check-change-state

  Remove room null assertion in `TestMultiplayerClient.ChangeState` to avoid assert

  Dan Balasescu · 2022-06-23 16:55:58 +09:00
  ac91c9de7d