76132 Commits

This Branch

This Branch

All Branches

• Show vote count in tag tooltip
  Dan Balasescu · 2025-12-29 17:47:35 +09:00
  2e324fe856
• Fix code style
  Dan Balasescu · 2025-12-29 17:37:57 +09:00
  e34d266987
• Fix panel depth
  Dan Balasescu · 2025-12-29 17:29:21 +09:00
  a6e1713514
• Adjust metrics
  Dan Balasescu · 2025-12-29 17:29:21 +09:00
  10ebb5286f
• Add top tag and difficulty attributes
  Dan Balasescu · 2025-12-29 16:20:14 +09:00
  69fee16eee
• Move top user tags enumeration to helper
  Dan Balasescu · 2025-12-29 15:43:43 +09:00
  60d9c358b8
• Merge pull request #36140 from nbvdkamp/add-fps-settings-keywords

  Add keywords to FPS related settings

  Dean Herbert · 2025-12-27 23:11:58 +09:00
  ef3338ba93
• Add keywords to FPS related settings
  Nathan van der Kamp · 2025-12-27 00:29:25 +01:00
  99b00ab72f
• Revert "Merge pull request #36102 from bdach/move-check-to-better-place"

  This reverts commit 2cb2167765, reversing
  changes made to 0bcb3c5839.

  Dean Herbert · 2025-12-26 22:36:16 +09:00
  56ef5eae14
• Merge pull request #36102 from bdach/move-check-to-better-place

  Perform online ID checks during import in more proper sequence

  Dean Herbert · 2025-12-26 22:35:02 +09:00
  2cb2167765
• Merge pull request #36103 from bdach/form-sample-set

  Implement form control for adding/removing custom samples in editor

  Dean Herbert · 2025-12-25 15:11:33 +09:00
  0bcb3c5839
• Merge pull request #36116 from frenzibyte/new-settings/form-visuals

  Prepare form controls for use in settings

  Dean Herbert · 2025-12-25 03:16:12 +09:00
  2acc2a84db
• Merge pull request #36118 from bdach/zip-magic
  Dean Herbert · 2025-12-25 02:29:18 +09:00
  64d16776be
• Merge pull request #36121 from smoogipoo/mp-fix-availability-tracker

  Fix potentially incorrect online play beatmap availability

  Dean Herbert · 2025-12-24 20:32:46 +09:00
  2d06c2b1a6
• Reduce code duplication

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2025-12-24 19:30:04 +09:00
  81f03957d8
• Fix tests
  Dan Balasescu · 2025-12-24 16:53:08 +09:00
  ecaf3e05d4
• Fix tournament screens not having colour provider cached
  Salman Alshamrani · 2025-12-24 02:22:59 -05:00
  2d85fe8133
• Fix potentially incorrect online play beatmap availability
  Dan Balasescu · 2025-12-24 15:08:37 +09:00
  0af07b97c5
• Adjust naming
  Dean Herbert · 2025-12-24 14:57:17 +09:00
  03f44705b3
• Update switch button visuals
  Salman Alshamrani · 2025-12-23 20:18:59 -05:00
  033a73e969
• Merge pull request #36101 from bdach/guest-difficulty-export

  Add explicit menu item for exporting guest difficulties from editor

  Dean Herbert · 2025-12-24 00:45:19 +09:00
  1340e18d93
• Make setter protected to fix build error
  Salman Alshamrani · 2025-12-23 06:31:26 -05:00
  95cf050298
• Expose constant for max decimal digits display
  Salman Alshamrani · 2025-12-23 06:14:48 -05:00
  fa32be37d6
• Seal tooltip text overrides
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  e4d7bc3896
• Add explanatory note
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  520baf6c50
• Revert unintended change
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  a1d4d44151
• Fix tests not having colour providers
  Salman Alshamrani · 2025-12-23 05:58:57 -05:00
  a3a5b2ca92
• Make sound playback consistent across all disabled controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  cb32d2da3e
• Add label and tooltip formatting to form sliders
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  4ee7e6f787
• Add right margin to form dropdown chevron
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  c2c1fa4d4c
• Use switch button for form checkbox controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  339aad42a7
• Update "disabled" visual feedback of form controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  a2872ee870
• Add extra form controls in test scene
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  c6a8d9a150
• Merge pull request #36081 from bdach/esdfiopj

  Fix cursor scale affecting trail spacing

  Dean Herbert · 2025-12-23 19:48:34 +09:00
  6eec2b0ff8
• Merge pull request #36047 from bdach/reveal-other-difficulties-thing

  Add ability to view other beatmaps in set when difficulties are split apart

  Dean Herbert · 2025-12-23 19:43:47 +09:00
  0999e3f048
• Merge pull request #36056 from peppy/fix-stacking-woes

  Fix osu! stacking not matching stable in very specific edge cases

  Bartłomiej Dach · 2025-12-23 08:45:40 +01:00
  71386fe465
• Use sane initial value for cursor scale to avoid infinite loops
  Bartłomiej Dach · 2025-12-23 08:43:07 +01:00
  f58e4e4862
• Replace spread operator usage with manual linq

  `dotnet format` expects me to put a space between the spread `..` and
  the expression after which is UTTERLY STUPID AND UGLY AND WRONG AND
  CANNOT BE `.editorconfig`'d BECAUSE [INSERT EXCESSIVELY LONG BLEEP].
  
  God I hate when good features are kneecapped by this sort of stupidity.

  Bartłomiej Dach · 2025-12-23 08:35:20 +01:00
  0bebabba94
• Fix replay files potentially getting misclassified as zip archives

  Resolves https://github.com/ppy/osu/discussions/36107.
  
  The replay linked in the aforementioned discussion happens to contain
  the magic sequence for ZIP headers in the binary stream (50 4b 05 06)
  which led to it getting classified as a ZIP with no entries and
  completely bogus everything in the header at
  
  	https://github.com/ppy/osu/blob/c8b18acd4dd1d98170a069240b6666cea3d5da07/osu.Game/Database/ImportTask.cs#L51-L56
  
  and then finally dying of
  
  	2025-12-23 07:26:45 [error]: [?????] Model creation of replay-osu_2040232_4828629841.osr failed.
  	2025-12-23 07:26:45 [error]: System.InvalidOperationException: Sequence contains no matching element
  	2025-12-23 07:26:45 [error]: at System.Linq.ThrowHelper.ThrowNoMatchException()
  	2025-12-23 07:26:45 [error]: at System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
  	2025-12-23 07:26:45 [error]: at osu.Game.Scoring.ScoreImporter.CreateModel(ArchiveReader archive, ImportParameters parameters)
  	2025-12-23 07:26:45 [error]: at osu.Game.Database.RealmArchiveModelImporter`1.importFromArchive(ArchiveReader archive, ImportParameters parameters, CancellationToken cancellationToken)
  
  at
  
  	https://github.com/ppy/osu/blob/554961036e23615b35eb6b66b341b10924664c4d/osu.Game/Scoring/ScoreImporter.cs#L46

  Bartłomiej Dach · 2025-12-23 08:23:23 +01:00
  95233fc638
• Merge branch 'master' into esdfiopj
  Dean Herbert · 2025-12-23 02:33:08 +09:00
  2ed37ecbbc
• Merge pull request #36080 from bdach/form-slider-bar-disabled

  Fix disabled form slider bars being half-baked

  Dean Herbert · 2025-12-23 02:26:34 +09:00
  554961036e
• Merge branch 'master' into form-slider-bar-disabled
  Dean Herbert · 2025-12-22 23:44:33 +09:00
  dbcc7cc09d
• Merge pull request #36055 from frenzibyte/new-settings/item

  Implement new settings item component

  Dean Herbert · 2025-12-22 22:55:53 +09:00
  d9dad4c3a8
• Adjust colour of inactive slider bar
  Dean Herbert · 2025-12-22 22:06:39 +09:00
  0787345a84
• Implement form control for adding/removing custom samples in editor

  The test scene doesn't exercise the custom sample playback, but I hope I
  can be forgiven for this as setting up a custom editor beatmap just for
  this to work is rather cumbersome.

  Bartłomiej Dach · 2025-12-22 13:48:31 +01:00
  9d07ad2761
• Fix test
  Bartłomiej Dach · 2025-12-22 12:48:53 +01:00
  1ab922af12
• Only perform replace-on-import based on online beatmap set ID after it's validated

  Even without the ID resetting logic before `Populate()` getting broken
  and annotated with a TODO, this was kinda stupid. Why was purging logic
  allowed to run *using a not-yet-completely-validated online ID of the
  set*?
  
  This is the other part of hopefully fixing scenarios like
  https://osu.ppy.sh/community/forums/topics/2162457?n=8 (hopefully with
  no babies poured out in the mean time, but only time will tell).

  Bartłomiej Dach · 2025-12-22 12:27:29 +01:00
  44df9047ae
• Move online ID validation check into its proper location

  The end of `Populate()` is too early to do any validation of online IDs,
  as population happens in `PostImport()` via `ProcessBeatmap`.
  
  Additionally, this modifies the check to also include the set's ID. This
  is one part of curtailing issues like
  https://osu.ppy.sh/community/forums/topics/2162457?n=8 - the featured
  artist template beatmap in question has a single difficulty with a bogus
  positive beatmap set ID and a beatmap ID of 0, and my opinion is that
  this sort of situation should for all intents and purposes cause the
  beatmap set's ID to be reset.

  Bartłomiej Dach · 2025-12-22 12:22:04 +01:00
  17143ca0a8
• Add explicit menu item for exporting guest difficulties from editor

  A few facts of life:
  
  - Guest difficulties are at this point a staple of mapping.
  
  - People are very much used to flinging `.osu`s around (because there's
    no better alternative).
  
  - Currently there are two ways to get an `.osu` out of lazer. You can:
  
    - Export the beatmap as "compatibility" to an `.osz`, then
      transmogrify the `.osz` to a `.zip`, then extract the `.zip`, then
      pluck out the `.osu`. This is the "correct" way to make sure stable
      works, but is also stupidly arcane.
  
    - Use "edit externally" to mount the beatmap files to disk, then
      copy-paste out the `.osu`. This is the *wrong* way to make sure
      stable works, because the mounting process exposes the raw "for
      editing" format with features stable doesn't support, but it the
      actual easy one.
  
  - Reports about guest difficulties exported from lazer "working wrong on
    stable" are prevalent. Probably mostly because of the preceding point.
  
  What this PR does is introduce a *third* method to export an `.osu`,
  which is designed to be both the easiest one yet *and* correct. I am
  hoping this will curb the complaints until support for direct submission
  of guest difficulties is added - which I still hope to see, but it will
  be a significant effort *client-side* (the server side has been ready
  for years now).
  
  And yes, you will notice that much of the code added in
  `LegacyBeatmapExporter` related to manipulation of the path is
  copy-pasted from `LegacyExporter`. I don't care enough to invent
  protected / abstract / whatever else OOP faff for something that may not
  survive review and is mostly a weird semi-temporary wart.

  Bartłomiej Dach · 2025-12-22 11:36:23 +01:00
  3712093158
• Move disable to better place
  Bartłomiej Dach · 2025-12-22 10:04:29 +01:00
  df524d68fd