1822 Commits

• Fix dodgy threading

  The fact that the stuff "just worked" previously due to one load-bearing
  detach in a random location is really scary because a lot of this was
  just not written the way it is supposed to be.

  Bartłomiej Dach · 2025-06-30 14:17:27 +02:00
  2e0e7ff3c2
• Use better method of disallowing skin changes during external edit
  Bartłomiej Dach · 2025-06-30 14:17:27 +02:00
  b82bf228ab
• Merge branch 'master' into skin-mounting
  Bartłomiej Dach · 2025-06-30 12:53:55 +02:00
  368850967b
• Remove unnecessary skin settings descriptions
  Salman Alshamrani · 2025-06-30 12:00:21 +03:00
  2b92b59504
• Fix beatmap skin sample lookups falling back to non-custom sample banks if the custom sample bank sample was not found

  Closes https://github.com/ppy/osu/issues/33900. I think. Stable's sample
  lookup logic is horrible.
  
  The user in the issue claimed they were hearing `drum-hitfinish2`, but
  they were really hearing `drum-hitfinish`, because they're the same
  `.wav` file in the beatmap. Now the reason *why* they were hearind
  `drum-hitfinish` is that the sample control point was specifying
  something like:
  
  	23946,-200,4,2,4,40,0,0
  
  To decipher, this is:
  - default sample bank of soft
  - custom sample bank of 4
  
  Taking one of the objects affected, namely 00:23:946 (2) - that's a
  slider with finish addition and drum addition bank on the slider head.
  The slider head is thus attempting to play `soft-hitnormal4` and
  `drum-hitfinish4`.
  
  Neither `soft-hitnormal4` or `soft-hitnormal` exist in the beatmap, so
  that plays fine via falling back to user skin's `soft-hitnormal`, but
  `drum-hitfinish4` ends up falling back to `drum-hitfinish` which *does*
  exist in the beatmap skin and thus plays wrongly from the beatmap skin
  rather than the user skin.
  
  I have no idea how to ensure this is correct across every beatmap and
  skin out there so my approach is to just spray and pray (and rely on
  issue reports I guess). I *think* this matches the stable logic which is
  nestled within
  https://github.com/peppy/osu-stable-reference/blob/a5e5fe6ef240505d13526cf32783cad261e9bd8b/osu!/Audio/AudioEngine.cs#L1136-L1230
  but honestly if you put a gun to my head I couldn't be sure if it
  matches completely in every possible circumstance or not.

  Bartłomiej Dach · 2025-06-27 13:00:50 +02:00
  c7cd3a9842
• Remove pointless tooltip

  I agree that these are pointless and we should probably remove the
  others and stop wasting localiser's time on these.

  Dean Herbert · 2025-06-27 17:09:29 +09:00
  5485abd3a5
• Support changing weight in text-based elements
  Salman Alshamrani · 2025-06-26 07:36:11 +03:00
  fa508245a1
• Add support for rank change SFX to LegacyRankDisplay and debouncing
  Jamie Taylor · 2025-06-12 14:42:29 +09:00
  b729091244
• Fix abhorrently incorrect bindable usage
  Dean Herbert · 2025-05-31 00:41:28 +09:00
  43b7171f5c
• Make BeatmapDifficultyCache's returned bindable non-nullable
  Dean Herbert · 2025-05-25 22:27:37 +09:00
  6500be3f2d
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-05-07 10:45:51 +02:00
  5b61761bbd
• Clarify purpose of helper lookup entries in osu!mania skinning
  Salman Alshamrani · 2025-05-01 06:30:32 +03:00
  3151fe7ef1
• Make column spacing lookups easy to use
  Salman Alshamrani · 2025-04-30 03:59:41 +03:00
  d63f9533b1
• Fix TriangleSkin not always returning a container for GlobalSkinnableContainerLookup

  We have other safeties which mean that this is not an issue during
  gameplay, but in the new `TestSceneHUDOverlayRulesetLayouts` it became
  apparent that allowing this to fallback (via `null` return) could lead
  to weirdness.

  Dean Herbert · 2025-04-26 05:14:36 +09:00
  54e0e1420f
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Fix incorrect sizing of legacy health display "ki" markers

  Closes https://github.com/ppy/osu/issues/32724.

  Dean Herbert · 2025-04-08 13:52:07 +09:00
  6d833939ae
• Disable user customisation of spectator list font / colour

  It's all a bit weird so let's just disable it for now. For instance,
  this is exposed as "text" font / colour but only affects the header.
  Also, no other headers are cusotmisable in similar components.

  Dean Herbert · 2025-03-10 15:19:34 +09:00
  3cb32c38ad
• Add support for legacy osu!mania barline height and colour spec
  Dean Herbert · 2025-02-28 15:13:13 +09:00
  cb29459a1e
• Merge pull request #31527 from bdach/spectator-list-ready

  Show spectating users during gameplay

  Dan Balasescu · 2025-01-21 18:54:11 +09:00
  8f8246278a
• Fix one more new inspection in EAP 2025
  Dean Herbert · 2025-01-20 15:00:35 +09:00
  525e16ad1d
• Merge spectator list classes into one skinnable
  Bartłomiej Dach · 2025-01-17 11:23:14 +01:00
  3c4bfc0a01
• Add skinnable spectator list to default skins
  Bartłomiej Dach · 2025-01-15 14:29:53 +01:00
  99c7e164dc
• Add FormatStarRating() method util
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  e95dc2b308
• Merge branch 'master' into skin-mounting
  Bartłomiej Dach · 2024-12-12 12:16:22 +09:00
  09d55ed306
• Rename SkinInfo when it is changed in skin.ini

  Peppy spoke about using a shortcut and/or hashes to determine if the
  skin.ini is changed, and if so, then to rename the skin.
  
  In my opinion, hashing and doing numerous comparisons is probably less
  efficient than just syncing the SkinInfo's name during the update.
  
  This is an easy solution that does what it needs to.

  smallketchup82 · 2024-12-11 10:19:10 -05:00
  165afe357f
• Merge branch 'master'
  Huo Yaoyuan · 2024-11-30 01:07:08 +08:00
  fa3c95c296
• Centralise supported file extensions to one helper class

  As proposed in
  https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

  Bartłomiej Dach · 2024-11-29 08:42:45 +01:00
  110e4fbb30
• Apply minor performance rules
  Huo Yaoyuan · 2024-11-28 20:41:44 +08:00
  f5a7716509
• Use consistent decimal places in BeatmapAttributeText
  Cadence Ember · 2024-11-21 14:04:42 +13:00
  37394a5027
• Round to integral units

  The rounding matches the implementation of `PerformancePointsCounter`.

  Dan Balasescu · 2024-11-01 22:43:52 +09:00
  ef22b6b1a8
• Merge branch 'master' into bat-max-performance
  Bartłomiej Dach · 2024-11-01 13:13:20 +01:00
  3dc2408965
• Merge branch 'master' into bat-mods
  Bartłomiej Dach · 2024-11-01 11:27:06 +01:00
  1b5d1347aa
• Add missing disposal
  Bartłomiej Dach · 2024-11-01 11:26:59 +01:00
  5f63950598
• Fix old looping samples not stopping when replacing a SkinnableSound's Samples

  Closes https://github.com/ppy/osu/issues/30365.

  Bartłomiej Dach · 2024-10-22 14:35:21 +02:00
  1008d32ddb
• Merge branch 'master' into bat-mods
  Dan Balasescu · 2024-10-18 18:58:45 +09:00
  def499e7cb
• Return empty strings rather than erroring

  Preventing malicious actors from permanently destroying games via skins.

  Dan Balasescu · 2024-10-18 17:18:01 +09:00
  e27aa0c761
• Only add as many values as are replaced
  Dan Balasescu · 2024-10-18 17:16:42 +09:00
  2de5e3392e
• Use better exception messaging
  Bartłomiej Dach · 2024-10-18 08:51:01 +02:00
  8804769da1
• Discard unused argument
  Bartłomiej Dach · 2024-10-18 08:39:23 +02:00
  b455b9ad09
• Use stored difficulty to reduce flickering
  Dan Balasescu · 2024-10-17 20:39:50 +09:00
  0473f0b60a
• Merge branch 'bat-mods' into bat-max-performance
  Dan Balasescu · 2024-10-17 20:38:29 +09:00
  2ce1475303
• Store difficulty to reduce flickering

  The computation usually finishes in a few milliseconds anyway.

  Dan Balasescu · 2024-10-17 20:37:37 +09:00
  b40c31af3a
• Add max performance beatmap attribute text
  Dan Balasescu · 2024-10-17 20:00:18 +09:00
  6749768b9e
• Also bind to mod setting changes
  Dan Balasescu · 2024-10-17 17:57:49 +09:00
  f9a9ceb41c
• Show bpm and length inclusive of mods
  Dan Balasescu · 2024-10-17 17:57:49 +09:00
  9ea15a3961
• Show difficulty values inclusive of mods
  Dan Balasescu · 2024-10-17 17:57:49 +09:00
  400142545d
• Show star difficulty attribute inclusive of mods
  Dan Balasescu · 2024-10-17 17:57:49 +09:00
  1e2c1323ff
• Refactor BeatmapAttributeText to compute values on the fly
  Dan Balasescu · 2024-10-17 16:10:06 +09:00
  102f55a213
• Remove a comment
  smallketchup82 · 2024-10-12 17:15:48 -04:00
  3d16e45d79
• Revert "Add a toggle for checking overwriting"

  This reverts commit b7883f18be.

  smallketchup82 · 2024-10-11 16:15:57 -04:00
  0dc77a70e1