Dean Herbert
a912d86dc9
Merge pull request #29710 from bdach/silence-favourite-button-errors
...
Silence beatmap retrieval failures from results screen favourite button
2024-09-06 18:08:32 +09:00
Dan Balasescu
6913d75792
Add 'yes'/'no' acronyms to the played= filter
2024-09-06 18:04:39 +09:00
Bartłomiej Dach
9f834ca1a2
Silence beatmap retrieval failures from results screen favourite button
...
As reported (very poorly) in
https://github.com/ppy/osu/pull/28991#issuecomment-2331854970 .
I believe this is a total edge case and is mostly visible on dev due to
some beatmaps existing on `osu.ppy.sh` and not on `dev.ppy.sh`, but I
tend to agree in general that these types of failures should not be
firing very loud error notifications; logging to network and disabling
the button with a tooltip adjustment should be enough.
2024-09-06 10:29:23 +02:00
Bartłomiej Dach
925710d9b3
Merge pull request #29702 from peppy/fix-offset-control-wrong-order
...
Fix beatmap offset control not working correctly when calibrating from quitting gameplay
2024-09-06 09:39:14 +02:00
Dean Herbert
36a30cf077
Add note about using hard links in the future
2024-09-06 16:01:47 +09:00
Dean Herbert
96042349ac
Merge pull request #29707 from Sheppsu/replay-analysis-marker-depth
...
Fix replay analysis marker depth when rewinding
2024-09-06 12:03:35 +09:00
Sheppsu
e94e08fec3
fix marker depth when rewinding
2024-09-05 20:14:36 -04:00
Fabep
584d4a9abf
Merge branch 'master' into ModCustomisationHeaderColor
2024-09-05 12:44:26 +02:00
Dean Herbert
9802b59459
Merge pull request #29693 from bdach/editor/setup-screen-textbox
...
Implement "form" text box control
2024-09-05 19:31:02 +09:00
Dean Herbert
37f61b26ea
Fix offset adjust control not correctly applying changes after song select quit
...
This is an interesting scenario where we arrive at a fresh
`BeatmapOffsetControl` but with a reference score (from the last play).
Our best assumption here is that the beatmap's offset hasn't changed
since the last play, so we want to use it for the `lastPlayBeatmapOffset`.
But due to unfortunate order of execution, `Current.Value` was not yet
initialised.
2024-09-05 19:04:52 +09:00
Dean Herbert
791ce218fc
Add test coverage of beatmap offset edge case failure
2024-09-05 19:04:52 +09:00
Dean Herbert
c51503cfee
Merge pull request #29695 from peppy/fail-t-request-on-null-response
...
Trigger request failure on receiving a null response for a typed `APIRequest`
2024-09-05 18:31:54 +09:00
Bartłomiej Dach
3a3a912ebc
Merge pull request #29701 from peppy/fix-gc-fuck-fuck-fuck
...
Fix high performance session potentially getting stuck after multiplayer spectator
2024-09-05 11:24:54 +02:00
Bartłomiej Dach
49b14ad579
Merge branch 'master' into editor/setup-screen-textbox
2024-09-05 11:22:10 +02:00
Bartłomiej Dach
e1b763ff0d
Apply review suggestions wrt border appearance
2024-09-05 11:21:59 +02:00
Dean Herbert
446c8109b7
Merge pull request #27334 from Sheppsu/replay-analysis-settings
...
Add a replay analysis overlay
2024-09-05 17:43:00 +09:00
Dean Herbert
86a06c7e10
Fix high performance session potentially getting stuck after multiplayer spectator
2024-09-05 17:19:53 +09:00
Bartłomiej Dach
b9ddac4201
Fix test failures
2024-09-05 09:45:37 +02:00
Bartłomiej Dach
7136483f85
Fix nullability inspections
2024-09-05 09:45:34 +02:00
Dean Herbert
167e3a3377
Make loading asynchronous
2024-09-05 16:25:08 +09:00
Dean Herbert
a1cf67be62
Add setting to adjust replay analysis display length
2024-09-05 15:53:53 +09:00
Dean Herbert
0f01a855af
Add note about cursor hiding being potentially flaky
2024-09-05 15:30:42 +09:00
Dean Herbert
47a9b345eb
Rename config variables and setting strings
2024-09-05 15:15:15 +09:00
Dean Herbert
7983a765ab
Update test scene to show more button holds (including both buttons sometimes)
2024-09-05 15:12:53 +09:00
Dean Herbert
7390d89c75
Switch to using CircularProgress for more consistent sizing
...
Also show both mouse buttons at once on frame markers.
2024-09-05 15:12:53 +09:00
Dean Herbert
4f719b9fec
One more rename pass
2024-09-05 14:28:20 +09:00
Dean Herbert
2d198e57e1
Second visual design pass
2024-09-05 14:17:53 +09:00
Dean Herbert
ee26ff2e29
Add out-of-bounds tests to test case
2024-09-05 13:07:49 +09:00
Dean Herbert
08ebc83a89
Fix path getting misaligned with negative position values
2024-09-05 12:14:24 +09:00
Dean Herbert
21146c3501
Add back shadow cast
2024-09-05 12:08:49 +09:00
Dean Herbert
a6ed719454
Visual design pass
2024-09-05 12:08:49 +09:00
Dean Herbert
a4a37c5ba6
Simplify lifetime entries and stuff
2024-09-05 12:08:49 +09:00
Dean Herbert
7f9a98a7aa
More renames
2024-09-05 12:08:48 +09:00
Dean Herbert
dcb463acaf
Split out classes and avoid weird configuration stuff
2024-09-05 12:08:48 +09:00
Dean Herbert
6fc60908c0
Trigger request failure on receiving a null response for a typed APIRequest
2024-09-05 01:00:23 +09:00
Fabep
17760afa60
Changed ModCustomisationHeader to inherit from OsuClickableContainer.
...
ModCustomisationHeader changes color depending on state.
2024-09-04 15:29:48 +02:00
Bartłomiej Dach
b7a56c8a45
Implement "form" text box control
2024-09-04 14:09:50 +02:00
Dean Herbert
6a309725ed
Make test more usable
2024-09-04 19:50:45 +09:00
Dean Herbert
abd74ab41c
Add note about being able to apply a newer update during runtime
2024-09-04 19:41:40 +09:00
Bartłomiej Dach
6f99d839b0
Make struct readonly
2024-09-04 12:41:02 +02:00
Dean Herbert
0e85110ee2
Merge pull request #29690 from peppy/update-framework
...
Update framework
2024-09-04 19:39:47 +09:00
Dean Herbert
ca09028b06
Merge pull request #29616 from peppy/break-overlay-animation
...
Add beat-synced animation to break overlay
2024-09-04 19:39:35 +09:00
Dean Herbert
6c07b873af
Isolate configuration container from analysis overlay
2024-09-04 19:37:36 +09:00
Bartłomiej Dach
130802e480
Add hotkey hints to editor menus
2024-09-04 12:16:54 +02:00
Bartłomiej Dach
0c4f5bcdaa
Decouple editor main menu items from DrawableOsuMenuItem
...
It didn't ever really make sense for it to be sharing the implementation
details of that (e.g. colouring of primary/dangerous actions), and with
the hotkey display things got outright hacky, so I'm decoupling it
entirely.
2024-09-04 12:16:52 +02:00
Dean Herbert
9b81deb3ac
Fix settings not working if ReplayPlayer is not available
2024-09-04 19:09:23 +09:00
Dean Herbert
cc3d220f6f
Allow settings to be added to replay HUD from ruleset
2024-09-04 19:00:23 +09:00
Dean Herbert
992a0da957
Rename classes slightly
2024-09-04 19:00:22 +09:00
Dean Herbert
a417fec234
Move analysis container implementation completely local to osu! ruleset
2024-09-04 19:00:22 +09:00
Bartłomiej Dach
3acc5fe5a0
Integrate hotkey display into drawable menu items
2024-09-04 11:58:10 +02:00
