h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 14:52:56 +08:00
Code Issues Releases Wiki Activity
66,635 Commits 3 Branches 661 Tags 357 MiB
2a3ae6bce1
Commit Graph

66635 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Arthur Araujo
9e92ebaa43
Make message more general 
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
 2024-04-03 19:15:22 -03:00
Dean Herbert
2f64c16088
Merge pull request #27784 from bdach/double-skip-yet-again 
Fix some maps requiring multiple intro skips that weren't there on stable
 2024-04-04 04:14:03 +08:00
Arthur Araujo
8e00368f7c Add custom message in the case of a invalid beatmap_hash 2024-04-03 11:30:14 -03:00
Bartłomiej Dach
9d54f1a092
Fix some maps requiring multiple intro skips that weren't there on stable 
Closes https://github.com/ppy/osu/issues/25633.

The reason why that particular beatmap did not have a double skip
on stable is here:

    e53980dd76/osu!/GameModes/Play/Player.cs#L1761-L1770

The particular place of interest is the `leadInTime < 10000` check.
If `leadInTime < 10000`, then `leadIn == leadInTime`, and it turns out
that `AudioEngine.Time` will always be more than or equal to `leadIn`,
because it's also the gameplay start time:

    e53980dd76/osu!/GameModes/Play/Player.cs#L2765

This essentially means that if the `leadInTime` is less than 10000,
that particular check is just dead. So a double skip can only occur
if the gameplay starts at time -10000 or earlier due to the storyboard.
 2024-04-03 16:12:20 +02:00
Bartłomiej Dach
524a5815bc
Add test coverage 2024-04-03 16:11:40 +02:00
Bartłomiej Dach
ca525f6a91
Merge pull request #27779 from smoogipoo/fix-skineditor-external-event-bind 
Fix SkinEditor binding event to external bindable
 2024-04-03 12:05:41 +02:00
Bartłomiej Dach
6d6412afdf
Merge branch 'master' into fix-skineditor-external-event-bind 2024-04-03 11:42:15 +02:00
Bartłomiej Dach
05fe8968d8
Only interact with clipboard via bound copy 2024-04-03 11:39:12 +02:00
Bartłomiej Dach
3b7d427c52
Merge pull request #27778 from smoogipoo/fix-spectator-player-rentention 
Fix SpectatorClient holding references to Player
 2024-04-03 11:30:34 +02:00
Dan Balasescu
ce68f6adb7
Fix SkinEditor binding event to external bindable 2024-04-03 17:46:26 +09:00
Dan Balasescu
b5adcf2e0e
Fix SpectatorClient holding references to Player 2024-04-03 17:32:02 +09:00
Bartłomiej Dach
fd9b890a94
Merge pull request #27747 from smoogipoo/mania-key-count-mod-query 
Consider keymods in beatmap filtering + panel display
 2024-04-03 09:49:35 +02:00
Bartłomiej Dach
cb82fb0487
Merge branch 'master' into mania-key-count-mod-query 2024-04-03 09:29:32 +02:00
Dean Herbert
94cbe1838f
Replace usages of is null with == null 2024-04-03 01:50:39 +08:00
Dean Herbert
aa7b357063
Merge pull request #27768 from 64ArthurAraujo/editor-fix-sliders-same-start-time-merge 
Fix merging sliders with the same `StartTime` causing a Unhandled Exception
 2024-04-03 01:45:55 +08:00
Arthur Araujo
9315aefe41 Fix remove additional blank line 2024-04-02 08:48:01 -03:00
Arthur Araujo
2a2a372595 Check if blueprint is in SelectionBlueprints before changing its depth 2024-04-02 07:45:27 -03:00
Dean Herbert
51e9348d27
Merge pull request #26702 from honguyenminh/fix-rotate-editor-button-disabled 
Fix rotate tool button in editor disabled when selecting 1 circle
 2024-04-02 14:31:43 +08:00
Nguyên Minh Hồ
6642702fa9
Update plurals in editor rotate button tooltip 
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
 2024-04-02 12:36:44 +07:00
Dean Herbert
eca242c1c7
Change tooltip text slightly 2024-04-02 13:17:16 +08:00
Dean Herbert
ed5dd5c8cd
Bind using local bindables to avoid potentially event pollution 2024-04-02 13:04:34 +08:00
Dan Balasescu
4806ea54f1
Only optimise Catmull segments in osu ruleset 2024-04-01 17:22:50 +09:00
Dan Balasescu
8e0ca11d1c
Fully qualify LegacyBeatmapConversionDifficultyInfo 2024-04-01 17:02:32 +09:00
Dan Balasescu
d12a2e7df7
Replace schedule with SequenceEqual() 2024-04-01 17:02:02 +09:00
Dean Herbert
95b50576bd
Merge pull request #27698 from bdach/banish-rulesets-that-do-stupid-crap-to-the-BLAGOLE 
Attempt to disable custom rulesets that can be linked to an unhandled crash
 2024-04-01 15:47:47 +08:00
Dan Balasescu
8160ffa353
Merge pull request #27761 from 64ArthurAraujo/editor-fix-control-points-update-on-stacking 
Update Slider path control points and connections after stacking application
 2024-04-01 16:17:51 +09:00
Dan Balasescu
099ad22a92
Use local bindable instead 
Binding events directly to an external bindable will cause that
bindable to hold a permanent reference to the current object.

We use `GetBoundCopy()` or otherwise a local bindable + `.BindTo()` to create a
weak-referenced copy of the target bindable. When the local bindable's
lifetime expires, so does the external bindable's reference to it.
 2024-04-01 15:31:35 +09:00
Dan Balasescu
7615c71efe
Fix inspection 2024-04-01 15:28:20 +09:00
Arthur Araujo
19f0caa0f3 Fix wrong formatting in array creation 2024-03-31 13:39:19 -03:00
Nguyên Minh Hồ
1adba68357 Merge branch 'fix-rotate-editor-button-disabled' of https://github.com/honguyenminh/osu into fix-rotate-editor-button-disabled 2024-03-31 16:00:58 +07:00
Nguyên Minh Hồ
86def7e263
Change editor rotate button disabled tooltip text 
Co-authored-by: Dean Herbert <pe@ppy.sh>
 2024-03-31 16:00:47 +07:00
Dean Herbert
c17ce3362b
Merge pull request #27760 from EVAST9919/better-break-arrows 
Fix break overlay arrows look ugly on bright backgrounds
 2024-03-31 10:24:32 +08:00
Arthur Araujo
450e7016bc Bind StackHeight changes to visual update methods 2024-03-30 21:23:05 -03:00
Andrei Zavatski
11b1135804 Adjust blurred icons position due to size handling differences 2024-03-31 01:55:34 +03:00
Andrei Zavatski
58a68e94af Simplify glowing icons in break overlay 2024-03-31 01:44:54 +03:00
Andrei Zavatski
54472e6452 Decouple GlowingDrawable from GlowingSpriteText 2024-03-31 01:44:54 +03:00
Nguyên Minh Hồ
b445e27ad6 Aggregate two CanRotate bindable for enabling the Rotate button 2024-03-30 17:54:27 +07:00
Nguyên Minh Hồ
6f782266b5 Fix inspection 2024-03-30 17:28:57 +07:00
Nguyên Minh Hồ
5d497ba4a8 Simplify TooltipText for EditorRadioButton 2024-03-30 16:04:22 +07:00
Nguyên Minh Hồ
8d6358a138 Fix editor rotation allowing spinner only bug 2024-03-30 16:02:31 +07:00
Nguyên Minh Hồ
9950395e5f Merge branch 'fix-rotate-editor-button-disabled' of https://github.com/honguyenminh/osu into fix-rotate-editor-button-disabled 2024-03-30 13:57:44 +07:00
Nguyên Minh Hồ
113dbcd10f
Merge branch 'master' into fix-rotate-editor-button-disabled 2024-03-30 13:56:31 +07:00
Salman Ahmed
93f1578c10
Merge pull request #27758 from peppy/fix-mascot-size 
Fix taiko mascot size not matching stable
 2024-03-29 23:53:24 +03:00
Salman Ahmed
51f79c33e1 Fix URL pointing to non-existent commit 2024-03-29 23:33:06 +03:00
Dean Herbert
c21805589e
Fix taiko mascot size not matching stable 2024-03-29 22:40:04 +08:00
Dan Balasescu
48f8d9c916
Merge pull request #27756 from bdach/pp-on-results-provisional 
Apply partial fade on pp display on results screen when score will not give pp
 2024-03-29 19:57:59 +09:00
Bartłomiej Dach
5371141d3b
Merge pull request #27755 from peppy/fix-import-weirdness 
Avoid reporting an import as successful when all beatmaps failed to import
 2024-03-29 11:25:41 +01:00
Bartłomiej Dach
e06df34a1c
Apply partial fade on pp display on results screen when score will not give pp 2024-03-29 11:16:31 +01:00
Bartłomiej Dach
2d3b273974
Remove redundant string interpolation 2024-03-29 10:37:49 +01:00
Dean Herbert
df4a28db91
Fix failing test due to missing ruleset store 2024-03-29 17:32:20 +08:00