57203 Commits

This Branch

This Branch

All Branches

• Merge pull request #21386 from peppy/fix-editor-tap-timing-crash

  Fix crash when hitting 'T' to tap timing while no timing point is selected

  Bartłomiej Dach · 2022-11-23 18:40:13 +01:00
  224bf85e4a
• Merge branch 'master' into fix-editor-tap-timing-crash
  Bartłomiej Dach · 2022-11-23 17:51:50 +01:00
  60422be9af
• Merge pull request #21351 from peppy/limit-barline-generation-sanity

  Limit how far before the first hitobject that barlines can be generated

  Bartłomiej Dach · 2022-11-23 17:51:10 +01:00
  1ad9d66e65
• Protect offset and bpm adjustments from null selection too
  Bartłomiej Dach · 2022-11-23 17:25:43 +01:00
  30f9cc46a7
• Extend tap timing control test coverage in no point selected case
  Bartłomiej Dach · 2022-11-23 17:25:34 +01:00
  cf5f5a4de3
• Merge branch 'master' into limit-barline-generation-sanity
  Bartłomiej Dach · 2022-11-23 17:12:36 +01:00
  508f1f488c
• Add test coverage for crash scenario
  Bartłomiej Dach · 2022-11-23 16:11:57 +01:00
  06449b62f1
• Merge pull request #21224 from honguyenminh/VerticalStackedCatchTouchInput

  Vertically stacked osu!catch touch input

  Dean Herbert · 2022-11-23 18:55:20 +09:00
  8d0fe61aff
• Fix barlines being misaligned if generation start time is clamped
  Dean Herbert · 2022-11-23 18:12:03 +09:00
  f9d952220f
• Add test of barline generation with negative start time control point
  Dean Herbert · 2022-11-23 18:11:52 +09:00
  e69ed67335
• Fix crash when hitting 'T' to tap timing while no timing point is selected
  Dean Herbert · 2022-11-23 15:39:56 +09:00
  d146f86511
• Merge pull request #21379 from Joppe27/taiko-animations-recovered

  Add taiko hit overlay animations

  Dean Herbert · 2022-11-23 15:09:44 +09:00
  23f91ec717
• Merge pull request #21228 from Terochi/recent-messages-implementation

  Add ability to view chat send history in input box

  Dean Herbert · 2022-11-23 14:58:42 +09:00
  172e798847
• Specify canBeNull: true in [Resolved] for now
  Bartłomiej Dach · 2022-11-22 20:56:07 +01:00
  6e9d163c72
• Add test steps for testing combo reset to 0
  Bartłomiej Dach · 2022-11-22 20:43:22 +01:00
  675e32df57
• Always use current timing point for circle piece animation

  Using `LifetimeStart` seemed arbitrary and wrong not only in a
  compatibility-with-stable sense, but also in a general sanity sense (why
  would each object potentially be using a different timing point to
  animate?)

  Bartłomiej Dach · 2022-11-22 20:39:22 +01:00
  ce7af0df63
• Split animation logic to its own method

  Also add a guard, to bypass all of it if the foreground layer is not in
  fact animatable.

  Bartłomiej Dach · 2022-11-22 20:39:05 +01:00
  38f2a27f53
• Set combo immediately rather than via repeat steps

  Doesn't help anyone to be waiting literal minutes for combo to hit 50 or
  150 in a test scene supposed to quickly visually demonstrate a
  component. Doesn't help for CI runtime, either.

  Bartłomiej Dach · 2022-11-22 20:30:27 +01:00
  8ac0a759f0
• Restructure tests not to call each other

  Bit weird to have tests call other tests. Private helper methods is
  better, if unavoidable.

  Bartłomiej Dach · 2022-11-22 20:28:41 +01:00
  5a5b0ed4ef
• Remove unused setter
  Bartłomiej Dach · 2022-11-22 20:14:22 +01:00
  8dbc38e17a
• Add back removed test coverage
  Bartłomiej Dach · 2022-11-22 19:47:41 +01:00
  39934bccd6
• Merge pull request #21377 from peppy/song-select-alt-scroll-only

  Change song select to only allow volume adjusting if alt is held while scrolling

  Bartłomiej Dach · 2022-11-22 19:00:04 +01:00
  0d2d77f276
• Merge branch 'master' into song-select-alt-scroll-only
  Bartłomiej Dach · 2022-11-22 17:29:58 +01:00
  012e69fe4f
• Merge pull request #21372 from peppy/mania-hold-note-end-nearby-tests

  Add test coverage of input near end of hold note with nearby subsequent note

  Bartłomiej Dach · 2022-11-22 17:29:44 +01:00
  54c2becda7
• Add tests and clean up inefficient code
  Joppe27 · 2022-11-22 17:22:34 +01:00
  db34fa99b1
• Add legacy circle piece animations based on combo
  Joppe27 · 2022-11-22 17:22:00 +01:00
  5343f6922c
• Merge branch 'master' into mania-hold-note-end-nearby-tests
  Bartłomiej Dach · 2022-11-22 16:41:25 +01:00
  eb311f3fe5
• Change song select to only allow volume adjusting if alt is held while scrolling
  Dean Herbert · 2022-11-22 19:48:55 +09:00
  de163b2bb5
• Merge pull request #21371 from peppy/fix-mania-hold-note-stuck

  Fix osu!mania hold notes occasionally getting in a visually incorrect hit state

  Dan Balasescu · 2022-11-22 17:14:39 +09:00
  2e4dc7c467
• Add test coverage of input near end of hold note with nearby subsequent note

  Covers the scenarios mentioned in #21371.
  
  Turns out this seems mostly okay already, so there are no fixes applied here.

  Dean Herbert · 2022-11-22 17:09:14 +09:00
  c1b193149c
• Fix osu!mania hold notes occasionally getting in a visually incorrect hit state

  To correctly end a mania hold note, `endHold()` needs to be called. This
  was not happening in a very specific scenario:
  
  - The hold note's head is not hit
  - The user pressed the column's key within the hold note's tail's window,
    but does so to hit the next object (a note in proximity to the hold note's tail).
  - The hit policy forces a miss on the hold note, but `endHold()` is not called
  - `CheckForResult` is not called after this point due to `Judged` being `true`.
  
  Closes #21311.

  Dean Herbert · 2022-11-22 16:15:34 +09:00
  57723107dd
• Merge pull request #21366 from bdach/broken-rank-graph-test

  Fix broken rank graph test

  Dan Balasescu · 2022-11-22 14:35:14 +09:00
  6b75f529c7
• Merge pull request #21356 from peppy/standardise-broken-storyboard-paths

  Add support for storyboards with incorrect path specifications (`\\` instead of `\`)

  Dan Balasescu · 2022-11-22 14:33:51 +09:00
  985781bc3b
• Merge pull request #21344 from peppy/tablet-settings-test-scene

  Fix `TestSceneTabletSettings` falling off the bottom of the screen

  Bartłomiej Dach · 2022-11-21 21:46:15 +01:00
  cd43e83494
• Fix rank graphs not showing in test due to unset IsRanked
  Bartłomiej Dach · 2022-11-21 21:00:06 +01:00
  41039340cf
• Add failing assertions
  Bartłomiej Dach · 2022-11-21 20:58:52 +01:00
  1777a60136
• Rewrite rank graph test to use more modern style
  Bartłomiej Dach · 2022-11-21 20:56:38 +01:00
  735cac3104
• Merge branch 'master' into tablet-settings-test-scene
  Bartłomiej Dach · 2022-11-21 20:42:04 +01:00
  f36ccab84e
• Merge pull request #21346 from peppy/higher-aspect-ratio-max

  Increase maximum aspect ratio for tablet settings to 23:9 / 2.55

  Bartłomiej Dach · 2022-11-21 20:41:47 +01:00
  4490504104
• Merge branch 'master' into higher-aspect-ratio-max
  Bartłomiej Dach · 2022-11-21 19:51:39 +01:00
  8dbe31a172
• Merge pull request #21350 from peppy/hide-no-spin-bonus

  Hide spinner ticks / bonus from results screen when not applicable to score

  Bartłomiej Dach · 2022-11-21 19:50:56 +01:00
  f75353d8f4
• Fix weird scroll container sizing
  Bartłomiej Dach · 2022-11-21 19:27:06 +01:00
  ff5cb116f0
• Merge branch 'master' into hide-no-spin-bonus
  Bartłomiej Dach · 2022-11-21 19:14:54 +01:00
  c0f65d83b3
• Merge pull request #21360 from peppy/mania-argon-hold-better

  Realign white line on argon hold note ends to match hit target

  Bartłomiej Dach · 2022-11-21 18:53:05 +01:00
  c79841dad2
• Merge branch 'master' into mania-argon-hold-better
  Bartłomiej Dach · 2022-11-21 18:17:35 +01:00
  c805eb330a
• Merge pull request #21352 from peppy/avoid-null-audio-device-name-crahs

  Avoid crashing when a system audio device provides a `null` name

  Bartłomiej Dach · 2022-11-21 17:16:30 +01:00
  d5e9cb2477
• Merge branch 'master' into avoid-null-audio-device-name-crahs
  Bartłomiej Dach · 2022-11-21 16:37:13 +01:00
  206aece77b
• Merge pull request #21304 from EVAST9919/beatmap-bar

  Rework BarGraph to use Quads

  Bartłomiej Dach · 2022-11-21 16:24:18 +01:00
  7944d9cefa
• Realign white line on argon hold note ends to match hit target
  Dean Herbert · 2022-11-21 18:26:53 +09:00
  b404b87f68
• Variant 5: cannot change history, edit resets index
  Terochi · 2022-11-21 10:17:28 +01:00
  d81ef541bc