Salman Alshamrani
e0aec6f907
Revert unnecessary complexity
2024-12-11 01:03:55 -05:00
Salman Alshamrani
723883e1f0
Revert "Update exporter test to use OsuStorage"
...
This reverts commit f0f3c53571
2024-12-11 01:03:20 -05:00
Bartłomiej Dach
89e3c551ff
Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files
...
Allow choosing different background/audio files for individual difficulties
2024-12-11 14:12:58 +09:00
Bartłomiej Dach
b37a06c0fe
Hide "show playing rooms" toggle when in filter mode it doesn't make sense with
2024-12-11 13:24:54 +09:00
Bartłomiej Dach
3352571f2a
Add ability to filter out currently playing rooms
...
Addresses https://osu.ppy.sh/community/forums/topics/2013293?n=1 .
2024-12-11 13:24:08 +09:00
Bartłomiej Dach
637fe07b31
Rename Room{Status -> Mode}Filter
...
I need the "status" term free for an upcoming change. And web calls this
parameter "mode" as well:
642e973f91/app/Models/Multiplayer/Room.php (L184-L199)
2024-12-11 12:36:42 +09:00
Dean Herbert
842829db7a
Merge pull request #31071 from smoogipoo/add-diffcalc-allowed-users
2024-12-10 18:28:40 -08:00
Dan Balasescu
315a9dba9b
Allow tsunyoku and stanriders to trigger diffcalc spreadsheet generator
2024-12-11 09:59:18 +09:00
Dan Balasescu
86f86fa5d4
Merge pull request #31052 from peppy/fix-hitcircle-lookup-fallback
...
Fix lookups of hit circle slider pieces potentially using wrong source skin
2024-12-10 23:16:40 +09:00
Dean Herbert
dae380b7fa
Fix lookups of hit circle slider pieces potentially using wrong source skin
...
Addresses https://github.com/ppy/osu/discussions/30927 .
2024-12-10 22:03:07 +09:00
Salman Alshamrani
d8e545e034
Merge pull request #31047 from peppy/silly-thing
...
Avoid beatmap lookup per bar in logo visualisation
2024-12-10 03:41:44 -05:00
Salman Alshamrani
e6e79cbd11
Merge branch 'master' into silly-thing
2024-12-10 03:00:53 -05:00
Dean Herbert
bbaa542d4a
Add note about expensive operation
2024-12-10 16:45:26 +09:00
Dean Herbert
3cac583754
Rewrite resource changing code to be more legible (to my eye)
2024-12-10 16:45:26 +09:00
Dean Herbert
48bf2fa001
Merge pull request #30960 from bdach/bookmarks
...
Implement basic bookmark support in editor
2024-12-09 23:42:04 -08:00
Bartłomiej Dach
7fcfebf4b4
Use Alt-{Left,Right} as default bindings for bookmark navigation
2024-12-10 14:59:19 +09:00
Dean Herbert
d69f5fd4cf
Avoid beatmap lookup per bar in logo visualisation
...
Just noticed in passing.
2024-12-10 14:45:36 +09:00
Dean Herbert
92dfcae6eb
Adjust bad grammar
2024-12-10 14:35:09 +09:00
Dean Herbert
7ec2d91e14
Merge branch 'master' into editor-multiple-background-audio-files
2024-12-10 14:19:55 +09:00
Dean Herbert
197d553238
Merge pull request #31041 from bdach/wtf-wtf-wtf-wtf-wtf-wtf
...
Fix top score statistics section total score display being terminally broken
2024-12-09 19:57:00 -08:00
Bartłomiej Dach
1febed66cf
Fix top score statistics section total score display being terminally broken
...
Closes https://github.com/ppy/osu/issues/31038 .
If you don't realise why this does anything, realise this: the drawable
creation callback runs for every created sprite text in the text flow.
ANd the created sprite texts are split by whitespace. And Russian /
Ukrainian / Polish etc. use spaces as thousands separators.
So on those languages the first encountered part of the score would
duplicate itself to the remaining parts.
I'm actively convinced it was _more difficult_ to produce what was in
place in `master` than to do it properly. Why did `TextColumn` even have
`LocalisableString Text` and `Bindable<string> Current` next to each
other?????
2024-12-09 23:51:57 +09:00
Salman Alshamrani
f0f3c53571
Update exporter test to use OsuStorage
2024-12-09 08:26:18 -05:00
Dan Balasescu
216e0c768b
Merge pull request #31035 from frenzibyte/ios-uttype-description
...
Add description to osu! file associations in iOS
2024-12-09 22:16:42 +09:00
Salman Alshamrani
0c0dcb1e15
Use temporary storage for exported files on iOS
2024-12-09 08:16:37 -05:00
Salman Alshamrani
e9868c6318
Enable exporting beatmaps in iOS
2024-12-09 07:47:28 -05:00
Salman Alshamrani
a46070be30
Add description to osu! file associations in iOS
2024-12-09 07:02:53 -05:00
Dan Balasescu
1b8d9370aa
Merge pull request #30973 from frenzibyte/copy-effect-points
...
Preserve effect point specifications when creating blank difficulties
2024-12-09 16:13:52 +09:00
Bartłomiej Dach
459533aba6
Merge branch 'master' into bookmarks
2024-12-07 22:22:04 +09:00
Dean Herbert
eeac8f530f
Merge pull request #31000 from LittleEndu/release-ipc-name
...
Fix IPC not working in release
2024-12-07 04:37:13 -08:00
Endrik Tombak
b04f5ab6e4
Fix IPC not working in release
2024-12-07 14:13:14 +02:00
Dean Herbert
2713ae601a
Remove unused using
2024-12-07 14:41:30 +09:00
Bartłomiej Dach
13759f5aa0
Back out test change
...
It was mostly a demonstrative thing to use in the heat in the moment for
the skinnable mod display and it breaks all other tests. So let's just
not.
2024-12-07 13:47:09 +09:00
Thomas Müller
db18492fbc
Update default osk for skinnable mod display
2024-12-07 13:12:09 +09:00
Thomas Müller
0a00f7a7c2
Implement skinnable mod display
...
Also makes the mod display initialization sequence (start expanded, then
unexpand) controlled by HUDOverlay rather than mod display itself. This
enabled different treatment depending on whether the mod display is
viewed in the skin editor or in the player.
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-12-07 12:06:33 +09:00
Dean Herbert
3e7005d50f
Merge pull request #30956 from peppy/named-pipe
...
Fix osu! sometimes not starting when WSL is running in the background
2024-12-06 18:49:52 -08:00
Dean Herbert
b9f1fef250
Update framework
2024-12-07 10:46:03 +09:00
Dean Herbert
e22f3b7d05
Merge branch 'master' into named-pipe
2024-12-07 10:42:55 +09:00
Dean Herbert
5849a69a86
Merge pull request #30921 from huoyaoyuan/netcore-analyzer
...
Set up-to-date .NET code quality analyzers
2024-12-06 17:29:09 -08:00
Salman Alshamrani
5cb6b86b1c
Fix reference effect point getting mutated
2024-12-06 05:47:41 -05:00
Dan Balasescu
ec8b320e21
Handle non-legacy types
...
Also used in some tests (e.g. beatmaps containing `HitCircle`s).
2024-12-06 17:47:49 +09:00
Dan Balasescu
8dda5aada8
Populate default LegacyType value on convert hitobjects
...
Normally not an issue, but some tests create their own hitobjects
deriving from `ConvertHitObject`.
2024-12-06 17:47:14 +09:00
Dan Balasescu
e703d9e814
NRT refactorings + rename generators to match usage
...
In particular, "EndTimeObject" is no longer correct - it's strictly used
for spinners and not holds.
2024-12-06 17:16:04 +09:00
Dan Balasescu
1bbf32d567
Add some explanatory comments
...
In particular, the spinner one is the most relevant to this batch of
changes.
2024-12-06 16:40:29 +09:00
Dan Balasescu
e8728abc00
Rename LegacyPatternGenerator to stop naming conflicts
2024-12-06 16:40:29 +09:00
Dan Balasescu
e65f8ba7a0
Simplify implementation
2024-12-06 16:40:29 +09:00
Dan Balasescu
8e1bd98386
Split out + rename PassThroughPatternGenerator
...
Better symbolises the intent of this generator which is to convert
hitobjects in their most simple forms - anything with an end time
converts to a hold or otherwise converts to a normal note.
2024-12-06 16:40:29 +09:00
Dan Balasescu
8b456e1379
Always convert mania spinners
...
A big part of these changes is refactoring, which is somewhat necessary
because it was previously implemented as two separate pathways which
in-fact need to be joined at the hip when handling spinners.
I've chosen to use `IHasLegacyHitObjectType` here because there's no
other flag that allows us to tell `ConvertHold` apart from
`ConvertSpinner`.
2024-12-06 16:40:28 +09:00
Dan Balasescu
62ea4e0970
Add failing test
2024-12-06 16:40:25 +09:00
Dean Herbert
7592813e56
Merge pull request #30910 from nekodex/improve-menu-sample-playback
...
Improve menu/context-menu sample playback
2024-12-05 20:50:14 -08:00
Dean Herbert
69014550b5
Remove unnecessary null checks
2024-12-06 12:48:06 +09:00
