8043 Commits

• Fix weird nullability in TestSceneSkinEditor
  Dean Herbert · 2023-02-22 18:17:20 +09:00
  90ca635a17
• Update assertion to also check GameplayClockContainer's current time
  Dean Herbert · 2023-02-22 15:26:09 +09:00
  f61fbcf3fc
• Seek using GameplayClockContainer
  Dean Herbert · 2023-02-22 14:41:20 +09:00
  a511e64fa5
• Fix test compile failures from Audio hoisting
  Bartłomiej Dach · 2023-02-21 21:03:00 +01:00
  d59d153654
• Addressed change requests
  Terochi · 2023-02-21 21:01:31 +01:00
  dd53a70071
• Merge branch 'master' into fix-taiko-drum-nested-sample-detection
  Bartłomiej Dach · 2023-02-21 20:53:06 +01:00
  3d2fcb0cca
• Merge branch 'master' into skin-editor-clipboard
  Bartłomiej Dach · 2023-02-21 19:35:58 +01:00
  ec1bf7b0b2
• Added a way for mod settings to be kept when changing ruleset + test
  Terochi · 2023-02-21 19:05:10 +01:00
  191604340f
• Update slider sample source asserts to match expected behaviour

  As pointed out in review, if the current time is after the end of the
  slider, the correct hit object to use for sample retrieval is the object
  itself, not any nested object.

  Dean Herbert · 2023-02-21 14:04:38 +09:00
  9321ec29dc
• Add wait steps to ensure frame-stable clock has caught up before checking state
  Dean Herbert · 2023-02-21 14:04:19 +09:00
  e686b4393e
• Merge branch 'master' into fix-taiko-drum-nested-sample-detection
  Dean Herbert · 2023-02-21 13:58:15 +09:00
  5ba6059911
• Merge branch 'master' into revert-result-in-playfield
  Bartłomiej Dach · 2023-02-19 16:33:10 +01:00
  3183f5cee2
• Merge branch 'master' into skin-editor-clipboard
  Bartłomiej Dach · 2023-02-17 22:59:18 +01:00
  704dddf14b
• Merge branch 'master' into skinnable-clean-up-documentation
  Bartłomiej Dach · 2023-02-17 20:59:18 +01:00
  6afa65bd3d
• refactor(KeyCounter): address bindables issues

  `IsCounting` is back being an auto-property.
  `countPresses` is now encapsulated and being exposed as an
  `IBindable<int>` via `CountPresses`

  tsrk · 2023-02-16 22:20:34 +00:00
  ddd6c1a1c6
• Merge branch 'master' into revert-result-in-playfield
  Bartłomiej Dach · 2023-02-16 21:54:29 +01:00
  3ee046000e
• Merge branch 'master' into fix-taiko-drum-nested-sample-detection
  Bartłomiej Dach · 2023-02-16 19:43:02 +01:00
  2fdf1fd876
• Add one more assert to keep coverage from previous implementation
  Bartłomiej Dach · 2023-02-16 19:02:51 +01:00
  5bdc5dfadd
• Add test coverage of GameplaySampleTriggerSource not considering nested objects
  Dean Herbert · 2023-02-16 18:21:33 +09:00
  b59ec551f6
• Refactor GameplaySampleTriggerSource test to not be realtime dependent
  Dean Herbert · 2023-02-16 17:58:44 +09:00
  979c079f8b
• Apply NRT to GamepleSampleTriggerSource tests
  Dean Herbert · 2023-02-16 17:58:44 +09:00
  9d02a2ef0e
• Add clipboard dependency to SkinEditor specific tests

  This is usually provided by the `SkinEditorOverlay`, which is not always
  present in tests.

  Dean Herbert · 2023-02-16 15:24:38 +09:00
  2fbaf88a3c
• feat: implement new design of key counter
  tsrk · 2023-02-15 22:18:02 +00:00
  74e7cc2056
• refactor: rename trigger classes

  Makes it better to understand their purpose

  tsrk · 2023-02-15 21:46:13 +00:00
  076eb81b21
• refactor: rename Trigger class to InputTrigger
  tsrk · 2023-02-15 21:41:36 +00:00
  157bba7830
• Rename SkinnableTargetContainer to SkinComponentsContainer

  Also use full `SkinComponentsContainerLookup` instead of the sub-type.
  This will potentially be useful once we bring in per-ruleset targets.

  Dean Herbert · 2023-02-15 18:37:41 +09:00
  a92e42bb84
• Move extension methods closer to serialisation classes
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  b1cf6d83d8
• Rename SkinnableDrawableInfo to SerialisedDrawableInfo
  Dean Herbert · 2023-02-15 18:23:19 +09:00
  856efd9fd9
• Rename SkinnableInfo to SkinnableDrawableInfo
  Dean Herbert · 2023-02-15 18:23:17 +09:00
  9e651a7ca2
• Move SkinnableInfo to better namespace
  Dean Herbert · 2023-02-15 18:23:10 +09:00
  6010dde86e
• Fix test container lookup failure
  Dean Herbert · 2023-02-15 17:47:34 +09:00
  d9b4d932c9
• Apply NRT to TestSceneBeatmapSkinFallbacks
  Dean Herbert · 2023-02-15 17:30:21 +09:00
  ca75f0ec77
• Simplify and rename SkinnableTargetComponentsContainer
  Dean Herbert · 2023-02-15 17:30:21 +09:00
  8bbd00822c
• Merge branch 'master' into footer_V2_implementation
  Dean Herbert · 2023-02-14 14:00:53 +09:00
  51d4ae5241
• Merge pull request #22628 from EVAST9919/letterbox-no-containers

  Remove unnecessary containers in `LetterboxOverlay`

  Bartłomiej Dach · 2023-02-13 23:54:48 +01:00
  939144fb6c
• Change FooterV2.cs colour to use ColourProvider instead of OsuColour.

  Remove unnecessary `FillFlowContainer`

  mk56-spn · 2023-02-13 22:12:25 +01:00
  6e6421caea
• Add TestSceneLetterboxOverlay
  Andrei Zavatski · 2023-02-13 14:17:33 +03:00
  006356e617
• refactor: separate impl of KeyCounterDisplay

  This allows for different layouts of display. Idk, maybe someone would
  want to mix both variants? (don't do this please). This commit is mostly
  prep for further changes.

  tsrk · 2023-02-13 01:36:12 +00:00
  11d0e185b8
• Use existing ModdingBeatmap activity
  Joseph Madamba · 2023-02-12 15:01:50 -08:00
  cb51b9e350
• Add TestingBeatmap activity
  Joseph Madamba · 2023-02-12 13:11:42 -08:00
  bbeef53569
• Make user activity class names more specific
  Joseph Madamba · 2023-02-12 12:32:17 -08:00
  afb66d8af4
• Merge pull request #22598 from peppy/fix-skip-intro-replay

  Fix "skip" key binding no longer working in replay playback

  Bartłomiej Dach · 2023-02-11 11:27:10 +01:00
  8292052dc2
• Merge pull request #22529 from ItsShamed/dsc/presence

  Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`

  Dean Herbert · 2023-02-11 17:29:47 +09:00
  0c5dae5f26
• Add failing test coverage of skip no longer working in replay playback
  Dean Herbert · 2023-02-10 18:57:04 +09:00
  96fbd04698
• Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability

  Improve readability of `AccuracyCircle`

  Dean Herbert · 2023-02-10 17:03:46 +09:00
  eccde923e5
• Fix test setting invalid TimeOffset
  ekrctb · 2023-02-09 17:43:04 +09:00
  5ddaf8ea3c
• Simplify TestSceneAccuracyCircle test specifications
  Dean Herbert · 2023-02-09 15:42:03 +09:00
  92eb6b6717
• Display tournament banner on user profile
  Joseph Madamba · 2023-02-08 17:16:09 -08:00
  3b5d573db1
• use values closer to the extremities for test cases
  Walavouchey · 2023-02-09 00:02:32 +01:00
  9544a1d26d
• ensure AccuracyCircle doesn't land in gaps created by RankNotches
  Walavouchey · 2023-02-08 13:20:53 +01:00
  6ace6bfee1