3408 Commits

• Refetch list of user favourites on every change to favourites

  Is this lazy? Sure it is. Friends and blocks do the same thing, though,
  and I'm not overthinking this any more than I already have.
  
  Being smarter here would likely mean being more invasive with respect to
  listening in on all outgoing API requests and silently updating
  favourites on that basis. Which is "smart" but also complicated.

  Bartłomiej Dach · 2025-10-24 08:41:52 +02:00
  6b56a0611b
• Merge branch 'master' into fix-qp-availability
  Dean Herbert · 2025-10-24 14:27:45 +09:00
  d062c99666
• Adjust gameplay sample models to support custom sample sets

  This is a set of model changes which is supposed to facilitate support
  for custom sample sets to the beatmap editor that is on par with stable.
  
  It is the minimal set of changes. Because of this, it can probably be
  considered "ugly" or however else you want to put it - but before you
  say that, I want to try and pre-empt that criticism by explaining where
  the problems lie.
  
  Problem #1: duality in sample models
  ---
  
  There is currently a weird duality of what a `HitObject`'s samples will
  be.
  
  - If an object has just been placed in the editor, and not saved /
    decoded yet, it will use `HitSampleInfo`.
  
  - If an object has already been encoded to the beatmap at least once, it
    will use `ConvertHitObjectParser.LegacyHitSampleInfo`.
  
  As long as that state of affairs remains, `HitSampleInfo` must be able
  to represent anything that `LegacyHitSampleInfo` can, if feature parity
  is to be achieved.
  
  Problem 2: The 0 & 1 sample banks
  ---
  
  Custom sample banks of 2 and above are a pretty clean affair. They map to
  a suffix on the sample filename, and said samples are allowed to be
  looked up from the beatmap skin. `Suffix` already exists in
  `HitSampleInfo`.
  
  However, the 1 custom sample bank is evil. It uses *non-suffixed*
  samples, *allows lookups from the beatmap skins*, contrary to no bank /
  bank 0, which *also* uses non-suffixed samples, but *doesn't* allow them
  to be looked up from the beatmap skin.
  
  This is why `HitSampleInfo.UseBeatmapSamples` has been called to
  existence - without it there is no way to represent the ability of using
  or not using the beatmap skin assets.
  
  As has been stated previously in discussions about this feature, it's
  both a *mapping* and a *skinning* concern.
  
  There are many things you could do about either of these problems, but I
  am pretty sure tackling either one is going to take *many* more lines of
  code than this commit does. Which is why this is the starting point of
  negotiation.

  Bartłomiej Dach · 2025-10-22 14:58:08 +02:00
  c361e6d3c2
• Use interface instead
  Dan Balasescu · 2025-10-22 16:02:46 +09:00
  4cac1781c5
• Fix quick play not redownloading modified beatmaps
  Dan Balasescu · 2025-10-22 15:34:29 +09:00
  c6fcba7e1c
• Add locus 2025 winners to bundled download beatmaps list
  Dean Herbert · 2025-10-17 02:03:52 +09:00
  98762ce09e
• SSV2 : Replace "Mark as Played" with "Remove from Played" if map is already played (#35287)

  * SSV2 : Replace Mark as Played with Remove from Played if already played
  
  * Remove checks of BeatmapInfo.LastPlayed for DateTimeOffset.MinValue
  
  * Make FooterButtonOptions use a RealmLive<BeatmapInfo> and act on review comments
  
  * FIXUP: Detach BeatmapInfo before passing it to FooterButtonOptions.Popover
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Alban Cabannes-Michel · 2025-10-16 14:59:16 +02:00
  8f6f859c15
• Add some logging when FindWithRefresh triggers a slow realm refresh
  Dean Herbert · 2025-10-10 13:36:28 +09:00
  94c7489c1c
• Fix shift-clicking not working on extra size beatmap cards

  Was broken due to double assignment to `Action`.

  Bartłomiej Dach · 2025-10-09 08:59:26 +02:00
  6da6edd1d1
• Always explicitly assign the action for beatmap cards
  Dean Herbert · 2025-09-29 17:31:45 +09:00
  3f5b71fdc3
• Keep panel backgrounds loaded
  Dean Herbert · 2025-09-26 18:26:11 +09:00
  b743506207
• Use BeatmapCard for matchmaking beatmap display
  Dean Herbert · 2025-09-26 18:09:05 +09:00
  0a17a3c4ed
• Allow visibly disabling the "go to beatmap" button

  Easiest way to make this work without rewriting the layout logic.
  
  I think it makes sense to have the button still exist there but not be
  usable on certain screens.

  Dean Herbert · 2025-09-26 18:08:47 +09:00
  da80b61f38
• Merge pull request #34900 from bdach/invalid-filenames-in-imported-skins

  Fix external edit operations failing due to invalid filenames

  Dean Herbert · 2025-09-03 18:50:17 +09:00
  0ab3b593e7
• Replace local copy of GetValidFilename() with direct usage

  Noticed in passing.

  Bartłomiej Dach · 2025-09-03 09:32:43 +02:00
  5c66998c57
• Merge pull request #34892 from bdach/shift-click-beatmap-card

  Download online beatmap / present local beatmap on shift-clicking beatmap cards

  Dean Herbert · 2025-09-03 16:19:48 +09:00
  1e50e36a64
• Ignore .osu files not placed at top level of beatmap archive on import

  Closes https://github.com/ppy/osu/issues/34677.

  Bartłomiej Dach · 2025-09-02 14:50:31 +02:00
  79f7f0ecad
• Download online beatmap / present local beatmap on shift-clicking beatmap cards

  Closes https://github.com/ppy/osu/issues/34883.

  Bartłomiej Dach · 2025-09-02 13:11:18 +02:00
  6c82f543e6
• Adjust interpolation workaround to catch-up slightly smoother
  Dean Herbert · 2025-08-29 21:24:23 +09:00
  41b8033ebd
• Fix metadata cache version queries failing hard if the image is corrupted

  This was not fatal but with this change it should recover in a slightly
  better way.
  
  Also incidentally fixes the cache refetch potentially being attempted
  twice by each of the two background population tasks that use it.

  Bartłomiej Dach · 2025-08-07 11:10:02 +02:00
  dac643121a
• Fix metadata cache refetches failing on windows

  Reported at
  https://discord.com/channels/188630481301012481/1097318920991559880/1402910684320108574
  among others.
  
  Only really visible on windows for reasons outlined in inline comment.

  Bartłomiej Dach · 2025-08-07 10:24:15 +02:00
  7da94c4010
• Merge pull request #34432 from bdach/unified-beatmap-attribute-display

  Unify display logic of beatmap difficulty attributes across usages

  Dean Herbert · 2025-08-01 13:35:48 +09:00
  71644e4629
• Merge pull request #34346 from bdach/user-tag-population

  Backpopulate user tag data using `online.db`

  Dean Herbert · 2025-07-30 22:24:19 +09:00
  094f703c02
• Rename property to reduce confusion

  Caused an actual bug in one of the replaced usages.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  cd2c5075df
• Migrate other usages of GetAdjustedDisplayDifficulty() to use GetBeatmapAttributesForDisplay() instead

  This ensures parity between all beatmap attribute displays that used the
  former method.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  a952e3704e
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Only perform user tag backpopulation after the local metadata cache updates
  Bartłomiej Dach · 2025-07-29 11:50:41 +02:00
  8307947a10
• Fix some issues
  Dean Herbert · 2025-07-29 13:19:43 +09:00
  f8f37f53a7
• Clear user tags when performing metadata lookup
  Bartłomiej Dach · 2025-07-28 10:29:48 +02:00
  aae16045f6
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-25 11:36:52 +03:00
  4b73afd195
• Add back-population operation for user tags
  Bartłomiej Dach · 2025-07-23 10:35:32 +02:00
  1709811458
• Add support for retrieving user tags from local metadata cache
  Bartłomiej Dach · 2025-07-23 10:26:31 +02:00
  05923d3b2b
• Merge pull request #34231 from bdach/user-tag-search-wip

  Add initial support for filtering by user tags in song select

  Dean Herbert · 2025-07-21 14:52:47 +09:00
  b4466aa7a2
• Merge pull request #34306 from EYHN/eyhn/fix/beatmap-set-cover-load

  Fix beatmap set cover not loading at screen edges

  Dean Herbert · 2025-07-21 14:49:02 +09:00
  6f0111583d
• Fix beatmap set cover not loading at screen edges
  eyhn · 2025-07-20 22:24:59 +08:00
  d770a08526
• Allow beatmap cards' collapsible icon buttons to be accessible via context menu
  Bartłomiej Dach · 2025-07-17 12:49:12 +02:00
  1ee439ad7f
• Merge branch 'ppy:master' into ssv2-localisation
  Denis Titovets · 2025-07-16 11:59:47 +03:00
  021ef6d727
• Add initial support for filtering by user tags in song select

  The way that this works is that it plugs into the online request to
  retrieve the beatmap set that the client is already performing, and
  stores user tag data to the local realm database.
  
  This means that for now user tags will only populate for beatmaps that
  the user has displayed on song select which is obviously subpar. I plan
  to follow this change up by adding user tag state dumps to `online.db`
  and using that data for initial tag population to make the majority case
  (ranked beatmaps) work.
  
  Note that several decisions were made here that are potential discussion
  points:
  
  - `RealmPopulatingOnlineLookupSource` is set up such that it can be the
    middle man / redirection point for similar flows that we need and we
    are currently missing, such as storing guest difficulty information,
    or storing the user's current best score on a beatmap (handy for rank
    achieved sorting / filtering / etc.)
  
  - The user tags are stored in `BeatmapMetadata` which breaks the
    longstanding assumption that you can arbitrarily pull out a metadata
    instance from any of the beatmaps in a set and get essentially the
    same object back.
  
    I've attempted to constrain this some by not adding user tags to
    the `IBeatmapMetadataInfo` interface through which `BeatmapSetInfo`
    exposes metadata further, but I warn in advance that this is
    a temporary state of affairs and I will make it worse in the future
    when `BeatmapMetadata.Author` becomes `Authors` plural in order to
    support guest mapper display (and direct guest difficulty submission).
  
  - The syntax for searching via user tags is chosen to mostly match web -
    it's `tag=`, with support for all of the string matching modes song
    select already has (bare word for substring, `""` quotes for phrase
    isolated by whitespace, `""!` for exact full match).

  Bartłomiej Dach · 2025-07-15 11:09:40 +02:00
  8cb81974eb
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-12 10:37:17 +03:00
  0065331659
• Disallow hiding beatmap difficulties if only one difficulty remains
  Dean Herbert · 2025-07-10 17:57:45 +09:00
  789ddcf395
• Fix tests #3
  Denis Titovets · 2025-07-09 18:16:57 +03:00
  7af655f98f
• Fix tests #2
  Denis Titovets · 2025-07-09 18:14:34 +03:00
  7c6f0d1d11
• Fix tests
  Denis Titovets · 2025-07-09 17:26:22 +03:00
  94beb9178a
• Fully localise SSV2
  Denis Titovets · 2025-07-09 15:07:07 +03:00
  1f052bb195
• Add note about LATEST_VERSION cross-project usage
  Dean Herbert · 2025-07-01 19:19:18 +09:00
  68ab89a8f1
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Switch to IconPills, add storyboard icon
  StanR · 2025-06-22 13:45:07 +05:00
  25eb9914a4
• Merge pull request #33402 from bdach/preview-point-validity

  Fix track not looping if specified preview point exceeds duration of track

  Dan Balasescu · 2025-06-05 13:59:26 +09:00
  cf297ae743
• Ensure valid ruleset for gameplay
  Dean Herbert · 2025-06-04 15:45:40 +09:00
  c73ef15ebf