728 Commits

• Resolve inspection issues
  Dan Balasescu · 2022-04-14 13:11:11 +09:00
  494955aff1
• Add ability to switch between most common tournament scenes using key bindings
  Dean Herbert · 2022-04-01 12:44:49 +09:00
  ea672745b0
• Fix tournament bracket parsing's ruleset refetch logic not working correctly

  Due to equality being based on `ShortName`, it was feasible that the
  re-fetch exited early (in bindable shortcutting logic) causing the
  ruleset's `OnlineID` to remain `-1` or something equally wrong.
  
  Resolves issue pointed out at
  https://github.com/ppy/osu/discussions/17538#discussioncomment-2471746.

  Dean Herbert · 2022-03-31 18:41:00 +09:00
  a06b0a4966
• Add test coverage ensuring ruleset ID is correct after bracket read

  Historically, tournament client may have written incorrect `OnlineID`
  values. We wanted to use `ShortName` to re-fetch the ruleset. This test
  ensures this flow is working correctly.

  Dean Herbert · 2022-03-31 18:39:58 +09:00
  a7a7584d3e
• Update PresentExternally usages in line with framework changes
  Dean Herbert · 2022-03-24 23:41:07 +09:00
  2938f44e6c
• Display star ratings in tournament mode using two decimal places
  Dean Herbert · 2022-02-27 23:17:04 +09:00
  df4170b939
• Remove unused constants
  Dean Herbert · 2022-02-27 23:16:04 +09:00
  297e5ec62e
• Change button location to the right side of dropdown
  Shivam · 2022-02-25 15:15:40 +01:00
  4c56458173
• Add open folder button to open currently selected tournament
  Shivam · 2022-02-25 14:31:46 +01:00
  333c0cd4f9
• Allow game folder migration to fail gracefully when cleanup cannot completely succeed
  Dean Herbert · 2022-02-10 19:30:26 +09:00
  44f2d8a448
• Fix tournament client not loading

  Caused by a `LoadComponentsAsync()` call being fired from a worker
  thread, which will throw exceptions since the recent addition of safety
  checks around that method.

  Bartłomiej Dach · 2022-01-27 17:31:12 +01:00
  9deeaee404
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Turn on high poll rate when tournament chat is expanded
  Salman Ahmed · 2022-01-22 16:34:57 +03:00
  b2d1bd029d
• Merge branch 'master' into realm-integration/score-and-beatmaps
  Bartłomiej Dach · 2022-01-15 14:45:42 +01:00
  03e4ec4214
• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• Add far too many fixes for ruleset non-nullable requirements
  Dean Herbert · 2022-01-12 23:24:11 +09:00
  b5f670cc5b
• Fix CI reported warnings
  Dean Herbert · 2022-01-12 22:39:00 +09:00
  51251e3204
• Fix some identifiers using shortened naming
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  5082b0e63f
• Fix most open compound words in identifiers being closed
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  7de43e3aba
• Merge branch 'master' into i-ruleset-store
  Bartłomiej Dach · 2021-12-04 15:05:39 +01:00
  38702beabf
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Cache and consume IRulesetStore where feasible
  Dean Herbert · 2021-12-03 18:16:01 +09:00
  e75e209053
• Avoid saving bracket if parsing failed, at all costs
  Dean Herbert · 2021-12-03 16:06:38 +09:00
  5158736839
• Centralise specification of bracket.json filename
  Dean Herbert · 2021-12-03 16:04:11 +09:00
  ba05a0a383
• Migrate custom tournament client assets to uppercased directories

  It has transpired that on filename-case-sensitive filesystems, the
  tournament client does not consistently handle custom asset paths.
  Videos and mods could only be looked up from `videos` and `mods`
  directories (lowercase), while flags could only be looked up from the
  `Flags` directory (uppercase).
  
  A complicating circumstance is that default country flags, coming from
  osu-resources, also depend on the flag lookup being uppercased.
  
  To attempt to clean up the handling as much as it appears to be
  possible, automatically move user-supplied lowercase directories to
  uppercase.

  Bartłomiej Dach · 2021-11-28 16:36:19 +01:00
  87d6a743dd
• Update all actual usages of RulesetInfo.ID to use OnlineID instead
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  bbd3ea5b77
• Update existing usages of Author as string to access Username directly
  Dean Herbert · 2021-11-04 18:57:54 +09:00
  86540d1fb6
• Rename User to APIUser and move to correct namespace
  Dean Herbert · 2021-11-04 18:21:31 +09:00
  b9983add15
• Fix beatmap creator showing twice in tournament map pool panels
  Dean Herbert · 2021-11-01 14:33:24 +09:00
  10a9266956
• Merge branch 'master' into beatmap-refactor/uncontested
  Dean Herbert · 2021-10-28 16:37:26 +09:00
  6f5040722a
• Merge pull request #15319 from peppy/beatmap-refactor/tournament

  Remove all usage of `BeatmapInfo` / `BeatmapSetInfo` from tournament mode

  Dan Balasescu · 2021-10-28 16:26:06 +09:00
  f9ca7f5df1
• Fix non-null inspection
  smoogipoo · 2021-10-28 15:24:44 +09:00
  313f78cbfb
• Add mention of why the serialisation happens outside stream usage
  Dean Herbert · 2021-10-28 15:04:09 +09:00
  a6669a3892
• Fix serlialisation failure during ladder saving causing all existing file content to be deleted
  Dean Herbert · 2021-10-28 15:00:30 +09:00
  ef26b0ba8a
• Remove TODO (tested to work correctly)
  Dean Herbert · 2021-10-28 14:48:36 +09:00
  f3d208fecf
• Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases
  Dean Herbert · 2021-10-28 00:50:45 +09:00
  7245baba69
• Rename all usages of APIBeatmap to beatmap in tournament namespace
  Dean Herbert · 2021-10-27 18:42:48 +09:00
  f1499641f3
• Change repopulation rules to cover the fact that the serisalisation model has changed

  This also adds a progress display to show how repopulation is going. It
  can take a while on a large bracket.

  Dean Herbert · 2021-10-27 18:42:48 +09:00
  5448b94039
• Fix PopulateUser not populating immediately when immediate is specified (due to scheduling)
  Dean Herbert · 2021-10-27 18:26:44 +09:00
  35168948fe
• Update tournament components to use APIBeatmap directly
  Dean Herbert · 2021-10-27 18:26:44 +09:00
  3130616300
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Fix tournament client silently failing on error during parsing
  Dean Herbert · 2021-10-25 16:49:33 +09:00
  7111f58bfe
• Add tournament LadderInfo serialisation tests
  Dean Herbert · 2021-10-25 16:49:33 +09:00
  7c99193ada
• Rename usages which rely on online backing
  Dean Herbert · 2021-10-21 16:58:42 +09:00
  32d01f022f
• Move BeatmapSetOnlineInfo to an interface type
  Dean Herbert · 2021-10-21 16:58:42 +09:00
  0706ad70fb
• Split score counter class into two distinct classes to simplify usages
  Dean Herbert · 2021-10-10 17:56:32 +09:00
  794b4c46cf
• Use comma separator for tournament score displays
  Dean Herbert · 2021-10-10 16:06:12 +09:00
  446f091d32
• Fix all remaining cases of incorrect Bindable<string> defaults
  Dean Herbert · 2021-10-08 13:55:22 +09:00
  672664dce7
• Merge branch 'master' into fix-SettingsTextBox-using-null-as-default
  Dean Herbert · 2021-10-08 13:37:28 +09:00
  42d3fe8f02
• Merge branch 'master' into new-interfaces
  Dan Balasescu · 2021-10-06 11:38:17 +09:00
  4bbff2ebf7