osu-lazer

Tooling updates (#37031 )

Most of this is as everywhere else, but there's also interesting code
inspection fixes from the InspectCode bump, so I'll talk about that a
little.

## [Fix suspicious equality in
`Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)

Inspection:
https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html

Pretty annoying to fix, nullable array types are a pain. Does look legit
though.

## [Fix `StarDifficulty` using inefficient struct
equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)

Inspection:
https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html

This is a dodgy one because there's no real sane way to define equality
on `StarDifficulty` now that it has difficulty and performance
attributes jammed into it. So I just basically shut the inspection up
with a `record` modifier and move on.

Unclear where the equality is used precisely. It's from a global
inspection. F12 is very unhelpful when trying to track down usages of
`Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
those do use equality. Maybe more than that.

## [Use `nameof` expressions to reference enum member
names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)

Inspection:
https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html

Pretty quaint.

## [Prefer using concrete values over `default` or
`new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)

Inspection:
https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html

I could see this one going both ways, but I'm kinda sold on this
inspection. Explicit is always better. Saves some allocations in the
`CancellationToken` cases as well.

## [Explicitly call `.AsEnumerable()` in some realm
usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)

Inspection:
https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html

Not fully sold on this one but it's quick and simple so might as well.

## [Simplify dictionary removal with single `.Remove()`
call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)

Inspection:
https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html

Not much to say.

Bartłomiej Dach · 2026-03-19 00:05:52 +09:00

18d4ba5874

Improve song select audio transitions (#37022 )

Based on feedback I've heard more than once ([most
recently](https://github.com/ppy/osu/discussions/36933)), there's too
much overlap compared to stable. And it can sound a bit "jumbled" as a
result, especially when transitioning between two songs with loud and
"complex" audio.

This also fixes noticeable audio glitching that some users may have been
experiencing when switching tracks.

---

Unless there's any very loud objections, I'd ask that review is on the
code not the audible change. This is the kind of change that I tweak to
my personal spec and then push out to hear the general reaction.

### b8d0dfe2ed Better default preview time
based on global fade

This is an oversight. The preview point wasn't being offset to account
for the fade in. This is something we do when generating web-side
previews, which allows for the actual preview point to be audible,
rather than mid-fade.

### 8de323b68c Adjust fade in and fade out
during track transitions to reduce overlap

Yes, I'm aware that the delay is not accounted for in the constant. This
is intentional because it sounds better. I want this to be an internal
adjustment which is not to be considered by any external usages of those
constants. Just sounds better.

### aab01b0fe5 Remove weird/dated schedule
usage

This causes audible artifacts in playback. The track is not set to zero
volume early enough. Original change was made in [this ancient
PR](https://github.com/ppy/osu/pull/9792) (see
[commit](https://github.com/ppy/osu/commit/688e4479506645bdacee7cdc7ae9ee9deaa5f1b4)).
The original failure does not occur. Tests still pass. I'd argue that if
we encounter this again, it's an issue at the call site, not this code.

This is a drive-by fix, as I noticed this glitching while working on the
main issue here. Arguably should be it's own PR 🤷 .

Dean Herbert · 2026-03-18 10:58:05 +01:00

978e380087

Fix track not looping if specified preview point exceeds duration of track

By falling back to the default of 40% of track duration in such cases.

Also added a safety for the restart point exceeding acceptable bounds in
case of a non-zero offset.

Closes https://github.com/ppy/osu/issues/33308.

Bartłomiej Dach · 2025-06-03 14:55:05 +02:00

511c1d835b

Include beatmap details in logs when load fails

See
https://github.com/ppy/osu/discussions/32682#discussioncomment-12760059
for ambiguous logs.

Dean Herbert · 2025-04-08 15:33:43 +09:00

d31ffd9014

Apply more granular copying from database when retrieving working beatmap

Bartłomiej Dach · 2025-03-10 13:06:50 +01:00

afad2cf278

Avoid accessing WorkingBeatmap.Beatmap every update call

Notice in passing.

Comes with overheads that can be easily avoided. Left a note for a
future (slightly more involved) optimisation.

Dean Herbert · 2025-02-03 16:30:31 +09:00

a23de0b188

Merge branch 'master' into beatmap-info-purge

Dean Herbert · 2024-11-22 18:47:32 +09:00

086a34f5c0

Fix usage of locked context without locking

Raised in the latest Rider EAP, seems valid enough.

Dean Herbert · 2024-10-01 18:01:06 +09:00

307cc5581d

Fix WidescreenStoryboard breakage after moving out of BeatmapInfo

Bartłomiej Dach · 2024-07-23 12:19:45 +02:00

1d4d806362

Crop and disable mipmaps on beatmap panel backgrounds

This is an effort to improve general performance at song select. At
least on the metal renderer, I can notice very high draw frame overheads
related to texture uploads.

By reducing the size of the texture uploads to roughly match what is
actually being displayed on screen (using a relatively inexpensive crop
operation), we can bastly reduce stuttering both during initial load and
carousel scroll.

You might ask if it's safe to disable mipmapping, but I've tested with
lower resolutions and bilinear filtering seems to handle just fine.
Bilinear without mipmaps only falls apart when you scale below 50% and
we're not going too far past that at minimum game scale, if at all.

Dean Herbert · 2023-06-08 16:51:07 +09:00

3978d4babb

Refactor IWorkingBeatmap.Background to GetBackground()

Dean Herbert · 2023-06-08 16:19:32 +09:00

a842f79ad4

Remove usages of [ExcludeFromDynamicCompile]

Dan Balasescu · 2023-05-08 18:12:56 +09:00

d2380bd840

Dispose previous waveform on track reload

Salman Ahmed · 2022-12-23 00:35:59 +03:00

30de9ba795

Invalidate waveform on track load

ansel · 2022-12-22 20:49:09 +03:00

20370bd5ae

Rewrite waveform invalidation

ansel · 2022-12-22 15:59:51 +03:00

d0645ce151

Clear cached waveform on track change in editor

ansel · 2022-12-22 01:23:24 +03:00

66a02374da

Fix incorrect offset logic for beatmaps without a preview point specified

Dean Herbert · 2022-10-12 14:47:37 +09:00

db148d145b

Rename parameter to read better

Dean Herbert · 2022-10-12 14:46:35 +09:00

721bfb5369

Update WorkingBeatmap.cs

NotGumballer91 · 2022-10-11 01:48:55 +08:00

3cd6ce8e3f

Update WorkingBeatmap.cs

NotGumballer91 · 2022-10-10 21:03:11 +08:00

749dc40062

Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset

# Conflicts:
#	osu.Game.Rulesets.Catch/CatchRuleset.cs
#	osu.Game.Rulesets.Osu/OsuRuleset.cs
#	osu.Game.Rulesets.Taiko/TaikoRuleset.cs
#	osu.Game/Rulesets/Ruleset.cs

andy840119 · 2022-09-10 10:40:12 +08:00

e62999fb16

Fix a couple of oversights regarding track nullability

Dean Herbert · 2022-08-25 14:45:00 +09:00

ad3dd1c700

Allow preparing preview point without looping

Dean Herbert · 2022-08-17 13:20:24 +09:00

37799e3b31

Mark the CreateBeatmapProcessor() as nullable.

Also, should add the null check in the working beatmap.

為什麼 · 2022-07-10 10:15:27 +08:00

57c6763556

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Use Track to ensure its loaded before transferring

Salman Ahmed · 2022-05-21 16:52:16 +03:00

a17eed64f9

Bring back virtual track condition given its cheapness

Will still keep the override in `ClockBackedTestWorkingBeatmap` because
it still relies on a local track store and will fail the moment it uses
a non-virtual track.

Salman Ahmed · 2022-05-21 16:51:56 +03:00

a42f5ea34e

Fix wrong return xmldoc

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Salman Ahmed · 2022-05-21 16:43:31 +03:00

466ed3c791

Refactor track transferring logic for ability to override and disallow

Salman Ahmed · 2022-05-20 14:43:07 +03:00

c78d90ccbd

Change WorkingBeatmap.GetVirtualTrack to use length provided by BeatmapInfo

A lot of tests are using test resources that populate the length field,
but do not populate hitobjects. The general expectation is that
components should be using the cached length in cases where hitobjects
are not relevant, but `GetVirtualTrack` was doing its own local
calculation.

This could cause tests to fail due to `MusicController` changing track
in the background.

Dean Herbert · 2022-04-06 14:51:15 +09:00

552ec5282f

Fix incorrect Metadata-related null checks

Dean Herbert · 2022-01-12 16:39:36 +09:00

df088f96f4

Update usages to new naming

Dean Herbert · 2022-01-06 22:54:43 +09:00

00177a3ae1

Replace usage of .Result with .WaitSafelyForResult

Dean Herbert · 2022-01-04 11:51:41 +09:00

73b40e6833

Revert "Apply NRT to WorkingBeatmap"

This reverts commit 9e17d7d4e3.

Dean Herbert · 2021-12-22 19:14:18 +09:00

bc47801cbb

Apply NRT to WorkingBeatmap

Dean Herbert · 2021-12-22 18:41:45 +09:00

9e17d7d4e3

Move public accessor properties to top of file

Dean Herbert · 2021-12-22 18:25:09 +09:00

53c0a6708f

Move load methods and rename loadedTrack to match other private fields

Dean Herbert · 2021-12-22 18:24:51 +09:00

a5f77a86ef

Remove RecyclableLazy

Dean Herbert · 2021-12-22 18:18:12 +09:00

7344c87b16

Remove unused load checks