35 Commits

• Tooling updates (#37031)

  Most of this is as everywhere else, but there's also interesting code
  inspection fixes from the InspectCode bump, so I'll talk about that a
  little.
  
  ## [Fix suspicious equality in
  `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html
  
  Pretty annoying to fix, nullable array types are a pain. Does look legit
  though.
  
  ## [Fix `StarDifficulty` using inefficient struct
  equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html
  
  This is a dodgy one because there's no real sane way to define equality
  on `StarDifficulty` now that it has difficulty and performance
  attributes jammed into it. So I just basically shut the inspection up
  with a `record` modifier and move on.
  
  Unclear where the equality is used precisely. It's from a global
  inspection. F12 is very unhelpful when trying to track down usages of
  `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
  those do use equality. Maybe more than that.
  
  ## [Use `nameof` expressions to reference enum member
  names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Pretty quaint.
  
  ## [Prefer using concrete values over `default` or
  `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html
  
  I could see this one going both ways, but I'm kinda sold on this
  inspection. Explicit is always better. Saves some allocations in the
  `CancellationToken` cases as well.
  
  ## [Explicitly call `.AsEnumerable()` in some realm
  usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html
  
  Not fully sold on this one but it's quick and simple so might as well.
  
  ## [Simplify dictionary removal with single `.Remove()`
  call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Not much to say.

  Bartłomiej Dach · 2026-03-19 00:05:52 +09:00
  18d4ba5874
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Store default skins to database
  Dean Herbert · 2021-11-29 18:28:25 +09:00
  f6a3709060
• Replace "end glow" terminology with "hyper-dash after-image"

  Because the is "end glow" is when a hyper-dash is *started*, the name was confusing.
  The "after-image" was already used in the code as a synonym of "end glow" inconsistently.

  ekrctb · 2021-07-28 19:11:22 +09:00
  a960a28d06
• Avoid internal property by using ChildrenOfType
  ekrctb · 2021-07-28 18:13:43 +09:00
  0bf04ece34
• Move catcher trail generation logic to CatcherArea
  ekrctb · 2021-07-27 19:07:37 +09:00
  da69867fd4
• Move catcher trail generation logic to Catcher

  It resolves mutual dependency of `Catcher` and `CatcherTrailDisplay`.
  Trail generation logic is moved to `Catcher`.
  The generation logic no longer uses delayed scheduling because the hidden state is hard to manage.
  Instead, the last time a trail is generated is calculated and used.
  The new logic has a different behavior when the dash key is pressed in succession under 50ms, but it is not noticeable for normal plays.

  ekrctb · 2021-07-26 17:51:59 +09:00
  bb046fa3b8
• Pass DroppedObjectContainer via constructor instead of DI

  It is now just one level deep, so it is not beneficial to use DI here.
  This effectively reverts ae09c23e.

  ekrctb · 2021-07-19 20:11:49 +09:00
  b88ee3c1a1
• Create Catcher in CatchPlayfield
  ekrctb · 2021-07-19 19:44:40 +09:00
  97059a9f50
• Remove redundant arguments
  PercyDan54 · 2021-07-05 23:52:39 +08:00
  e1c646b9b2
• Resolve DroppedObjectContainer via DI
  ekrctb · 2021-06-24 16:09:13 +09:00
  ae09c23e4e
• Add DroppedObjectContainer class
  ekrctb · 2021-06-24 15:51:54 +09:00
  16d5893535
• more specific type droppedObjectContainer
  ekrctb · 2020-12-09 10:35:01 +09:00
  ccca7e0b25
• Adjust namespace
  ekrctb · 2020-12-07 12:35:24 +09:00
  d18397acad
• Fix depth of dropped objects
  ekrctb · 2020-12-04 10:21:54 +09:00
  e82ca66d3e
• Fix osu!catch test failures due to trying to retrieve container too early
  Dean Herbert · 2020-10-19 20:00:17 +09:00
  a50ca0a1ed
• Remove special case for moving catcher sprite
  Bartłomiej Dach · 2020-05-06 23:25:25 +02:00
  ed83ac188e
• Replace finishing catcher transforms with until-true step
  Salman Ahmed · 2020-04-22 10:43:49 +03:00
  bffe6742e0
• Make the Catcher.Colour assertion read better
  Salman Ahmed · 2020-04-22 10:40:21 +03:00
  730b5ea1a9
• Retrieve CatcherTrailDisplay for asserting colours set correctly
  Salman Ahmed · 2020-04-22 05:12:51 +03:00
  5d3475a5ed
• Merge branch 'master' of github.com:ppy/osu into catch-hyperdash-catcher-colouring
  Salman Ahmed · 2020-04-21 05:58:56 +03:00
  e17a44c99b
• Refactor test code to eliminate boolean flags
  Bartłomiej Dach · 2020-04-19 12:46:28 +02:00
  e3e0cd149f
• Convert all static getter-only properties to static readonly fields
  Salman Ahmed · 2020-04-08 14:23:29 +03:00
  d27d8671ab
• Test CatchSkinColour transformation on colour retrieval implicitly
  Salman Ahmed · 2020-04-05 00:13:23 +03:00
  b100230538
• Revert "Add support for custom hyper-dash fruit colouring"

  This reverts commit 6f2cc5471a and also its testing cases.
  
  This became dead code after actual correct osu!catch skin colouring, we don't support modern skinning (non-legacy skinning) at the moment, so for what it's worth this can be reverted to default red-coloured

  Salman Ahmed · 2020-04-05 00:07:25 +03:00
  c4f7b45768
• Merge branch 'catch-hyperdash-fruit-colouring' into catch-hyperdash-catcher-colouring
  Salman Ahmed · 2020-04-04 18:07:29 +03:00
  ee247e58c8
• Make parameters required
  Salman Ahmed · 2020-04-03 19:53:38 +03:00
  dd684b68d9
• Describe step names more
  Salman Ahmed · 2020-04-03 19:50:32 +03:00
  0340b6db51
• CatchSkinConfiguration -> CatchSkinColour
  Salman Ahmed · 2020-03-30 09:33:47 +03:00
  16a4525a9c
• Add a legacy skin provider above the test skin
  Salman Ahmed · 2020-03-30 09:29:00 +03:00
  e51097da9e
• Apply review suggestions
  Salman Ahmed · 2020-03-28 07:43:47 +03:00
  45eb03bfe2
• Add hyper-dash catcher & trails colouring test cases
  Salman Ahmed · 2020-03-26 09:19:00 +03:00
  77b3011394
• Add hyper-dash fruit colouring test cases
  Salman Ahmed · 2020-03-26 05:42:13 +03:00
  29274b004c
• Setup hyper-dash colouring test scene
  Salman Ahmed · 2020-03-26 05:42:11 +03:00
  aa162b1033