44264 Commits

This Branch

This Branch

All Branches

• Fix FindProvider calls on SkinProvidingContainer not considering disable flags

  Closes #13394.

  Dean Herbert · 2021-06-09 16:19:04 +09:00
  448e4e7ee5
• Add failing test coverage for beatmap skin disable
  Dean Herbert · 2021-06-09 16:19:04 +09:00
  38fc9347be
• Fix circle piece animation is sometimes not playing when a replay is rewound
  ekrctb · 2021-06-09 16:14:55 +09:00
  610cdaea98
• Check skin version for legacy catcher sprite
  ekrctb · 2021-06-09 15:47:23 +09:00
  e5deecf459
• Merge branch 'master' into fix-skin-background-regression
  Bartłomiej Dach · 2021-06-09 08:09:21 +02:00
  023015f9a6
• Merge pull request #13400 from peppy/remove-obsoleted-drawable-judgement-methods

  Remove some obsoleted members

  Dan Balasescu · 2021-06-09 15:01:25 +09:00
  8a221f501d
• Use candidate skin for mania skin key lookup rather than this
  Dean Herbert · 2021-06-09 15:00:55 +09:00
  d248bbd4c8
• Ensure background rotation on default skins
  Bartłomiej Dach · 2021-06-09 07:59:47 +02:00
  a801a9a14d
• Add test coverage for default skin background cycling
  Bartłomiej Dach · 2021-06-09 07:48:16 +02:00
  5487012060
• Remove difficulty calculator exceptions

  I don't think there's any reason difficulty calculators shouldn't be
  able to calculate for autoplays.

  Dean Herbert · 2021-06-09 14:33:35 +09:00
  85abee5fc7
• Update ModAutoplay matching to use new UserPlayable flag instead
  Dean Herbert · 2021-06-09 14:32:48 +09:00
  b754c52392
• Fix incorrect method referenced in xmldco

  Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com>

  Dean Herbert · 2021-06-09 14:20:01 +09:00
  b8df3fff9e
• Replace and obsolete Ranked flag with IsUserPlayable
  Dean Herbert · 2021-06-09 14:17:03 +09:00
  d0e9f8ef90
• Add one missing obsoletion removal date
  Dean Herbert · 2021-06-09 14:11:50 +09:00
  62199a38a8
• Remove more obsoleted members
  Dean Herbert · 2021-06-09 14:10:48 +09:00
  f41e34ae2c
• Remove obsoleted DrawableJudgement methods

  Undated, but change was made on 2020-11-18.

  Dean Herbert · 2021-06-09 14:09:23 +09:00
  a87226ab10
• Remove "Unranked" text from ModDisplay
  Dean Herbert · 2021-06-09 13:45:09 +09:00
  7774344f0e
• Reword "unranked" to "not ranked" on beatmap overlay

  This will be replaced anyway once we start to consume osu-web
  translation strings.

  Dean Herbert · 2021-06-09 13:44:27 +09:00
  249a8f259b
• Merge pull request #13397 from ekrctb/fix-event-not-unregistered

  Fix registered event not unregistered on dispose

  Dean Herbert · 2021-06-09 13:12:06 +09:00
  2f6227e0f2
• Fix event not unregistered on dispose
  ekrctb · 2021-06-09 12:35:14 +09:00
  555ab8fccd
• Merge pull request #13396 from ekrctb/fix-circle-piece

  Fix hit circle animation is removed when a replay is rewound

  Dean Herbert · 2021-06-09 11:39:38 +09:00
  e914fbf449
• Fix hit circle animation when a replay is rewound
  ekrctb · 2021-06-09 10:53:52 +09:00
  4707918c6a
• Reduce unnecessary background changes via IEquatable implementation
  Bartłomiej Dach · 2021-06-08 22:37:18 +02:00
  97204b6f27
• Add test coverage for keeping same background instance
  Bartłomiej Dach · 2021-06-08 22:31:09 +02:00
  f628ec25ef
• Bring back skin background source
  Bartłomiej Dach · 2021-06-08 22:04:59 +02:00
  a98c302211
• Add test coverage for skin background source
  Bartłomiej Dach · 2021-06-08 22:03:59 +02:00
  d86ace4d11
• Move skin background to separate file
  Bartłomiej Dach · 2021-06-08 21:57:08 +02:00
  5bf4dd6358
• Ensure scale x or y does not go below zero in SkinSelectionHandler.HandleScale
  Robin Avery · 2021-06-08 11:49:25 -04:00
  2484ccd50c
• Apply fixed label width to setup screen items
  Bartłomiej Dach · 2021-06-08 17:18:00 +02:00
  410cb16340
• Add option to fix label width of a LabelledDrawable
  Bartłomiej Dach · 2021-06-08 16:57:32 +02:00
  88266eac63
• Merge pull request #13380 from smoogipoo/fix-multi-spec-dt-doubling-2

  Fix DT being doubled in multiplayer spectator

  Dean Herbert · 2021-06-08 23:31:56 +09:00
  2021.608.0 04cc788627
• Add guard clause to applyOrigins and rename parameter
  Robin Avery · 2021-06-08 10:29:45 -04:00
  10b6b72909
• Rename applyCustomAnchors to applyFixedAnchors for consistency with UsesFixedAnchor
  Robin Avery · 2021-06-08 10:14:07 -04:00
  d212918d67
• Add colours for tick judgements
  smoogipoo · 2021-06-08 23:10:21 +09:00
  00efed2c39
• Simplify applyClosestAnchor to one line by moving another guard clause
  Robin Avery · 2021-06-08 10:09:48 -04:00
  2c88e6df8d
• Ignore non-scorable and bonus judgements
  smoogipoo · 2021-06-08 23:09:23 +09:00
  c8e14d7710
• Fix DT being doubled in multiplayer spectator
  smoogipoo · 2021-06-08 22:51:42 +09:00
  c3ea1b26e1
• Move guard clause from checkAndApplyClosestAnchor to applyAnchor
  Robin Avery · 2021-06-08 09:51:39 -04:00
  f22cc981d1
• Rename some methods for clarity

  Methods which operate on a collection of `ISkinnableDrawable`s are now
  plural; ones which take a single item are singular.
  
  This also allows cutting down the name of `getClosestAnchorForDrawable`
  to just `getClosestAnchor`.

  Robin Avery · 2021-06-08 09:44:42 -04:00
  529a80871b
• Refactor updateDrawableAnchorIfUsingClosest
  Robin Avery · 2021-06-08 09:25:49 -04:00
  01da73daf2
• Inline updateDrawableAnchorIfUsingClosest
  Robin Avery · 2021-06-08 09:14:04 -04:00
  6b127f50f2
• ICatcherPiece -> ICatcherSprite
  ekrctb · 2021-06-08 22:10:13 +09:00
  7df971a970
• Make current state bindable protected
  ekrctb · 2021-06-08 22:08:54 +09:00
  194c78f67a
• Use separate classes for old and new catcher legacy skin element

  - Fix catcher texture animation is reset for legacy old catcher skin

  ekrctb · 2021-06-08 21:59:09 +09:00
  109a366722
• Refactor catcher sprite to use skinned piece pattern
  ekrctb · 2021-06-08 21:29:41 +09:00
  0192549d6c
• Rename OverridesClosestAnchor to UsesFixedAnchor
  Robin Avery · 2021-06-08 08:28:42 -04:00
  dc50ae40b9
• Merge pull request #13337 from Pasi4K5/fix-sliders-out-of-screen

  Fix sliders sometimes being outside of the playfield with osu! random mod enabled

  Dean Herbert · 2021-06-08 21:18:21 +09:00
  475788041a
• Merge pull request #13375 from smoogipoo/fix-multi-nullref

  Fix possible nullref when exiting song select too fast

  Dean Herbert · 2021-06-08 20:47:40 +09:00
  25af4dfa8a
• Merge pull request #13377 from peppy/fix-lazer-replays-getting-classic

  Move legacy `ScoreInfo` to be completely based on presence of classic mod

  Dan Balasescu · 2021-06-08 19:15:13 +09:00
  5a8cde7e6f
• Merge pull request #12970 from peppy/fix-skin-sample-lookup

  Fix default skin sample fallback logic existing within `PoolableSkinnableSample`

  Dan Balasescu · 2021-06-08 19:10:04 +09:00
  d9ac9f641a