75266 Commits

This Branch

This Branch

All Branches

• Avoid triggering changes when add operations are empty

  Only seems to happen in tests. I think.

  Dean Herbert · 2025-08-27 18:13:13 +09:00
  0e57ee9ba6
• Add test coverage ensuring filtering does not occur on unnecessary updates
  Dean Herbert · 2025-08-27 18:13:12 +09:00
  043235fed2
• Merge pull request #34803 from peppy/update-framework-please-no-clock-breakage

  Update framework

  Dean Herbert · 2025-08-27 13:23:09 +09:00
  2025.827.0-tachyon ec21685c25
• Update framework
  Dean Herbert · 2025-08-26 21:43:09 +09:00
  244bad07c7
• test(ManiaFilterCriteriaTest): simplify test case
  Binwalker · 2025-08-26 21:36:20 +09:00
  149f18c3f5
• refactor(ManiaFilterCriteria): exclude converted beatmaps from long note filter
  Binwalker · 2025-08-26 21:36:20 +09:00
  6a82b7331f
• test(ManiaFilterCriteriaTest): fix some test case for ln filter
  Binwalker · 2025-08-26 21:36:20 +09:00
  65253708d8
• fix(ManiaFilterCriteria): converted beatmaps are not included
  Binwalker · 2025-08-26 21:36:20 +09:00
  556c2469bf
• test(ManiaFilterCriteriaTest): add some testcase
  Binwalker · 2025-08-26 21:36:20 +09:00
  f7b0e114a9
• feat(ManiaFilterCriteria): add long note ratio filter for mania
  Binwalker · 2025-08-26 21:36:19 +09:00
  68677200f3
• Merge pull request #34802 from bdach/hack-around-carousel-panel-refresh

  Work around excessive refreshes of carousel beatmap set panel backgrounds

  Dean Herbert · 2025-08-26 21:13:28 +09:00
  2bea59e65f
• Work around excessive refreshes of carousel beatmap set panel backgrounds

  Closes https://github.com/ppy/osu/issues/34511 I guess.

  Bartłomiej Dach · 2025-08-26 13:27:54 +02:00
  c0fd5637de
• Merge pull request #34801 from peppy/replay-player-null

  Fix crash on exiting `ReplayPlayer` is beatmap was not loaded successfully

  Bartłomiej Dach · 2025-08-26 12:11:27 +02:00
  5e7a99c97f
• Merge pull request #34800 from peppy/fix-daily-challenge-leaderboard-skip

  Fix daily challenge / playlist leaderboard sometimes showing incorrect default state

  Bartłomiej Dach · 2025-08-26 12:07:41 +02:00
  8f628d16ae
• Add test coverage and fix one more fail case
  Dean Herbert · 2025-08-26 18:41:14 +09:00
  2ccb65aa65
• Fix crash on exiting ReplayPlayer is beatmap was not loaded successfully

  Closes https://github.com/ppy/osu/issues/34763.

  Dean Herbert · 2025-08-26 18:31:42 +09:00
  4d851f2527
• Apply NRT to ReplayPlayer for good measure
  Dean Herbert · 2025-08-26 18:30:12 +09:00
  4bafbfb9e4
• Sort scores immediately for good measure
  Dean Herbert · 2025-08-26 17:51:14 +09:00
  3f179e3903
• Fix playlist leaderboard provider potentially inserting local user in wrong order

  Due to `Perform` being used from a BDL method in conjunction with
  `Success` (which is scheduled to the *update* thread), there was a
  chance that the order of execution would be not quite as intended.
  
  To rectify, let's not use `Success` and just continue with synchronous
  flow.

  Dean Herbert · 2025-08-26 17:51:02 +09:00
  196b28115e
• Merge pull request #34794 from bdach/fix-aim-meter

  Fix aim error meter applying incorrect scaling constant in normalised mode

  Dean Herbert · 2025-08-26 15:16:15 +09:00
  7660a9ba8e
• Fix aim error meter applying incorrect scaling constant in relative mode

  Closes https://github.com/ppy/osu/issues/34769
  
  Visible (and easiest to check) in test scene.

  Bartłomiej Dach · 2025-08-25 14:20:05 +02:00
  e908b80359
• Fix copy-paste fail in log message
  Bartłomiej Dach · 2025-08-25 13:43:03 +02:00
  a2bf8e3988
• Merge pull request #34761 from frenzibyte/fix-flashlight

  Fix flashlight not always matching gameplay scaling

  Bartłomiej Dach · 2025-08-25 12:03:58 +02:00
  6e8246b539
• Fix xmldoc error and reword
  Salman Alshamrani · 2025-08-24 18:55:45 +03:00
  3cca458c21
• Fix flashlight not handling internal playfield sizing changes

  Note that this does not handle sizing/scaling changes applied directly
  to `Playfield`, but it handles any changes within the layers inside
  `PlayfieldAdjustmentContainer`.

  Salman Alshamrani · 2025-08-24 17:51:05 +03:00
  bc59270f3e
• Merge pull request #34766 from bdach/remove-double-lookup

  Pull up online beatmap set lookup to song select level to avoid two components doing the same fetch independently

  Dean Herbert · 2025-08-23 20:50:17 +09:00
  16343fd7d6
• Merge pull request #34757 from bdach/new-mod-icons

  Update mod icons

  Dean Herbert · 2025-08-23 19:55:10 +09:00
  acafc06bcc
• Remove no longer valid test
  Salman Alshamrani · 2025-08-23 09:28:14 +03:00
  c0c3690908
• Fix song select favourite button potentially showing stale data from (un)favourite request callback
  Bartłomiej Dach · 2025-08-22 14:25:25 +02:00
  5292d4a04e
• Pull up online beatmap set lookup to song select level to avoid two components doing the same fetch independently
  Bartłomiej Dach · 2025-08-22 14:25:21 +02:00
  d3ae20dd88
• Merge pull request #34723 from bdach/status-updates-are-great-arent-they

  Refresh realm before performing song select refetches following an online metadata lookup

  Dean Herbert · 2025-08-22 20:25:36 +09:00
  2025.822.0-tachyon c852e5854c
• Update tests
  Bartłomiej Dach · 2025-08-22 12:44:08 +02:00
  03e7e2b0d8
• Add indicator for pinned rooms in upper right of room panel
  Bartłomiej Dach · 2025-08-22 10:17:15 +02:00
  20b316d32d
• No longer download iOS simulator

  https://github.com/actions/runner-images/issues/12862#issuecomment-3209787203

  Dan Balasescu · 2025-08-22 13:29:46 +09:00
  0756c45d70
• Add visual test setup for taiko flashlight
  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  73624e4e25
• Fix taiko flashlight applying aspect ratio twice
  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  f374af7ce7
• Adjust default flashlight size on osu! & osu!catch

  Because the flashlight is made to be scaled by playfield, there are
  constant scale factors applied somewhere in the
  `PlayfieldAdjustmentContainer` which needs to be reflected in the
  flashlight size to keep the size the same.
  
  The factor is specifically 1.6x, computed in {Osu,Catch}PlayfieldAdjustmentContainer.ScalingContainer`.
  
  More generally, I've deduced these factors by logging the difference
  between the `flashlightSize` before and after b78abe2f.

  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  7530ad1a7b
• Fix flashlight not correctly scaled to match playfield
  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  a049f5065d
• Update resources
  Bartłomiej Dach · 2025-08-21 14:44:43 +02:00
  4627c8a859
• Show pinned rooms on top of listing
  Bartłomiej Dach · 2025-08-21 14:18:13 +02:00
  a6f823e5bc
• Merge pull request #34759 from bdach/BACKGROUND-STUCK-PLEASE-I-BEG-YOU

  Fix song select background being stuck in revealed state

  Dean Herbert · 2025-08-21 21:01:59 +09:00
  30f7da8f71
• Merge pull request #34752 from bdach/avoid-endless-futile-backpopulation

  Fix submission & rank date backpopulation failing every launch for some users

  Dean Herbert · 2025-08-21 20:37:03 +09:00
  4b8ff481fd
• Fix song select background being stuck in revealed state

  Closes https://github.com/ppy/osu/issues/34731.
  
  The failure scenario here is as follows:
  
  - User holds down left mouse button for >200ms to reveal the background.
  - User presses down another mouse button and releases it in <200ms.
  - User releases left mouse button. Song select does not return.
  
  The timing here is key because what is happening here is that the second
  mouse button press is overwriting the `revealingBackground` scheduled
  delegate. Releasing that same mouse button within 200ms leads to that
  scheduled delegate being cancelled and cleared, and thus the release of
  left mouse wrongly decides there is nothing left to do.
  
  One thing I'm not entirely sure about is the release behaviour even with
  this change; as things stand, the first release of any mouse button will
  bring song select back, even if it was not the button that was initially
  held down to reveal the background. That's probably easily fixed if
  deemed required, but I'm most interested in fixing the bad breakage.

  Bartłomiej Dach · 2025-08-21 11:31:37 +02:00
  a7f1795f98
• Adjust icon sizings in mod display to match new assets
  Bartłomiej Dach · 2025-08-21 09:00:48 +02:00
  c053cfbf9b
• Add test steps to mod icon test scene for exercising all rulesets
  Bartłomiej Dach · 2025-08-21 09:00:46 +02:00
  e47a60f303
• Add and use new mod icon assets
  Bartłomiej Dach · 2025-08-21 09:00:44 +02:00
  92016a7d9b
• Merge pull request #34643 from frenzibyte/leaderboard-resize

  Fix leaderboard not resizing correctly

  Dean Herbert · 2025-08-21 13:33:24 +09:00
  41885c0fc0
• Log bass issues for more than one frame
  Dean Herbert · 2025-08-21 13:27:14 +09:00
  e75a6b4010
• Adjust bass invalid data threshold
  Dean Herbert · 2025-08-21 13:27:13 +09:00
  ddce11fbc8
• Fix submission & rank date failing every launch for some users

  Addresses https://github.com/ppy/osu/discussions/34705, I suppose.
  
  The cagey tone of that statement is because this change merely papers
  over the issue. The issue in question for the user that reported this is
  that they have a bunch of very old beatmaps, whose md5 hashes do not
  match the online hashes, that need updating. The submission/rank date
  population was running every single time for these, and failing every
  time, because there is really not much useful that the lookup *can* do.
  
  Because mappers have made `OnlineID` essentially useless for determining
  the provenance of a beatmap due to reusing them to "fix" beatmap
  submission failures, online IDs have been explicitly disallowed from use
  in any sort of beatmap lookup flow. The only things that are allowed to
  be used are: md5 of the beatmap, and filename as a fallback for very old
  beatmaps / beatmap packs.
  
  If the user has local beatmaps with md5 not matching online, chances are
  that any metadata lookups are likely to fail or return bogus data. At
  that point my personal feeling is that backpopulation flows should leave
  such beatmaps well alone and the user should just go update the beatmap
  themselves.
  
  I am aware that updating 124 individual beatmap sets would - in the
  current state of things - would probably be a ridiculously onerous thing
  to do, and that people have been asking multiple times for a facility to
  update all local beatmaps at once, but that discussion is out of scope
  at this stage.

  Bartłomiej Dach · 2025-08-20 09:21:35 +02:00
  c894969d17