75266 Commits

This Branch

This Branch

All Branches

• Merge pull request #33420 from peppy/song-select-v2-hold-for-entry

  Change method of accessing song select v2 to hold

  Bartłomiej Dach · 2025-06-05 08:15:29 +02:00
  38550c25d2
• Merge pull request #33419 from peppy/song-select-v2-fix-edit-crash

  SongSelectV2: Fix crash when returning to song select from editor

  Bartłomiej Dach · 2025-06-05 08:08:04 +02:00
  0ac8759471
• Adjust background fade for placeholder to run faster
  Dean Herbert · 2025-06-05 14:55:18 +09:00
  64d9868ddf
• Update resources
  Dean Herbert · 2025-06-05 14:49:35 +09:00
  08f4e6512e
• Merge pull request #33402 from bdach/preview-point-validity

  Fix track not looping if specified preview point exceeds duration of track

  Dan Balasescu · 2025-06-05 13:59:26 +09:00
  cf297ae743
• Merge pull request #33414 from bdach/song-select-v2-fix-sheared-triangles

  SongSelectV2: Fix triangles being sheared on leaderboard panels

  Dean Herbert · 2025-06-05 13:55:51 +09:00
  16ab32b456
• Fix heights of title wedge sections to avoid weirdness when showing placeholder
  Dean Herbert · 2025-06-05 04:18:55 +09:00
  db7afd0e21
• Merge branch 'master' into feature/ssv2-animated-ghost
  maarvin · 2025-06-04 21:15:24 +02:00
  14cd6eac87
• Fix tiny stats showing when larger ones still could
  Dean Herbert · 2025-06-05 04:08:23 +09:00
  2082a31a69
• Change method of accessing song select v2 to hold
  Dean Herbert · 2025-06-05 04:00:47 +09:00
  63d52de1a7
• Fix beatmap changes handling when song select is not active
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  e35d0f8953
• Add test coverage of editor flow from song select
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  bb49bb5e23
• Add back more song select navigation tests
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  118583bf21
• Fix incorrect operation order for calculating shader time uniform
  marvin · 2025-06-04 20:43:01 +02:00
  1c32b5364f
• Extract animation duration property
  marvin · 2025-06-04 20:23:54 +02:00
  24e102066b
• Merge pull request #33413 from bdach/update-framework

  Update framework

  Dean Herbert · 2025-06-05 03:15:27 +09:00
  6d5bf22a71
• Add disposal logic in ghost drawnode
  marvin · 2025-06-04 20:03:50 +02:00
  7b7e57543c
• Add xmldoc
  marvin · 2025-06-04 20:03:40 +02:00
  96db7b3af6
• Change ghost animation to up-down movement
  marvin · 2025-06-04 19:59:52 +02:00
  7f618b1dc7
• Use ghost icon in NoResultsPlaceholder
  marvin · 2025-06-04 19:58:55 +02:00
  8d1702fbac
• Add ghost drawable
  marvin · 2025-06-04 19:58:04 +02:00
  7ecf81d3a0
• Merge pull request #33416 from peppy/song-select-v2-fix-selection-change
  Bartłomiej Dach · 2025-06-04 19:48:59 +02:00
  695f925b66
• Merge pull request #33391 from smoogipoo/no-cleanup-test-trackstore

  Attempt to fix flaky tests by removing finaliser

  Bartłomiej Dach · 2025-06-04 14:29:55 +02:00
  1d1ade48d6
• SongSelectV2: Fix incorrect selection change when filtered down to one set
  Dean Herbert · 2025-06-04 21:19:51 +09:00
  f52fabbb0c
• Add failing test showing recommended selection occurring on already selected set
  Dean Herbert · 2025-06-04 21:19:51 +09:00
  7e922763c1
• Merge pull request #33390 from peppy/song-select-v2-ensure-valid-selection

  SongSelectV2: Fix being able to reach gameplay with invalid ruleset selection

  Dean Herbert · 2025-06-04 21:09:47 +09:00
  c8b7ab4f28
• Fix cursor test
  Bartłomiej Dach · 2025-06-04 13:34:21 +02:00
  68795255ee
• Update framework

  Contains a native libs / BASS rollback due to
  https://github.com/ppy/osu/discussions/33260.
  
  - Reopens https://github.com/ppy/osu/issues/31702.
  - Reopens https://github.com/ppy/osu/issues/26879.

  Bartłomiej Dach · 2025-06-04 13:34:21 +02:00
  d262b6e88f
• SongSelectV2: Fix triangles being sheared on leaderboard panels
  Bartłomiej Dach · 2025-06-04 13:25:01 +02:00
  136c5c866b
• Fix wedge pieces disappearing when they shouldn't
  Dean Herbert · 2025-06-04 19:51:46 +09:00
  d79de43a29
• Mark test scene class partial
  Bartłomiej Dach · 2025-06-04 11:23:10 +02:00
  2cd923ba26
• Add back test covering immediate exit song select
  Dean Herbert · 2025-06-04 17:59:08 +09:00
  7d8df1d8d4
• Avoid showing wedge until a valid beatmap is selected
  Dean Herbert · 2025-06-04 17:39:22 +09:00
  8842f935f1
• Fix audio not correctly continuing on resuming from gameplay
  Dean Herbert · 2025-06-04 17:39:22 +09:00
  f086be9c18
• Ensure we use valid criteria when attempting to select a beatmap

  `OnEntering` runs before `FilterControl.LoadComplete` meaning that
  `BeatmapCarousel` doesn't have filter populated yet...

  Dean Herbert · 2025-06-04 17:36:44 +09:00
  c009d4d03c
• Move state updates to separate method and flow
  Dean Herbert · 2025-06-04 15:45:40 +09:00
  4fcdfa2cfc
• Ensure valid ruleset for gameplay
  Dean Herbert · 2025-06-04 15:45:40 +09:00
  c73ef15ebf
• SongSelectV2: Simplify and standardise selection logic

  Before attempting to fix issues with invalid selections reaching
  gameplay, I needed to do a pass of the song select class as selection
  logic was already more complex than I'd hope.
  
  All operations now go through a single flow (`SelectAndRun`) when
  leaving the song select screen in a "success" state.

  Dean Herbert · 2025-06-04 15:45:40 +09:00
  12d3952905
• Add failing test coverage showing bad selection logic
  Dean Herbert · 2025-06-04 15:45:36 +09:00
  b42b8ba0de
• Merge pull request #33373 from peppy/song-select-v2-more-sane-input-padding

  SongSelectV2: Store input padding adjustments in `CarouselItem` to allow more reliable inflation

  Bartłomiej Dach · 2025-06-04 07:41:18 +02:00
  3624c251a2
• Merge pull request #33404 from peppy/song-select-v2-remove-dead-code

  Remove local manifestation of beatmap sets now that set items is always populated

  Bartłomiej Dach · 2025-06-04 07:40:38 +02:00
  fa34ca91af
• Update one more inline comment
  Bartłomiej Dach · 2025-06-03 15:14:56 +02:00
  367b6727cd
• Remove local manifestation of beatmap sets now that set items is always populated

  Since 4d33602.

  Dean Herbert · 2025-06-03 22:03:12 +09:00
  4a4991e348
• Fix track not looping if specified preview point exceeds duration of track

  By falling back to the default of 40% of track duration in such cases.
  
  Also added a safety for the restart point exceeding acceptable bounds in
  case of a non-zero offset.
  
  Closes https://github.com/ppy/osu/issues/33308.

  Bartłomiej Dach · 2025-06-03 14:55:05 +02:00
  511c1d835b
• Merge pull request #33401 from bdach/utf-8-skins

  Use UTF-8 encoding when exporting skin archives

  Dean Herbert · 2025-06-03 21:51:15 +09:00
  ad186480a1
• Fix negative input lenience being applied to overlapping panels
  Bartłomiej Dach · 2025-06-03 14:28:41 +02:00
  ad251d701e
• Use UTF-8 encoding when exporting skin archives

  Closes https://github.com/ppy/osu/issues/33337.
  
  See also: https://github.com/ppy/osu/pull/28034#issuecomment-2084450285

  Bartłomiej Dach · 2025-06-03 13:54:54 +02:00
  fe325ba861
• Remove another similar finaliser
  Dan Balasescu · 2025-06-03 20:48:36 +09:00
  f08743302b
• Merge pull request #33400 from bdach/argon-slider-body-colour

  Fix argon & triangles skins reading legacy slider colour overrides from beatmap skins

  Dan Balasescu · 2025-06-03 20:43:14 +09:00
  b0e4ebe75a
• Merge pull request #33396 from smoogipoo/fix-flaky-editor-test

  Isolate EditorBeatmap instance to fix flaky tests

  Bartłomiej Dach · 2025-06-03 13:14:35 +02:00
  59f583cd65