h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-03 14:24:18 +08:00
Code Issues Releases Wiki Activity

Merge pull request #33404 from peppy/song-select-v2-remove-dead-code

Browse Source 
Remove local manifestation of beatmap sets now that set items is always populated
This commit is contained in:
Bartłomiej Dach
2025-06-04 07:40:38 +02:00
committed by GitHub
Unverified
parent ad186480a1 367b6727cd
commit fa34ca91af
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/SelectV2/BeatmapCarousel.cs
+1 -8
View File
@@ -609,16 +609,9 @@ namespace osu.Game.Screens.SelectV2
if (carouselItems?.Any() != true)
return false;
// If set grouping is available, this is the fastest way to retrieve sets for randomisation.
// This is the fastest way to retrieve sets for randomisation.
ICollection<BeatmapSetInfo> visibleSets = grouping.SetItems.Keys;
// If not, we need to do an expensive copy.
//
// There's probably a more efficient way to handle this. Maybe the grouping filter should always expose grouped sets regardless
// as that process is done asynchronously.
if (!visibleSets.Any())
visibleSets = carouselItems.Select(i => i.Model).OfType<BeatmapInfo>().Select(b => b.BeatmapSet!).Distinct().ToList();
if (CurrentSelection is BeatmapInfo beatmapInfo)
{
randomSelectedBeatmaps.Add(beatmapInfo);